[X2Go-Dev] [XREF] [Qt bugreports] (QTBUG-24729) Out of source building for App bundles broken (Info.plist and ICON)

And this is why I don't like qmake. ;)

-------- Original Message --------

Mihai Moldovan created QTBUG-24729:

         Summary: Out of source building for App bundles broken (Info.plist and ICON)
             Key: QTBUG-24729
             URL: https://bugreports.qt-project.org/browse/QTBUG-24729
         Project: Qt
      Issue Type: Bug
      Components: Build tools: qmake
Affects Versions: 4.8.0, 4.7.4
        Reporter: Mihai Moldovan
        Assignee: Oswald Buddenhagen
     Attachments: qt.patch

Out of source building is currently broken when adding a custom Info.list file (and consequently also an icon) on Mac OS X.

Consider this layout:

src/ app.pro Info.plist icon.icns build/ app.app (to be created by make)

Go to build and run qmake ../app.pro.

The problem lies within qmake, which "fixifies" the Info.plist path from "Info.plist" to "../Info.plist" and then can't find the find the file anymore, as qmake changes the cwd to the .pro file's directory (thus, in this example, src/).

Add both parameters out_d and in_d to MakefileGenerator::fileFixify as Option::output_dir to prevent qmake from "fixing" the file path to a path relative from the (out of source) build dir to the source dir, so that exists() can actually find the file where ever it is, specified by the user and relative to the source dir.