On 11.02.2015 12:53 PM, Mike Gabriel wrote:
On Mi 11 Feb 2015 00:30:45 CET, Orion Poplawski wrote:
I don't understand the reason for this change, it seems clearly to be a noarch package.
see https://jenkins.x2go.org:8443/view/CUPS/job/cups-x2go+nightly+sles-11.3/1/co...
""" (rpmlint says:) [ 19s] ... checking filelist [ 19s] cups-x2go: "/usr/lib64/cups" is not allowed in a noarch package. [ 19s] cups-x2go: "/usr/lib64/cups/backend" is not allowed in a noarch package. [ 19s] cups-x2go: "/usr/lib64/cups/backend/cups-x2go" is not allowed in a noarch package. """
Yep, makes sense if installing in %{_libdir}. However, we really want %{_prefix}/lib for a noarch package, as Orion suggested.
There's one problem though: SLES 11 by default installs CUPS content in /usr/lib64/cups on x86_64. I have no idea whether this old CUPS version will be able to pick up cups-x2go in /usr/lib/cups.
This WILL need testing on SLES 11.
I've added back noarch in the master branch.
- Alsi, in Fedora, you should not own directories own by other packages that it requires. I have:
%files %doc ChangeLog COPYING README.txt %{_prefix}/lib/cups/backend/cups-x2go %config(noreplace) %{_sysconfdir}/cups/cups-x2go.conf %{_datadir}/ppd/cups-x2go/ %{_datadir}/x2go/
It seems, that Mihai has started working on this, but builds are currently failing, it seems. So let's wait for him to figure things out.
This is really only very nice and easy and uncomplicated on Fedora/RHEL. On OpenSUSE 13.2, SLES 12 and below, nothing provides %{_datadir}/ppd/. Instead, PPDs are installed into /usr/lib/cups/...
OpenSUSE 13.2 and SLES 12 have a package called cups-filters, that does provide %{_datadir}/ppd/. We cannot depend on this package though, as it currently conflicts with the main cups package. This is guaranteed to break printing. Never versions of OpenSUSE and SLES will likely switch to CUPS >= 1.6 and the conflict will be resolved, but until then, we have to own %{_datadir}/ppd/ ourselves.
Mihai