Hi all
For the last couple of weeks, I've been working on the OS X side of X2Go Client, as some of you may or may not have noticed.
Part of that work was a restructuring of the x2goclient.git repository. I started forking master to features/cleanup, gradually moved files around into new sub-directories and adapted all files affected by these moves.
Additionally, macbuild.sh has been severely improved. It now supports multiple environment variables. A help message can be queried by (./)macbuild.sh -h or --help from any OS and will not be included here. x2goclient is now built in the client_build sub-directory to not pollute the main directory or overwrite the Makefile.
List of changes:
- moved .cpp/.h/.ui sources to src/
- moved png, svg and icons to res/
- moved all translation files to res/i18n/
- moved OS X build related files to res/macbuild/
- removed config_mac.sh (macbuild.sh supersedes it)
- aforementioned macbuild.sh changes
- change "legacy" resource URL's (":/icons/...", ":/png/...", ":/svg/...") to their ":/img/..." counterparts
- added transparent wrapper to x2goutils.cpp for wrapping "legacy" resource URL's to their new locations for backwards-compatibility with old session config files
- fixed some compiler warnings (mostly unused variables/parameters)
- fixed *some* QMessageBox::<function> calls. There still are a lot of plain incorrect calls left.
- typo, grammar and outdated information fixes
A visual representation of these changes can be seen when comparing
http://code.x2go.org/gitweb?p=x2goclient.git;a=tree and http://code.x2go.org/gitweb?p=x2goclient.git;a=tree;h=refs/heads/feature/cle...
The bugfix/osx branch is currently equivalent to features/cleanup. Subsequent OS X fixes will be published on bugfix/osx.
features/cleanup is scheduled to be merged into master (and thus become the X2Go Client 4.0.4.0 base) either shortly after this report, or after the upcoming X2Go Developer Meeting at the beginning of March.
What is YOUR opinion?
Best,
Mihai