Re: [X2Go-Dev] Patch to support Qt5 as well as Qt4

On 01.04.2016 10:45 AM, Nable wrote:

QString::toLocal8Bit() may be more suitable in some places. At least, it doesn't break access to files with non-ASCII names as QString::toLatin1() do.

Good point. toLocal8Bit() might carry out conversions, though, while toAscii() is equivalent to toLatin1(), iff no conversion method was set. We never do the latter, so within X2Go Client toAscii() should be functionally equivalent to toLatin1().

Thus, to retain the old (potentially broken(!), as you pointed out) behavior for now, toLatin1() sounds like the best option.

Mihai