-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512
- On 21.06.2014 11:23 pm, Mike Gabriel wrote:
Hi Mihai,
On Sa 21 Jun 2014 23:12:59 CEST, Mihai Moldovan wrote:
Multiple endiannes issues were setting incorrect event masks when creating and drawing X11 windows.
This time, a smaller integer has been casted to a bigger one and passed to some function actually setting its value.
This meant, that garbage from stack was attached to the smaller integer value, putting unknown memory into the lower bytes of the bigger integer.
Fix this by creating a big, initialized temporary variable, let the function do its magic on that one and pass the value back to the smaller variable -- and cross your fingers the smaller variable can hold it without overrunning. (The last bit is a design issue we can't really fix and has been around even before this patch.)
This fixes window creation and redrawing/updating issues on Big Endian 64bit systems.
Fixed patch included. However, unfortunately I forgot to rebase before pushing...
Thanks, Mike!
Unfortunately the "057_nx-X11-bigendian-ppc64-no-session-window.full.patch" description is still the "old" one. Mind updating that? -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (Darwin) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/
iQIcBAEBCgAGBQJTpfqeAAoJEB/WLtluJTqHtc4P/3RB4o6sfk0xP8LAqxNRk42q beKzVXVUEBiRgXJmDfnkDbHav/AAe2M6ATxPMdut+EYUmk/+W9dzrJwZHPoD5shu /TmPRV3EYIaoGDOKo3ZXZP/k+rkFXg1eBrnDgzoJJf0bF7fn9NztJ3vqHjSA8Cu7 VMtw7/J/uXBffSni0UKjaCtMHOe/GnrZM6bcjph6AykiLT0xPOXOxx1kTXvGeNx0 uFG3maxHYJC/nf2zs8pPt9/5K/lc+v09RoJptrFjZpzzIldCki0Q1/n3jZhsm5mJ 9dDeQg59wIyCSo7OU2vVX2RLByvAzkfr8TaU1+zThYkf58NJNmpuXXqBPuDXC0PI Ve51GrUF4mLz2bdZD57d27iYyu9H41S+5c6GNkhcObVHd6C6MKfL5AqwIgGvSbie If3+s7kpDv8p6UqERL6PnSBT6HMk8cYbNc2+mA9cFisYwi/kwESc5jd8odz2oG08 uTT+AS6MIncg9l5OSPKT79BGLNm390beY3C+hIgo84zyRCFghMOmdPRbCSOOOjR2 0f8hiN5QHxH59m4ZNKkE0eE5RY61AFMdn+PE5zqX6p75e4YxYG8oOjYcE2L6mtTG miT0YqEItpP//v2m7jr0g1FfT73sFXGDSnL/VrXiRR0eJJ/QSahYWtkGEgRV6RYg Fi+nHSePnoeo04jx3twM =pKrh -----END PGP SIGNATURE-----