- x2go-dev - X2Go ListServ

Bug#666: X2Go issue (in src:x2gobroker) has been marked as pending for release
by Mike Gabriel 30 Mar '15

30 Mar '15

tag #666 pending fixed #666 0.0.3.0 thanks Hello, X2Go issue #666 (src:x2gobroker) reported by you has been fixed in X2Go Git. You can see the changelog below, and you can check the diff of the fix at: http://code.x2go.org/gitweb?p=x2gobroker.git;a=commitdiff;h=6652693 The issue will most likely be fixed in src:x2gobroker (0.0.3.0). light+love X2Go Git Admin (on behalf of the sender of this mail) --- commit 6652693c1fe47dbc53f84db84fab34f70485951a Author: Mike Gabriel <mike.gabriel(a)das-netzwerkteam.de> Date: Mon Mar 30 16:57:56 2015 +0200 Add security notice / disclaimer to x2gbroker.1 man page as suggested by Stefan Baur. (Fixes: #666). diff --git a/debian/changelog b/debian/changelog index 8ac74a1..a0640e5 100644 --- a/debian/changelog +++ b/debian/changelog @@ -283,6 +283,8 @@ x2gobroker (0.0.3.0-0x2go1) UNRELEASED; urgency=low - man pages: Update date. - If non-load-balanced session profiles reference a non-reachable host, hand-back the system's hostname to X2Go Client / Python X2Go. + - Add security notice / disclaimer to x2gbroker.1 man page as suggested + by Stefan Baur. (Fixes: #666). * debian/control: + Provide separate bin:package for SSH brokerage: x2gobroker-ssh. + Replace LDAP support with session brokerage support in LONG_DESCRIPTION.

2 1

X2Go Session Broker, now with load checker service
by Mike Gabriel 30 Mar '15

30 Mar '15

Dear all, within the last week I have been working on X2Go Session Broker a bit more, pushing it towards release 0.0.3.0. One feature, that was still missing, was a means to perform load checks on associated load-balanced X2Go servers, so that a real "load" balancing could take place. Until last week, server load was detected by only counting the number of running / suspended X2Go sessions. If you have users that are working hard on an X2Go server, then the number of sessions is a very inaccurate way of detecting server load. So now, we count X2Go sessions plus detect a couple of server metrics (via a background daemon, aka x2gobroker-loadchecker). All gathered information will be combined into a load-factor. The load-factor and the number of running/suspended sessions, will decide on what host the next new X2Go session will be started. Quick install for testing the new feature (from the nightly builds, of couse): Debian: apt-get install x2gobroker # will update your x2gobroker packages apt-get install x2gobroker-loadchecker -> make sure x2gobroker-loadchecker starts via your init system edit /etc/x2go/x2gobroker.conf, set use-load-checker for inifile broker backend -> make sure, you have at least one session profile setup in /etc/x2go/broker/x2gobroker-sessionprofiles.conf that uses more than one host -> make sure, that you use "broker-agent-query-mode = SSH" for this session profile. -> for the fully-featured show, enable X2GOBROKER_DEBUG in /etc/x2go/broker/defaults.conf Now watch /var/log/x2gobroker/loadchecker.log and /var/log/x2gobroker/broker.log for system load information. I'd be happy to receive some test results within the next couple of days/2-weeks. The 0.0.3.0 release is heavily overdue and I would like to finalize this version by the beginning of April. Thanks+Greets, Mike -- DAS-NETZWERKTEAM mike gabriel, herweg 7, 24357 fleckeby fon: +49 (1520) 1976 148 GnuPG Key ID 0x25771B31 mail: mike.gabriel(a)das-netzwerkteam.de, http://das-netzwerkteam.de freeBusy: https://mail.das-netzwerkteam.de/freebusy/m.gabriel%40das-netzwerkteam.de.x…

1 0

Bug#830: QAction::eventFilter: Ambiguous shortcut overload: Ctrl+Q
by Mike Gabriel 30 Mar '15

30 Mar '15

Package: x2goclient Version: 4.0.4.0 Severity: minor This mail's subject says it all: QAction::eventFilter: Ambiguous shortcut overload: Ctrl+Q. When hitting Ctrl+Q in X2Go Client, I would expect X2Go Client to close. However, it only throws the above message on the underlying terminal if launched from one. Greets, Mike -- DAS-NETZWERKTEAM mike gabriel, herweg 7, 24357 fleckeby fon: +49 (1520) 1976 148 GnuPG Key ID 0x25771B31 mail: mike.gabriel(a)das-netzwerkteam.de, http://das-netzwerkteam.de freeBusy: https://mail.das-netzwerkteam.de/freebusy/m.gabriel%40das-netzwerkteam.de.x…

3 5

Bug#832: X2Go Client in broker mode wiath autologin enabled expects transmission of private SSH key file
by Mike Gabriel 30 Mar '15

30 Mar '15

Package: x2goclient Severity: important Version: 4.0.4.0 If brokerage with autologin is in use (a very common broker setup), the current client<->broker communication design in X2Go Client is that the broker creates a SSH pubkey/privkey pair and transmits the private key to the client. Never should we transmit private key files over the wire!!! The X2Go Session Broker is already able to accept pubkey files from the client side and deploy those pubkeys appropriately. In Python X2Go, this is already used. X2Go Client should switch here: create pubkey/privkey pair on client-side, push the pubkey to the broker and have it temporarily deployed from there to the X2Go Server where the next session login is scheduled by the broker. Mike -- DAS-NETZWERKTEAM mike gabriel, herweg 7, 24357 fleckeby fon: +49 (1520) 1976 148 GnuPG Key ID 0x25771B31 mail: mike.gabriel(a)das-netzwerkteam.de, http://das-netzwerkteam.de freeBusy: https://mail.das-netzwerkteam.de/freebusy/m.gabriel%40das-netzwerkteam.de.x…

1 0

Bug#831: handle autologin failures via broker gracefully
by Mike Gabriel 30 Mar '15

30 Mar '15

Package: x2goclient Version: 4.0.4.0 Severity: minor With brokerage enabled, the broker can mediate an autologin mechanism from X2Go Client to a given (brokeraged) server. The mechanism is this: o broker deploys a public key in ~/.x2go/authorized_keys on X2Go Server o X2Go Client receives the corresponding private key o (the above is already flawed, no private keys should be sent over networks, I will file another bug for that) o in SSHd, the ~/.x2go/authorized_keys must be configured as potential place for authorized_keys file If the last step is forgotten, SSH authentication with X2Go Client against the X2Go Server fails. If that fails, my expectation would be a fall-back to username / password authentication. But what happens, is: X2Go Client "gets stuck" in the session startup procedure (it's not a real freeze), it does not return to the login dialog widget anymore. Options remaining: closing X2Go Client and reopening. I stumbled over this because of a configuration in SSH daemon on one of my test boxes. Mike -- DAS-NETZWERKTEAM mike gabriel, herweg 7, 24357 fleckeby fon: +49 (1520) 1976 148 GnuPG Key ID 0x25771B31 mail: mike.gabriel(a)das-netzwerkteam.de, http://das-netzwerkteam.de freeBusy: https://mail.das-netzwerkteam.de/freebusy/m.gabriel%40das-netzwerkteam.de.x…

1 0

nx-libs SetPictureFilter() crash fix
by Mihai Moldovan 29 Mar '15

29 Mar '15

Hi Jan, The following patch will probably interest you, because it fixes the crash in SetPictureFilter(): http://code.x2go.org/gitweb?p=nx-libs.git;a=blob;f=debian/patches/0017_nx-X… Incidentally, this was also the reason why nxagent on my Gentoo system always crashed when clicking on any button in a XFCE desktop session. This fix will also be included in the next nx-libs release, but I haven't plan a date for this yet. Probably not coming any time soon, especially due to the previous emergency releases a few weeks back... Mihai

1 0

Bug#830: X2Go issue (in src:x2goclient) has been marked as pending for release
by Mike Gabriel 28 Mar '15

28 Mar '15

tag #830 pending fixed #830 4.0.4.0 thanks Hello, X2Go issue #830 (src:x2goclient) reported by you has been fixed in X2Go Git. You can see the changelog below, and you can check the diff of the fix at: http://code.x2go.org/gitweb?p=x2goclient.git;a=commitdiff;h=8008873 The issue will most likely be fixed in src:x2goclient (4.0.4.0). light+love X2Go Git Admin (on behalf of the sender of this mail) --- commit 800887326bb6dfe30170d74121422fb2c94439ff Author: Mike Gabriel <mike.gabriel(a)das-netzwerkteam.de> Date: Sat Mar 28 14:11:39 2015 +0100 debian/changelog: add closure for #830 diff --git a/debian/changelog b/debian/changelog index c48c4d2..334f8ee 100644 --- a/debian/changelog +++ b/debian/changelog @@ -240,7 +240,7 @@ x2goclient (4.0.4.0-0x2go1) UNRELEASED; urgency=low - configdialog.cpp: make XQuartz detection algorithm QStringList-based and add MacPorts location. - onmainwindow.cpp: do not define Ctrl+Q two times. Made it unusable on - Linux and Windows. + Linux and Windows. (Fixes: #830). - onmainwindow:cpp: correctly pass escaped single quote when writing remote xinerama config file. Post-fixup for #797. - {onmainwindow.cpp,README.i18n}: fix localization -- resource strings

2 1

Issue with ssh-agent fix for bug #672
by Daryl Clevenger 27 Mar '15

27 Mar '15

Folks, I run x2go sessions for weeks, so just recently noticed this regression after a recent update from ppa:x2go/stable. I'm running % cat /etc/lsb-release DISTRIB_ID=LinuxMint DISTRIB_RELEASE=17 DISTRIB_CODENAME=qiana DISTRIB_DESCRIPTION="Linux Mint 17 Qiana" The fix was for http://bugs.x2go.org/cgi-bin/bugreport.cgi?bug=672 and the commit http://code.x2go.org/gitweb?p=x2goserver.git;a=commitdiff;h=7fdcc5d The issue is that when starting a new session, the SSH_AUTH_SOCKET is always set. As a result, on Linux Mint 17 the following code in /etc/x2go/Xsession.d/90x11-common_ssh-agent is bypassed if has_option use-ssh-agent; then if [ -x "$SSHAGENT" ] && [ -z "$SSH_AUTH_SOCK" ] \ && [ -z "$SSH2_AUTH_SOCK" ]; then STARTSSH=yes if [ -f /usr/bin/ssh-add1 ] && cmp -s $SSHAGENT /usr/bin/ssh-agent2; then # use ssh-agent2's ssh-agent1 compatibility mode SSHAGENTARGS=-1 fi fi fi since -z "$SSH_AUTH_SOCK" fails. I have a work around in my ~/.xsessionrc-x2go, but it seems that the export should only occur when the symlink is created. I personally would use &&, ln -sf "$SSH_AUTH_SOCK" "$X2GOSSH_AUTH_SOCK" && export SSH_AUTH_SOCK="$X2GOSSH_AUTH_SOCK" but the GNU ln documentation lacks any documentation about exit status for ln(1). -- Daryl Clevenger P.S. I considered replying via 672(a)bugs.x2go.org, but did not know if that is appropriate for done/closed, etc. bugs.

1 0

Bug#276: qt/kde applications does not work as root.
by Pascal d'Hermilly 27 Mar '15

27 Mar '15

Package: x2goclient Version: 4.0.1.0 When I start qt/kde applications on the x2go server via the x2goclient, I get a grey application and a lot of error messages in the konsole. A workaround seems to be to change the graphicssystem to native instead of raster. However raster is the default in Kubuntu and it doesnt work when running things as root or through sudo. administrator@desktops-x2go:~$ sudo dolphin --graphicssystem raster X Error: BadDrawable (invalid Pixmap or Window parameter) 9 Major opcode: 62 (X_CopyArea) Resource id: 0x420007d X Error: BadDrawable (invalid Pixmap or Window parameter) 9 Major opcode: 62 (X_CopyArea) Resource id: 0x420007d X Error: BadDrawable (invalid Pixmap or Window parameter) 9 Major opcode: 62 (X_CopyArea) Resource id: 0x420007d X Error: BadDrawable (invalid Pixmap or Window parameter) 9 Major opcode: 62 (X_CopyArea) Resource id: 0x420007d X Error: BadPixmap (invalid Pixmap parameter) 4 Major opcode: 54 (X_FreePixmap) Resource id: 0x420007d X Error: BadShmSeg (invalid shared segment parameter) 128 Extension: 129 (MIT-SHM) Minor opcode: 2 (X_ShmDetach) Resource id: 0x420007c administrator@desktops-x2go:~$ sudo dolphin --graphicssystem native this works fine. Also gtk applications such as gimp works fine as root. This is quite a problem when you want to add/remove users and do other administrative things in KDE.

6 16

Re: [X2Go-Dev] [X2Go-Commits] [x2gobroker] 05/08: New feature: x2gobroker-loadchecker daemon.
by Mike Gabriel 26 Mar '15

26 Mar '15

Hi all, I just pushed a new feature to the X2Go Session Broker Git repo (master branch). This feature is still work in progress, but for multi-site testing, I need the packages from the nightly builds repo. So, stay tuned... Mike On Do 26 Mär 2015 11:47:54 CET, git-admin wrote: > This is an automated email from the git hooks/post-receive script. > > x2go pushed a commit to branch master > in repository x2gobroker. > > commit c571e891e4203eedd1b4f68346e66eb49b09c7b5 > Author: Mike Gabriel <mike.gabriel(a)das-netzwerkteam.de> > Date: Thu Mar 26 09:57:39 2015 +0100 > > New feature: x2gobroker-loadchecker daemon. > --- > bin/x2gobroker-ssh | Bin 10328 -> > 10328 bytes > debian/control | 33 ++ > debian/x2gobroker-agent.postrm | 6 +- > debian/x2gobroker-authservice.postrm | 6 +- > debian/x2gobroker-daemon.postrm | 6 +- > debian/x2gobroker-loadchecker.default | 1 + > debian/x2gobroker-loadchecker.init | 1 + > debian/x2gobroker-loadchecker.install | 3 + > debian/x2gobroker-loadchecker.manpages | 1 + > debian/x2gobroker-loadchecker.postinst | 76 +++++ > ...ervice.postrm => x2gobroker-loadchecker.postrm} | 8 +- > debian/x2gobroker-loadchecker.service | 1 + > debian/x2gobroker-wsgi.postrm | 6 +- > defaults/python-x2gobroker.default | 3 + > defaults/x2gobroker-loadchecker.default | 20 ++ > etc/broker/defaults.conf | 3 + > etc/broker/x2gobroker-loadchecker-logger.conf | 51 ++++ > etc/x2gobroker.conf | 49 +++ > init/x2gobroker-loadchecker.init | 104 +++++++ > lib/x2gobroker-agent.pl | 49 +++ > logrotate/x2gobroker-loadchecker | 14 + > man/man8/x2gobroker-authservice.8 | 2 +- > man/man8/x2gobroker-loadchecker.8 | 93 ++++++ > sbin/x2gobroker-loadchecker | 319 > ++++++++++++++++++++ > x2gobroker-loadchecker.service | 12 + > x2gobroker.spec | 119 ++++++++ > x2gobroker/agent.py | 25 ++ > x2gobroker/brokers/base_broker.py | 115 +++++++ > x2gobroker/defaults.py | 18 ++ > x2gobroker/loadchecker.py | 219 ++++++++++++++ > 30 files changed, 1346 insertions(+), 17 deletions(-) > > diff --git a/bin/x2gobroker-ssh b/bin/x2gobroker-ssh > index 10f24a3..ad1a492 100755 > Binary files a/bin/x2gobroker-ssh and b/bin/x2gobroker-ssh differ > diff --git a/debian/control b/debian/control > index aca8fce..1a90ed5 100644 > --- a/debian/control > +++ b/debian/control > @@ -115,6 +115,37 @@ Description: X2Go Session Broker (PAM > authentication service) > This package contains the authentication service > against the PAM system. > > +Package: x2gobroker-loadchecker > +Architecture: all > +Depends: > + ${python:Depends}, > + ${misc:Depends}, > + adduser, > + python, > + python-argparse, > + python-setproctitle, > + python-x2gobroker (>= ${source:Version}), python-x2gobroker (<< > ${source:Version}.1~), > +Suggests: > + x2gobroker-daemon, > +Description: X2Go Session Broker (load checker service) > + X2Go is a server based computing environment with > + - session resuming > + - low bandwidth support > + - session brokerage support > + - client side mass storage mounting support > + - client side printing support > + - audio support > + - authentication by smartcard and USB stick > + . > + The session broker is a server tool for X2Go that tells your X2Go Client > + application in a terminal server cluster what servers and session types are > + most appropriate for the user in front of the X2Go terminal. > + . > + A session broker is most useful in load balanced X2Go server farms. > + . > + This package contains the load checker service required for broker setups > + with dynamic load balancing. > + > Package: x2gobroker-daemon > Architecture: all > Depends: > @@ -123,6 +154,8 @@ Depends: > x2gobroker (>= ${source:Version}), x2gobroker (<< ${source:Version}.1~), > Recommends: > x2gobroker-authservice, > +Suggests: > + x2gobroker-loadchecker, > Description: X2Go Session Broker (standalone daemon) > X2Go is a server based computing environment with > - session resuming > diff --git a/debian/x2gobroker-agent.postrm b/debian/x2gobroker-agent.postrm > index 0739da6..0f5c579 100755 > --- a/debian/x2gobroker-agent.postrm > +++ b/debian/x2gobroker-agent.postrm > @@ -23,15 +23,15 @@ case "$1" in > dpkg-statoverride --remove /usr/lib/x2go/x2gobroker-agent > fi > > - if [ ! -d /usr/share/doc/x2gobroker-daemon ] && [ ! -d > /usr/share/doc/x2gobroker-authservice ] && [ ! -d > /usr/share/doc/x2gobroker-wsgi ]; then > + if [ ! -d /usr/share/doc/x2gobroker-daemon ] && [ ! -d > /usr/share/doc/x2gobroker-authservice ] && [ ! -d > /usr/share/doc/x2gobroker-wsgi ] && [ ! -d > /usr/share/doc/x2gobroker-loadchecker ]; then > if dpkg-statoverride --list /var/log/x2gobroker 1>/dev/null; then > dpkg-statoverride --remove /var/log/x2gobroker > fi > rm -Rf /var/log/x2gobroker > fi > > - if [ ! -d /usr/share/doc/x2gobroker-daemon ] && [ ! -d > /usr/share/doc/x2gobroker-authservice ] && [ ! -d > /usr/share/doc/x2gobroker-wsgi ]; then > - # remove user/group x2gobroker from system (if not in use by > x2gobroker-daemon, x2gobroker-authservice, x2gobroker-wsgi) > + if [ ! -d /usr/share/doc/x2gobroker-daemon ] && [ ! -d > /usr/share/doc/x2gobroker-authservice ] && [ ! -d > /usr/share/doc/x2gobroker-wsgi ] && [ ! -d > /usr/share/doc/x2gobroker-loadchecker ]; then > + # remove user/group x2gobroker from system (if not in use by > x2gobroker-daemon, x2gobroker-authservice, x2gobroker-wsgi, > x2gobroker-loadchecker) > getent passwd x2gobroker 1>/dev/null && deluser x2gobroker > getent group x2gobroker 1>/dev/null && delgroup x2gobroker > getent group x2gobroker 1>/dev/null && delgroup x2gobroker > diff --git a/debian/x2gobroker-authservice.postrm > b/debian/x2gobroker-authservice.postrm > index 851bfa5..6db5213 100755 > --- a/debian/x2gobroker-authservice.postrm > +++ b/debian/x2gobroker-authservice.postrm > @@ -19,15 +19,15 @@ set -e > case "$1" in > purge) > > - if [ ! -d /usr/share/doc/x2gobroker-daemon ] && [ ! -d > /usr/share/doc/x2gobroker-wsgi ] && [ ! -d > /usr/share/doc/x2gobroker-agent ] ; then > + if [ ! -d /usr/share/doc/x2gobroker-daemon ] && [ ! -d > /usr/share/doc/x2gobroker-wsgi ] && [ ! -d > /usr/share/doc/x2gobroker-agent ] && [ ! -d > /usr/share/doc/x2gobroker-loadchecker ]; then > if dpkg-statoverride --list /var/log/x2gobroker 1>/dev/null; then > dpkg-statoverride --remove /var/log/x2gobroker > fi > rm -Rf /var/log/x2gobroker > fi > > - if [ ! -d /usr/share/doc/x2gobroker-daemon ] && [ ! -d > /usr/share/doc/x2gobroker-agent ] && [ ! -d > /usr/share/doc/x2gobroker-wsgi ]; then > - # remove user/group x2gobroker from system (only if not in use > by x2gobroker-daemon, x2gobroker-agent, x2gobroker-wsgi) > + if [ ! -d /usr/share/doc/x2gobroker-daemon ] && [ ! -d > /usr/share/doc/x2gobroker-agent ] && [ ! -d > /usr/share/doc/x2gobroker-wsgi ] && [ ! -d > /usr/share/doc/x2gobroker-loadchecker ]; then > + # remove user/group x2gobroker from system (only if not in use > by x2gobroker-daemon, x2gobroker-agent, x2gobroker-wsgi, > x2gobroker-loadchecker) > getent passwd x2gobroker 1>/dev/null && deluser x2gobroker > getent group x2gobroker 1>/dev/null && delgroup x2gobroker > getent group x2gobroker 1>/dev/null && delgroup x2gobroker > diff --git a/debian/x2gobroker-daemon.postrm > b/debian/x2gobroker-daemon.postrm > index 5d76a1b..ab50ca0 100755 > --- a/debian/x2gobroker-daemon.postrm > +++ b/debian/x2gobroker-daemon.postrm > @@ -19,15 +19,15 @@ set -e > case "$1" in > purge) > > - if [ ! -d /usr/share/doc/x2gobroker-agent ] && [ ! -d > /usr/share/doc/x2gobroker-authservice ] && [ ! -d > /usr/share/doc/x2gobroker-wsgi ]; then > + if [ ! -d /usr/share/doc/x2gobroker-agent ] && [ ! -d > /usr/share/doc/x2gobroker-authservice ] && [ ! -d > /usr/share/doc/x2gobroker-wsgi ] && [ ! -d > /usr/share/doc/x2gobroker-loadchecker ]; then > if dpkg-statoverride --list /var/log/x2gobroker 1>/dev/null; then > dpkg-statoverride --remove /var/log/x2gobroker > fi > rm -Rf /var/log/x2gobroker > fi > > - if [ ! -d /usr/share/doc/x2gobroker-agent ] && [ ! -d > /usr/share/doc/x2gobroker-authservice ] && [ ! -d > /usr/share/doc/x2gobroker-wsgi ]; then > - # remove user/group x2gobroker from system (only if not in use > by x2gobroker-agent, x2gobroker-authservice, x2gobroker-wsgi) > + if [ ! -d /usr/share/doc/x2gobroker-agent ] && [ ! -d > /usr/share/doc/x2gobroker-authservice ] && [ ! -d > /usr/share/doc/x2gobroker-wsgi ] && [ ! -d > /usr/share/doc/x2gobroker-loadchecker ]; then > + # remove user/group x2gobroker from system (only if not in use > by x2gobroker-agent, x2gobroker-authservice, x2gobroker-wsgi, > x2gobroker-loadchecker) > getent passwd x2gobroker 1>/dev/null && deluser x2gobroker > getent group x2gobroker 1>/dev/null && delgroup x2gobroker > getent group x2gobroker 1>/dev/null && delgroup x2gobroker > diff --git a/debian/x2gobroker-loadchecker.default > b/debian/x2gobroker-loadchecker.default > new file mode 120000 > index 0000000..25ba295 > --- /dev/null > +++ b/debian/x2gobroker-loadchecker.default > @@ -0,0 +1 @@ > +../defaults/x2gobroker-loadchecker.default > \ No newline at end of file > diff --git a/debian/x2gobroker-loadchecker.init > b/debian/x2gobroker-loadchecker.init > new file mode 120000 > index 0000000..b970565 > --- /dev/null > +++ b/debian/x2gobroker-loadchecker.init > @@ -0,0 +1 @@ > +../init/x2gobroker-loadchecker.init > \ No newline at end of file > diff --git a/debian/x2gobroker-loadchecker.install > b/debian/x2gobroker-loadchecker.install > new file mode 100644 > index 0000000..769abbc > --- /dev/null > +++ b/debian/x2gobroker-loadchecker.install > @@ -0,0 +1,3 @@ > +sbin/x2gobroker-loadchecker usr/sbin/ > +logrotate/x2gobroker-loadchecker etc/logrotate.d/ > +etc/broker/x2gobroker-loadchecker-logger.conf etc/x2go/broker > \ No newline at end of file > diff --git a/debian/x2gobroker-loadchecker.manpages > b/debian/x2gobroker-loadchecker.manpages > new file mode 100644 > index 0000000..1832989 > --- /dev/null > +++ b/debian/x2gobroker-loadchecker.manpages > @@ -0,0 +1 @@ > +man/man8/x2gobroker-loadchecker.8 > \ No newline at end of file > diff --git a/debian/x2gobroker-loadchecker.postinst > b/debian/x2gobroker-loadchecker.postinst > new file mode 100755 > index 0000000..c2f42ce > --- /dev/null > +++ b/debian/x2gobroker-loadchecker.postinst > @@ -0,0 +1,76 @@ > +#!/bin/sh > +# postinst script for x2gobroker-loadchecker > +# > +# see: dh_installdeb(1) > + > +set -e > + > +# summary of how this script can be called: > +# * <postinst> `configure' <most-recently-configured-version> > +# * <old-postinst> `abort-upgrade' <new version> > +# * <conflictor's-postinst> `abort-remove' `in-favour' <package> > +# <new-version> > +# * <postinst> `abort-remove' > +# * <deconfigured's-postinst> `abort-deconfigure' `in-favour' > +# <failed-install-package> <version> `removing' > +# <conflicting-package> <version> > +# for details, see http://www.debian.org/doc/debian-policy/ or > +# the debian-policy package > + > + > +case "$1" in > + configure) > + > + # setup user/group x2gobroker > + if ! getent group x2gobroker 1>/dev/null; then > + echo "Creating x2gobroker group." 1>&2 > + addgroup --system x2gobroker > + else > + echo "Group x2gobroker already exists." 1>&2 > + fi > + if ! getent passwd x2gobroker 1>/dev/null; then > + echo "Creating x2gobroker user." 1>&2 > + adduser --system \ > + --disabled-password --disabled-login \ > + --shell /bin/bash --group --home /var/lib/x2gobroker x2gobroker > + else > + echo "User x2gobroker already exists." 1>&2 > + > + # make sure the home directory exists belongs to x2gobroker:x2gobroker > + mkdir -p /var/lib/x2gobroker > + chown x2gobroker:x2gobroker /var/lib/x2gobroker -f > + > + # make sure all settings are appropriate > + if getent passwd x2gobroker | grep /dev/null 1>/dev/null > 2>/dev/null; then > + usermod --home /var/lib/x2gobroker x2gobroker > + fi > + if getent passwd x2gobroker | grep /bin/false 1>/dev/null > 2>/dev/null; then > + usermod --shell /bin/bash x2gobroker > + fi > + fi > + > + # the x2gobroker-daemon needs special permissions on its log directory > + if ! dpkg-statoverride --list /var/log/x2gobroker 1>/dev/null; then > + dpkg-statoverride --add --update x2gobroker adm 2750 /var/log/x2gobroker > + fi > + > + mkdir -p /var/log/x2gobroker && chown x2gobroker:adm > /var/log/x2gobroker && chmod 2755 /var/log/x2gobroker > + touch /var/log/x2gobroker/authservice.log && chown x2gobroker:adm > /var/log/x2gobroker/authservice.log > + touch /var/log/x2gobroker/error.log && chown x2gobroker:adm > /var/log/x2gobroker/error.log > + ;; > + > + abort-upgrade|abort-remove|abort-deconfigure) > + ;; > + > + *) > + echo "postinst called with unknown argument \`$1'" 1>&2 > + exit 1 > + ;; > +esac > + > +# dh_installdeb will replace this with shell code automatically > +# generated by other debhelper scripts. > + > +#DEBHELPER# > + > +exit 0 > diff --git a/debian/x2gobroker-authservice.postrm > b/debian/x2gobroker-loadchecker.postrm > similarity index 86% > copy from debian/x2gobroker-authservice.postrm > copy to debian/x2gobroker-loadchecker.postrm > index 851bfa5..588f3a1 100755 > --- a/debian/x2gobroker-authservice.postrm > +++ b/debian/x2gobroker-loadchecker.postrm > @@ -1,5 +1,5 @@ > #! /bin/sh > -# postrm script for x2gobroker-authservice > +# postrm script for x2gobroker-loadchecker > # > # see: dh_installdeb(1) > # summary of how this script can be called: > @@ -19,15 +19,15 @@ set -e > case "$1" in > purge) > > - if [ ! -d /usr/share/doc/x2gobroker-daemon ] && [ ! -d > /usr/share/doc/x2gobroker-wsgi ] && [ ! -d > /usr/share/doc/x2gobroker-agent ] ; then > + if [ ! -d /usr/share/doc/x2gobroker-daemon ] && [ ! -d > /usr/share/doc/x2gobroker-wsgi ] && [ ! -d > /usr/share/doc/x2gobroker-agent ] && [ ! -d > /usr/share/doc/x2gobroker-authservice ]; then > if dpkg-statoverride --list /var/log/x2gobroker 1>/dev/null; then > dpkg-statoverride --remove /var/log/x2gobroker > fi > rm -Rf /var/log/x2gobroker > fi > > - if [ ! -d /usr/share/doc/x2gobroker-daemon ] && [ ! -d > /usr/share/doc/x2gobroker-agent ] && [ ! -d > /usr/share/doc/x2gobroker-wsgi ]; then > - # remove user/group x2gobroker from system (only if not in use > by x2gobroker-daemon, x2gobroker-agent, x2gobroker-wsgi) > + if [ ! -d /usr/share/doc/x2gobroker-daemon ] && [ ! -d > /usr/share/doc/x2gobroker-agent ] && [ ! -d > /usr/share/doc/x2gobroker-wsgi ] && [ ! -d > /usr/share/doc/x2gobroker-authservice ]; then > + # remove user/group x2gobroker from system (only if not in use > by x2gobroker-daemon, x2gobroker-agent, x2gobroker-wsgi, > x2gobroker-authservice) > getent passwd x2gobroker 1>/dev/null && deluser x2gobroker > getent group x2gobroker 1>/dev/null && delgroup x2gobroker > getent group x2gobroker 1>/dev/null && delgroup x2gobroker > diff --git a/debian/x2gobroker-loadchecker.service > b/debian/x2gobroker-loadchecker.service > new file mode 120000 > index 0000000..426059a > --- /dev/null > +++ b/debian/x2gobroker-loadchecker.service > @@ -0,0 +1 @@ > +../x2gobroker-authservice.service > \ No newline at end of file > diff --git a/debian/x2gobroker-wsgi.postrm b/debian/x2gobroker-wsgi.postrm > index 4c7c120..1299a7a 100755 > --- a/debian/x2gobroker-wsgi.postrm > +++ b/debian/x2gobroker-wsgi.postrm > @@ -35,15 +35,15 @@ case "$1" in > > apacheconf_remove > > - if [ ! -d /usr/share/doc/x2gobroker-agent ] && [ ! -d > /usr/share/doc/x2gobroker-authservice ] && [ ! -d > /usr/share/doc/x2gobroker-daemon ]; then > + if [ ! -d /usr/share/doc/x2gobroker-agent ] && [ ! -d > /usr/share/doc/x2gobroker-authservice ] && [ ! -d > /usr/share/doc/x2gobroker-daemon ] && [ ! -d > /usr/share/doc/x2gobroker-loadchecker ]; then > if dpkg-statoverride --list /var/log/x2gobroker 1>/dev/null; then > dpkg-statoverride --remove /var/log/x2gobroker > fi > rm -Rf /var/log/x2gobroker > fi > > - if [ ! -d /usr/share/doc/x2gobroker-agent ] && [ ! -d > /usr/share/doc/x2gobroker-authservice ] && [ ! -d > /usr/share/doc/x2gobroker-daemon ]; then > - # remove user/group x2gobroker from system (only if not in use > by x2gobroker-agent, x2gobroker-authservice, x2gobroker-daemon) > + if [ ! -d /usr/share/doc/x2gobroker-agent ] && [ ! -d > /usr/share/doc/x2gobroker-authservice ] && [ ! -d > /usr/share/doc/x2gobroker-daemon ] && [ ! -d > /usr/share/doc/x2gobroker-loadchecker ]; then > + # remove user/group x2gobroker from system (only if not in use > by x2gobroker-agent, x2gobroker-authservice, x2gobroker-daemon, > x2gobroker-loadchecker) > getent passwd x2gobroker 1>/dev/null && deluser x2gobroker > getent group x2gobroker 1>/dev/null && delgroup x2gobroker > getent group x2gobroker 1>/dev/null && delgroup x2gobroker > diff --git a/defaults/python-x2gobroker.default > b/defaults/python-x2gobroker.default > index 73ee9ac..d31c113 100644 > --- a/defaults/python-x2gobroker.default > +++ b/defaults/python-x2gobroker.default > @@ -37,3 +37,6 @@ > > # The unix socket file for communication between the broker and the > authentication service. > #X2GOBROKER_AUTHSERVICE_SOCKET=/run/x2gobroker/x2gobroker-authservice.socket > + > +# The unix socket file for communication between the broker and the > authentication service. > +#X2GOBROKER_LOADCHECKER_SOCKET=/run/x2gobroker/x2gobroker-loadchecker.socket > diff --git a/defaults/x2gobroker-loadchecker.default > b/defaults/x2gobroker-loadchecker.default > new file mode 100644 > index 0000000..b5bcd3e > --- /dev/null > +++ b/defaults/x2gobroker-loadchecker.default > @@ -0,0 +1,20 @@ > +# X2Go Session Broker (Load Checker Service) configuration > +# SystemV-like init systems > + > +# For PAM authentication the X2Go Session Broker needs its authentication > +# service. The session broker itself runs as a non-privileged user > (see below) > +# whereas the authentication service must run as super-user root. > +# > +# If you do not use PAM as authentication mechanism with the X2Go > Session Broker, > +# you can disable the authentication service here. > +START_LOADCHECKER=false > + > +# Control debug mode (0=disable, 1=enable) of the X2Go Broker Authentication > +# Service. > +# > +# Logging is (by default) written to /var/log/x2gobroker/*log. > +# > +# This option can also be configured in /etc/default/python-x2go. > +# The value configured here overrides the value from python-x2go > +# defaults and only sets the x2gobroker-authservice into debug mode. > +#X2GOBROKER_DEBUG=0 > diff --git a/etc/broker/defaults.conf b/etc/broker/defaults.conf > index 01ca667..38dfc2d 100644 > --- a/etc/broker/defaults.conf > +++ b/etc/broker/defaults.conf > @@ -35,6 +35,9 @@ > # The unix socket file for communication between the broker and the > authentication service. > #X2GOBROKER_AUTHSERVICE_SOCKET=/run/x2gobroker/x2gobroker-authservice.socket > > +# The unix socket file for communication between the broker and the > authentication service. > +#X2GOBROKER_LOADCHECKER_SOCKET=/run/x2gobroker/x2gobroker-loadchecker.socket > + > [daemon] > # X2Go Session Broker configuration for Debian > > diff --git a/etc/broker/x2gobroker-loadchecker-logger.conf > b/etc/broker/x2gobroker-loadchecker-logger.conf > new file mode 100644 > index 0000000..e18a143 > --- /dev/null > +++ b/etc/broker/x2gobroker-loadchecker-logger.conf > @@ -0,0 +1,51 @@ > +# This file is part of the X2Go Project - http://www.x2go.org > +# Copyright (C) 2012-2015 by Mike Gabriel <mike.gabriel(a)das-netzwerkteam.de> > +# > +# X2Go Session Broker is free software; you can redistribute it > and/or modify > +# it under the terms of the GNU Affero General Public License as > published by > +# the Free Software Foundation; either version 3 of the License, or > +# (at your option) any later version. > +# > +# X2Go Session Broker is distributed in the hope that it will be useful, > +# but WITHOUT ANY WARRANTY; without even the implied warranty of > +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > +# GNU Affero General Public License for more details. > +# > +# You should have received a copy of the GNU Affero General Public License > +# along with this program; if not, write to the > +# Free Software Foundation, Inc., > +# 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA. > + > +# WARNING: only modify this file if you _exactly_ know what you are doing!!! > + > +[loggers] > +keys=root,loadchecker > + > +[logger_root] > +level=NOTSET > +handlers=stderrHandler > + > +[handlers] > +keys=stderrHandler,loadcheckerFileHandler > + > +[formatters] > +keys=loadcheckerFormatter > + > +[handler_stderrHandler] > +class=StreamHandler > +args=(sys.stderr,) > + > +[logger_loadchecker] > +level=DEBUG > +handlers=loadcheckerFileHandler > +qualname=loadchecker > +propagate=0 > + > +[handler_loadcheckerFileHandler] > +class=FileHandler > +formatter=loadcheckerFormatter > +args=('/var/log/x2gobroker/loadchecker.log',) > + > +[formatter_loadcheckerFormatter] > +format=%(asctime)s - %(name)s - %(levelname)s - %(message)s > +datefmt= > diff --git a/etc/x2gobroker.conf b/etc/x2gobroker.conf > index 1901673..8d57ae1 100644 > --- a/etc/x2gobroker.conf > +++ b/etc/x2gobroker.conf > @@ -247,6 +247,53 @@ > # false in the session profile configuration). > #default-portscan-x2goservers = true > > +# Use load checker for querying X2Go Servers' loads in regular intervals > +# > +# When load-balancing shall be used, the simplest way to detect > "server load" > +# is counting the numbers of running and suspended sessions. No extra daemon > +# nor service is required for this. > +# > +# However, simply counting running and suspended sessions per X2Go Server > +# as a representative for the server load can be highly inaccurate. A better > +# approach is checking each X2Go Server's load in regular intervals by a > +# separate daemon (running on the broker host) and querying this > load checker > +# service before selecting the best server on session startup requests. > +# > +# The load factor calculation uses this algorithm: > +# > +# ( memAvail/1000 ) * numCPUs * typeCPUs > +# load-factor = -------------------------------------- > +# loadavg*100 * numSessions > +# > +# (memAvail in MByte, typeCPUs in MHz) > +# > +# The higher the load-factor, the more likely that a server will be chosen > +# for the next to be allocated X2Go session. > +# > +# If you set the default-use-load-checker option here, the queries to the > +# x2gobroker-loadchecker daemon will be performed for all broker backends by > +# defaults. > +# > +# The x2gobroker-loadchecker only gets consulted, if: > +# > +# o if enabled here for all backends > +# o or if enabled on a per broker backend basis (see below) > +# > +# and > +# > +# o the session profile defines more than one host > +# o the session profile does not block queries to the load checker daemon > +# on a per profile basis > +# > +#default-use-load-checker = false > + > +# If the x2gobroker-loadchecker daemon gets used, define here how > +# many seconds to sleep between querying system load from the > +# associated X2Go Servers. > +# > +#load-checker-intervals = 300 > + > + > ### > ### Auth Mechs section > ### > @@ -291,6 +338,7 @@ > [broker_inifile] > #enable = true > #session-profiles = /etc/x2go/broker/x2gobroker-sessionprofiles.conf > +#use-load-checker = false > > #[broker_ldap] -> MUSIC OF THE FUTURE > #enable = false > @@ -304,4 +352,5 @@ > #group-search-filter = (&(objectClass=posifxGroup)(cn=*)) > #starttls = false > #agent-query-mode = SSH > +#use-load-checker = true > > diff --git a/init/x2gobroker-loadchecker.init > b/init/x2gobroker-loadchecker.init > new file mode 100755 > index 0000000..de8f2d0 > --- /dev/null > +++ b/init/x2gobroker-loadchecker.init > @@ -0,0 +1,104 @@ > +#!/bin/sh > +# > +# Start the X2Go Session Broker PAM Authentication Service > +# > +# Copyright © 2014 Mike Gabriel <mike.gabriel(a)das-netzwerkteam.de> > +# Distributable under the terms of the GNU AGPL version 3+. > +# > +### BEGIN INIT INFO > +# Provides: x2gobroker-loadchecker > +# Required-Start: $remote_fs $syslog > +# Required-Stop: $remote_fs $syslog > +# Default-Start: 2 3 4 5 > +# Default-Stop: 0 1 6 > +# Short-Description: X2Go Session Broker PAM Authentication Service > +# Description: PAM authentication service for X2Go Session Broker > +### END INIT INFO > +# > + > +set -eu > + > +LOADCHECKER=/usr/sbin/x2gobroker-loadchecker > +test -d /run && RUNDIR=/run || RUNDIR=/var/run > +PIDFILE_LOADCHECKER=$RUNDIR/x2gobroker/x2gobroker-loadchecker.pid > +DEBIANCONFIG_COMMON=/etc/default/python-x2gobroker > +DEBIANCONFIG_LOADCHECKER=/etc/default/x2gobroker-loadchecker > + > +test -x "$LOADCHECKER" || exit 0 > + > +START_LOADCHECKER=false > +X2GOBROKER_DEBUG=0 > +X2GOBROKER_DAEMON_USER='x2gobroker' > +X2GOBROKER_DAEMON_GROUP='x2gobroker' > +X2GOBROKER_LOADCHECKER_SOCKET="$RUNDIR/x2gobroker/x2gobroker-loadchecker.socket" > +test -f $DEBIANCONFIG_COMMON && . $DEBIANCONFIG_COMMON > +test -f $DEBIANCONFIG_LOADCHECKER && . $DEBIANCONFIG_LOADCHECKER > + > +if ! getent passwd $X2GOBROKER_DAEMON_USER 1>/dev/null 2>/dev/null; then > + X2GOBROKER_DAEMON_USER=nobody > +fi > +if ! getent group $X2GOBROKER_DAEMON_GROUP 1>/dev/null 2>/dev/null; then > + X2GOBROKER_DAEMON_GROUP=nogroup > +fi > + > +# create PID directory > +mkdir -p $RUNDIR/x2gobroker > +chown $X2GOBROKER_DAEMON_USER:$X2GOBROKER_DAEMON_GROUP $RUNDIR/x2gobroker > +chmod 0770 $RUNDIR/x2gobroker > + > +export X2GOBROKER_DEBUG > +export X2GOBROKER_DAEMON_USER > +export X2GOBROKER_DAEMON_GROUP > +export X2GOBROKER_LOADCHECKER_SOCKET > + > +. /lib/lsb/init-functions > + > +is_true() > +{ > + case "${1:-}" in > + [Yy]es|[Yy]|1|[Tt]|[Tt]rue) return 0;; > + *) return 1; > + esac > +} > + > +case "${1:-}" in > + start) > + if [ -f $PIDFILE_LOADCHECKER ]; then > + if ps a -u root | grep -v egrep | egrep ".*$(basename > $LOADCHECKER).*$X2GOBROKER_LOADCHECKER_SOCKET.*" 1>/dev/null > 2>/dev/null; then > + log_warning_msg "X2Go Broker Authentication Service already running" > + else > + log_warning_msg "X2Go Broker Authentication Service: stale PID > file ($PIDFILE_LOADCHECKER). Delete it manually!" > + fi > + START_LOADCHECKER=no > + fi > + if is_true $START_LOADCHECKER; then > + set +e > + # once we are here, we have to make sure the loadchecker.socket > does not exist > + rm -f $X2GOBROKER_LOADCHECKER_SOCKET > + # and now we can start the auth service > + log_daemon_msg "Starting X2Go Broker Authentication Service" > "$(basename $LOADCHECKER)" > + start-stop-daemon -b -m -S -p $PIDFILE_LOADCHECKER -x > $LOADCHECKER -- -s $X2GOBROKER_LOADCHECKER_SOCKET -o > $X2GOBROKER_DAEMON_USER -g $X2GOBROKER_DAEMON_GROUP -p 0660 > + log_end_msg $? > + set -e > + fi > + ;; > + stop) > + if [ -f $PIDFILE_LOADCHECKER ] ; then > + log_daemon_msg "Stopping X2Go Broker Authentication Service" > "$(basename $LOADCHECKER)" > + set +e > + start-stop-daemon -K -p $PIDFILE_LOADCHECKER && rm -f > $PIDFILE_LOADCHECKER > + log_end_msg $? > + set -e > + fi > + ;; > + restart|reload|force-reload) > + ${0:-} stop > + ${0:-} start > + ;; > + *) > + echo "Usage: ${0:-} {start|stop|restart|reload|force-reload}" >&2 > + exit 1 > + ;; > +esac > + > +exit 0 > diff --git a/lib/x2gobroker-agent.pl b/lib/x2gobroker-agent.pl > index 242f78a..9463018 100755 > --- a/lib/x2gobroker-agent.pl > +++ b/lib/x2gobroker-agent.pl > @@ -36,6 +36,7 @@ if ( system("x2goversion x2goserver 1>/dev/null") == 0 ) > "listsessions", > "findbusyservers", > "findbusyservers_by_sessionstats", > + "checkload", > "getservers", > "suspendsession", > "terminatesession", > @@ -133,6 +134,54 @@ if($mode eq 'ping') > exit; > } > > +if ( $mode eq 'checkload' ) { > + print "OK\n"; > + > + # Read the values from /proc/loadavg and combine all three values > in a linear > + # way and make a percent value out of the result: > + open FILE, "< /proc/loadavg" or die return ("Cannot open > /proc/loadavg: $!"); > + my ($avg1, $avg5, $avg15, undef, undef) = split / /, <FILE>; > + close FILE; > + my $loadavgXX = ( $avg1 + $avg5 + $avg15 ) * 100/3; > + if ( $loadavgXX == 0 ) { > + # load may not be ZERO > + $loadavgXX = 1; > + } > + > + # calculate total memory vs. free memory > + my $memAvail; > + open FILE, "< /proc/meminfo" or die return ("Cannot open > /proc/meminfo: $!"); > + foreach(<FILE>) { > + if ( m/^MemAvailable:\s+(\S+)/ ) { > + $memAvail = $1/1000; > + last; > + } > + } > + close(FILE); > + > + # check number and type of available CPU cores > + my $numCPU = 0; > + my $typeCPU; > + open FILE, "< /proc/cpuinfo" or die return ("Cannot open > /proc/cpuinfo: $!"); > + foreach(<FILE>) { > + if ( m/model name.*CPU\ \@\ ([\d\.]+)/ ) { > + $typeCPU = $1*1000; > + $numCPU += 1; > + } > + } > + close(FILE); > + > + print sprintf 'loadavgXX:%1$d', $loadavgXX; > + print "\n"; > + print sprintf 'memAvail:%1$d', $memAvail; > + print "\n"; > + print sprintf 'numCPU:%1$d', $numCPU; > + print "\n"; > + print sprintf 'typeCPU:%1$d', $typeCPU; > + print "\n"; > + exit; > +} > + > if($mode eq 'availabletasks') > { > print "OK\n"; > diff --git a/logrotate/x2gobroker-loadchecker > b/logrotate/x2gobroker-loadchecker > new file mode 100644 > index 0000000..e5c8c65 > --- /dev/null > +++ b/logrotate/x2gobroker-loadchecker > @@ -0,0 +1,14 @@ > +/var/log/x2gobroker/loadchecker.log { > + weekly > + missingok > + rotate 52 > + compress > + delaycompress > + notifempty > + create 640 root adm > + su root adm > + sharedscripts > + postrotate > + invoke-rc.d x2gobroker-loadchecker restart > /dev/null > + endscript > +} > diff --git a/man/man8/x2gobroker-authservice.8 > b/man/man8/x2gobroker-authservice.8 > index eff8569..8981ee6 100644 > --- a/man/man8/x2gobroker-authservice.8 > +++ b/man/man8/x2gobroker-authservice.8 > @@ -31,7 +31,7 @@ Thus, the PAM authentication has been moved into a > separate service. The communi > between X2Go Session Broker and PAM Authentication Service is > handled through a > unix domain socket file > (\fI<RUNDIR>/x2gobroker/x2gobroker-authservice.socket\fR). > .PP > -This command is normally started through an init script. > +This command is normally started through the host's init system. > .SH COMMON OPTIONS > \fBx2gobroker-authservice\fR accepts the following common options: > .TP > diff --git a/man/man8/x2gobroker-loadchecker.8 > b/man/man8/x2gobroker-loadchecker.8 > new file mode 100644 > index 0000000..f025f5e > --- /dev/null > +++ b/man/man8/x2gobroker-loadchecker.8 > @@ -0,0 +1,93 @@ > +'\" -*- coding: utf-8 -*- > +.if \n(.g .ds T< \\FC > +.if \n(.g .ds T> \\F[\n[.fam]] > +.de URL > +\\$2 \(la\\$1\(ra\\$3 > +.. > +.if \n(.g .mso www.tmac > +.TH x2gobroker-loadchecker 8 "Mar 2015" "Version 0.0.3.x" "X2Go > Session Broker" > +.SH NAME > +x2gobroker-loadchecker \- Load checker service for X2Go Session Broker > +.SH SYNOPSIS > +'nh > +.fi > +.ad l > +\fBx2gobroker-loadchecker\fR \kx > +.if (\nx>(\n(.l/2)) .nr x (\n(.l/5) > +'in \n(.iu+\nxu > +[ > +\fIoptions\fR > +] > +'in \n(.iu-\nxu > +.ad b > +'hy > +.SH DESCRIPTION > +\fBx2gobroker-loadchecker\fR is a service that collects system load > metrics from > +broker-associated X2Go Servers. > +.PP > +When load-balancing shall be used, the simplest way to detect "server load" > +is counting the numbers of running and suspended sessions. No extra daemon > +nor service is required for this. The server with the least amount > of sessions > +will be selected for starting the next X2Go session. > +.PP > +However, simply counting running and suspended sessions per X2Go Server > +as a representative for the server load can be highly inaccurate. A better > +approach is checking each X2Go Server's load in regular intervals by the > +\fBx2gobroker-loadchecker\fR daemon (running on the broker host) > and querying > +the \fBx2gobroker-loadchecker\fR daemon before selecting the best server on > +session startup requests. > +.PP > +The \fBx2gobroker-loadchecker\fR collects server metrics of all > +associated X2Go Servers and keeps the latest load factors in RAM. Once > +the broker needs load factors of a certain session profile (i.e., of all > +servers configured in that session profile), the > +\fBx2gobroker-loadchecker\fR delivers that info immediately. The > +remembered load factors may not be 100% up-to-date (default: collected > +within the last five minutes), but the response time of the load checker > +is much faster than a query to all possible X2Go Servers would be. > +.PP > +The load factor calculation uses this algorithm: > +.PP > + ( memAvail[MByte]/1000 ) * numCPUs * typeCPUs[MHz] > + load-factor = -------------------------------------------------- > + loadavg*100 * numSessions > +.PP > +The higher the load-factor, the more likely that a server will be chosen > +for the next to be allocated X2Go session. > +.PP > +The communication > +between X2Go Session Broker and the Load Checker Service is handled > through a > +unix domain socket file > (\fI<RUNDIR>/x2gobroker/x2gobroker-loadchecker.socket\fR). > +.PP > +This command is normally started through the host's init system. > +.SH COMMON OPTIONS > +\fBx2gobroker-loadchecker\fR accepts the following common options: > +.TP > +\*(T<\fB\-h, \-\-help\fR\*(T> > +Display a help with all available command line options and exit. > +.TP > +\*(T<\fB\-D, \-\-daemonize\fR\*(T> > +Fork this application to background and detach from the running terminal. > +.TP > +\*(T<\fB\-P, \-\-pidfile\fR\*(T> > +Custom PID file location when daemonizing (default: > \fI<RUNDIR>/x2gobroker/x2gobroker-loadchecker.pid\fR). > +.TP > +\*(T<\fB\-L, \-\-logdir\fR\*(T> > +Directory where stdout/stderr will be redirected after having > daemonized (default: \fI/var/log/x2gobroker/\fR). > +.TP > +\*(T<\fB\-s <LOADCHECKERSOCKET>, \-\-socket <LOADCHECKERSOCKET>\fR\*(T> > +File name of the unix domain socket file used for communication > between broker and load checker service. > +.TP > +\*(T<\fB\-o <OWNER>, \-\-owner <OWNER>\fR\*(T> > +User ownership of the \fI<LOADCHECKERSOCKET>\fR file. > +.TP > +\*(T<\fB\-g <GROUP>, \-\-group <GROUP>\fR\*(T> > +Group ownership of the \fI<LOADCHECKERSOCKET>\fR file. > +.TP > +\*(T<\fB\-p <PERMISSIONS>, \-\-permissions <PERMISSIONS>\fR\*(T> > +Set these file permissions for the \fI<LOADCHECKERSOCKET>\fR file. > Use numerical permissions (e.g. 0640). > +.SH "FILES" > +<RUNDIR>/x2gobroker/x2gobroker-loadchecker.socket > +.SH AUTHOR > +This manual has been written for the X2Go project by > +Mike Gabriel <mike.gabriel(a)das-netzwerkteam.de>. > diff --git a/sbin/x2gobroker-loadchecker b/sbin/x2gobroker-loadchecker > new file mode 100755 > index 0000000..8d6ae32 > --- /dev/null > +++ b/sbin/x2gobroker-loadchecker > @@ -0,0 +1,319 @@ > +#!/usr/bin/env python > +# -*- coding: utf-8 -*- > + > +# This file is part of the X2Go Project - http://www.x2go.org > +# Copyright (C) 2012-2015 by Mike Gabriel <mike.gabriel(a)das-netzwerkteam.de> > +# > +# X2Go Session Broker is free software; you can redistribute it > and/or modify > +# it under the terms of the GNU Affero General Public License as > published by > +# the Free Software Foundation; either version 3 of the License, or > +# (at your option) any later version. > +# > +# X2Go Session Broker is distributed in the hope that it will be useful, > +# but WITHOUT ANY WARRANTY; without even the implied warranty of > +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > +# GNU Affero General Public License for more details. > +# > +# You should have received a copy of the GNU Affero General Public License > +# along with this program; if not, write to the > +# Free Software Foundation, Inc., > +# 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA. > + > +import os > +import sys > +import setproctitle > +import argparse > +import logging > +import asyncore > +import socket > +import getpass > +import logging.config > +import atexit > +import ConfigParser > + > +if os.path.isdir('/run'): > + RUNDIR = '/run' > +else: > + RUNDIR = '/var/run' > + > +try: > + import daemon > + import lockfile > + CAN_DAEMONIZE = True > + pidfile = > '{run}/x2gobroker/x2gobroker-loadchecker.pid'.format(run=RUNDIR) > + daemon_logdir = '/var/log/x2gobroker/' > +except ImportError: > + CAN_DAEMONIZE = False > + > +from pwd import getpwnam > +from grp import getgrnam > + > +PROG_NAME = os.path.basename(sys.argv[0]) > +PROG_OPTIONS = sys.argv[1:] > +setproctitle.setproctitle("%s %s" % (PROG_NAME, " ".join(PROG_OPTIONS))) > + > +from x2gobroker import __VERSION__ > +from x2gobroker import __AUTHOR__ > +import x2gobroker.loadchecker > + > +global load_checker > + > +class LoadCheckerServiceHandler(asyncore.dispatcher_with_send): > + > + def __init__(self, sock, logger=None): > + self.logger = logger > + asyncore.dispatcher_with_send.__init__(self, sock) > + self._buf = '' > + > + def handle_read(self): > + data = self._buf + self.recv(1024) > + if not data: > + self.close() > + return > + reqs, data = data.rsplit('\n', 1) > + self._buf = data > + output = "" > + for req in reqs.split('\n'): > + backend, profile_id, hostname = req.split('\r') > + if self.logger: > self.logger.debug('LoadCheckServiceHandler.handle_read(): received > load check query: backend={backend}, profile_id={profile_id}, > hostname={hostname}'.format(backend=backend, profile_id=profile_id, > hostname=hostname)) > + if hostname: > + load_factor = load_checker.get_server_load(backend, > profile_id, hostname) > + if load_factor is not None: > + output += "{lf}".format(lf=load_factor) > + if self.logger: > self.logger.info('LoadCheckServiceHandler.handle_read(): load check > result for backend={backend}, profile_id={profile_id}, > hostname={hostname}: {lf}'.format(backend=backend, > profile_id=profile_id, hostname=hostname, lf=load_factor)) > + else: > + output += "LOAD-UNAVAILABLE" > + if self.logger: > self.logger.warning('LoadCheckServiceHandler.handle_read(): load > check failure for backend={backend}, profile_id={profile_id}, > hostname={hostname}: LOAD-UNAVAILABLE'.format(backend=backend, > profile_id=profile_id, hostname=hostname)) > + else: > + load_factors = > load_checker.get_profile_load(backend, profile_id) > + if load_factors: > + for h in load_factors.keys(): > + if load_factors[h] is not None: > + output > +="{hostname}:{loadfactor}".format(hostname=h, > loadfactor=load_factors[h]) > + if self.logger: > self.logger.info('LoadCheckServiceHandler.handle_read(): load check > result for backend={backend}, profile_id={profile_id}, > hostname={hostname}: {lf}'.format(backend=backend, > profile_id=profile_id, hostname=h, lf=load_factors[h])) > + else: > + output += > "{hostname}:LOAD-UNAVAILABLE".formate(hostname=h) > + if self.logger: > self.logger.warning('LoadCheckServiceHandler.handle_read(): load > check failure for backend={backend}, profile_id={profile_id}, > hostname={hostname}: LOAD-UNAVAILABLE'.format(backend=backend, > profile_id=profile_id, hostname=h)) > + else: > + output += "LOAD-UNAVAILABLE" > + if self.logger: > self.logger.warning('LoadCheckServiceHandler.handle_read(): load > check failure for backend={backend}, profile_id={profile_id}: > LOAD-UNAVAILABLE'.format(backend=backend, profile_id=profile_id)) > + self.send(output) > + > + def handle_close(self): > + self.close() > + > + > +class LoadCheckerService(asyncore.dispatcher_with_send): > + > + def __init__(self, socketfile, owner='root', > group_owner='root', permissions='0660', logger=None): > + self.logger = logger > + asyncore.dispatcher_with_send.__init__(self) > + self.create_socket(socket.AF_UNIX, socket.SOCK_STREAM) > + self.set_reuse_addr() > + self.bind(socketfile) > + os.chown(socketfile, getpwnam(owner).pw_uid, > getgrnam(group_owner).gr_gid) > + os.chmod(socketfile, int(permissions, 8)) > + self.listen(1) > + > + def handle_accept(self): > + conn, _ = self.accept() > + LoadCheckerServiceHandler(conn, logger=self.logger) > + > + > +def loop(): > + ### the "loop" has two tasks... > + > + # 1. Do regular queries to remote X2Go Broker Agent instances to collect > + # load average, CPU usage and type, memory usage, etc. > + load_checker.start() > + > + # 2. Provide a listening UNIX domain socket file that can be > used for querying > + # server states. > + asyncore.loop() > + > + > +def cleanup_on_exit(): > + os.remove(X2GOBROKER_LOADCHECKER_SOCKET) > + try: os.remove(pidfile) > + except: pass > + > + > +# load the defaults.conf file, if present > +iniconfig_loaded = None > +iniconfig_section = '-'.join(PROG_NAME.split('-')[1:]) > +X2GOBROKER_DEFAULTS = "/etc/x2go/broker/defaults.conf" > +if os.path.isfile(X2GOBROKER_DEFAULTS) and > os.access(X2GOBROKER_DEFAULTS, os.R_OK): > + iniconfig = ConfigParser.SafeConfigParser() > + iniconfig.optionxform = str > + iniconfig_loaded = iniconfig.read(X2GOBROKER_DEFAULTS) > + > +# normally this would go into defaults.py, however, we do not want > to pull in defaults.py here as that will create > +# unwanted logfiles (access.log, broker.log, error.log) when > x2gobroker-loadchecker is installed as standalone service > +if os.environ.has_key('X2GOBROKER_DEBUG'): > + X2GOBROKER_DEBUG = ( os.environ['X2GOBROKER_DEBUG'].lower() in > ('1', 'on', 'true', 'yes', ) ) > +elif iniconfig_loaded and iniconfig.has_option(iniconfig_section, > 'X2GOBROKER_DEBUG'): > + X2GOBROKER_DEBUG=iniconfig.get(iniconfig_section, 'X2GOBROKER_DEBUG') > +elif iniconfig_loaded and iniconfig.has_option('common', > 'X2GOBROKER_DEBUG'): > + X2GOBROKER_DEBUG=iniconfig.get('common', 'X2GOBROKER_DEBUG') > +else: > + X2GOBROKER_DEBUG = False > + > +if os.environ.has_key('X2GOBROKER_DAEMON_USER'): > + X2GOBROKER_DAEMON_USER=os.environ['X2GOBROKER_DAEMON_USER'] > +elif iniconfig_loaded and iniconfig.has_option(iniconfig_section, > 'X2GOBROKER_DAEMON_USER'): > + X2GOBROKER_DAEMON_USER=iniconfig.get(iniconfig_section, > 'X2GOBROKER_DAEMON_USER') > +elif iniconfig_loaded and iniconfig.has_option('common', > 'X2GOBROKER_DAEMON_USER'): > + X2GOBROKER_DAEMON_USER=iniconfig.get('common', 'X2GOBROKER_DAEMON_USER') > +else: > + X2GOBROKER_DAEMON_USER="x2gobroker" > + > +if os.environ.has_key('X2GOBROKER_LOADCHECKER_LOGCONFIG'): > + > X2GOBROKER_LOADCHECKER_LOGCONFIG=os.environ['X2GOBROKER_LOADCHECKER_LOGCONFIG'] > +elif iniconfig_loaded and iniconfig.has_option(iniconfig_section, > 'X2GOBROKER_LOADCHECKER_LOGCONFIG'): > + > X2GOBROKER_LOADCHECKER_LOGCONFIG=iniconfig.get(iniconfig_section, > 'X2GOBROKER_LOADCHECKER_LOGCONFIG') > +elif iniconfig_loaded and iniconfig.has_option('common', > 'X2GOBROKER_LOADCHECKER_LOGCONFIG'): > + X2GOBROKER_LOADCHECKER_LOGCONFIG=iniconfig.get('common', > 'X2GOBROKER_LOADCHECKER_LOGCONFIG') > +else: > + > X2GOBROKER_LOADCHECKER_LOGCONFIG="/etc/x2go/broker/x2gobroker-loadchecker-logger.conf" > + > +if os.environ.has_key('X2GOBROKER_LOADCHECKER_SOCKET'): > + > X2GOBROKER_LOADCHECKER_SOCKET=os.environ['X2GOBROKER_LOADCHECKER_SOCKET'] > +elif iniconfig_loaded and iniconfig.has_option(iniconfig_section, > 'X2GOBROKER_LOADCHECKER_SOCKET'): > + X2GOBROKER_LOADCHECKER_SOCKET=iniconfig.get(iniconfig_section, > 'X2GOBROKER_LOADCHECKER_SOCKET') > +elif iniconfig_loaded and iniconfig.has_option('common', > 'X2GOBROKER_LOADCHECKER_SOCKET'): > + X2GOBROKER_LOADCHECKER_SOCKET=iniconfig.get('common', > 'X2GOBROKER_LOADCHECKER_SOCKET') > +else: > + > X2GOBROKER_LOADCHECKER_SOCKET="{run}/x2gobroker/x2gobroker-loadchecker.socket".format(run=RUNDIR) > + > + > +if __name__ == '__main__': > + > + common_options = [ > + {'args':['-s','--socket-file'], 'default': > X2GOBROKER_LOADCHECKER_SOCKET, 'metavar': 'LOADCHECKERSOCKET', > 'help': 'socket file for LoadChecker communication', }, > + {'args':['-o','--owner'], 'default': 'root', 'help': 'owner > of the LoadChecker socket file', }, > + {'args':['-g','--group'], 'default': 'root', 'help': 'group > ownership of the LoadChecker socket file', }, > + {'args':['-p','--permissions'], 'default': '0660', 'help': > 'set these file permissions for the LoadChecker socket file', }, > + {'args':['-d','--debug'], 'default': False, 'action': > 'store_true', 'help': 'enable debugging code', }, > + {'args':['-i','--debug-interactively'], 'default': False, > 'action': 'store_true', 'help': 'force output of log message to the > stderr (rather than to the log files)', }, > + > + ] > + if CAN_DAEMONIZE: > + common_options.extend([ > + {'args':['-D', '--daemonize'], 'default': False, > 'action': 'store_true', 'help': 'Detach the X2Go Broker process from > the current terminal and fork to background', }, > + {'args':['-P', '--pidfile'], 'default': pidfile, > 'help': 'Alternative file path for the daemon\'s PID file', }, > + {'args':['-L', '--logdir'], 'default': daemon_logdir, > 'help': 'Directory where log files for the process\'s stdout and > stderr can be created', }, > + ]) > + p = argparse.ArgumentParser(description='X2Go Session Broker > (Load Checker Service)',\ > + > formatter_class=argparse.RawDescriptionHelpFormatter, \ > + add_help=True, argument_default=None) > + p_common = p.add_argument_group('common parameters') > + > + for (p_group, opts) in ( (p_common, common_options), ): > + for opt in opts: > + args = opt['args'] > + del opt['args'] > + p_group.add_argument(*args, **opt) > + > + cmdline_args = p.parse_args() > + > + # standalone daemon mode (x2gobroker-loadchecker as daemon) or > interactive mode (called from the cmdline)? > + if getpass.getuser() in (X2GOBROKER_DAEMON_USER, 'root') and > not cmdline_args.debug_interactively: > + > + # we run in standalone daemon mode, so let's use the system > configuration for logging > + logging.config.fileConfig(X2GOBROKER_LOADCHECKER_LOGCONFIG) > + > + # create loadchecker logger > + logger_loadchecker = logging.getLogger('loadchecker') > + > + else: > + logger_root = logging.getLogger() > + stderr_handler = logging.StreamHandler(sys.stderr) > + > stderr_handler.setFormatter(logging.Formatter(fmt='%(asctime)s - > %(name)s - %(levelname)s - %(message)s', datefmt='')) > + > + # all loggers stream to stderr... > + logger_root.addHandler(stderr_handler) > + > + logger_loadchecker = logging.getLogger('loadchecker') > + logger_loadchecker.addHandler(stderr_handler) > + logger_loadchecker.propagate = 0 > + > + if cmdline_args.debug_interactively: > + cmdline_args.debug = True > + > + # raise log level to DEBUG if requested... > + if cmdline_args.debug or X2GOBROKER_DEBUG: > + X2GOBROKER_DEBUG = True > + logger_loadchecker.setLevel(logging.DEBUG) > + > + logger_loadchecker.info('X2Go Session Broker ({version}), > written by {author}'.format(version=__VERSION__, author=__AUTHOR__)) > + logger_loadchecker.info('Setting up the Load Checker service\'s > environment...') > + logger_loadchecker.info(' X2GOBROKER_DEBUG: > {value}'.format(value=X2GOBROKER_DEBUG)) > + logger_loadchecker.info(' X2GOBROKER_LOADCHECKER_SOCKET: > {value}'.format(value=X2GOBROKER_LOADCHECKER_SOCKET)) > + > + load_checker = > x2gobroker.loadchecker.LoadChecker(logger=logger_loadchecker) > + > + if CAN_DAEMONIZE and cmdline_args.daemonize: > + > + # create directory for the PID file > + pidfile = os.path.expanduser(cmdline_args.pidfile) > + if not os.path.isdir(os.path.dirname(pidfile)): > + try: > + os.makedirs(os.path.dirname(pidfile)) > + except: > + pass > + if not os.access(os.path.dirname(pidfile), os.W_OK) or > (os.path.exists(pidfile) and not os.access(pidfile, os.W_OK)): > + print("") > + p.print_usage() > + print("Insufficent privileges. Cannot create PID file > {pidfile} path".format(pidfile=pidfile)) > + print("") > + sys.exit(-3) > + > + # create directory for logging > + daemon_logdir = os.path.expanduser(cmdline_args.logdir) > + if not os.path.isdir(daemon_logdir): > + try: > + os.makedirs(daemon_logdir) > + except: > + pass > + if not os.access(daemon_logdir, os.W_OK): > + print("") > + p.print_usage() > + print("Insufficent privileges. Cannot create directory > for stdout/stderr log files: {logdir}".format(logdir=daemon_logdir)) > + print("") > + sys.exit(-3) > + else: > + if not daemon_logdir.endswith('/'): > + daemon_logdir += '/' > + > + socket_file = cmdline_args.socket_file > + > + if os.path.exists(socket_file): > + os.remove(socket_file) > + > + if not os.path.exists(os.path.dirname(socket_file)): > + os.makedirs(os.path.dirname(socket_file)) > + > + runtimedir_permissions = int(cmdline_args.permissions, 8) > + if runtimedir_permissions & 0400: runtimedir_permissions = > runtimedir_permissions | 0100 > + if runtimedir_permissions & 0040: runtimedir_permissions = > runtimedir_permissions | 0010 > + if runtimedir_permissions & 0004: runtimedir_permissions = > runtimedir_permissions | 0001 > + try: > + os.chown(os.path.dirname(socket_file), > getpwnam(cmdline_args.owner).pw_uid, > getpwnam(cmdline_args.group).pw_gid) > + os.chmod(os.path.dirname(socket_file), runtimedir_permissions) > + except OSError: > + pass > + > + LoadCheckerService(socket_file, owner=cmdline_args.owner, > group_owner=cmdline_args.group, > permissions=cmdline_args.permissions, logger=logger_loadchecker) > + atexit.register(cleanup_on_exit) > + try: > + if CAN_DAEMONIZE and cmdline_args.daemonize: > + keep_fds = [int(fd) for fd in > os.listdir('/proc/self/fd') if fd not in (0,1,2) ] > + daemon_stdout = > file(daemon_logdir+'x2gobroker-loadchecker.stdout', 'w+') > + daemon_stderr = > file(daemon_logdir+'x2gobroker-loadchecker.stderr', 'w+') > + with daemon.DaemonContext(stdout=daemon_stdout, > stderr=daemon_stderr, files_preserve=keep_fds, umask=0o027, > pidfile=lockfile.FileLock(pidfile), detach_process=True): > + file(pidfile, 'w+').write(str(os.getpid())+"\n") > + loop() > + else: > + loop() > + except KeyboardInterrupt: > + pass > diff --git a/x2gobroker-loadchecker.service b/x2gobroker-loadchecker.service > new file mode 100644 > index 0000000..692e15f > --- /dev/null > +++ b/x2gobroker-loadchecker.service > @@ -0,0 +1,12 @@ > +[Unit] > +Description=X2Go Session Broker Load Checker Service > + > +[Service] > +User=root > +Group=root > +Type=forking > +ExecStart=/usr/sbin/x2gobroker-loadchecker > --socket-file=/run/x2gobroker/x2gobroker-loadchecker.socket > --daemonize -o root -g x2gobroker -p 0660 > --pidfile=/run/x2gobroker/x2gobroker-loadchecker.pid > +PIDFile=/run/x2gobroker/x2gobroker-loadchecker.pid > + > +[Install] > +WantedBy=multi-user.target > diff --git a/x2gobroker.spec b/x2gobroker.spec > index bcb398f..55b1fdb 100644 > --- a/x2gobroker.spec > +++ b/x2gobroker.spec > @@ -14,6 +14,7 @@ Url: http://www.x2go.org/ > Source0: > http://code.x2go.org/releases/source/%name/%name-%version.tar.gz > Source1: x2gobroker-daemon.init > Source2: x2gobroker-authservice.init > +Source2: x2gobroker-loadchecker.init > Source3: x2gobroker-rpmlintrc > > %if 0%{?el5} > @@ -147,6 +148,46 @@ A session broker is most useful in load > balanced X2Go server farms. > > This package contains the authentication service against the PAM system. > > +%package loadchecker > +Summary: X2Go Session Broker (load checker service) > +%if 0%{?suse_version} > +Group: Productivity/Networking/Remote Desktop > +%else > +Group: Applications/Communications > +%endif > +%if 0%{?suse_version} > +Requires: python > +%else > +Requires: python2 > +%endif > +Requires: python-argparse > +Requires: python-setproctitle > +Requires: logrotate > +Requires(pre): python-x2gobroker = %{version}-%{release} > +%if 0%{?suse_version} > +Requires(pre): permissions > +%endif > + > +%description loadchecker > +X2Go is a server based computing environment with > + - session resuming > + - low bandwidth support > + - session brokerage support > + - client side mass storage mounting support > + - client side printing support > + - audio support > + - authentication by smartcard and USB stick > + > +The session broker is a server tool for X2Go that tells your X2Go Client > +application in a terminal server cluster what servers and session types are > +most appropriate for the user in front of the X2Go terminal. > + > +A session broker is most useful in load balanced X2Go server farms. > + > +This package contains the load checker service required for broker setups > +with dynamic load balancing. > + > + > %package daemon > Summary: X2Go Session Broker (standalone daemon) > %if 0%{?suse_version} > @@ -346,6 +387,8 @@ grep -l -r -E '^#!/usr/bin/env python$' | while > read file; do \ > %endif > sed -i logrotate/x2gobroker-authservice \ > -e 's/adm/root/' > +sed -i logrotate/x2gobroker-loadchecker \ > + -e 's/adm/root/' > sed -i logrotate/x2gobroker-daemon \ > -e 's/adm/root/' > sed -i logrotate/x2gobroker-wsgi \ > @@ -379,14 +422,18 @@ ln -s > "%_sysconfdir/x2go/x2gobroker-wsgi.apache.vhost" \ > mkdir -p %{buildroot}%{_unitdir} > install -pm0644 x2gobroker-daemon.service %{buildroot}%{_unitdir} > install -pm0644 x2gobroker-authservice.service %{buildroot}%{_unitdir} > +install -pm0644 x2gobroker-loadchecker.service %{buildroot}%{_unitdir} > rm -f %{buildroot}%{_sysconfdir}/default/x2gobroker-daemon > rm -f %{buildroot}%{_sysconfdir}/default/x2gobroker-authservice > +rm -f %{buildroot}%{_sysconfdir}/default/x2gobroker-loadchecker > rm -f %{buildroot}%{_sysconfdir}/default/python-x2gobroker > %else > # SysV session cleanup script > %if 0%{?el5} > rm -f %{buildroot}%{_sysconfdir}/x2go/broker/defaults.conf > mkdir -p %{buildroot}%{_initrddir} > +install -pm0755 %SOURCE3 \ > + "$b/%_initrddir/x2gobroker-loadchecker" > install -pm0755 %SOURCE2 \ > "$b/%_initrddir/x2gobroker-authservice" > install -pm0755 %SOURCE1 \ > @@ -395,6 +442,8 @@ install -pm0755 %SOURCE1 \ > %if 0%{?el6} || ( 0%{?suse_version} && 0%{?suse_version} < 1140) > rm -f %{buildroot}%{_sysconfdir}/x2go/broker/defaults.conf > mkdir -p "$b/%_initddir" > +install -pm0755 %SOURCE3 \ > + "$b/%_initddir/x2gobroker-loadchecker" > install -pm0755 %SOURCE2 \ > "$b/%_initddir/x2gobroker-authservice" > install -pm0755 %SOURCE1 \ > @@ -480,6 +529,56 @@ fi > > > %if 0%{?suse_version} >= 1230 > +%pre loadchecker > +%service_add_pre x2gobroker-loadchecker.service > +%endif > + > +%post loadchecker > +%if 0%{?fedora} || 0%{?el7} || 0%{?suse_version} >= 1230 > +%if 0%{?suse_version} > +%service_add_post x2gobroker-loadchecker.service > +%else > +%systemd_post x2gobroker-loadchecker.service > +%endif > +%else > +/sbin/chkconfig --add x2gobroker-loadchecker > +if [ "$1" -ge "1" ] ; then > + /sbin/service x2gobroker-loadchecker condrestart >/dev/null 2>&1 || : > +fi > +%endif > +%if 0%{?suse_version} > +%set_permissions %{_localstatedir}/log/x2gobroker > + > + > +%verifyscript loadchecker > +%verify_permissions -e %{_localstatedir}/log/x2gobroker > +%endif > + > +%preun loadchecker > +%if 0%{?fedora} || 0%{?el7} || 0%{?suse_version} >= 1230 > +%if 0%{?suse_version} > +%service_del_preun x2gobroker-loadchecker.service > +%else > +%systemd_preun x2gobroker-loadchecker.service > +%endif > +%else > +if [ "$1" = 0 ]; then > + /sbin/service x2gobroker-loadchecker stop >/dev/null 2>&1 > + /sbin/chkconfig --del x2gobroker-loadchecker > +fi > +%endif > + > +%if 0%{?fedora} || 0%{?el7} || 0%{?suse_version} >= 1230 > +%postun loadchecker > +%if 0%{?suse_version} > +%service_del_postun x2gobroker-loadchecker.service > +%else > +%systemd_postun x2gobroker-loadchecker.service > +%endif > +%endif > + > + > +%if 0%{?suse_version} >= 1230 > %pre daemon > %service_add_pre x2gobroker-daemon.service > %endif > @@ -620,6 +719,26 @@ fi > %attr(02750,x2gobroker,x2gobroker) %_localstatedir/log/x2gobroker > > > +%files loadchecker > +%defattr(-,root,root) > +%if 0%{?el5} > +%_initrddir/x2gobroker-loadchecker > +%endif > +%if 0%{?el6} > +%_initddir/x2gobroker-loadchecker > +%endif > +%if 0%{?fedora} || 0%{?el7} || 0%{?suse_version} >= 1230 > +%{_unitdir}/x2gobroker-loadchecker.service > +%endif > +%if 0%{?el5} || 0%{?el6} || (0%{?suse_version} && 0%{?suse_version} < 1140) > +%config %_sysconfdir/default/x2gobroker-loadchecker > +%endif > +%config %_sysconfdir/logrotate.d/x2gobroker-loadchecker > +%_sbindir/x2gobroker-loadchecker > +%_mandir/man8/x2gobroker-loadchecker.8* > +%attr(02750,x2gobroker,x2gobroker) %_localstatedir/log/x2gobroker > + > + > %files daemon > %defattr(-,root,root) > %_bindir/x2gobroker-daemon > diff --git a/x2gobroker/agent.py b/x2gobroker/agent.py > index 5364825..462f188 100644 > --- a/x2gobroker/agent.py > +++ b/x2gobroker/agent.py > @@ -338,6 +338,31 @@ def find_busy_servers(username, > remote_agent=None, **kwargs): > tasks['findbusyservers'] = find_busy_servers > > > +def checkload(remote_agent=None, **kwargs): > + """\ > + Query X2Go Broker Agent for a summary of system load specific > + parameters. > + > + @param remote_agent: information about the remote agent that is > to be called. > + @type remote_agent: C{dict} > + > + """ > + _success, _load_params = call_broker_agent('foo', > task='checkload', remote_agent=remote_agent, **kwargs) > + > + p = {} > + for _param in _load_params: > + if ':' in _param: > + key, val = _param.split(':', 1) > + p[key] = float(val) > + > + load_factor = None > + try: > + load_factor = long( ( (p['memAvail']/1000) * p['numCPU'] * > p['typeCPU'] * 100 ) / p['loadavgXX'] ) > + except KeyError: > + pass > + > + return load_factor > + > def add_authorized_key(username, pubkey_hash, > authorized_keys_file='%h/.x2go/authorized_keys', remote_agent=None, > **kwargs): > """\ > Add a public key hash to the user's authorized_keys file. > diff --git a/x2gobroker/brokers/base_broker.py > b/x2gobroker/brokers/base_broker.py > index fe9ecc5..ad22803 100644 > --- a/x2gobroker/brokers/base_broker.py > +++ b/x2gobroker/brokers/base_broker.py > @@ -708,6 +708,59 @@ class X2GoBroker(object): > > return unicode(_group_db) > > + def get_use_load_checker(self): > + """\ > + Is this broker backend configured to access an X2Go Broker > LoadChecker daemon. > + > + @return: C{True} if there should a load checker daemon running. > + @rtype: C{bool} > + > + """ > + _use_load_checker = False > + if self.config.has_value('global', 'default-use-load-checker'): > + _use_load_checker = self.config.get_value('global', > 'default-use-load-checker') or _use_load_checker > + > + if > self.config.has_value('broker_{backend}'.format(backend=self.backend_name), > 'use-load-checker'): > + _use_load_checker = > self.config.get_value('broker_{backend}'.format(backend=self.backend_name), > 'use-load-checker') or _use_load_checker > + > + return _use_load_checker > + > + def use_load_checker(self, profile_id): > + """\ > + Actually query the load checker daemon for the given > session profile ID. > + This method will check: > + > + - broker backend configured to use load checker daemon? > + - more than one host configured? > + - load checker queries not explicitly disabled in session profile? > + > + @param profile_id: choose remote agent for this profile ID > + @type profile_id: C{unicode} > + > + @return: C{True} if there is a load checker daemon running. > + @rtype: C{bool} > + > + """ > + # only use load checker if... > + > + # it is enabled for the broker backend... > + if self.get_use_load_checker(): > + > + _profile = self.get_profile(profile_id) > + > + # it is not explicitly disabled per session profile definition > + if _profile and > _profile.has_key(u'broker-use-load-checker') and > _profile['broker-use-load-checker'] is False: > + return False > + > + # more than one host is defined in the session profile > + if len(_profile[u'host']) < 2: > + return False > + > + else: > + return False > + > + return True > + > def _import_nameservice_module(self, service='libnss'): > try: > if self.nameservice_module is None: > @@ -1046,6 +1099,49 @@ class X2GoBroker(object): > > return remote_agent > > + def get_all_remote_agents(self, profile_id): > + """\ > + Get all remote agents. > + > + @param profile_id: choose remote agent for this profile ID > + @type profile_id: C{unicode} > + > + @return: C{list} of remote agents for the given profile ID > + @rtype: C{list} > + > + """ > + remote_agents = [] > + > + # no remote agent needed for shadow sessions > + if self.is_shadow_profile(profile_id): > + return remote_agents > + > + agent_query_mode = self.get_agent_query_mode(profile_id).upper() > + if agent_query_mode == u'SSH' and > x2gobroker.agent.has_remote_broker_agent_setup(): > + > + profile = self.get_profile(profile_id) > + server_list = profile[u'host'] > + > + while server_list: > + > + remote_agent_hostname = server_list[-1] > + remote_agent_hostaddr = remote_agent_hostname > + remote_agent_port = profile[u'sshport'] > + if > profile.has_key('sshport={hostname}'.format(hostname=remote_agent_hostname)): > + remote_agent_port = > profile["sshport={hostname}".format(hostname=remote_agent_hostname)] > + if > profile.has_key('host={hostname}'.format(hostname=remote_agent_hostname)): > + remote_agent_hostaddr = > profile["host={hostname}".format(hostname=remote_agent_hostname)] > + > + remote_agents.append({ > + u'hostname': remote_agent_hostname, > + u'hostaddr': remote_agent_hostaddr, > + u'port': remote_agent_port, } > + ) > + > + server_list = server_list[0:-1] > + > + return remote_agents > + > def is_shadow_profile(self, profile_id): > """\ > Detect from the session profile, if it defines a desktop > sharing (shadow) > @@ -1357,6 +1453,25 @@ class X2GoBroker(object): > if busy_server not in server_list: > del busy_servers[busy_server] > > + > + # dynamic load-balancing > + if self.use_load_checker(self, profile_id): > + busy_servers_temp = copy.deepcopy(busy_servers) > + load_factors = > x2gobroker.loadchecker.checkload(self.backend_name, profile_id) > + if load_factors: > + for busy_server in busy_servers_temp.keys(): > + # FIXME: this may need love later > for peculiar multi-farm setups with non-FQDN hostnames in session > profile configurations > + if busy_server in > load_factors.keys() and type(load_factors[busy_server]) == > types.LongType: > + # do the load-factor / > relX2GoServerUsage calculation here... > + busy_servers_temp[busy_server] > = load_factors[busy_server] / busy_servers[busy_server] > + else: > + # ignore the load checker, > results are garbage... > + busy_servers_temp = None > + break > + > + if busy_servers_temp is not None: > + busy_servers = copy.deepcopy(busy_servers_temp) > + > busy_server_list = [ (load, server) for server, > load in busy_servers.items() ] > busy_server_list.sort() > > diff --git a/x2gobroker/defaults.py b/x2gobroker/defaults.py > index c7d4dbf..a6d4830 100644 > --- a/x2gobroker/defaults.py > +++ b/x2gobroker/defaults.py > @@ -131,6 +131,19 @@ else: > RUNDIR = '/var/run/x2gobroker' > > X2GOBROKER_AUTHSERVICE_SOCKET="{run}/x2gobroker/x2gobroker-authservice.socket".format(run=RUNDIR) > > +if os.environ.has_key('X2GOBROKER_LOADCHECKER_SOCKET'): > + > X2GOBROKER_LOADCHECKER_SOCKET=os.environ['X2GOBROKER_LOADCHECKER_SOCKET'] > +elif iniconfig_loaded and iniconfig.has_option(iniconfig_section, > 'X2GOBROKER_LOADCHECKER_SOCKET'): > + X2GOBROKER_LOADCHECKER_SOCKET=iniconfig.get(iniconfig_section, > 'X2GOBROKER_LOADCHECKER_SOCKET') > +elif iniconfig_loaded and iniconfig.has_option('common', > 'X2GOBROKER_LOADCHECKER_SOCKET'): > + X2GOBROKER_LOADCHECKER_SOCKET=iniconfig.get('common', > 'X2GOBROKER_LOADCHECKER_SOCKET') > +else: > + if os.path.isdir('/run/x2gobroker'): > + RUNDIR = '/run' > + else: > + RUNDIR = '/var/run/x2gobroker' > + > X2GOBROKER_LOADCHECKER_SOCKET="{run}/x2gobroker/x2gobroker-loadchecker.socket".format(run=RUNDIR) > + > if os.environ.has_key('X2GOBROKER_DEFAULT_BACKEND'): > X2GOBROKER_DEFAULT_BACKEND = os.environ['X2GOBROKER_DEFAULT_BACKEND'] > elif iniconfig_loaded and iniconfig.has_option(iniconfig_section, > 'X2GOBROKER_DEFAULT_BACKEND'): > @@ -210,6 +223,8 @@ X2GOBROKER_CONFIG_DEFAULTS = { > u'default-sshproxy-authorized-keys': u'%h/.x2go/authorized_keys', > u'default-agent-query-mode': u'NONE', > u'default-portscan-x2goservers': True, > + u'default-use-load-checker': False, > + u'load-checker-intervals': 300, > }, > 'broker_base': { > u'enable': False, > @@ -220,6 +235,7 @@ X2GOBROKER_CONFIG_DEFAULTS = { > u'user-db': u'libnss', > u'group-db': u'libnss', > u'desktop-shell': u'KDE', > + u'load-checker': False, > }, > 'broker_inifile': { > u'enable': True, > @@ -227,6 +243,7 @@ X2GOBROKER_CONFIG_DEFAULTS = { > u'auth-mech': u'', > u'user-db': u'', > u'group-db': u'', > + u'use-load-checker': True, > }, > 'broker_ldap': { > u'enable': False, > @@ -240,6 +257,7 @@ X2GOBROKER_CONFIG_DEFAULTS = { > u'group-search-filter': u'(&(objectClass=posifxGroup)(cn=*))', > u'starttls': False, > u'agent-query-mode': u'SSH', > + u'load-checker': True, > }, > } > > diff --git a/x2gobroker/loadchecker.py b/x2gobroker/loadchecker.py > new file mode 100644 > index 0000000..f38717e > --- /dev/null > +++ b/x2gobroker/loadchecker.py > @@ -0,0 +1,219 @@ > +# -*- coding: utf-8 -*- > + > +# This file is part of the X2Go Project - http://www.x2go.org > +# Copyright (C) 2012-2015 by Mike Gabriel <mike.gabriel(a)das-netzwerkteam.de> > +# > +# X2Go Session Broker is free software; you can redistribute it > and/or modify > +# it under the terms of the GNU Affero General Public License as > published by > +# the Free Software Foundation; either version 3 of the License, or > +# (at your option) any later version. > +# > +# X2Go Session Broker is distributed in the hope that it will be useful, > +# but WITHOUT ANY WARRANTY; without even the implied warranty of > +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > +# GNU Affero General Public License for more details. > +# > +# You should have received a copy of the GNU Affero General Public License > +# along with this program; if not, write to the > +# Free Software Foundation, Inc., > +# 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA. > + > +import threading > +import time > +import copy > +import socket > + > +# X2Go Session Broker modules > +import x2gobroker.defaults > +import x2gobroker.config > +from x2gobroker.loggers import logger_broker > + > + > +def checkload(backend, profile_id, hostname=None): > + s = socket.socket(socket.AF_UNIX, socket.SOCK_STREAM) > + logger_broker.debug('loadchecker.checkload(): connecting to > load checker service socket > {socket}'.format(socket=x2gobroker.defaults.X2GOBROKER_LOADCHECKER_SOCKET)) > + try: > + s.connect(x2gobroker.defaults.X2GOBROKER_LOADCHECKER_SOCKET) > + except socket.error, e: > + logger_broker.error('loadchecker.checkload(): failure when > connecting to the load checker service socket {socket}: > {errmsg}'.format(socket=x2gobroker.defaults.X2GOBROKER_LOADCHECKER_SOCKET, > errmsg=str(e))) > + > + if hostname is not None: > + load_factor = 'LOAD-UNAVAILABLE' > + logger_broker.debug('loadchecker.checkload(): sending > backend={backend}, profile_id={profile_id}, hostname={hostname} to > load checker service'.format(backend=backend, profile_id=profile_id, > hostname=hostname)) > + try: > + > s.send('{backend}\r{profile_id}\r{hostname}\n'.format(backend=backend, > profile_id=profile_id, hostname=hostname)) > + load_factor = s.recv(1024) > + s.close() > + except socket.error, e: > + logger_broker.error('loadchecker.checkload(): failure > when sending data to the load checker service socket {socket}: > {errmsg}'.format(socket=x2gobroker.defaults.X2GOBROKER_LOADCHECKER_SOCKET, > errmsg=str(e))) > + > + if load_factor.startswith('LOAD-UNAVAILABLE'): > + logger_broker.warning('loadchecker.checkload(): load > unavailable for backend={backend}, profile_id={profile_id}, > hostname={hostname}'.format(backend=backend, profile_id=profile_id, > hostname=hostname)) > + return None > + > + logger_broker.info('loadchecker.checkload(): load factor > for backend={backend}, profile_id={profile_id}, hostname={hostname} > is: {lf}'.format(backend=backend, profile_id=profile_id, > hostname=hostname, lf=load_factor)) > + return load_factor > + > + else: > + raw_output = "" > + logger_broker.debug('loadchecker.checkload(): sending > backend={backend}, profile_id={profile_id} to load checker > service'.format(backend=backend, profile_id=profile_id, > hostname=hostname)) > + try: > + > s.send('{backend}\r{profile_id}\r\n'.format(backend=backend, > profile_id=profile_id)) > + raw_output = s.recv(1024) > + s.close() > + except socket.error, e: > + logger_broker.error('loadchecker.checkload(): failure > when sending data to the load checker service socket {socket}: > {errmsg}'.format(socket=x2gobroker.defaults.X2GOBROKER_LOADCHECKER_SOCKET, > errmsg=str(e))) > + > + load_factors = {} > + items = raw_output.split('\n') > + for item in items: > + if ":" in item: > + key, val = item.split(':', 1) > + load_factors[key] = val > + > + logger_broker.info('loadchecker.checkload(): load metrics > for backend={backend}, profile_id={profile_id} are: > {lf}'.format(backend=backend, profile_id=profile_id, > hostname=hostname, lf=load_factors)) > + return load_factors > + > + > +class LoadChecker(threading.Thread): > + > + def __init__(self, config_file=None, config_defaults=None, > logger=None, **kwargs): > + """\ > + Initialize a new LoadChecker instance for querying remote > X2Go Broker Agent instances > + about server/system load, CPU usage, etc. > + > + """ > + self.logger = logger > + > + self.config_file = config_file > + if self.config_file is None: self.config_file = > x2gobroker.defaults.X2GOBROKER_CONFIG > + self.config_defaults = config_defaults > + if self.config_defaults is None: self.config_defaults = > x2gobroker.defaults.X2GOBROKER_CONFIG_DEFAULTS > + self.kwargs = kwargs > + > + threading.Thread.__init__(self, target=self.loadchecker) > + self.server_load = {} > + self.keep_alive = True > + self.daemon = True > + > + def get_server_load(self, backend, profile_id, hostname): > + """\ > + Retrieve system load for a given server (via broker backend, > + profile ID and hostname). > + > + @param backend: broker backend to query. > + @type backend: C{unicode} > + @param profile_id: profile ID of the session profile to query > + @type profile_id: C{unicode} > + @param hostname: hostname of the X2Go Server > + @type hostname: C{unicode} > + > + @return: load factor of the given server (or None if an > error occurs) > + @rtype: C{int} > + > + """ > + try: > + return self.server_load[backend][profile_id][hostname] > + except KeyError: > + return None > + > + def get_profile_load(self, backend, profile_id): > + """\ > + Retrieve system load for all servers for a given profile ID > (and a given > + broker backend). > + > + @param backend: broker backend to query. > + @type backend: C{unicode} > + @param profile_id: profile ID of the session profile to query > + @type profile_id: C{unicode} > + > + @return: load factor of the given server (or None if an > error occurs) > + @rtype: C{dict} > + > + """ > + try: > + return self.server_load[backend][profile_id] > + except KeyError: > + return None > + > + def loadchecker(self): > + """\ > + This is the actual thread runner that queries configured / > available X2Go Broker Agents in regular > + intervals about system load, CPU types and usage. > + > + """ > + time_to_sleep = 0 > + while self.keep_alive: > + > + # in every loop we re-read the main configuration file(s) > + # this allows changes to the config files to take > effect immediately... > + > + self.config = > x2gobroker.config.X2GoBrokerConfigFile(config_files=self.config_file, > defaults=self.config_defaults) > + self.load_checker_intervals = > self.config.get_value('global', 'load-checker-intervals') > + > + self.broker_backends = [ "_".join(bs.split('_')[1:]) > for bs in self.config.list_sections() if bs.startswith('broker_') > and self.config.get_value(bs, 'enable') ] > + > + # potentially, the X2Go Session Broker can manage > different broker backends at the same time, so we initialize > + # all configured/enabled broker backends > + self.brokers = {} > + num_queries = 0 > + for backend in self.broker_backends: > + > + if self.logger: > self.logger.debug('LoadChecker.loadchecker(): load checker thread > waking up...') > + > + if not self.server_load.has_key(backend): > + self.server_load[backend] = {} > + > + _broker_backend_module = None > + exec("import x2gobroker.brokers.{backend}_broker as > _broker_backend_module".format(backend=backend)) > + self.brokers[backend] = > _broker_backend_module.X2GoBroker(config_file=self.config_file, > config_defaults=self.config_defaults, **self.kwargs) > + profile_ids_to_check = [ id for id in > self.brokers[backend].get_profile_ids() if > self.brokers[backend].use_load_checker(id) ] > + > + for profile_id in profile_ids_to_check: > + > + if not self.server_load[backend].has_key(profile_id): > + self.server_load[backend][profile_id] = {} > + remote_agents = > self.brokers[backend].get_all_remote_agents(profile_id) > + for remote_agent in remote_agents: > + > self.server_load[backend][profile_id][remote_agent[u'hostname']] = > x2gobroker.agent.checkload(remote_agent) > + if self.logger: > self.logger.info('LoadChecker.loadchecker(): contacted remote broker > agent for backend={backend}, profile_id={profile_id}, > hostname={hostname}, new load factor is: > {lf}'.format(backend=backend, profile_id=profile_id, > hostname=remote_agent[u'hostname'], > lf=self.server_load[backend][profile_id][remote_agent[u'hostname']])) > + num_queries += 1 > + if time_to_sleep > 0: > + if self.logger: > self.logger.debug('LoadChecker.loadchecker(): sleeping for > {secs}secs before querying next server'.format(secs=time_to_sleep)) > + time.sleep(time_to_sleep) > + > + # clean up vanished hostnames > + _hostnames = > self.server_load[backend][profile_id].keys() > + for hostname in _hostnames: > + if hostname not in [ ra[u'hostname'] for ra > in remote_agents ]: > + del > self.server_load[backend][profile_id][hostname] > + > + # clean up vanished profile IDs > + _profile_ids = > copy.deepcopy(self.server_load[backend].keys()) > + for profile_id in _profile_ids: > + if profile_id not in profile_ids_to_check: > + del self.server_load[backend][profile_id] > + > + # clean up vanished backends > + _backends = copy.deepcopy(self.server_load.keys()) > + for backend in _backends: > + if backend not in self.broker_backends: > + del self.server_load[backend] > + > + # don't do all queries every 300-or-so seconds, but > distribute next round of queries over the > + # complete load_checker_intervals range > + if time_to_sleep == 0: > + if self.logger: > self.logger.debug('LoadChecker.loadchecker(): sleeping for > {secs}secs before starting next query > cycle'.format(secs=self.load_checker_intervals)) > + time.sleep(self.load_checker_intervals) > + if num_queries > 0: > + if time_to_sleep > 0: > + if self.logger: > self.logger.debug('LoadChecker.loadchecker(): performed {num} > queries, sleeping for {secs}secs before starting next query > cycle'.format(num=num_queries, secs=self.load_checker_intervals - > time_to_sleep * num_queries)) > + time.sleep(self.load_checker_intervals - > time_to_sleep * num_queries) > + time_to_sleep = self.load_checker_intervals / > (num_queries +1) > + else: > + if num_queries == 0: > + if self.logger: > self.logger.warning('LoadChecker.loadchecker(): performed {num} > queries in this cycle, if this message keeps repeating itself, > consider disabling the X2Go Broker Load Checker > daemon'.format(num=num_queries, secs=self.load_checker_intervals - > time_to_sleep * num_queries)) > + time_to_sleep = 0 > + > + def stop_thread(self): > + self.keep_alive = False > > -- > Alioth's > /srv/git/code.x2go.org/x2gobroker.git//..//_hooks_/post-receive-email on > /srv/git/code.x2go.org/x2gobroker.git > _______________________________________________ > x2go-commits mailing list > x2go-commits(a)lists.x2go.org > http://lists.x2go.org/listinfo/x2go-commits -- DAS-NETZWERKTEAM mike gabriel, herweg 7, 24357 fleckeby fon: +49 (1520) 1976 148 GnuPG Key ID 0x25771B31 mail: mike.gabriel(a)das-netzwerkteam.de, http://das-netzwerkteam.de freeBusy: https://mail.das-netzwerkteam.de/freebusy/m.gabriel%40das-netzwerkteam.de.x…

1 0

2nd Preview of X2Go Client 4.0.4.0 for OS X available
by Mihai Moldovan 26 Mar '15

26 Mar '15

Hi, Today I'm releasing the second preview of the upcoming release of X2Go Client for OS X. This version is based upon my bugfix/osx branch, branched off current master. Notable differences to the last preview : o X2Go Client now localizes to different languages again. o Updated nxproxy from the current nx-libs bundle. o Might solve Xinerama issues (hopefully for real this time -- needs testing, as I do not have multiple monitors.) Please report any regressions. Like last time, two versions are provided: one built on OS X 10.9, the other one built on OS X 10.6. The disk images can be found at: http://code.x2go.org/releases/binary-macosx/x2goclient/previews/4.0.4.0/ Best, Mihai

1 0

Failure negotiating the session in stage '7'
by Herbst, Sebastian 25 Mar '15

25 Mar '15

HI all, thank you for your work on x2go. It is a great tool. Unfortunately there is one single server. I can't connect to. It is installed just like another one (same packages different hardware), that is working, so it surely's got all necessary packages. XForwarding over ssh is working. As my other machines work well with each other, I am positive that this is an issue on the server. I tried to debug this, by increasing the log level on the server, but nothing suspicious showed up. The only hint is the client output: "Error: Failure negotiating the session in stage '7'. Error: Wrong version or invalid session authentication cookie." However none of the hints I googled worked for me. Also in IRC nobody was able to help me. I don't how to proceed. So I figured you could perhaps help me narrow down the problem. It is there any documentation describing the interaction of the server parts? If this is the wrong list to ask, please excuse me. Regards Sebastian Herbst

2 2

Bug#828: X2Go issue (in src:x2goclient) has been marked as pending for release
by Mihai Moldovan 25 Mar '15

25 Mar '15

tag #828 pending fixed #828 4.0.4.0 thanks Hello, X2Go issue #828 (src:x2goclient) reported by you has been fixed in X2Go Git. You can see the changelog below, and you can check the diff of the fix at: http://code.x2go.org/gitweb?p=x2goclient.git;a=commitdiff;h=e20207b The issue will most likely be fixed in src:x2goclient (4.0.4.0). light+love X2Go Git Admin (on behalf of the sender of this mail) --- commit e20207bcfc271286fcb07b0a3b471fff5809fab4 Author: Mihai Moldovan <ionic(a)ionic.de> Date: Wed Mar 25 21:17:38 2015 +0100 {onmainwindow.cpp,README.i18n}: fix localization -- resource strings were not correctly updated. Fixes: #828. diff --git a/debian/changelog b/debian/changelog index 5481173..c48c4d2 100644 --- a/debian/changelog +++ b/debian/changelog @@ -243,6 +243,8 @@ x2goclient (4.0.4.0-0x2go1) UNRELEASED; urgency=low Linux and Windows. - onmainwindow:cpp: correctly pass escaped single quote when writing remote xinerama config file. Post-fixup for #797. + - {onmainwindow.cpp,README.i18n}: fix localization -- resource strings + were not correctly updated. Fixes: #828. [ Fernando Pedemonte ] * New upstream release (4.0.4.0):

2 1

Bug#797: X2Go issue (in src:x2goclient) has been marked as pending for release
by Mihai Moldovan 25 Mar '15

25 Mar '15

tag #797 pending fixed #797 4.0.4.0 thanks Hello, X2Go issue #797 (src:x2goclient) reported by you has been fixed in X2Go Git. You can see the changelog below, and you can check the diff of the fix at: http://code.x2go.org/gitweb?p=x2goclient.git;a=commitdiff;h=5e1351d The issue will most likely be fixed in src:x2goclient (4.0.4.0). light+love X2Go Git Admin (on behalf of the sender of this mail) --- commit 5e1351dade7803521c9d65fd018efa2eb90f9621 Author: Mihai Moldovan <ionic(a)ionic.de> Date: Wed Mar 25 19:41:18 2015 +0100 onmainwindow:cpp: correctly pass escaped single quote when writing remote xinerama config file. Post-fixup for #797. diff --git a/debian/changelog b/debian/changelog index ff72971..5481173 100644 --- a/debian/changelog +++ b/debian/changelog @@ -241,6 +241,8 @@ x2goclient (4.0.4.0-0x2go1) UNRELEASED; urgency=low add MacPorts location. - onmainwindow.cpp: do not define Ctrl+Q two times. Made it unusable on Linux and Windows. + - onmainwindow:cpp: correctly pass escaped single quote when writing + remote xinerama config file. Post-fixup for #797. [ Fernando Pedemonte ] * New upstream release (4.0.4.0):

2 1

Bug#828: Nightly(heuler) x2goclient does not localize
by Florian Wicke - Hetzner Online AG 25 Mar '15

25 Mar '15

Package: x2goclient Version: 4.0.4.0-0x2go1~git20150321.952+wheezy.heuler.1_amd64 The x2goclient package from heuler does not localize to the current LANG/locales. Reproducable with my debian wheezy thinclient. The previously installed x2goclient from main correctly localizes to german. Uninstalling x2go* from main and installing from heuler results in a full englisch client. -- Kind regards Florian Wicke Hetzner Online AG Industriestr. 25 91710 Gunzenhausen / Germany Tel: +49 9831 505-0 Fax: +49 9831 505-3 florian.wicke(a)hetzner.de www.hetzner.com Register Court: Registergericht Ansbach, HRB 3204 Management Board: Dipl. Ing. (FH) Martin Hetzner Chairwoman of the Supervisory Board: Diana Rothhan

2 1

Why are we not adding packages.x2go.org to mock and obs?
by Mihai Moldovan 24 Mar '15

24 Mar '15

Hi The subject pretty much sums it up. We are currently not adding our packages on packages.x2go.org to mock and obs builds. Is there any specific reason, why not? To build cleanly? This is a deal breaker for packages that require x2go packages at build time when downstream does not have official x2go* packages. For instance, any package depending on x2goserver at build time will fail to build for OpenSUSE, because OpenSUSE is not providing any x2go packages. Another incarnation is the issue I mentioned here: http://lists.x2go.org/pipermail/x2go-dev/2015-March/009739.html On Fedora (possibly EPEL, too), x2goserver-extensions does not exist as a special package, but the functionality is merged into the "x2goserver" package. A more general description: our builds for packages.x2go.org will fail whenever there is a build dependency on x2go packages, that may have been edited by distribution maintainers. We have no control over this. Adding the x2go repositories will, though, make sure we control this aspect. Furthermore, Debian builds always* add our own package repository. I will go ahead and add our repository to obs and mock builds, if the reason is merely "because nobody implemented it so far". Mihai *) No rule without an exception. In this case the exception is "x2go-keyring".

2 4

Preview of X2Go Client 4.0.4.0 for OS X available
by Mihai Moldovan 23 Mar '15

23 Mar '15

Hi, I am happy to once again provide a preview version of what is hopefully to be included in the next upcoming release of X2Go Client. This version is based upon my bugfix/osx branch, branched off current master. Notable differences to the current 4.0.3.2 release: o Does not show an error message if a local SSH daemon is not running and Remote Printing/File Sharing support has been enabled. Instead, an sshd daemon is started explicitly for this session with user privileges. Configuration and authentication data is contained in ~/.x2go/.ssh and ~/.x2go/ssh for this daemon. o Improved error messages, including removing wrong ones, when XQuartz is not installed on the machine. o Completely new, automatic UNIX cleanup helper utility. X2Go Client now starts a new process which tracks its parent. Should the main process crash for any reason, the cleanup process terminates "zombie" processes started by the main process and commits suicide. This is important for killing started OpenSSH, PulseAudio servers etc. This feature is also available on Linux and *BSD. o Some non-critical error messages are now not blocking the client anymore. This allows for the session to start even though the error message pops up and is not confirmed. o Version is now exposed when using "Get Info" in Finder.app. Please report any regressions. Like last time, two versions are provided: one built on OS X 10.9, the other one built on OS X 10.6. The disk images can be found at: http://code.x2go.org/releases/binary-macosx/x2goclient/previews/4.0.4.0/ Best, Mihai

1 0

Bug#774: please set DESKTOP_SESSION and XDG_CURRENT_DESKTOP like local sessions
by Ryan Tandy 20 Mar '15

20 Mar '15

Package: x2goserver Version: 4.1.0.0-0~1215~ubuntu14.04.1 Severity: wishlist Hi, In Ubuntu before 15.04, and Debian jessie, the DESKTOP_SESSION for GNOME Flashback is actually "gnome-fallback". In particular, this name is found in /etc/upstart-xsessions while "gnome-flashback" is not, which prevents Upstart user sessions from being enabled. ("gnome-session --session=gnome-flashback is still the correct command, though.) Furthermore, recent (Ubuntu >= 13.10, Debian jessie) login managers also export XDG_CURRENT_DESKTOP using the value of the DesktopNames field from the session file. This variable is starting to gain wide use by applications that care about the desktop environment they run under. I can write a patch that adds all this information to x2goruncommand in the existing format. However it occurs to me that it might make more sense to parse the files in /usr/share/xsessions and use the information directly instead of duplicating it. Please let me know which you'd prefer to see. -- Ryan Tandy - Programmer/Analyst rtandy(a)sd63.bc.ca School District 63 (Saanich) +1 250 652 7385

4 5

Patch: x2goserver: x2goruncommand - set IMEXIT="true" for gnome-terminal
by Rok Mandeljc 20 Mar '15

20 Mar '15

Hello, I have been trying to set up x2goserver on my Fedora 21 boxes, and gnome-terminal seems to be failing with symptoms similar to those described in #268. It seems that x2goruncommand has been reworked a bit since that patch, and now attempts to force the forking programs to stay in the foreground by capturing their output to STDOUT. Unfortunately, this does not seem to work for gnome-terminal; the terminal window appears on the client for a second, then closes and the session is proclaimed to be finished. This can be fixed by explicitly setting IMEXIT="true" if called binary is gnome-terminal, which is done by the attached patch. Regards, Rok

4 8

x2goserver not upgradable on CentOS
by Wim De Smet 20 Mar '15

20 Mar '15

Hi, I assume that this is the same problem as on ubuntu. Is a fix forthcoming? Error: Package: libNX_Xfixes-3.5.0.28-0.0x2go1.1.git20141114.546.main.el6.x86_64 (@x2go-releases) Requires: nx-libs(x86-64) = 3.5.0.28-0.0x2go1.1.git20141114.546.main.el6 Removing: nx-libs-3.5.0.28-0.0x2go1.1.git20141114.546.main.el6.x86_64 (@x2go-releases) nx-libs(x86-64) = 3.5.0.28-0.0x2go1.1.git20141114.546.main.el6 Updated By: nx-libs-3.5.0.30-0.0x2go1.1.git20150314.661.main.el6.x86_64 (x2go-releases) nx-libs(x86-64) = 3.5.0.30-0.0x2go1.1.git20150314.661.main.el6 Error: Package: x2goserver-4.0.1.19-0.0x2go2.1.git20150314.1064.main.el6.x86_64 (x2go-releases) Requires: perl(Try::Tiny) Error: Package: libXcomp-3.5.0.28-0.0x2go1.1.git20141114.546.main.el6.x86_64 (@x2go-releases) Requires: nx-libs(x86-64) = 3.5.0.28-0.0x2go1.1.git20141114.546.main.el6 Removing: nx-libs-3.5.0.28-0.0x2go1.1.git20141114.546.main.el6.x86_64 (@x2go-releases) nx-libs(x86-64) = 3.5.0.28-0.0x2go1.1.git20141114.546.main.el6 Updated By: nx-libs-3.5.0.30-0.0x2go1.1.git20150314.661.main.el6.x86_64 (x2go-releases) nx-libs(x86-64) = 3.5.0.30-0.0x2go1.1.git20150314.661.main.el6 Error: Package: libXcompshad-3.5.0.28-0.0x2go1.1.git20141114.546.main.el6.x86_64 (@x2go-releases) Requires: nx-libs(x86-64) = 3.5.0.28-0.0x2go1.1.git20141114.546.main.el6 Removing: nx-libs-3.5.0.28-0.0x2go1.1.git20141114.546.main.el6.x86_64 (@x2go-releases) nx-libs(x86-64) = 3.5.0.28-0.0x2go1.1.git20141114.546.main.el6 Updated By: nx-libs-3.5.0.30-0.0x2go1.1.git20150314.661.main.el6.x86_64 (x2go-releases) nx-libs(x86-64) = 3.5.0.30-0.0x2go1.1.git20150314.661.main.el6 Error: Package: libXcompext-3.5.0.28-0.0x2go1.1.git20141114.546.main.el6.x86_64 (@x2go-releases) Requires: nx-libs(x86-64) = 3.5.0.28-0.0x2go1.1.git20141114.546.main.el6 Removing: nx-libs-3.5.0.28-0.0x2go1.1.git20141114.546.main.el6.x86_64 (@x2go-releases) nx-libs(x86-64) = 3.5.0.28-0.0x2go1.1.git20141114.546.main.el6 Updated By: nx-libs-3.5.0.30-0.0x2go1.1.git20150314.661.main.el6.x86_64 (x2go-releases) nx-libs(x86-64) = 3.5.0.30-0.0x2go1.1.git20150314.661.main.el6

2 7

Bug#827: X2Go issue (in src:x2goclient) has been marked as pending for release
by Mihai Moldovan 20 Mar '15

20 Mar '15

tag #827 pending fixed #827 4.0.4.0 thanks Hello, X2Go issue #827 (src:x2goclient) reported by you has been fixed in X2Go Git. You can see the changelog below, and you can check the diff of the fix at: http://code.x2go.org/gitweb?p=x2goclient.git;a=commitdiff;h=3d57875 The issue will most likely be fixed in src:x2goclient (4.0.4.0). light+love X2Go Git Admin (on behalf of the sender of this mail) --- commit 3d578752ed4de8f03673d22181952e798f4484ba Author: Jason Alavaliant <alavaliant(a)ra09.com> Date: Fri Mar 20 05:37:38 2015 +0100 onmainwindow.cpp: handle %i and %c format flags in desktop files correctly: remove the %i flag and replace %c with the application name. Fixes: #827. diff --git a/debian/changelog b/debian/changelog index db1aefd..f14053e 100644 --- a/debian/changelog +++ b/debian/changelog @@ -254,6 +254,12 @@ x2goclient (4.0.4.0-0x2go1) UNRELEASED; urgency=low * New upstream release (4.0.4.0): - onmainwindow.cpp: fix desktop sharing via session broker. Fixes: #584. + [ Jason Alavaliant ] + * New upstream release (4.0.4.0): + - onmainwindow.cpp: handle %i and %c format flags in desktop files + correctly: remove the %i flag and replace %c with the application name. + Fixes: #827. + -- X2Go Release Manager <git-admin(a)x2go.org> Thu, 19 Feb 2015 13:25:28 +0100 x2goclient (4.0.3.2-0x2go1) unstable; urgency=medium

2 1

Bug#827: hosted application doesn't support %i and %c in application exec param
by Jason Alavaliant 19 Mar '15

19 Mar '15

Package: x2goclient Version: 4.0.3.2 Tags: patch kde based apps on my machines have Exec lines in their desktop files along the line of Exec=okular %U %i -caption %c when launched via the hosted applications mode applications menu of x2goclient the "%i -caption %c" get passed as arguments to the command directly. That results in the program trying to load the file '%i' (and naturally failing) and setting the window caption to '%c' The attached patch updates the x2go client to removes the %i param and replaces %c with the application name so the program is titled correctly. Thanks Jason

1 0

Bug#584: X2Go issue (in src:x2goclient) has been marked as pending for release
by Mihai Moldovan 19 Mar '15

19 Mar '15

tag #584 pending fixed #584 4.0.4.0 thanks Hello, X2Go issue #584 (src:x2goclient) reported by you has been fixed in X2Go Git. You can see the changelog below, and you can check the diff of the fix at: http://code.x2go.org/gitweb?p=x2goclient.git;a=commitdiff;h=d294bbb The issue will most likely be fixed in src:x2goclient (4.0.4.0). light+love X2Go Git Admin (on behalf of the sender of this mail) --- commit d294bbb3bb4178dfca02d1a999775b9e974e36b0 Author: Mike Gabriel <mike.gabriel(a)das-netzwerkteam.de> Date: Thu Mar 19 02:06:10 2015 +0100 onmainwindow.cpp: fix desktop sharing via session broker. Fixes: #584. diff --git a/debian/changelog b/debian/changelog index 7ffc347..db1aefd 100644 --- a/debian/changelog +++ b/debian/changelog @@ -250,6 +250,10 @@ x2goclient (4.0.4.0-0x2go1) UNRELEASED; urgency=low - {LICENSE,debian/copyright}: fix typo in URL of obviously-nice.de. Fixes: #811. + [ Mike Gabriel ] + * New upstream release (4.0.4.0): + - onmainwindow.cpp: fix desktop sharing via session broker. Fixes: #584. + -- X2Go Release Manager <git-admin(a)x2go.org> Thu, 19 Feb 2015 13:25:28 +0100 x2goclient (4.0.3.2-0x2go1) unstable; urgency=medium

2 1

Bug#811: X2Go issue (in src:x2goclient) has been marked as pending for release
by Mihai Moldovan 19 Mar '15

19 Mar '15

tag #811 pending fixed #811 4.0.4.0 thanks Hello, X2Go issue #811 (src:x2goclient) reported by you has been fixed in X2Go Git. You can see the changelog below, and you can check the diff of the fix at: http://code.x2go.org/gitweb?p=x2goclient.git;a=commitdiff;h=02dda79 The issue will most likely be fixed in src:x2goclient (4.0.4.0). light+love X2Go Git Admin (on behalf of the sender of this mail) --- commit 02dda7931f6a6e10f1535eae4ef15e45f53c0bd3 Author: René Genz <liebundartig(a)freenet.de> Date: Mon Mar 16 05:47:15 2015 +0100 {LICENSE,debian/copyright}: fix typo in URL of obviously-nice.de. diff --git a/debian/changelog b/debian/changelog index 6301aa0..7ffc347 100644 --- a/debian/changelog +++ b/debian/changelog @@ -245,6 +245,11 @@ x2goclient (4.0.4.0-0x2go1) UNRELEASED; urgency=low - onmainwindow.cpp: fix bad quoting when writing remote xinerama config file. Fixes: #797. + [ René Genz ] + * New upstream release (4.0.4.0): + - {LICENSE,debian/copyright}: fix typo in URL of obviously-nice.de. + Fixes: #811. + -- X2Go Release Manager <git-admin(a)x2go.org> Thu, 19 Feb 2015 13:25:28 +0100 x2goclient (4.0.3.2-0x2go1) unstable; urgency=medium

2 1

Bug#584: x2go Session Broker don't work with shadow sessions
by KeRo 19 Mar '15

19 Mar '15

Package: x2gobroker Version: 0.0.3.0 I have two type of broker session configured, MATE for normal desktop use and a SHADOW session for support and presentation. MATE sessions work fine but SHADOW session show Access Denied throw broker (Direct shadow session configured in x2go client work fine) The session displays of shadow connection dont appear throw broker :S x2go Server is a Ubuntu Desktop 14.04 with MATE Error in x2go Server syslog: NOVEA-desk /usr/bin/x2gostartagent: user ,,pam'' requests desktop sharing from user ,,'' for desktop ,,'' NOVEA-desk /usr/bin/x2gostartagent: ERROR: user denied desktop sharing session Broker sessions config: [DEFAULT] command=TERMINAL defsndport=true useiconv=false iconvfrom=UTF-8 height=768 export= quality=9 fullscreen=false layout=es useexports=true width=1024 speed=2 soundsystem=pulse print=true type=pc105/es sndport=4713 xinerama=true variant= usekbd=true fstunnel=true applications=TERMINAL,WWWBROWSER,MAILCLIENT,OFFICE multidisp=false sound=true rootless=true iconvto=UTF-8 soundtunnel=true dpi=96 sshport=22 setdpi=0 pack=16m-jpeg directrdp=false user=BROKER_USER usesshproxy=true sshproxytype=SSH sshproxyhost=broker.test.com sshproxyport=22 sshproxyautologin=false sshproxysamepass=true sshproxysameuser=true [NOVEA-pim-access] name=NOVEA ACCESS host=172.16.110.101 command=MATE acl-users-allow=pim acl-users-deny=ALL acl-clients-deny=ALL acl-clients-allow=0.0.0.0/0 acl-any-order=deny-allow [NOVEA-pim-support] name=NOVEA Support host=172.16.110.101 command=SHADOW acl-users-allow=pim acl-users-deny=ALL acl-clients-deny=ALL acl-clients-allow=0.0.0.0/0 acl-any-order=deny-allow [NOVEA-pam-access] name=NOVEA ACCESS host=172.16.110.101 command=MATE acl-users-allow=pam acl-users-deny=ALL acl-clients-deny=ALL acl-clients-allow=0.0.0.0/0 acl-any-order=deny-allow [NOVEA-pam-support] name=NOVEA Support host=172.16.110.101 command=SHADOW acl-users-allow=pam acl-users-deny=ALL acl-clients-deny=ALL acl-clients-allow=0.0.0.0/0 acl-any-order=deny-allow Thanks for your help.

3 5

Bug#825: soft cursor for shared NX sessions
by Mike Gabriel 18 Mar '15

18 Mar '15

Package: libxcompshad Severity: wishlist Version: 3.5.0.29 Control: forwarded -1 https://github.com/ArcticaProject/nx-libs/issues/7 (1) launch NX/X2Go session on remote machine (2) share that remote session from another location (e.g. helpdesk center) if the person running the shared session (helpdesk agent) moves the mouse pointer, the person running the native NX session cannot see those pointer movements. Feature request: add a soft mouse pointer that presents mouse events of the desktop sharing agent. Further discussion here: https://github.com/ArcticaProject/nx-libs/issues/7 Mike -- DAS-NETZWERKTEAM mike gabriel, herweg 7, 24357 fleckeby fon: +49 (1520) 1976 148 GnuPG Key ID 0x25771B31 mail: mike.gabriel(a)das-netzwerkteam.de, http://das-netzwerkteam.de freeBusy: https://mail.das-netzwerkteam.de/freebusy/m.gabriel%40das-netzwerkteam.de.x…

1 0

Bug#824: X2GoClient Session Sharing does not work from a Windows Client
by Stefan Baur 18 Mar '15

18 Mar '15

package: x2goclient version: 4.0.3.2-0x2go1 I am trying to connect from Win7x64, with a 32-bit color depth, to a Linux X2Go server's :0 display, running in 24-bit color depth. Please have a look at the attached screenshot - it will explain why this is unusable, bettern than any words. -Stefan -- BAUR-ITCS UG (haftungsbeschränkt) Geschäftsführer: Stefan Baur Eichenäckerweg 10, 89081 Ulm | Registergericht Ulm, HRB 724364 Fon/Fax 0731 40 34 66-36/-35 | USt-IdNr.: DE268653243

1 0

Bug#823: Unable to enter SSH keyfile passphrase into X2GoClient in ThinClient mode when combined with Session Boker Login
by Stefan Baur 18 Mar '15

18 Mar '15

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 package: x2goclient version: 4.0.3.2 severity: normal When running X2GoClient in ThinClient mode, it is impossible to log in to a Sesion Broker using an SSH private key file that is protected with a passphrase. It will always show a popup prompting for the passphrase, but it is impossible to enter the passphrase - the cursor is blinking, but only the OK and cancel buttons work. (I tried typing the passphrase in anyways, it didn't work either) - -Stefan - -- BAUR-ITCS UG (haftungsbeschränkt) Geschäftsführer: Stefan Baur Eichenäckerweg 10, 89081 Ulm | Registergericht Ulm, HRB 724364 Fon/Fax 0731 40 34 66-36/-35 | USt-IdNr.: DE268653243 -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (MingW32) iQEcBAEBAgAGBQJVCZnwAAoJEG7d9BjNvlEZktIH/i2YBn+UtwTUFyH3nA6B+j32 XeEkoc3bLfNWYdU5+UjVf3I7nWDRTi12Z96MGAJWX/feZrTQXpPm0dU9dNYzyP3P KfSHKzBie4pwLS0jk/uCDzJzFUkjCtzTIPBWIUVnvr2fZlkrtT8G2v5IdebrUd3l y7alLqyMKtCy3ogSCR9diOHB02rsfapGfeogl6RaG3gnIh/LaAC/hXEnL+c8Z6D+ +mT8ZUbsx16F6cq4A/oEbzgz2VSe4RYLfNgMulc5Mh5VEjkfkrB4jR2/xksEQe2k BSn4jskZIP+S1FZoKsFLSIJxcSkzGDHQyWbKca6VhJLrp33Ma7zYmmdYeoLDM7g= =Hg+3 -----END PGP SIGNATURE-----

1 0

Bug#808: x2goclient freeze after several seconds
by Jozsef Kozo 18 Mar '15

18 Mar '15

Package: x2goclient Version: 4.0.3.1 ( Qt- 4.8.6) Client OS: Windows 8.1 Enterprise x64 Server OS: CentOS 6.5 Hi all, I can connect from a client to my server. I am able to connect but several seconds ~30 my session freeze and x2go ask me for terminate my session. Tried with several versions of client, with same issue. Also tried disable audio, file sharing,clipboard,keyboard settings, and run with administrator privileges, disable firewall. This happens even when no other sessions are running on the client machine. Debug says : http://pastebin.com/837xZS97 I reported this on IRC they told me create ticket cause this can be a bug. Best, JK

4 6

Bug#822: X2Go issue (in src:x2gomatebindings) has been marked as pending for release
by Mihai Moldovan 18 Mar '15

18 Mar '15

tag #822 pending fixed #822 0.0.1.4 thanks Hello, X2Go issue #822 (src:x2gomatebindings) reported by you has been fixed in X2Go Git. You can see the changelog below, and you can check the diff of the fix at: http://code.x2go.org/gitweb?p=x2gomatebindings.git;a=commitdiff;h=36e4e11 The issue will most likely be fixed in src:x2gomatebindings (0.0.1.4). light+love X2Go Git Admin (on behalf of the sender of this mail) --- commit 36e4e1122e412362441c562f6bb1beec06ae185e Author: Mihai Moldovan <ionic(a)ionic.de> Date: Wed Mar 18 06:03:06 2015 +0100 x2gomatebindings.spec: only own files, do not blindly own complete (and alien!) directories. Fixes: #822. diff --git a/debian/changelog b/debian/changelog index a55765a..669b792 100644 --- a/debian/changelog +++ b/debian/changelog @@ -9,6 +9,8 @@ x2gomatebindings (0.0.1.4-0~x2go1) UNRELEASED; urgency=low [ Mihai Moldovan ] * x2gomatebindings.spec: - Add run and build time dependency: filesystem. + - Only own files, do not blindly own complete (and alien!) directories. + Fixes: #822. -- X2Go Release Manager <git-admin(a)x2go.org> Tue, 10 Feb 2015 23:48:43 +0100

2 1

Bug#821: x2gomatebindings fails to install from RPM
by Michael DePaulo 18 Mar '15

18 Mar '15

Package:x2gomatebindings Version: 0.0.1.3 As reported by Matt1 on IRC, and reproduced by myself, x2ogmatebindings fails to install on Fedora 21 (64-bit), and presumably every other RPM-based distro: http://pastebin.com/PUZ6Mgec Error: Package: x2gomatebindings-0.0.1.3-0.0x2go1.1.git20150211.160.main.fc20.x86_64 (x2go-releases) Requires: or It appears to be due to line 31 in x2gomatebindings.spec: Requires: gtk2 or gtk3

2 1

Bug#822: x2gomatebindings fails to install from RPM #2
by Michael DePaulo 17 Mar '15

17 Mar '15

Package: x2gomatebindings Version: 0.0.1.3 After fixing #821 ("x2gomatebindings fails to install from RPM"), I discovered that x2gomatebindings will not install on Fedora 21 64-bit (and presumably every other RPM-based distro) for another reason: http://pastebin.com/3K7Q8xSr file /usr/bin from install of x2gomatebindings-0.0.1.4-0.0x2go1.0.git20150317.162.heuler.fc21.x86_64 conflicts with file from package filesystem-3.2-28.fc21.x86_64 file /usr/lib64 from install of x2gomatebindings-0.0.1.4-0.0x2go1.0.git20150317.162.heuler.fc21.x86_64 conflicts with file from package filesystem-3.2-28.fc21.x86_64 file /usr/sbin from install of x2gomatebindings-0.0.1.4-0.0x2go1.0.git20150317.162.heuler.fc21.x86_64 conflicts with file from package filesystem-3.2-28.fc21.x86_64 The problem appears to be in the %files section in x2gomatebindings.spec: %files %defattr(-,root,root) %doc debian/changelog %doc debian/copyright %{_sysconfdir}/ %{_bindir}/ %{_sbindir}/ %{_datadir}/ %{_libdir}/

2 1

Bug#821: X2Go issue (in src:x2gomatebindings) has been marked as pending for release
by Mike DePaulo 17 Mar '15

17 Mar '15

tag #821 pending fixed #821 0.0.1.4 thanks Hello, X2Go issue #821 (src:x2gomatebindings) reported by you has been fixed in X2Go Git. You can see the changelog below, and you can check the diff of the fix at: http://code.x2go.org/gitweb?p=x2gomatebindings.git;a=commitdiff;h=589edbf The issue will most likely be fixed in src:x2gomatebindings (0.0.1.4). light+love X2Go Git Admin (on behalf of the sender of this mail) --- commit 589edbf2b9d243f5a53163b4314870400d3630e5 Author: Mike DePaulo <mikedep333(a)gmail.com> Date: Tue Mar 17 08:36:28 2015 -0400 Update changelog about bug #821 diff --git a/debian/changelog b/debian/changelog index 6e237a0..ecf53d0 100644 --- a/debian/changelog +++ b/debian/changelog @@ -3,7 +3,7 @@ x2gomatebindings (0.0.1.4-0~x2go1) UNRELEASED; urgency=low [ Mike DePaulo ] * New upstream version (0.0.1.4): - Fix error when installing from an RPM built from the X2Go - project's .spec file: + project's .spec file (Fixes: #821): "Error: Package: x2gomatebinding ... Requires: or" -- X2Go Release Manager <git-admin(a)x2go.org> Tue, 10 Feb 2015 23:48:43 +0100

2 1

Bug#819: X2Go Client exposes all (network and local) drives on client-side folder sharing
by Mike Gabriel 16 Mar '15

16 Mar '15

Package: x2goclient Version: 4.0.3.2 Tags: build-win32 Severity: grave Hi all, I am not sure if this bug is X2Go Client or X2Go Server related, because I have no extended access to the site where the below issue just occurred. Client: X2Go Client for Windows (4.0.3.2-20150301) on Windows 8.1 64bit Server: X2Go Server 4.0.1.19 running on Ubuntu 10.04 Session Type: GNOMEv2 desktop session The windows machine is hooked into a network, i.e. the Windows's users %HOMEDRIVE% is on a server-side share, there are also several other network drives available. (as drive letters). The user (a customer of mine) tried to directly share the "Documents" folder with the running X2Go session and then this SSHFS mount appeared on the X2Go Server's side: ~user/media/disk/_cygdrive_ This "_cygdrive_" folder contained letters (one drive letter per available network drive). From there on you could browse all drive letters and sub-directories available on the client-side MS Windows machine. Thus, exposing all sorts of drive letters and their subfolders to the X2Go session. !!! This must be considered as a severe data security breach. !!! minor side issue: Furthermore, client-side shared folders hosted on network drives appeared in the X2Go session, but were not accessible by the user running the X2Go session (marked by a read cross and a padlock). Greets, Mike -- DAS-NETZWERKTEAM mike gabriel, herweg 7, 24357 fleckeby fon: +49 (1520) 1976 148 GnuPG Key ID 0x25771B31 mail: mike.gabriel(a)das-netzwerkteam.de, http://das-netzwerkteam.de freeBusy: https://mail.das-netzwerkteam.de/freebusy/m.gabriel%40das-netzwerkteam.de.x…

1 0

Processed: your mail
by owner＠bugs.x2go.org 16 Mar '15

16 Mar '15

Processing commands for control(a)bugs.x2go.org: > reassign #815 nx-libs Bug #815 {Done: Mike Gabriel <mike.gabriel(a)das-netzwerkteam.de>} [nx-libs] x2goserver not installable Ubuntu 14.04 Bug #816 {Done: Mike Gabriel <mike.gabriel(a)das-netzwerkteam.de>} [nx-libs] Installation x2goserver on Ubuntu 14.04 Bug #817 {Done: Mike Gabriel <mike.gabriel(a)das-netzwerkteam.de>} [nx-libs] x2goserver from x2go ppa doesn't install due to unmet dependencies Ignoring request to reassign bug #815 to the same package Ignoring request to reassign bug #816 to the same package Ignoring request to reassign bug #817 to the same package > reassign #816 nx-libs Bug #816 {Done: Mike Gabriel <mike.gabriel(a)das-netzwerkteam.de>} [nx-libs] Installation x2goserver on Ubuntu 14.04 Bug #815 {Done: Mike Gabriel <mike.gabriel(a)das-netzwerkteam.de>} [nx-libs] x2goserver not installable Ubuntu 14.04 Bug #817 {Done: Mike Gabriel <mike.gabriel(a)das-netzwerkteam.de>} [nx-libs] x2goserver from x2go ppa doesn't install due to unmet dependencies Ignoring request to reassign bug #816 to the same package Ignoring request to reassign bug #815 to the same package Ignoring request to reassign bug #817 to the same package > close #816 Bug #816 {Done: Mike Gabriel <mike.gabriel(a)das-netzwerkteam.de>} [nx-libs] Installation x2goserver on Ubuntu 14.04 Bug #815 {Done: Mike Gabriel <mike.gabriel(a)das-netzwerkteam.de>} [nx-libs] x2goserver not installable Ubuntu 14.04 Bug #817 {Done: Mike Gabriel <mike.gabriel(a)das-netzwerkteam.de>} [nx-libs] x2goserver from x2go ppa doesn't install due to unmet dependencies Bug 816 is already marked as done; not doing anything. > forcemerge #815 #816 Bug #815 {Done: Mike Gabriel <mike.gabriel(a)das-netzwerkteam.de>} [nx-libs] x2goserver not installable Ubuntu 14.04 Bug #816 {Done: Mike Gabriel <mike.gabriel(a)das-netzwerkteam.de>} [nx-libs] Installation x2goserver on Ubuntu 14.04 Bug #817 {Done: Mike Gabriel <mike.gabriel(a)das-netzwerkteam.de>} [nx-libs] x2goserver from x2go ppa doesn't install due to unmet dependencies Bug #816 {Done: Mike Gabriel <mike.gabriel(a)das-netzwerkteam.de>} [nx-libs] Installation x2goserver on Ubuntu 14.04 Bug #817 {Done: Mike Gabriel <mike.gabriel(a)das-netzwerkteam.de>} [nx-libs] x2goserver from x2go ppa doesn't install due to unmet dependencies Merged 815 816 817 > reassign #817 nx-libs Bug #817 {Done: Mike Gabriel <mike.gabriel(a)das-netzwerkteam.de>} [nx-libs] x2goserver from x2go ppa doesn't install due to unmet dependencies Bug #815 {Done: Mike Gabriel <mike.gabriel(a)das-netzwerkteam.de>} [nx-libs] x2goserver not installable Ubuntu 14.04 Bug #816 {Done: Mike Gabriel <mike.gabriel(a)das-netzwerkteam.de>} [nx-libs] Installation x2goserver on Ubuntu 14.04 Ignoring request to reassign bug #817 to the same package Ignoring request to reassign bug #815 to the same package Ignoring request to reassign bug #816 to the same package > close #817 Bug #817 {Done: Mike Gabriel <mike.gabriel(a)das-netzwerkteam.de>} [nx-libs] x2goserver from x2go ppa doesn't install due to unmet dependencies Bug #815 {Done: Mike Gabriel <mike.gabriel(a)das-netzwerkteam.de>} [nx-libs] x2goserver not installable Ubuntu 14.04 Bug #816 {Done: Mike Gabriel <mike.gabriel(a)das-netzwerkteam.de>} [nx-libs] Installation x2goserver on Ubuntu 14.04 Bug 817 is already marked as done; not doing anything. > forcemerge #815 #817 Bug #815 {Done: Mike Gabriel <mike.gabriel(a)das-netzwerkteam.de>} [nx-libs] x2goserver not installable Ubuntu 14.04 Bug #816 {Done: Mike Gabriel <mike.gabriel(a)das-netzwerkteam.de>} [nx-libs] Installation x2goserver on Ubuntu 14.04 Bug #817 {Done: Mike Gabriel <mike.gabriel(a)das-netzwerkteam.de>} [nx-libs] x2goserver from x2go ppa doesn't install due to unmet dependencies Bug #816 {Done: Mike Gabriel <mike.gabriel(a)das-netzwerkteam.de>} [nx-libs] Installation x2goserver on Ubuntu 14.04 Bug #817 {Done: Mike Gabriel <mike.gabriel(a)das-netzwerkteam.de>} [nx-libs] x2goserver from x2go ppa doesn't install due to unmet dependencies Merged 815 816 817 > thanks Stopping processing here. Please contact me if you need assistance. -- 815: http://bugs.x2go.org/cgi-bin/bugreport.cgi?bug=815 816: http://bugs.x2go.org/cgi-bin/bugreport.cgi?bug=816 817: http://bugs.x2go.org/cgi-bin/bugreport.cgi?bug=817 X2Go Bug Tracking System Contact owner(a)bugs.x2go.org with problems

1 0

Processed: your mail
by owner＠bugs.x2go.org 16 Mar '15

16 Mar '15

Processing commands for control(a)bugs.x2go.org: > reassign #815 nx-libs Bug #815 {Done: Mike Gabriel <mike.gabriel(a)das-netzwerkteam.de>} [nx-libs] x2goserver not installable Ubuntu 14.04 Bug #816 {Done: Mike Gabriel <mike.gabriel(a)das-netzwerkteam.de>} [nx-libs] Installation x2goserver on Ubuntu 14.04 Bug #817 {Done: Mike Gabriel <mike.gabriel(a)das-netzwerkteam.de>} [nx-libs] x2goserver from x2go ppa doesn't install due to unmet dependencies Ignoring request to reassign bug #815 to the same package Ignoring request to reassign bug #816 to the same package Ignoring request to reassign bug #817 to the same package > reassign #816 nx-libs Bug #816 {Done: Mike Gabriel <mike.gabriel(a)das-netzwerkteam.de>} [nx-libs] Installation x2goserver on Ubuntu 14.04 Bug #815 {Done: Mike Gabriel <mike.gabriel(a)das-netzwerkteam.de>} [nx-libs] x2goserver not installable Ubuntu 14.04 Bug #817 {Done: Mike Gabriel <mike.gabriel(a)das-netzwerkteam.de>} [nx-libs] x2goserver from x2go ppa doesn't install due to unmet dependencies Ignoring request to reassign bug #816 to the same package Ignoring request to reassign bug #815 to the same package Ignoring request to reassign bug #817 to the same package > close #816 Bug #816 {Done: Mike Gabriel <mike.gabriel(a)das-netzwerkteam.de>} [nx-libs] Installation x2goserver on Ubuntu 14.04 Bug #815 {Done: Mike Gabriel <mike.gabriel(a)das-netzwerkteam.de>} [nx-libs] x2goserver not installable Ubuntu 14.04 Bug #817 {Done: Mike Gabriel <mike.gabriel(a)das-netzwerkteam.de>} [nx-libs] x2goserver from x2go ppa doesn't install due to unmet dependencies Bug 816 is already marked as done; not doing anything. > forcemerge #815 #816 Bug #815 {Done: Mike Gabriel <mike.gabriel(a)das-netzwerkteam.de>} [nx-libs] x2goserver not installable Ubuntu 14.04 Bug #816 {Done: Mike Gabriel <mike.gabriel(a)das-netzwerkteam.de>} [nx-libs] Installation x2goserver on Ubuntu 14.04 Bug #817 {Done: Mike Gabriel <mike.gabriel(a)das-netzwerkteam.de>} [nx-libs] x2goserver from x2go ppa doesn't install due to unmet dependencies Bug #816 {Done: Mike Gabriel <mike.gabriel(a)das-netzwerkteam.de>} [nx-libs] Installation x2goserver on Ubuntu 14.04 Bug #817 {Done: Mike Gabriel <mike.gabriel(a)das-netzwerkteam.de>} [nx-libs] x2goserver from x2go ppa doesn't install due to unmet dependencies Merged 815 816 817 > reassign #817 nx-libs Bug #817 {Done: Mike Gabriel <mike.gabriel(a)das-netzwerkteam.de>} [nx-libs] x2goserver from x2go ppa doesn't install due to unmet dependencies Bug #815 {Done: Mike Gabriel <mike.gabriel(a)das-netzwerkteam.de>} [nx-libs] x2goserver not installable Ubuntu 14.04 Bug #816 {Done: Mike Gabriel <mike.gabriel(a)das-netzwerkteam.de>} [nx-libs] Installation x2goserver on Ubuntu 14.04 Ignoring request to reassign bug #817 to the same package Ignoring request to reassign bug #815 to the same package Ignoring request to reassign bug #816 to the same package > close #817 Bug #817 {Done: Mike Gabriel <mike.gabriel(a)das-netzwerkteam.de>} [nx-libs] x2goserver from x2go ppa doesn't install due to unmet dependencies Bug #815 {Done: Mike Gabriel <mike.gabriel(a)das-netzwerkteam.de>} [nx-libs] x2goserver not installable Ubuntu 14.04 Bug #816 {Done: Mike Gabriel <mike.gabriel(a)das-netzwerkteam.de>} [nx-libs] Installation x2goserver on Ubuntu 14.04 Bug 817 is already marked as done; not doing anything. > forcemerge #815 #817 Bug #815 {Done: Mike Gabriel <mike.gabriel(a)das-netzwerkteam.de>} [nx-libs] x2goserver not installable Ubuntu 14.04 Bug #816 {Done: Mike Gabriel <mike.gabriel(a)das-netzwerkteam.de>} [nx-libs] Installation x2goserver on Ubuntu 14.04 Bug #817 {Done: Mike Gabriel <mike.gabriel(a)das-netzwerkteam.de>} [nx-libs] x2goserver from x2go ppa doesn't install due to unmet dependencies Bug #816 {Done: Mike Gabriel <mike.gabriel(a)das-netzwerkteam.de>} [nx-libs] Installation x2goserver on Ubuntu 14.04 Bug #817 {Done: Mike Gabriel <mike.gabriel(a)das-netzwerkteam.de>} [nx-libs] x2goserver from x2go ppa doesn't install due to unmet dependencies Merged 815 816 817 > thanks Stopping processing here. Please contact me if you need assistance. -- 815: http://bugs.x2go.org/cgi-bin/bugreport.cgi?bug=815 816: http://bugs.x2go.org/cgi-bin/bugreport.cgi?bug=816 817: http://bugs.x2go.org/cgi-bin/bugreport.cgi?bug=817 X2Go Bug Tracking System Contact owner(a)bugs.x2go.org with problems

1 0

Bug#815: x2goserver not installable Ubuntu 14.04
by Ralf Hemberger 16 Mar '15

16 Mar '15

Package: x2goserver Version: 4.0.1.19-0~1062~ubuntu14.04.1 Hello, today apt-get upgrade removed x2goserver from my ubuntu amd64 machine. When i try to reinstall (sudo apt-get install x2goserver x2goserver-xsession), I finally get: ralf@videobox:~$ sudo apt-get --reinstall install nxagent Paketlisten werden gelesen... Fertig Abhängigkeitsbaum wird aufgebaut. Statusinformationen werden eingelesen.... Fertig Einige Pakete konnten nicht installiert werden. Das kann bedeuten, dass Sie eine unmögliche Situation angefordert haben oder, wenn Sie die Unstable-Distribution verwenden, dass einige erforderliche Pakete noch nicht erstellt wurden oder Incoming noch nicht verlassen haben. Die folgenden Informationen helfen Ihnen vielleicht, die Situation zu lösen: Die folgenden Pakete haben unerfüllte Abhängigkeiten: nxagent : Hängt ab von: libnx-x11-6 (>= 3.5.0.29) soll aber nicht installiert werden Hängt ab von: libnx-xext6 (>= 3.5.0.29) soll aber nicht installiert werden Hängt ab von: libnx-xpm4 (>= 3.5.0.29) soll aber nicht installiert werden Hängt ab von: libnx-xrender1 (>= 3.5.0.29) soll aber nicht installiert werden Hängt ab von: libxcompext3 soll aber nicht installiert werden Hängt ab von: libxcompshad3 soll aber nicht installiert werden E: Probleme können nicht korrigiert werden, Sie haben zurückgehaltene defekte Pakete. ralf@videobox:~$ apt-cache policy libnx-x11-6 libnx-x11-6: Installiert: 2:3.5.0.29-0~592~ubuntu14.04.1 Installationskandidat: 2:3.5.0.29-0~592~ubuntu14.04.1 Versionstabelle: *** 2:3.5.0.29-0~592~ubuntu14.04.1 0 500 http://ppa.launchpad.net/x2go/stable/ubuntu/ trusty/main amd64 Packages 100 /var/lib/dpkg/status ralf@videobox:~$ apt-cache policy libnx-xext6 libnx-xext6: Installiert: 2:3.5.0.29-0~592~ubuntu14.04.1 Installationskandidat: 2:3.5.0.29-0~592~ubuntu14.04.1 Versionstabelle: *** 2:3.5.0.29-0~592~ubuntu14.04.1 0 500 http://ppa.launchpad.net/x2go/stable/ubuntu/ trusty/main amd64 Packages 100 /var/lib/dpkg/status ralf@videobox:~$ apt-cache policy libnx-xpm4 libnx-xpm4: Installiert: 2:3.5.0.29-0~592~ubuntu14.04.1 Installationskandidat: 2:3.5.0.29-0~592~ubuntu14.04.1 Versionstabelle: *** 2:3.5.0.29-0~592~ubuntu14.04.1 0 500 http://ppa.launchpad.net/x2go/stable/ubuntu/ trusty/main amd64 Packages 100 /var/lib/dpkg/status ralf@videobox:~$ apt-cache policy libnx-xrender1 libnx-xrender1: Installiert: 2:3.5.0.29-0~592~ubuntu14.04.1 Installationskandidat: 2:3.5.0.29-0~592~ubuntu14.04.1 Versionstabelle: *** 2:3.5.0.29-0~592~ubuntu14.04.1 0 500 http://ppa.launchpad.net/x2go/stable/ubuntu/ trusty/main amd64 Packages 100 /var/lib/dpkg/status ralf@videobox:~$ apt-cache policy libxcompext3 libxcompext3: Installiert: 2:3.5.0.29-0~592~ubuntu14.04.1 Installationskandidat: 2:3.5.0.29-0~592~ubuntu14.04.1 Versionstabelle: *** 2:3.5.0.29-0~592~ubuntu14.04.1 0 500 http://ppa.launchpad.net/x2go/stable/ubuntu/ trusty/main amd64 Packages 100 /var/lib/dpkg/status ralf@videobox:~$ apt-cache policy libxcompshad3 libxcompshad3: Installiert: 2:3.5.0.29-0~592~ubuntu14.04.1 Installationskandidat: 2:3.5.0.29-0~592~ubuntu14.04.1 Versionstabelle: *** 2:3.5.0.29-0~592~ubuntu14.04.1 0 500 http://ppa.launchpad.net/x2go/stable/ubuntu/ trusty/main amd64 Packages 100 /var/lib/dpkg/status 3.3.0-3-0ubuntu1 0 500 http://ftp-stud.hs-esslingen.de/ubuntu/ trusty/universe amd64 Packages

3 2

Bug#812: X2Go issue (in src:x2goserver) has been marked as pending for release
by Mihai Moldovan 16 Mar '15

16 Mar '15

tag #812 pending fixed #812 4.1.0.0 thanks Hello, X2Go issue #812 (src:x2goserver) reported by you has been fixed in X2Go Git. You can see the changelog below, and you can check the diff of the fix at: http://code.x2go.org/gitweb?p=x2goserver.git;a=commitdiff;h=e617a5b The issue will most likely be fixed in src:x2goserver (4.1.0.0). light+love X2Go Git Admin (on behalf of the sender of this mail) --- commit e617a5baec4b8971606bf37f5cef76c29ccd7423 Author: Mihai Moldovan <ionic(a)ionic.de> Date: Wed Mar 11 21:00:36 2015 +0100 x2goserver/bin/x2gogetapps: respect NoDisplay and Hidden values, don't parse the full desktop file if there are non-Desktop Entries groups. Based on a patch submitted by Jason Alavaliant. Fixes: #812. diff --git a/debian/changelog b/debian/changelog index f2f81a2..3ca102b 100644 --- a/debian/changelog +++ b/debian/changelog @@ -150,6 +150,9 @@ x2goserver (4.1.0.0-0x2go1.1) UNRELEASED; urgency=low [ Mihai Moldovan ] * New upstream version (4.1.0.0): - Change string "X2go" to "X2Go" where appropriate. + - x2goserver/bin/x2gogetapps: respect NoDisplay and Hidden values, don't + parse the full desktop file if there are non-Desktop Entries groups. + Based on a patch submitted by Jason Alavaliant. Fixes: #812. * x2goserver.spec: - Only create session DB in x2goserver's post install script. Do use proper Requires(post) statements to make sure perl-X2Go-Server-DB and

2 1

Bug#812: X2Go issue (in src:x2goserver) has been marked as pending for release
by Mihai Moldovan 16 Mar '15

16 Mar '15

tag #812 pending fixed #812 4.0.1.20 thanks Hello, X2Go issue #812 (src:x2goserver) reported by you has been fixed in X2Go Git. You can see the changelog below, and you can check the diff of the fix at: http://code.x2go.org/gitweb?p=x2goserver.git;a=commitdiff;h=86d9b3c The issue will most likely be fixed in src:x2goserver (4.0.1.20). light+love X2Go Git Admin (on behalf of the sender of this mail) --- commit 86d9b3c13f7a0055f6c06023832e8aa5469ecd8d Author: Mihai Moldovan <ionic(a)ionic.de> Date: Wed Mar 11 21:00:36 2015 +0100 x2goserver/bin/x2gogetapps: respect NoDisplay and Hidden values, don't parse the full desktop file if there are non-Desktop Entries groups. Based on a patch submitted by Jason Alavaliant. Fixes: #812. Conflicts: debian/changelog diff --git a/debian/changelog b/debian/changelog index af70337..2508b02 100644 --- a/debian/changelog +++ b/debian/changelog @@ -5,6 +5,12 @@ x2goserver (4.0.1.20-0x2go1) UNRELEASED; urgency=low - TERMINAL Session: Add support for qterminal (Lightweight terminal emulator written in Qt) + [ Mihai Moldovan ] + * New upstream version (4.0.1.20): + - x2goserver/bin/x2gogetapps: respect NoDisplay and Hidden values, don't + parse the full desktop file if there are non-Desktop Entries groups. + Based on a patch submitted by Jason Alavaliant. Fixes: #812. + -- X2Go Release Manager <git-admin(a)x2go.org> Tue, 24 Feb 2015 22:11:49 +0100 x2goserver (4.0.1.19-0x2go2) UNRELEASED; urgency=low

2 1

Bug#811: installation file -- obviouslynice.de => obviously-nice.de
by René Genz 16 Mar '15

16 Mar '15

Package: x2goclient Version: 4.0.3.2 within the installation file for Mac OS X: x2goclient-4.0.3.2-20150129.dmg the first line of the file 'LICENSE' contains the URL: http://www.obviouslynice.de which does not redirect/resolve on my end. According to DENIC it registered. According to the email at the end of the same file the URL should be http://www.obviously-nice.de Other installation files might be affected as well. -- Kind regards, René

2 1

Bug#797: X2Go issue (in src:x2goclient) has been marked as pending for release
by Mihai Moldovan 15 Mar '15

15 Mar '15

tag #797 pending fixed #797 4.0.4.0 thanks Hello, X2Go issue #797 (src:x2goclient) reported by you has been fixed in X2Go Git. You can see the changelog below, and you can check the diff of the fix at: http://code.x2go.org/gitweb?p=x2goclient.git;a=commitdiff;h=3d4c38e The issue will most likely be fixed in src:x2goclient (4.0.4.0). light+love X2Go Git Admin (on behalf of the sender of this mail) --- commit 3d4c38eff304949e90ffcf68527c6c078620b6c1 Author: Fernando Pedemonte <fpedemonte(a)sintys.gob.ar> Date: Sun Mar 15 17:47:04 2015 +0100 onmainwindow.cpp: fix bad quoting when writing remote xinerama config file. Fixes: #797. diff --git a/debian/changelog b/debian/changelog index b51ab6a..6301aa0 100644 --- a/debian/changelog +++ b/debian/changelog @@ -240,6 +240,11 @@ x2goclient (4.0.4.0-0x2go1) UNRELEASED; urgency=low - configdialog.cpp: make XQuartz detection algorithm QStringList-based and add MacPorts location. + [ Fernando Pedemonte ] + * New upstream release (4.0.4.0): + - onmainwindow.cpp: fix bad quoting when writing remote xinerama config file. + Fixes: #797. + -- X2Go Release Manager <git-admin(a)x2go.org> Thu, 19 Feb 2015 13:25:28 +0100 x2goclient (4.0.3.2-0x2go1) unstable; urgency=medium

2 1

Bug#810: donation buttons went astray
by René Genz 15 Mar '15

15 Mar '15

Package: wiki.x2go.org On the website http://wiki.x2go.org/doku.php/doc:professional-support the donation buttons have been removed with the comment '2015/02/03 12:23' How to donote money? -- Kind regards, René

2 1

Processed: your mail
by owner＠bugs.x2go.org 14 Mar '15

14 Mar '15

Processing commands for control(a)bugs.x2go.org: > reassign 815 nx-libs 3.5.0.29 Bug #815 [x2goserver] x2goserver not installable Ubuntu 14.04 Bug reassigned from package 'x2goserver' to 'nx-libs'. No longer marked as found in versions 4.0.1.19-0~1062~ubuntu14.04.1. Ignoring request to alter fixed versions of bug #815 to the same values previously set Bug #815 [nx-libs] x2goserver not installable Ubuntu 14.04 There is no source info for the package 'nx-libs' at version '3.5.0.29' with architecture '' Unable to make a source version for version '3.5.0.29' Marked as found in versions 3.5.0.29. > reassign 816 nx-libs 3.5.0.29 Bug #816 [x2goagent] Installation x2goserver on Ubuntu 14.04 Bug reassigned from package 'x2goagent' to 'nx-libs'. No longer marked as found in versions 3.5.0.25-0. Ignoring request to alter fixed versions of bug #816 to the same values previously set Bug #816 [nx-libs] Installation x2goserver on Ubuntu 14.04 There is no source info for the package 'nx-libs' at version '3.5.0.29' with architecture '' Unable to make a source version for version '3.5.0.29' Marked as found in versions 3.5.0.29. > reassign 817 nx-libs 3.5.0.29 Bug #817 [x2goserver] x2goserver from x2go ppa doesn't install due to unmet dependencies Bug reassigned from package 'x2goserver' to 'nx-libs'. Ignoring request to alter found versions of bug #817 to the same values previously set Ignoring request to alter fixed versions of bug #817 to the same values previously set Bug #817 [nx-libs] x2goserver from x2go ppa doesn't install due to unmet dependencies There is no source info for the package 'nx-libs' at version '3.5.0.29' with architecture '' Unable to make a source version for version '3.5.0.29' Marked as found in versions 3.5.0.29. > fixed 815 3.5.0.30 Bug #815 [nx-libs] x2goserver not installable Ubuntu 14.04 There is no source info for the package 'nx-libs' at version '3.5.0.30' with architecture '' Unable to make a source version for version '3.5.0.30' Marked as fixed in versions 3.5.0.30. > fixed 816 3.5.0.30 Bug #816 [nx-libs] Installation x2goserver on Ubuntu 14.04 There is no source info for the package 'nx-libs' at version '3.5.0.30' with architecture '' Unable to make a source version for version '3.5.0.30' Marked as fixed in versions 3.5.0.30. > fixed 817 3.5.0.30 Bug #817 [nx-libs] x2goserver from x2go ppa doesn't install due to unmet dependencies There is no source info for the package 'nx-libs' at version '3.5.0.30' with architecture '' Unable to make a source version for version '3.5.0.30' Marked as fixed in versions 3.5.0.30. > forcemerge 815 816 Bug #815 [nx-libs] x2goserver not installable Ubuntu 14.04 Bug #816 [nx-libs] Installation x2goserver on Ubuntu 14.04 Merged 815 816 > forcemerge 815 817 Bug #815 [nx-libs] x2goserver not installable Ubuntu 14.04 Bug #816 [nx-libs] Installation x2goserver on Ubuntu 14.04 Bug #816 [nx-libs] Installation x2goserver on Ubuntu 14.04 Bug #817 [nx-libs] x2goserver from x2go ppa doesn't install due to unmet dependencies Merged 815 816 817 > End of message, stopping processing here. Please contact me if you need assistance. -- 815: http://bugs.x2go.org/cgi-bin/bugreport.cgi?bug=815 816: http://bugs.x2go.org/cgi-bin/bugreport.cgi?bug=816 817: http://bugs.x2go.org/cgi-bin/bugreport.cgi?bug=817 X2Go Bug Tracking System Contact owner(a)bugs.x2go.org with problems

1 0

Bug#815: (x2goserver not installable Ubuntu 14.04)
by Ralf Hemberger 14 Mar '15

14 Mar '15

Hello, x2goserver 4.0.1.19-0~1063~ubuntu14.04.1 resolves this issue. Thank You Ralf

1 0

Bug#817: x2goserver from x2go ppa doesn't install due to unmet dependencies
by Luís Filipe Lucas 14 Mar '15

14 Mar '15

Package: x2goserver When I try to install x2goserver from x2go ppa on my ubuntu trusty machine it fails: # apt-get install x2goserver Reading package lists... Done Building dependency tree Reading state information... Done Some packages could not be installed. This may mean that you have requested an impossible situation or if you are using the unstable distribution that some required packages have not yet been created or been moved out of Incoming. The following information may help to resolve the situation: The following packages have unmet dependencies. x2goserver : Depends: x2goagent (>= 2:3.5.0.25-0~) but it is not going to be installed E: Unable to correct problems, you have held broken packages. # apt-get install x2goagent Reading package lists... Done Building dependency tree Reading state information... Done Some packages could not be installed. This may mean that you have requested an impossible situation or if you are using the unstable distribution that some required packages have not yet been created or been moved out of Incoming. The following information may help to resolve the situation: The following packages have unmet dependencies. x2goagent : Depends: nxagent (>= 2:3.5.0.29-0~592~ubuntu14.04.1) Depends: nxagent (< 2:3.5.0.29-0~592~ubuntu14.04.1.1) E: Unable to correct problems, you have held broken packages. It seems that the recent upgrade of nx-libs on ppa to 3.5.0.29 version is the root of the problem. I am using Ubuntu 14.04.2 LTS, kernel 3.13.0-43-generic Best regards Luis Lucas

1 0

Bug#816: Installation x2goserver on Ubuntu 14.04
by fri.K 14 Mar '15

14 Mar '15

Package: x2goagent Version: 3.5.0.25-0 Hi, there is an update for x2go packages in ppa:x2go/stable that breaks x2go installation. $ sudo apt-get install x2goserver x2goserver-xsession Reading package lists... Done Building dependency tree Reading state information... Done Some packages could not be installed. This may mean that you have requested an impossible situation or if you are using the unstable distribution that some required packages have not yet been created or been moved out of Incoming. The following information may help to resolve the situation: The following packages have unmet dependencies: x2goserver : Depends: x2goagent (>= 2:3.5.0.25-0~) but it is not going to be installed E: Unable to correct problems, you have held broken packages. $ sudo apt-get install x2goagent Reading package lists... Done Building dependency tree Reading state information... Done Some packages could not be installed. This may mean that you have requested an impossible situation or if you are using the unstable distribution that some required packages have not yet been created or been moved out of Incoming. The following information may help to resolve the situation: The following packages have unmet dependencies: x2goagent : Depends: nxagent (>= 2:3.5.0.29-0~592~ubuntu14.04.1) Depends: nxagent (< 2:3.5.0.29-0~592~ubuntu14.04.1.1) E: Unable to correct problems, you have held broken packages -- Regards fri.K

1 0

Bug#744: X2Go issue (in src:nx-libs) has been marked as closed
by X2Go Release Manager 13 Mar '15

13 Mar '15

close #744 thanks Hello, we are very hopeful that X2Go issue #744 reported by you has been resolved in the new release (2:3.5.0.29) of the X2Go source project »src:nx-libs«. You can view the complete changelog entry of src:nx-libs (2:3.5.0.29) below, and you can use the following link to view all the code changes between this and the last release of src:nx-libs. http://code.x2go.org/gitweb?p=nx-libs.git;a=commitdiff;h=3e4f8c722194feb520… If you feel that the issue has not been resolved satisfyingly, feel free to reopen this bug report or submit a follow-up report with further observations described based on the new released version of src:nx-libs. Thanks a lot for contributing to X2Go!!! light+love X2Go Git Admin (on behalf of the sender of this mail) --- X2Go Component: src:nx-libs Version: 2:3.5.0.29-0x2go2 Status: RELEASE Date: Fri, 13 Mar 2015 15:50:00 +0100 Fixes: 741 744 Changes: nx-libs (2:3.5.0.29-0x2go2) RELEASED; urgency=medium . [ Mike Gabriel ] * Update 0320_nxagent_configurable-keystrokes.full.patch. Fix patch header referring to keystrokes.cfg (plural), not keystroke.cfg. * Allow sysadmins to manipulate nxagent's / x2goagent's rgb file by placing it into /etc/nxagent or /etc/x2go. * Provide support for separate .keyboard files for nxagent/x2goagent. * Modify 0101_nxagent_set-rgb-path.full.patch. Allow configurable rgb files. * Extend 0999_nxagent_unbrand-nxagent-brand-x2goagent.full.patch. Let rgb file shipped with x2goagent supersede rgb file shipped with nxagent. FIXME: a better approach would be to decide at runtime if to use /etc/x2go/rgb or /etc/nxagent/rgb. * Extend 0999_nxagent_unbrand-nxagent-brand-x2goagent.full.patch. Allow separate .keyboard files for x2goagent and nxagent. * Update 0600_nx-X11+nxcompext+nxcompshad_unique-libnames.full.patch. Don't patch files that get removed during code reduction. * Add 0991_fix-hr-typos.full+lite.patch and 991_fix-hr-typos.full.patch. Fix several typos in upstream code detected by lintian. * Makefile.nx-libs: Don't allow symlinks to point into buildroot. * Makefile.nx-libs: Install man pages via main Makefile. * Add Description: and Author: fields to various patch headers. * Makefile.nx-libs: Run make install for nxproxy first, then create the wrapper script. * Make install-lite rule in Makefile.nx-libs more predictable and not rely on nxproxy/Makefile.in. * Makefile.nx-libs: Fix uninstall-lite rule. The nxproxy and nxcomp uninstallation has to be in uninstall-lite, not in uninstall-full. * Update 1042-Do-proper-input-validation-to-fix-for-CVE-2011-2895.patch. Fix broken comment paragraph, whitespace fix. . * NX code reduction efforts (from 93Mb to 41Mb): - Drop more unused code in nx-X11/programs/Xserver/hw/. Do this in roll-tarball.sh and in debian/rules alike. - Stop shipping unused / very old xterm code. - Drop nx-X11/programs/Xserver/hw/xfree86 except of four files symlinked to other locations in the source tree at build time. - More source tree size reduction by analyzing what exactly of the Mesa source code in nx-X11/extras/ is used and what not. - Drop more unused folders from tarball release / before .deb package build: . nx-X11/programs/Xserver/miext/shadow/ . nx-X11/programs/Xserver/XpConfig/ . nx-X11/programs/Xserver/Xprint/ - Makefile.nx-libs: Don't install Mesa header files into DESTDIR anymore. - Unify source tree reduction (debian/rules vs. roll-tarball.sh) via file/ folder lists in text files named debian/CODE-REDUCTION_*. - Update 0991_fix-hr-typos.full.patch. Don't patch files that get removed by the NX code reduction effort. - Drop 0604_nx-X11_recent-freetype-API.full.patch. Not used in current build process. - Update 0600_nx-X11+nxcompext+nxcompshad_unique-libnames.full.patch. Don't patch files matter to the NX code reduction efforts. - Update 0031_nx-X11_parallel-make.full.patch. Don't patch .original files in NX code tree. - Drop patches: 0017_nx-X11_update-autotools-helper-files.full.patch, 0018_nx-X11_update-libtool-ltmain-script.full.patch, 0019_nx-X11_expat-build-against-system-libxmltok.full.patch. They patch files that are not used at build time. . * Patch system: - Prepend a "0" to every patch file name in debian/patches/. The patch order is now given by a 4 digit ID. Adapt only this changelog stanza to this modification. . * Debian/Ubuntu packaging: + Fully rework the way nx-libs gets packaged for Debian/Ubuntu. + Split up libnx-x11 into individual packages. + Provide dbg:packages for each bin:package containing binaries. + Use Makefile logic to install files into DESTDIR. + Provide dev:packages for each lib:package individually. + Provide nx-x11proto-*-dev packages for all libnx-* libraries. + Install _all_ library files (*.so*) to /usr/lib/<triplet>/, so no extra settings of LD_LIBRARY_PATH is necessary. + Add Multi-Arch support for Debian based distro versions that support Multi-Arch. + Support hardened builds for nxcomp* libraries. + Support hardened builds for nxagent and libNX_*.so files. + Add debian/*.symbols files for shared nx-X11 libraries. + Support .symbols for 64bit and 32bit alike. + Provide CDBS-generated debian/copyright.in file. . * debian/rules: + Backup nxcomp/VERSION file from NoMachine before replacing it with a symlink to debian/VERSION. Recreate the original file when cleaning up. + Fix removal of unused code (that part of the code that we know of so far). (The debian/rules file is a Makefile and Makefiles don't understand shell globbing with curly braces). + Correctly link config files (etc/rgb, etc/nxagent.keyboard, etc/x2goagent.keyboard) before dh_auto_build. + Add to B-D: expat. + Install upstream ChangeLogs into bin:packages. + Remove upstream nx-libs ChangeLog during override_dh_clean. + Use proper quoting on build flag vars (they may contain spaces). . * nx-libs.spec: + The gpg-offline bin:package is not available in our SLE repo. We can do without. + Update .spec file to meet changes in tarball size reduction and restructuring. + Use SONAME based library package naming scheme. + Mention NX technology in every package description. + Install man pages into bin:packages. + Make libNX_X11-6 and libXinerama1 compliant to Shared Library Policy. + Add Obsoletes: fields to all shared libs for marking the non-versioned library package (names) as obsolete. + Don't depend on nx-libs base package with fixed version. + Don't fail if removing *.a files fails due to the files being non-present. + Set PREFIX=%{_prefix} USRLIBDIR=%{_libdir} SHLIBDIR=%{_libdir} at build time. + Assure that BuildRoot: is set. + On SLE 11.x: libX* packages are prefixed with "xorg-x11-". + Install "%{_libdir}/nx/bin" into nxproxy package. . * debian/roll-tarball.sh: + Install etc/ files into etc/ subfolder (rgb, nxagent.keyboard, x2goagent.keyboard). . [ Horst Schirmeier ] * Update 0320_nxagent_configurable-keystrokes.full.patch. Fix a typo that prevented the /etc/nxagent/keystrokes.cfg file from being parsed. (Fixes: #741). * Add 0321_nxagent_x2go-specific-keystroke-config.full.patch. If nxagent is launched as x2goagent, use X2Go-specific paths for the keystrokes.cfg file. (Fixes: #744). . [ Michael DePaulo ] * Security Fixes: - Rebase loads of X.Org patches (mainly from RHEL-5) against NX. If not all patches from a CVE patch series appear here, then it means that the affected file/code is not used in NX at build time. . - X.Org CVE-2011-2895: 1001-LZW-decompress-fix-for-CVE-2011-2895-From-xorg-lib-X.patch - X.Org CVE-2011-4028: 1002-Fix-CVE-2011-4028-File-disclosure-vulnerability.-ups.patch - X.Org CVE-2013-4396: 1003-Avoid-use-after-free-in-dix-dixfonts.c-doImageText-C.patch - X.Org CVE-2013-6462: 1004-CVE-2013-6462-unlimited-sscanf-overflows-stack-buffe.patch - X.Org CVE-2014-0209: 1005-CVE-2014-0209-integer-overflow-of-realloc-size-in-Fo.patch 1006-CVE-2014-0209-integer-overflow-of-realloc-size-in-le.patch - X.Org CVE-2014-0210: 1007-CVE-2014-0210-unvalidated-length-in-_fs_recv_conn_se.patch 1009-CVE-2014-0210-unvalidated-lengths-when-reading-repli.patch 1011-CVE-2014-0210-unvalidated-length-fields-in-fs_read_q.patch 1014-CVE-2014-0210-unvalidated-length-fields-in-fs_read_e.patch 1015-CVE-2014-0210-unvalidated-length-fields-in-fs_read_g.patch 1016-CVE-2014-0210-unvalidated-length-fields-in-fs_read_l.patch 1017-CVE-2014-0210-unvalidated-length-fields-in-fs_read_l.patch - X.Org CVE-2014-0211: 1010-CVE-2014-0211-Integer-overflow-in-fs_get_reply-_fs_s.patch 1012-CVE-2014-0211-integer-overflow-in-fs_read_extent_inf.patch 1013-CVE-2014-0211-integer-overflow-in-fs_alloc_glyphs-fr.patch 1018-unchecked-malloc-may-allow-unauthed-client-to-crash-.patch - X.Org CVE-2014-8092: 1019-dix-integer-overflow-in-ProcPutImage-CVE-2014-8092-1.patch 1020-dix-integer-overflow-in-GetHosts-CVE-2014-8092-2-4.patch 1021-dix-integer-overflow-in-RegionSizeof-CVE-2014-8092-3.patch 1022-dix-integer-overflow-in-REQUEST_FIXED_SIZE-CVE-2014-.patch - X.Org CVE-2014-8097: 1023-dbe-unvalidated-lengths-in-DbeSwapBuffers-calls-CVE-.patch - X.Org CVE-2014-8095: 1024-Xi-unvalidated-lengths-in-Xinput-extension-CVE-2014-.patch - X.Org CVE-2014-8096: 1025-xcmisc-unvalidated-length-in-SProcXCMiscGetXIDList-C.patch - X.Org CVE-2014-8099: 1026-Xv-unvalidated-lengths-in-XVideo-extension-swapped-p.patch - X.Org CVE-2014-8100: 1027-render-check-request-size-before-reading-it-CVE-2014.patch 1028-render-unvalidated-lengths-in-Render-extn.-swapped-p.patch - X.Org CVE-2014-8102: 1029-xfixes-unvalidated-length-in-SProcXFixesSelectSelect.patch - X.Org CVE-2014-8101: 1030-randr-unvalidated-lengths-in-RandR-extension-swapped.patch - X.Org CVE-2014-8093: 1031-glx-Be-more-paranoid-about-variable-length-requests-.patch 1032-glx-Be-more-strict-about-rejecting-invalid-image-siz.patch 1033-glx-Additional-paranoia-in-__glXGetAnswerBuffer-__GL.patch 1034-glx-Add-safe_-add-mul-pad-v3-CVE-2014-8093-4-6-v4.patch 1036-glx-Integer-overflow-protection-for-non-generated-re.patch - X.Org CVE-2014-8098: 1035-glx-Length-checking-for-GLXRender-requests-v2-CVE-20.patch 1037-glx-Top-level-length-checking-for-swapped-VendorPriv.patch 1038-glx-Length-checking-for-non-generated-single-request.patch 1039-glx-Length-checking-for-RenderLarge-requests-v2-CVE-.patch 1040-glx-Pass-remaining-request-length-into-varsize-v2-CV.patch - X.org CVE-2015-0255 1104-xkb-Check-strings-length-against-request-size.patch . - Security fixes with no assigned CVE: 1008-Don-t-crash-when-we-receive-an-FS_Error-from-the-fon.patch . - Rebase the following patches that are prerequisites for the CVE-2015-0255 patch: 1101-Coverity-844-845-846-Fix-memory-leaks.patch 1102-include-introduce-byte-counting-functions.patch 1103-xkb-Don-t-swap-XkbSetGeometry-data-in-the-input-buff.patch . - Fix FTBFS due to the nxproxy executable already existing under /usr/lib/nx/bin/nx/ . [ Mihai Moldovan ] * Change string "X2go" to "X2Go" where appropriate. * CVE security review: - Update 1007-CVE-2014-0210-unvalidated-length-in-_fs_recv_conn_se.patch. Use xfree() instead of free() in nx-libs. - Update 1011-CVE-2014-0210-unvalidated-length-fields-in-fs_read_q.patch. Apply correctly on nx-libs 3.6.x. - Update 1020-dix-integer-overflow-in-GetHosts-CVE-2014-8092-2-4.patch. Human-readable version of "1 MB". - Add 1041-nx-X11-lib-font-fc-fserve.c-initialize-remaining-buf.patch. Initialize remaining bufleft variables (nx-X11/lib/font/fc/fserve.c). - Add 1042-Do-proper-input-validation-to-fix-for-CVE-2011-2895.patch. Do proper input validation to fix for CVE-2011-2895.

2 1

Bug#744: X2Go issue (in src:nx-libs) has been marked as closed
by X2Go Release Manager 13 Mar '15

13 Mar '15

close #744 thanks Hello, we are very hopeful that X2Go issue #744 reported by you has been resolved in the new release (2:3.5.0.29) of the X2Go source project »src:nx-libs«. You can view the complete changelog entry of src:nx-libs (2:3.5.0.29) below, and you can use the following link to view all the code changes between this and the last release of src:nx-libs. http://code.x2go.org/gitweb?p=nx-libs.git;a=commitdiff;h=0db9c76dde03552579… If you feel that the issue has not been resolved satisfyingly, feel free to reopen this bug report or submit a follow-up report with further observations described based on the new released version of src:nx-libs. Thanks a lot for contributing to X2Go!!! light+love X2Go Git Admin (on behalf of the sender of this mail) --- X2Go Component: src:nx-libs Version: 2:3.5.0.29-0x2go2 Status: RELEASE Date: Fri, 13 Mar 2015 15:50:00 +0100 Fixes: 741 744 Changes: nx-libs (2:3.5.0.29-0x2go2) RELEASED; urgency=medium . [ Mike Gabriel ] * Update 0320_nxagent_configurable-keystrokes.full.patch. Fix patch header referring to keystrokes.cfg (plural), not keystroke.cfg. * Allow sysadmins to manipulate nxagent's / x2goagent's rgb file by placing it into /etc/nxagent or /etc/x2go. * Provide support for separate .keyboard files for nxagent/x2goagent. * Modify 0101_nxagent_set-rgb-path.full.patch. Allow configurable rgb files. * Extend 0999_nxagent_unbrand-nxagent-brand-x2goagent.full.patch. Let rgb file shipped with x2goagent supersede rgb file shipped with nxagent. FIXME: a better approach would be to decide at runtime if to use /etc/x2go/rgb or /etc/nxagent/rgb. * Extend 0999_nxagent_unbrand-nxagent-brand-x2goagent.full.patch. Allow separate .keyboard files for x2goagent and nxagent. * Update 0600_nx-X11+nxcompext+nxcompshad_unique-libnames.full.patch. Don't patch files that get removed during code reduction. * Add 0991_fix-hr-typos.full+lite.patch and 991_fix-hr-typos.full.patch. Fix several typos in upstream code detected by lintian. * Makefile.nx-libs: Don't allow symlinks to point into buildroot. * Makefile.nx-libs: Install man pages via main Makefile. * Add Description: and Author: fields to various patch headers. * Makefile.nx-libs: Run make install for nxproxy first, then create the wrapper script. * Make install-lite rule in Makefile.nx-libs more predictable and not rely on nxproxy/Makefile.in. * Makefile.nx-libs: Fix uninstall-lite rule. The nxproxy and nxcomp uninstallation has to be in uninstall-lite, not in uninstall-full. * Update 1042-Do-proper-input-validation-to-fix-for-CVE-2011-2895.patch. Fix broken comment paragraph, whitespace fix. . * NX code reduction efforts (from 93Mb to 41Mb): - Drop more unused code in nx-X11/programs/Xserver/hw/. Do this in roll-tarball.sh and in debian/rules alike. - Stop shipping unused / very old xterm code. - Drop nx-X11/programs/Xserver/hw/xfree86 except of four files symlinked to other locations in the source tree at build time. - More source tree size reduction by analyzing what exactly of the Mesa source code in nx-X11/extras/ is used and what not. - Drop more unused folders from tarball release / before .deb package build: . nx-X11/programs/Xserver/miext/shadow/ . nx-X11/programs/Xserver/XpConfig/ . nx-X11/programs/Xserver/Xprint/ - Makefile.nx-libs: Don't install Mesa header files into DESTDIR anymore. - Unify source tree reduction (debian/rules vs. roll-tarball.sh) via file/ folder lists in text files named debian/CODE-REDUCTION_*. - Update 0991_fix-hr-typos.full.patch. Don't patch files that get removed by the NX code reduction effort. - Drop 0604_nx-X11_recent-freetype-API.full.patch. Not used in current build process. - Update 0600_nx-X11+nxcompext+nxcompshad_unique-libnames.full.patch. Don't patch files matter to the NX code reduction efforts. - Update 0031_nx-X11_parallel-make.full.patch. Don't patch .original files in NX code tree. - Drop patches: 0017_nx-X11_update-autotools-helper-files.full.patch, 0018_nx-X11_update-libtool-ltmain-script.full.patch, 0019_nx-X11_expat-build-against-system-libxmltok.full.patch. They patch files that are not used at build time. . * Patch system: - Prepend a "0" to every patch file name in debian/patches/. The patch order is now given by a 4 digit ID. Adapt only this changelog stanza to this modification. . * Debian/Ubuntu packaging: + Fully rework the way nx-libs gets packaged for Debian/Ubuntu. + Split up libnx-x11 into individual packages. + Provide dbg:packages for each bin:package containing binaries. + Use Makefile logic to install files into DESTDIR. + Provide dev:packages for each lib:package individually. + Provide nx-x11proto-*-dev packages for all libnx-* libraries. + Install _all_ library files (*.so*) to /usr/lib/<triplet>/, so no extra settings of LD_LIBRARY_PATH is necessary. + Add Multi-Arch support for Debian based distro versions that support Multi-Arch. + Support hardened builds for nxcomp* libraries. + Support hardened builds for nxagent and libNX_*.so files. + Add debian/*.symbols files for shared nx-X11 libraries. + Support .symbols for 64bit and 32bit alike. + Provide CDBS-generated debian/copyright.in file. . * debian/rules: + Backup nxcomp/VERSION file from NoMachine before replacing it with a symlink to debian/VERSION. Recreate the original file when cleaning up. + Fix removal of unused code (that part of the code that we know of so far). (The debian/rules file is a Makefile and Makefiles don't understand shell globbing with curly braces). + Correctly link config files (etc/rgb, etc/nxagent.keyboard, etc/x2goagent.keyboard) before dh_auto_build. + Add to B-D: expat. + Install upstream ChangeLogs into bin:packages. + Remove upstream nx-libs ChangeLog during override_dh_clean. + Use proper quoting on build flag vars (they may contain spaces). . * nx-libs.spec: + The gpg-offline bin:package is not available in our SLE repo. We can do without. + Update .spec file to meet changes in tarball size reduction and restructuring. + Use SONAME based library package naming scheme. + Mention NX technology in every package description. + Install man pages into bin:packages. + Make libNX_X11-6 and libXinerama1 compliant to Shared Library Policy. + Add Obsoletes: fields to all shared libs for marking the non-versioned library package (names) as obsolete. + Don't depend on nx-libs base package with fixed version. + Don't fail if removing *.a files fails due to the files being non-present. + Set PREFIX=%{_prefix} USRLIBDIR=%{_libdir} SHLIBDIR=%{_libdir} at build time. + Assure that BuildRoot: is set. + On SLE 11.x: libX* packages are prefixed with "xorg-x11-". + Install "%{_libdir}/nx/bin" into nxproxy package. . * debian/roll-tarball.sh: + Install etc/ files into etc/ subfolder (rgb, nxagent.keyboard, x2goagent.keyboard). . [ Horst Schirmeier ] * Update 0320_nxagent_configurable-keystrokes.full.patch. Fix a typo that prevented the /etc/nxagent/keystrokes.cfg file from being parsed. (Fixes: #741). * Add 0321_nxagent_x2go-specific-keystroke-config.full.patch. If nxagent is launched as x2goagent, use X2Go-specific paths for the keystrokes.cfg file. (Fixes: #744). . [ Michael DePaulo ] * Security Fixes: - Rebase loads of X.Org patches (mainly from RHEL-5) against NX. If not all patches from a CVE patch series appear here, then it means that the affected file/code is not used in NX at build time. . - X.Org CVE-2011-2895: 1001-LZW-decompress-fix-for-CVE-2011-2895-From-xorg-lib-X.patch - X.Org CVE-2011-4028: 1002-Fix-CVE-2011-4028-File-disclosure-vulnerability.-ups.patch - X.Org CVE-2013-4396: 1003-Avoid-use-after-free-in-dix-dixfonts.c-doImageText-C.patch - X.Org CVE-2013-6462: 1004-CVE-2013-6462-unlimited-sscanf-overflows-stack-buffe.patch - X.Org CVE-2014-0209: 1005-CVE-2014-0209-integer-overflow-of-realloc-size-in-Fo.patch 1006-CVE-2014-0209-integer-overflow-of-realloc-size-in-le.patch - X.Org CVE-2014-0210: 1007-CVE-2014-0210-unvalidated-length-in-_fs_recv_conn_se.patch 1009-CVE-2014-0210-unvalidated-lengths-when-reading-repli.patch 1011-CVE-2014-0210-unvalidated-length-fields-in-fs_read_q.patch 1014-CVE-2014-0210-unvalidated-length-fields-in-fs_read_e.patch 1015-CVE-2014-0210-unvalidated-length-fields-in-fs_read_g.patch 1016-CVE-2014-0210-unvalidated-length-fields-in-fs_read_l.patch 1017-CVE-2014-0210-unvalidated-length-fields-in-fs_read_l.patch - X.Org CVE-2014-0211: 1010-CVE-2014-0211-Integer-overflow-in-fs_get_reply-_fs_s.patch 1012-CVE-2014-0211-integer-overflow-in-fs_read_extent_inf.patch 1013-CVE-2014-0211-integer-overflow-in-fs_alloc_glyphs-fr.patch 1018-unchecked-malloc-may-allow-unauthed-client-to-crash-.patch - X.Org CVE-2014-8092: 1019-dix-integer-overflow-in-ProcPutImage-CVE-2014-8092-1.patch 1020-dix-integer-overflow-in-GetHosts-CVE-2014-8092-2-4.patch 1021-dix-integer-overflow-in-RegionSizeof-CVE-2014-8092-3.patch 1022-dix-integer-overflow-in-REQUEST_FIXED_SIZE-CVE-2014-.patch - X.Org CVE-2014-8097: 1023-dbe-unvalidated-lengths-in-DbeSwapBuffers-calls-CVE-.patch - X.Org CVE-2014-8095: 1024-Xi-unvalidated-lengths-in-Xinput-extension-CVE-2014-.patch - X.Org CVE-2014-8096: 1025-xcmisc-unvalidated-length-in-SProcXCMiscGetXIDList-C.patch - X.Org CVE-2014-8099: 1026-Xv-unvalidated-lengths-in-XVideo-extension-swapped-p.patch - X.Org CVE-2014-8100: 1027-render-check-request-size-before-reading-it-CVE-2014.patch 1028-render-unvalidated-lengths-in-Render-extn.-swapped-p.patch - X.Org CVE-2014-8102: 1029-xfixes-unvalidated-length-in-SProcXFixesSelectSelect.patch - X.Org CVE-2014-8101: 1030-randr-unvalidated-lengths-in-RandR-extension-swapped.patch - X.Org CVE-2014-8093: 1031-glx-Be-more-paranoid-about-variable-length-requests-.patch 1032-glx-Be-more-strict-about-rejecting-invalid-image-siz.patch 1033-glx-Additional-paranoia-in-__glXGetAnswerBuffer-__GL.patch 1034-glx-Add-safe_-add-mul-pad-v3-CVE-2014-8093-4-6-v4.patch 1036-glx-Integer-overflow-protection-for-non-generated-re.patch - X.Org CVE-2014-8098: 1035-glx-Length-checking-for-GLXRender-requests-v2-CVE-20.patch 1037-glx-Top-level-length-checking-for-swapped-VendorPriv.patch 1038-glx-Length-checking-for-non-generated-single-request.patch 1039-glx-Length-checking-for-RenderLarge-requests-v2-CVE-.patch 1040-glx-Pass-remaining-request-length-into-varsize-v2-CV.patch - X.org CVE-2015-0255 1104-xkb-Check-strings-length-against-request-size.patch . - Security fixes with no assigned CVE: 1008-Don-t-crash-when-we-receive-an-FS_Error-from-the-fon.patch . - Rebase the following patches that are prerequisites for the CVE-2015-0255 patch: 1101-Coverity-844-845-846-Fix-memory-leaks.patch 1102-include-introduce-byte-counting-functions.patch 1103-xkb-Don-t-swap-XkbSetGeometry-data-in-the-input-buff.patch . - Fix FTBFS due to the nxproxy executable already existing under /usr/lib/nx/bin/nx/ . [ Mihai Moldovan ] * Change string "X2go" to "X2Go" where appropriate. * CVE security review: - Update 1007-CVE-2014-0210-unvalidated-length-in-_fs_recv_conn_se.patch. Use xfree() instead of free() in nx-libs. - Update 1011-CVE-2014-0210-unvalidated-length-fields-in-fs_read_q.patch. Apply correctly on nx-libs 3.6.x. - Update 1020-dix-integer-overflow-in-GetHosts-CVE-2014-8092-2-4.patch. Human-readable version of "1 MB". - Add 1041-nx-X11-lib-font-fc-fserve.c-initialize-remaining-buf.patch. Initialize remaining bufleft variables (nx-X11/lib/font/fc/fserve.c). - Add 1042-Do-proper-input-validation-to-fix-for-CVE-2011-2895.patch. Do proper input validation to fix for CVE-2011-2895.

2 1

Bug#741: X2Go issue (in src:nx-libs) has been marked as closed
by X2Go Release Manager 13 Mar '15

13 Mar '15

close #741 thanks Hello, we are very hopeful that X2Go issue #741 reported by you has been resolved in the new release (2:3.5.0.29) of the X2Go source project »src:nx-libs«. You can view the complete changelog entry of src:nx-libs (2:3.5.0.29) below, and you can use the following link to view all the code changes between this and the last release of src:nx-libs. http://code.x2go.org/gitweb?p=nx-libs.git;a=commitdiff;h=0db9c76dde03552579… If you feel that the issue has not been resolved satisfyingly, feel free to reopen this bug report or submit a follow-up report with further observations described based on the new released version of src:nx-libs. Thanks a lot for contributing to X2Go!!! light+love X2Go Git Admin (on behalf of the sender of this mail) --- X2Go Component: src:nx-libs Version: 2:3.5.0.29-0x2go2 Status: RELEASE Date: Fri, 13 Mar 2015 15:50:00 +0100 Fixes: 741 744 Changes: nx-libs (2:3.5.0.29-0x2go2) RELEASED; urgency=medium . [ Mike Gabriel ] * Update 0320_nxagent_configurable-keystrokes.full.patch. Fix patch header referring to keystrokes.cfg (plural), not keystroke.cfg. * Allow sysadmins to manipulate nxagent's / x2goagent's rgb file by placing it into /etc/nxagent or /etc/x2go. * Provide support for separate .keyboard files for nxagent/x2goagent. * Modify 0101_nxagent_set-rgb-path.full.patch. Allow configurable rgb files. * Extend 0999_nxagent_unbrand-nxagent-brand-x2goagent.full.patch. Let rgb file shipped with x2goagent supersede rgb file shipped with nxagent. FIXME: a better approach would be to decide at runtime if to use /etc/x2go/rgb or /etc/nxagent/rgb. * Extend 0999_nxagent_unbrand-nxagent-brand-x2goagent.full.patch. Allow separate .keyboard files for x2goagent and nxagent. * Update 0600_nx-X11+nxcompext+nxcompshad_unique-libnames.full.patch. Don't patch files that get removed during code reduction. * Add 0991_fix-hr-typos.full+lite.patch and 991_fix-hr-typos.full.patch. Fix several typos in upstream code detected by lintian. * Makefile.nx-libs: Don't allow symlinks to point into buildroot. * Makefile.nx-libs: Install man pages via main Makefile. * Add Description: and Author: fields to various patch headers. * Makefile.nx-libs: Run make install for nxproxy first, then create the wrapper script. * Make install-lite rule in Makefile.nx-libs more predictable and not rely on nxproxy/Makefile.in. * Makefile.nx-libs: Fix uninstall-lite rule. The nxproxy and nxcomp uninstallation has to be in uninstall-lite, not in uninstall-full. * Update 1042-Do-proper-input-validation-to-fix-for-CVE-2011-2895.patch. Fix broken comment paragraph, whitespace fix. . * NX code reduction efforts (from 93Mb to 41Mb): - Drop more unused code in nx-X11/programs/Xserver/hw/. Do this in roll-tarball.sh and in debian/rules alike. - Stop shipping unused / very old xterm code. - Drop nx-X11/programs/Xserver/hw/xfree86 except of four files symlinked to other locations in the source tree at build time. - More source tree size reduction by analyzing what exactly of the Mesa source code in nx-X11/extras/ is used and what not. - Drop more unused folders from tarball release / before .deb package build: . nx-X11/programs/Xserver/miext/shadow/ . nx-X11/programs/Xserver/XpConfig/ . nx-X11/programs/Xserver/Xprint/ - Makefile.nx-libs: Don't install Mesa header files into DESTDIR anymore. - Unify source tree reduction (debian/rules vs. roll-tarball.sh) via file/ folder lists in text files named debian/CODE-REDUCTION_*. - Update 0991_fix-hr-typos.full.patch. Don't patch files that get removed by the NX code reduction effort. - Drop 0604_nx-X11_recent-freetype-API.full.patch. Not used in current build process. - Update 0600_nx-X11+nxcompext+nxcompshad_unique-libnames.full.patch. Don't patch files matter to the NX code reduction efforts. - Update 0031_nx-X11_parallel-make.full.patch. Don't patch .original files in NX code tree. - Drop patches: 0017_nx-X11_update-autotools-helper-files.full.patch, 0018_nx-X11_update-libtool-ltmain-script.full.patch, 0019_nx-X11_expat-build-against-system-libxmltok.full.patch. They patch files that are not used at build time. . * Patch system: - Prepend a "0" to every patch file name in debian/patches/. The patch order is now given by a 4 digit ID. Adapt only this changelog stanza to this modification. . * Debian/Ubuntu packaging: + Fully rework the way nx-libs gets packaged for Debian/Ubuntu. + Split up libnx-x11 into individual packages. + Provide dbg:packages for each bin:package containing binaries. + Use Makefile logic to install files into DESTDIR. + Provide dev:packages for each lib:package individually. + Provide nx-x11proto-*-dev packages for all libnx-* libraries. + Install _all_ library files (*.so*) to /usr/lib/<triplet>/, so no extra settings of LD_LIBRARY_PATH is necessary. + Add Multi-Arch support for Debian based distro versions that support Multi-Arch. + Support hardened builds for nxcomp* libraries. + Support hardened builds for nxagent and libNX_*.so files. + Add debian/*.symbols files for shared nx-X11 libraries. + Support .symbols for 64bit and 32bit alike. + Provide CDBS-generated debian/copyright.in file. . * debian/rules: + Backup nxcomp/VERSION file from NoMachine before replacing it with a symlink to debian/VERSION. Recreate the original file when cleaning up. + Fix removal of unused code (that part of the code that we know of so far). (The debian/rules file is a Makefile and Makefiles don't understand shell globbing with curly braces). + Correctly link config files (etc/rgb, etc/nxagent.keyboard, etc/x2goagent.keyboard) before dh_auto_build. + Add to B-D: expat. + Install upstream ChangeLogs into bin:packages. + Remove upstream nx-libs ChangeLog during override_dh_clean. + Use proper quoting on build flag vars (they may contain spaces). . * nx-libs.spec: + The gpg-offline bin:package is not available in our SLE repo. We can do without. + Update .spec file to meet changes in tarball size reduction and restructuring. + Use SONAME based library package naming scheme. + Mention NX technology in every package description. + Install man pages into bin:packages. + Make libNX_X11-6 and libXinerama1 compliant to Shared Library Policy. + Add Obsoletes: fields to all shared libs for marking the non-versioned library package (names) as obsolete. + Don't depend on nx-libs base package with fixed version. + Don't fail if removing *.a files fails due to the files being non-present. + Set PREFIX=%{_prefix} USRLIBDIR=%{_libdir} SHLIBDIR=%{_libdir} at build time. + Assure that BuildRoot: is set. + On SLE 11.x: libX* packages are prefixed with "xorg-x11-". + Install "%{_libdir}/nx/bin" into nxproxy package. . * debian/roll-tarball.sh: + Install etc/ files into etc/ subfolder (rgb, nxagent.keyboard, x2goagent.keyboard). . [ Horst Schirmeier ] * Update 0320_nxagent_configurable-keystrokes.full.patch. Fix a typo that prevented the /etc/nxagent/keystrokes.cfg file from being parsed. (Fixes: #741). * Add 0321_nxagent_x2go-specific-keystroke-config.full.patch. If nxagent is launched as x2goagent, use X2Go-specific paths for the keystrokes.cfg file. (Fixes: #744). . [ Michael DePaulo ] * Security Fixes: - Rebase loads of X.Org patches (mainly from RHEL-5) against NX. If not all patches from a CVE patch series appear here, then it means that the affected file/code is not used in NX at build time. . - X.Org CVE-2011-2895: 1001-LZW-decompress-fix-for-CVE-2011-2895-From-xorg-lib-X.patch - X.Org CVE-2011-4028: 1002-Fix-CVE-2011-4028-File-disclosure-vulnerability.-ups.patch - X.Org CVE-2013-4396: 1003-Avoid-use-after-free-in-dix-dixfonts.c-doImageText-C.patch - X.Org CVE-2013-6462: 1004-CVE-2013-6462-unlimited-sscanf-overflows-stack-buffe.patch - X.Org CVE-2014-0209: 1005-CVE-2014-0209-integer-overflow-of-realloc-size-in-Fo.patch 1006-CVE-2014-0209-integer-overflow-of-realloc-size-in-le.patch - X.Org CVE-2014-0210: 1007-CVE-2014-0210-unvalidated-length-in-_fs_recv_conn_se.patch 1009-CVE-2014-0210-unvalidated-lengths-when-reading-repli.patch 1011-CVE-2014-0210-unvalidated-length-fields-in-fs_read_q.patch 1014-CVE-2014-0210-unvalidated-length-fields-in-fs_read_e.patch 1015-CVE-2014-0210-unvalidated-length-fields-in-fs_read_g.patch 1016-CVE-2014-0210-unvalidated-length-fields-in-fs_read_l.patch 1017-CVE-2014-0210-unvalidated-length-fields-in-fs_read_l.patch - X.Org CVE-2014-0211: 1010-CVE-2014-0211-Integer-overflow-in-fs_get_reply-_fs_s.patch 1012-CVE-2014-0211-integer-overflow-in-fs_read_extent_inf.patch 1013-CVE-2014-0211-integer-overflow-in-fs_alloc_glyphs-fr.patch 1018-unchecked-malloc-may-allow-unauthed-client-to-crash-.patch - X.Org CVE-2014-8092: 1019-dix-integer-overflow-in-ProcPutImage-CVE-2014-8092-1.patch 1020-dix-integer-overflow-in-GetHosts-CVE-2014-8092-2-4.patch 1021-dix-integer-overflow-in-RegionSizeof-CVE-2014-8092-3.patch 1022-dix-integer-overflow-in-REQUEST_FIXED_SIZE-CVE-2014-.patch - X.Org CVE-2014-8097: 1023-dbe-unvalidated-lengths-in-DbeSwapBuffers-calls-CVE-.patch - X.Org CVE-2014-8095: 1024-Xi-unvalidated-lengths-in-Xinput-extension-CVE-2014-.patch - X.Org CVE-2014-8096: 1025-xcmisc-unvalidated-length-in-SProcXCMiscGetXIDList-C.patch - X.Org CVE-2014-8099: 1026-Xv-unvalidated-lengths-in-XVideo-extension-swapped-p.patch - X.Org CVE-2014-8100: 1027-render-check-request-size-before-reading-it-CVE-2014.patch 1028-render-unvalidated-lengths-in-Render-extn.-swapped-p.patch - X.Org CVE-2014-8102: 1029-xfixes-unvalidated-length-in-SProcXFixesSelectSelect.patch - X.Org CVE-2014-8101: 1030-randr-unvalidated-lengths-in-RandR-extension-swapped.patch - X.Org CVE-2014-8093: 1031-glx-Be-more-paranoid-about-variable-length-requests-.patch 1032-glx-Be-more-strict-about-rejecting-invalid-image-siz.patch 1033-glx-Additional-paranoia-in-__glXGetAnswerBuffer-__GL.patch 1034-glx-Add-safe_-add-mul-pad-v3-CVE-2014-8093-4-6-v4.patch 1036-glx-Integer-overflow-protection-for-non-generated-re.patch - X.Org CVE-2014-8098: 1035-glx-Length-checking-for-GLXRender-requests-v2-CVE-20.patch 1037-glx-Top-level-length-checking-for-swapped-VendorPriv.patch 1038-glx-Length-checking-for-non-generated-single-request.patch 1039-glx-Length-checking-for-RenderLarge-requests-v2-CVE-.patch 1040-glx-Pass-remaining-request-length-into-varsize-v2-CV.patch - X.org CVE-2015-0255 1104-xkb-Check-strings-length-against-request-size.patch . - Security fixes with no assigned CVE: 1008-Don-t-crash-when-we-receive-an-FS_Error-from-the-fon.patch . - Rebase the following patches that are prerequisites for the CVE-2015-0255 patch: 1101-Coverity-844-845-846-Fix-memory-leaks.patch 1102-include-introduce-byte-counting-functions.patch 1103-xkb-Don-t-swap-XkbSetGeometry-data-in-the-input-buff.patch . - Fix FTBFS due to the nxproxy executable already existing under /usr/lib/nx/bin/nx/ . [ Mihai Moldovan ] * Change string "X2go" to "X2Go" where appropriate. * CVE security review: - Update 1007-CVE-2014-0210-unvalidated-length-in-_fs_recv_conn_se.patch. Use xfree() instead of free() in nx-libs. - Update 1011-CVE-2014-0210-unvalidated-length-fields-in-fs_read_q.patch. Apply correctly on nx-libs 3.6.x. - Update 1020-dix-integer-overflow-in-GetHosts-CVE-2014-8092-2-4.patch. Human-readable version of "1 MB". - Add 1041-nx-X11-lib-font-fc-fserve.c-initialize-remaining-buf.patch. Initialize remaining bufleft variables (nx-X11/lib/font/fc/fserve.c). - Add 1042-Do-proper-input-validation-to-fix-for-CVE-2011-2895.patch. Do proper input validation to fix for CVE-2011-2895.

2 1

Bug#741: X2Go issue (in src:nx-libs) has been marked as closed
by X2Go Release Manager 13 Mar '15

13 Mar '15

close #741 thanks Hello, we are very hopeful that X2Go issue #741 reported by you has been resolved in the new release (2:3.5.0.29) of the X2Go source project »src:nx-libs«. You can view the complete changelog entry of src:nx-libs (2:3.5.0.29) below, and you can use the following link to view all the code changes between this and the last release of src:nx-libs. http://code.x2go.org/gitweb?p=nx-libs.git;a=commitdiff;h=3e4f8c722194feb520… If you feel that the issue has not been resolved satisfyingly, feel free to reopen this bug report or submit a follow-up report with further observations described based on the new released version of src:nx-libs. Thanks a lot for contributing to X2Go!!! light+love X2Go Git Admin (on behalf of the sender of this mail) --- X2Go Component: src:nx-libs Version: 2:3.5.0.29-0x2go2 Status: RELEASE Date: Fri, 13 Mar 2015 15:50:00 +0100 Fixes: 741 744 Changes: nx-libs (2:3.5.0.29-0x2go2) RELEASED; urgency=medium . [ Mike Gabriel ] * Update 0320_nxagent_configurable-keystrokes.full.patch. Fix patch header referring to keystrokes.cfg (plural), not keystroke.cfg. * Allow sysadmins to manipulate nxagent's / x2goagent's rgb file by placing it into /etc/nxagent or /etc/x2go. * Provide support for separate .keyboard files for nxagent/x2goagent. * Modify 0101_nxagent_set-rgb-path.full.patch. Allow configurable rgb files. * Extend 0999_nxagent_unbrand-nxagent-brand-x2goagent.full.patch. Let rgb file shipped with x2goagent supersede rgb file shipped with nxagent. FIXME: a better approach would be to decide at runtime if to use /etc/x2go/rgb or /etc/nxagent/rgb. * Extend 0999_nxagent_unbrand-nxagent-brand-x2goagent.full.patch. Allow separate .keyboard files for x2goagent and nxagent. * Update 0600_nx-X11+nxcompext+nxcompshad_unique-libnames.full.patch. Don't patch files that get removed during code reduction. * Add 0991_fix-hr-typos.full+lite.patch and 991_fix-hr-typos.full.patch. Fix several typos in upstream code detected by lintian. * Makefile.nx-libs: Don't allow symlinks to point into buildroot. * Makefile.nx-libs: Install man pages via main Makefile. * Add Description: and Author: fields to various patch headers. * Makefile.nx-libs: Run make install for nxproxy first, then create the wrapper script. * Make install-lite rule in Makefile.nx-libs more predictable and not rely on nxproxy/Makefile.in. * Makefile.nx-libs: Fix uninstall-lite rule. The nxproxy and nxcomp uninstallation has to be in uninstall-lite, not in uninstall-full. * Update 1042-Do-proper-input-validation-to-fix-for-CVE-2011-2895.patch. Fix broken comment paragraph, whitespace fix. . * NX code reduction efforts (from 93Mb to 41Mb): - Drop more unused code in nx-X11/programs/Xserver/hw/. Do this in roll-tarball.sh and in debian/rules alike. - Stop shipping unused / very old xterm code. - Drop nx-X11/programs/Xserver/hw/xfree86 except of four files symlinked to other locations in the source tree at build time. - More source tree size reduction by analyzing what exactly of the Mesa source code in nx-X11/extras/ is used and what not. - Drop more unused folders from tarball release / before .deb package build: . nx-X11/programs/Xserver/miext/shadow/ . nx-X11/programs/Xserver/XpConfig/ . nx-X11/programs/Xserver/Xprint/ - Makefile.nx-libs: Don't install Mesa header files into DESTDIR anymore. - Unify source tree reduction (debian/rules vs. roll-tarball.sh) via file/ folder lists in text files named debian/CODE-REDUCTION_*. - Update 0991_fix-hr-typos.full.patch. Don't patch files that get removed by the NX code reduction effort. - Drop 0604_nx-X11_recent-freetype-API.full.patch. Not used in current build process. - Update 0600_nx-X11+nxcompext+nxcompshad_unique-libnames.full.patch. Don't patch files matter to the NX code reduction efforts. - Update 0031_nx-X11_parallel-make.full.patch. Don't patch .original files in NX code tree. - Drop patches: 0017_nx-X11_update-autotools-helper-files.full.patch, 0018_nx-X11_update-libtool-ltmain-script.full.patch, 0019_nx-X11_expat-build-against-system-libxmltok.full.patch. They patch files that are not used at build time. . * Patch system: - Prepend a "0" to every patch file name in debian/patches/. The patch order is now given by a 4 digit ID. Adapt only this changelog stanza to this modification. . * Debian/Ubuntu packaging: + Fully rework the way nx-libs gets packaged for Debian/Ubuntu. + Split up libnx-x11 into individual packages. + Provide dbg:packages for each bin:package containing binaries. + Use Makefile logic to install files into DESTDIR. + Provide dev:packages for each lib:package individually. + Provide nx-x11proto-*-dev packages for all libnx-* libraries. + Install _all_ library files (*.so*) to /usr/lib/<triplet>/, so no extra settings of LD_LIBRARY_PATH is necessary. + Add Multi-Arch support for Debian based distro versions that support Multi-Arch. + Support hardened builds for nxcomp* libraries. + Support hardened builds for nxagent and libNX_*.so files. + Add debian/*.symbols files for shared nx-X11 libraries. + Support .symbols for 64bit and 32bit alike. + Provide CDBS-generated debian/copyright.in file. . * debian/rules: + Backup nxcomp/VERSION file from NoMachine before replacing it with a symlink to debian/VERSION. Recreate the original file when cleaning up. + Fix removal of unused code (that part of the code that we know of so far). (The debian/rules file is a Makefile and Makefiles don't understand shell globbing with curly braces). + Correctly link config files (etc/rgb, etc/nxagent.keyboard, etc/x2goagent.keyboard) before dh_auto_build. + Add to B-D: expat. + Install upstream ChangeLogs into bin:packages. + Remove upstream nx-libs ChangeLog during override_dh_clean. + Use proper quoting on build flag vars (they may contain spaces). . * nx-libs.spec: + The gpg-offline bin:package is not available in our SLE repo. We can do without. + Update .spec file to meet changes in tarball size reduction and restructuring. + Use SONAME based library package naming scheme. + Mention NX technology in every package description. + Install man pages into bin:packages. + Make libNX_X11-6 and libXinerama1 compliant to Shared Library Policy. + Add Obsoletes: fields to all shared libs for marking the non-versioned library package (names) as obsolete. + Don't depend on nx-libs base package with fixed version. + Don't fail if removing *.a files fails due to the files being non-present. + Set PREFIX=%{_prefix} USRLIBDIR=%{_libdir} SHLIBDIR=%{_libdir} at build time. + Assure that BuildRoot: is set. + On SLE 11.x: libX* packages are prefixed with "xorg-x11-". + Install "%{_libdir}/nx/bin" into nxproxy package. . * debian/roll-tarball.sh: + Install etc/ files into etc/ subfolder (rgb, nxagent.keyboard, x2goagent.keyboard). . [ Horst Schirmeier ] * Update 0320_nxagent_configurable-keystrokes.full.patch. Fix a typo that prevented the /etc/nxagent/keystrokes.cfg file from being parsed. (Fixes: #741). * Add 0321_nxagent_x2go-specific-keystroke-config.full.patch. If nxagent is launched as x2goagent, use X2Go-specific paths for the keystrokes.cfg file. (Fixes: #744). . [ Michael DePaulo ] * Security Fixes: - Rebase loads of X.Org patches (mainly from RHEL-5) against NX. If not all patches from a CVE patch series appear here, then it means that the affected file/code is not used in NX at build time. . - X.Org CVE-2011-2895: 1001-LZW-decompress-fix-for-CVE-2011-2895-From-xorg-lib-X.patch - X.Org CVE-2011-4028: 1002-Fix-CVE-2011-4028-File-disclosure-vulnerability.-ups.patch - X.Org CVE-2013-4396: 1003-Avoid-use-after-free-in-dix-dixfonts.c-doImageText-C.patch - X.Org CVE-2013-6462: 1004-CVE-2013-6462-unlimited-sscanf-overflows-stack-buffe.patch - X.Org CVE-2014-0209: 1005-CVE-2014-0209-integer-overflow-of-realloc-size-in-Fo.patch 1006-CVE-2014-0209-integer-overflow-of-realloc-size-in-le.patch - X.Org CVE-2014-0210: 1007-CVE-2014-0210-unvalidated-length-in-_fs_recv_conn_se.patch 1009-CVE-2014-0210-unvalidated-lengths-when-reading-repli.patch 1011-CVE-2014-0210-unvalidated-length-fields-in-fs_read_q.patch 1014-CVE-2014-0210-unvalidated-length-fields-in-fs_read_e.patch 1015-CVE-2014-0210-unvalidated-length-fields-in-fs_read_g.patch 1016-CVE-2014-0210-unvalidated-length-fields-in-fs_read_l.patch 1017-CVE-2014-0210-unvalidated-length-fields-in-fs_read_l.patch - X.Org CVE-2014-0211: 1010-CVE-2014-0211-Integer-overflow-in-fs_get_reply-_fs_s.patch 1012-CVE-2014-0211-integer-overflow-in-fs_read_extent_inf.patch 1013-CVE-2014-0211-integer-overflow-in-fs_alloc_glyphs-fr.patch 1018-unchecked-malloc-may-allow-unauthed-client-to-crash-.patch - X.Org CVE-2014-8092: 1019-dix-integer-overflow-in-ProcPutImage-CVE-2014-8092-1.patch 1020-dix-integer-overflow-in-GetHosts-CVE-2014-8092-2-4.patch 1021-dix-integer-overflow-in-RegionSizeof-CVE-2014-8092-3.patch 1022-dix-integer-overflow-in-REQUEST_FIXED_SIZE-CVE-2014-.patch - X.Org CVE-2014-8097: 1023-dbe-unvalidated-lengths-in-DbeSwapBuffers-calls-CVE-.patch - X.Org CVE-2014-8095: 1024-Xi-unvalidated-lengths-in-Xinput-extension-CVE-2014-.patch - X.Org CVE-2014-8096: 1025-xcmisc-unvalidated-length-in-SProcXCMiscGetXIDList-C.patch - X.Org CVE-2014-8099: 1026-Xv-unvalidated-lengths-in-XVideo-extension-swapped-p.patch - X.Org CVE-2014-8100: 1027-render-check-request-size-before-reading-it-CVE-2014.patch 1028-render-unvalidated-lengths-in-Render-extn.-swapped-p.patch - X.Org CVE-2014-8102: 1029-xfixes-unvalidated-length-in-SProcXFixesSelectSelect.patch - X.Org CVE-2014-8101: 1030-randr-unvalidated-lengths-in-RandR-extension-swapped.patch - X.Org CVE-2014-8093: 1031-glx-Be-more-paranoid-about-variable-length-requests-.patch 1032-glx-Be-more-strict-about-rejecting-invalid-image-siz.patch 1033-glx-Additional-paranoia-in-__glXGetAnswerBuffer-__GL.patch 1034-glx-Add-safe_-add-mul-pad-v3-CVE-2014-8093-4-6-v4.patch 1036-glx-Integer-overflow-protection-for-non-generated-re.patch - X.Org CVE-2014-8098: 1035-glx-Length-checking-for-GLXRender-requests-v2-CVE-20.patch 1037-glx-Top-level-length-checking-for-swapped-VendorPriv.patch 1038-glx-Length-checking-for-non-generated-single-request.patch 1039-glx-Length-checking-for-RenderLarge-requests-v2-CVE-.patch 1040-glx-Pass-remaining-request-length-into-varsize-v2-CV.patch - X.org CVE-2015-0255 1104-xkb-Check-strings-length-against-request-size.patch . - Security fixes with no assigned CVE: 1008-Don-t-crash-when-we-receive-an-FS_Error-from-the-fon.patch . - Rebase the following patches that are prerequisites for the CVE-2015-0255 patch: 1101-Coverity-844-845-846-Fix-memory-leaks.patch 1102-include-introduce-byte-counting-functions.patch 1103-xkb-Don-t-swap-XkbSetGeometry-data-in-the-input-buff.patch . - Fix FTBFS due to the nxproxy executable already existing under /usr/lib/nx/bin/nx/ . [ Mihai Moldovan ] * Change string "X2go" to "X2Go" where appropriate. * CVE security review: - Update 1007-CVE-2014-0210-unvalidated-length-in-_fs_recv_conn_se.patch. Use xfree() instead of free() in nx-libs. - Update 1011-CVE-2014-0210-unvalidated-length-fields-in-fs_read_q.patch. Apply correctly on nx-libs 3.6.x. - Update 1020-dix-integer-overflow-in-GetHosts-CVE-2014-8092-2-4.patch. Human-readable version of "1 MB". - Add 1041-nx-X11-lib-font-fc-fserve.c-initialize-remaining-buf.patch. Initialize remaining bufleft variables (nx-X11/lib/font/fc/fserve.c). - Add 1042-Do-proper-input-validation-to-fix-for-CVE-2011-2895.patch. Do proper input validation to fix for CVE-2011-2895.

2 1

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

x2go-dev