x2go-dev March 2014

x2go-dev@lists.x2go.org

12 participants
111 discussions

Bug#448: KDE's libssh was patched for Pageant support
by Michael DePaulo 17 Mar '14

17 Mar '14

If you compare KDE's libssh 0.5.3 src/agent.c ftp://winkde.org/kde/ports/win32/releases/stable/latest/libssh-x86-mingw4-0… To the vanilla libssh 0.5.3 src/agent.c http://git.libssh.org/projects/libssh.git/tree/src/agent.c?id=libssh-0.5.3 You'll see that KDE patched it to add support for Pageant as an SSH agent for Windows. There's also winpgntc.c and winpgntc.h included in the KDE version, but not in the vanilla version. Our libssh 0.5.5 build doesn't have Pageant support: http://git.libssh.org/projects/libssh.git/tree/src/agent.c?id=libssh-0.5.5 And neither does libssh 0.6.3: http://git.libssh.org/projects/libssh.git/tree/src/agent.c?id=libssh-0.6.3 Or the current (2014-03-16) HEAD: http://git.libssh.org/projects/libssh.git/tree/src/agent.c So right now I need to find the applied patch they applied. The src.tar.bz2 file contains patches, but only for CVE vunlerabilities. I do not see .patch files for this feature, it is already applied to the source.

1 0

Bug#448: Linux not affected
by Michael DePaulo 17 Mar '14

17 Mar '14

This bug was not present on the following client setup: Fedora 20 64-bit GNOME keyring 3.10.1 (1.fc20) libssh 0.6.3 (1.fc20) x2goclient 4.0.1.3 (4.fc20) Specifically, 1. if I had not entered my passphrase for my private key into GNOME kerying yet, then upon initiating the connection GNOME keyring would prompt me. (X2Go Client did not prompt me.) Once it was done, X2Go Client would connect. 2. if I had already entered my passphrase for my private key into GNOME keyring, then upon initiating the connection, X2Go Client would connect without any prompts.

1 0

Bug#422: X2Go issue (in src:x2goclient) has been marked as pending for release
by Mike DePaulo 16 Mar '14

16 Mar '14

tag #422 pending fixed #422 4.0.2.0 thanks Hello, X2Go issue #422 (src:x2goclient) reported by you has been fixed in X2Go Git. You can see the changelog below, and you can check the diff of the fix at: http://code.x2go.org/gitweb?p=x2goclient.git;a=commitdiff;h=acbc897 The issue will most likely be fixed in src:x2goclient (4.0.2.0). light+love X2Go Git Admin (on behalf of the sender of this mail) --- commit acbc89719808a34f21888f8b66110d4ff79bd5f5 Author: Mike DePaulo <mikedep333(a)gmail.com> Date: Sun Mar 16 11:29:13 2014 -0400 Update comment for last commit and add to debian/changelog. (Fixes #422) diff --git a/debian/changelog b/debian/changelog index 30f8182..90d98ef 100644 --- a/debian/changelog +++ b/debian/changelog @@ -50,6 +50,11 @@ x2goclient (4.0.2.0-0x2go1) UNRELEASED; urgency=low * New upstream version (4.0.2.0): - Decrease HelpDialog's tab width from 320 to 30 (the width of 10 spaces.) (Fixes: #453) + - Windows: Fix compatibility with PulseAudio 3.0 & later through + new cookie handling. (Fixes: #422) + - Windows: Upgrade included PulseAudio from 1.1 to 5.0. + The 5.0 build is patched for X2Go bug #363. and available here: + https://build.opensuse.org/project/show/home:mikedep333:branches:home:mkbos… -- Mike Gabriel <mike.gabriel(a)das-netzwerkteam.de> Wed, 22 Jan 2014 09:20:08 +0100

2 1

Bug#422: Just Create the .config/pulse/ dir!
by Michael DePaulo 14 Mar '14

14 Mar '14

After spending lots of time debugging this issue, largely involving comparing the debug output from pulseaudio.exe, I believe I've determined a simple fix. I observed that if I create this directory ahead of time, the pulseaudio.exe process launched by x2goclient.exe creates the "cookie" file under it & stays running. C:\Users\mike\.x2go\pulse\.config\pulse\ Therefore, I believe a simple fix for this bug is for x2goclient.exe, regardless of what version of pulseaudio.exe is installed, to: 1. Create that directory (if it DNE). 2. Include logic around onmainwindow.cpp:5149 to use the cookie at that path. If the cookie is not in that location, fall back to ".pulse-cookie". We already have this logic for Linux. I plan to write, test, and (hopefully) commit this fix tomorrow night. Note that we cannot override the cookie location due to PulseAudio Bug 75006: https://bugs.freedesktop.org/show_bug.cgi?id=75006 Note that although I am not sure why PulseAudio.exe is incapable of creating this file when launched by x2goclient.exe, compared to when it is launched by cmd.exe, I believe this is still safe approach to solving the bug. I say this because PulseAudio devs's comments & commit messages make it clear that they support both the directory already existing, and the directory not already existing. For example: http://cgit.freedesktop.org/pulseaudio/pulseaudio/commit/src/pulsecore/auth…

2 1

Bug#453: X2Go issue (in src:x2goclient) has been marked as pending for release
by Mike DePaulo 14 Mar '14

14 Mar '14

tag #453 pending fixed #453 4.0.2.0 thanks Hello, X2Go issue #453 (src:x2goclient) reported by you has been fixed in X2Go Git. You can see the changelog below, and you can check the diff of the fix at: http://code.x2go.org/gitweb?p=x2goclient.git;a=commitdiff;h=dfaaabc The issue will most likely be fixed in src:x2goclient (4.0.2.0). light+love X2Go Git Admin (on behalf of the sender of this mail) --- commit dfaaabc9680cc621e4f13e4d9c293664615fe2e4 Author: Mike DePaulo <mikedep333(a)gmail.com> Date: Thu Mar 13 21:03:05 2014 -0400 Decrease HelpDialog tab width from 320 to 30 (the width of 10 spaces.) (Fixes: #453) diff --git a/debian/changelog b/debian/changelog index 7d89bd9..30f8182 100644 --- a/debian/changelog +++ b/debian/changelog @@ -46,6 +46,11 @@ x2goclient (4.0.2.0-0x2go1) UNRELEASED; urgency=low %setup. + Copy ChangeLog.gitlog (if present) into txt/ subfolder during %setup. + [ Mike DePaulo ] + * New upstream version (4.0.2.0): + - Decrease HelpDialog's tab width from 320 to 30 + (the width of 10 spaces.) (Fixes: #453) + -- Mike Gabriel <mike.gabriel(a)das-netzwerkteam.de> Wed, 22 Jan 2014 09:20:08 +0100 x2goclient (4.0.1.4-0x2go1) UNRELEASED; urgency=low

2 1

Bug#422: Commit 7fad67c4 is the culprit
by Michael DePaulo 13 Mar '14

13 Mar '14

After repeated testing of PulseAudio builds leading up to PulseAudio 3.0, I determined that this commit introduced this bug/incompatibility: 7fad67c46188991c04a42b190349ebb3f4a1756f 2012-05-15 17:06:53 (GMT) http://cgit.freedesktop.org/pulseaudio/pulseaudio/commit/?id=7fad67c4618899…

2 3

Bug#422: Also
by Michael DePaulo 12 Mar '14

12 Mar '14

Also, I forgot to write up these notes earlier. These are notes on me trying to debug this bug. These notes suggest that this bug is not a bug in PulseAudio, but rather an incompatibility between X2Go Client and PulseAudio. When pulseaudio.exe (3.0 and later) is launched from the command line, there is different behavior: 1. The cookie is created. By default, it is created at C:\Users\mike\.config\pulse\cookie 2. pulseaudio.exe stays running. I use the same command that x2go uses (with an actual x2go config file generated for pulseaudio): pulseaudio.exe -n -F c:\path-to-config.pa I also tried setting the environment variables to the same ones that x2goclient.exe sets. Still, the cookie was created and pulseaudio.exe stayed running. (I do not have the exact env vars on me at the moment. However, I viewed them using Process Explorer.) Since x2goclient.exe overrides USERPROFILE, that was one of the env vars I set. The cookie was created relative to it, for example, C:\Users\mike\.x2go\pulse\.config\pulse\cookie Maybe the use of forward slashes vs backslashes, or the use of the 8.3 format for some of the path values is to blame. However, I used the same exact values for those env vars on the command line, and still the behavior differed from when x2goclient.exe launches pulseaudio.exe

1 0

Bug#422: Status Update
by Michael DePaulo 12 Mar '14

12 Mar '14

Status Update 1. x2goclient's 4.0.2.0 2014.03.05 nightly build was the last nightly build to be built with --console. So I ran that build with --debug. I've attached the output. I wonder if x2goclient is detecting that pulseaudio.exe stopped and then restarting it, or if x2goclient is forcefully restarting pulseaudio.exe? I'm leaning towards the former explanation. Other than that though, the logs do not help me debug this bug. 2. It seems likely that this PulseAudio commit (which made it into PulseAudio 3.0) triggered this bug, since it changed the logic for cookie creation, in addition to specifying a different default cookie path. http://cgit.freedesktop.org/pulseaudio/pulseaudio/commit/?id=87ae8307057944… Most likely the bug/incompatibility lies in one or both of these files: src/pulsecore/authkey.c src/pulse/client-conf.c I plan on compiling pulseaudio before and after this commit to determine empirically if this commit triggered this bug/incompatibility.

1 0

Embed pyhoca-cli window in another window
by Borys Saulyak 08 Mar '14

08 Mar '14

Hello all, I am trying to develop X2GO plugin for Remmina and I am missing one very important feature in pyhoca. I need to be able to "embed" pyhoca window into another window. Something similar to "-parent" for Xephyr or "-X" for rdesktop. I tried myself to find how to do it but failed because my python knowledge is very limited. Do you think it is something that can be easily added? In case if nobody is interested would anyone please point me out in the code where the windows is getting created? Thanks a lot for your help in advance!

3 2

Bug#448: x2goclient won't connect with ssh agent (Q: Who was so afraid of the NSA that he disabled agent communication in x2go?)
by Stefan Baur 07 Mar '14

07 Mar '14

Addendum: Mike#2 suggested looking at libssh, as that was upgraded, too. So it might be that it's not a bug in x2goclient per se, but in how libssh talks to ssh agents. -Stefan

1 1

← Newer
1
...
6
7
8
9
10
11
12
Older →

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

x2go-dev March 2014