x2go-dev March 2012

x2go-dev@lists.x2go.org

23 participants
34 discussions

x2goclient crashing
by Oliver Burger 02 Mar '12

02 Mar '12

Hi, I have a "little" problem. I built x2goclient, the nx-libs and x2goserver from the SOURCES and it does work, when client and server are running on the same computer. But x2goclient crashes, as soon as it runs on a different one, after showing a popup window, telling me the server reset the connection. Is there any one having an idea, why that is the case? See the client's debug messages here: http://pastebin.com/RTRhRwaZ and the server's log output here: http://pastebin.com/qzEUjkyK Thanks, Oliver

1 0

[PATCH] Fix 051_nxcomp_macos105-fdisset.full+lite.patch.
by Mihai Moldovan 01 Mar '12

01 Mar '12

Patch attached.

3 2

Building problems with x2goserver
by Oliver Burger 01 Mar '12

01 Mar '12

Trying to build x2goserver-3.1.0.0 I get -----> snip <----- install -d -m 755 /mnt/data/mageia-build/packages/cauldron/x2goserver/BUILDROOT/x2goserver-3.1.0.0-1.mga2.x86_64/usr/share/x2go install -d -m 755 /mnt/data/mageia-build/packages/cauldron/x2goserver/BUILDROOT/x2goserver-3.1.0.0-1.mga2.x86_64/usr/share/x2go/x2gofeature.d install -m 755 share/x2gofeature.d/*.features /mnt/data/mageia-build/packages/cauldron/x2goserver/BUILDROOT/x2goserver-3.1.0.0-1.mga2.x86_64/usr/share/x2go/x2gofeature.d/ install: cannot stat `share/x2gofeature.d/*.features': No such file or directory make[1]: *** [install_scripts] Error 1 make[1]: Leaving directory `/mnt/data/mageia-build/packages/cauldron/x2goserver/BUILD/x2goserver/x2goserver-fmbindings' make: *** [install] Error 2 -----> snip <----- This happens with the release tar ball as well as with a git clone. There just is no "share" directory in there. Oliver

4 7

[PATCH] Fix compilation of nxcomp on Mac OS X 10.5.
by Mihai Moldovan 01 Mar '12

01 Mar '12

The Mac OS X 10.5 SDK requires the second argument of FD_ISSET to be writeable, although it does only access the data. Given that we have a const pointer for a const struct, copy and pass that. Note that this is merely a workaround for OS X 10.5, as 10.6 and later define the second argument of FD_ISSET as const struct const *foo, too. It it safe, as data is accessed read-only by FD_ISSET, even on 10.5. Signed-off-by: Mihai Moldovan <ionic(a)ionic.de> --- nxcomp/Agent.h | 28 ++++++++++++++++++++-------- 1 files changed, 20 insertions(+), 8 deletions(-) diff --git a/nxcomp/Agent.h b/nxcomp/Agent.h index fac5acd..ded344d 100644 --- a/nxcomp/Agent.h +++ b/nxcomp/Agent.h @@ -149,30 +149,38 @@ class Agent int remoteCanRead(const fd_set * const readSet) { + // OS X 10.5 requires the second argument to be non-const, so copy readSet. + // It's safe though, as FD_ISSET does not operate on it. + fd_set readWorkSet = *readSet; + #if defined(TEST) || defined(INFO) *logofs << "Agent: remoteCanRead() is " << - (FD_ISSET(remoteFd_, readSet) && transport_ -> dequeuable() != 0) - << " with FD_ISSET() " << (int) FD_ISSET(remoteFd_, readSet) + (FD_ISSET(remoteFd_, &readWorkSet) && transport_ -> dequeuable() != 0) + << " with FD_ISSET() " << (int) FD_ISSET(remoteFd_, &readWorkSet) << " and dequeuable " << transport_ -> dequeuable() << ".\n" << logofs_flush; #endif - return (FD_ISSET(remoteFd_, readSet) && + return (FD_ISSET(remoteFd_, &readWorkSet) && transport_ -> dequeuable() != 0); } int remoteCanWrite(const fd_set * const writeSet) { + // OS X 10.5 requires the second argument to be non-const, so copy writeSet. + // It's safe though, as FD_ISSET does not operate on it. + fd_set writeWorkSet = *writeSet; + #if defined(TEST) || defined(INFO) *logofs << "Agent: remoteCanWrite() is " << - (FD_ISSET(remoteFd_, writeSet) && transport_ -> + (FD_ISSET(remoteFd_, &writeWorkSet) && transport_ -> queuable() != 0 && canRead_ == 1) << " with FD_ISSET() " - << (int) FD_ISSET(remoteFd_, writeSet) << " queueable " + << (int) FD_ISSET(remoteFd_, &writeWorkSet) << " queueable " << transport_ -> queuable() << " channel can read " << canRead_ << ".\n" << logofs_flush; #endif - return (FD_ISSET(remoteFd_, writeSet) && + return (FD_ISSET(remoteFd_, &writeWorkSet) && transport_ -> queuable() != 0 && canRead_ == 1); } @@ -203,13 +211,17 @@ class Agent int proxyCanRead(const fd_set * const readSet) { + // OS X 10.5 requires the second argument to be non-const, so copy readSet. + // It's safe though, as FD_ISSET does not operate on it. + fd_set readWorkSet = *readSet; + #if defined(TEST) || defined(INFO) *logofs << "Agent: proxyCanRead() is " - << ((int) FD_ISSET(proxy -> getFd(), readSet) + << ((int) FD_ISSET(proxy -> getFd(), &readWorkSet) << ".\n" << logofs_flush; #endif - return (FD_ISSET(proxy -> getFd(), readSet)); + return (FD_ISSET(proxy -> getFd(), &readWorkSet)); } int enqueueData(const char *data, const int size) const -- 1.7.9

3 5

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

x2go-dev March 2012