This is an automated email from the git hooks/post-receive script. x2go pushed a change to branch bugfix/osx in repository x2goclient. discards c4004a2 src/onmainwindow.cpp: add some comments only to createRSAKey (). discards 7b1e999 src/onmainwindow.cpp: let startSshd () act as a wrapper and be called multiple times. discards f3184b0 src/onmainwindow.{cpp,h}: reformat createRSAKey () only. discards 37593ef src/onmainwindow.{cpp,h}: move createRSAKey () around. discards 2967b20 src/onmainwindow.{cpp,h}: reformat generateKey () only. discards 74fe4fa src/onmainwindow.h: move generateKey () declaration around. discards 9bb0bad src/onmainwindow.cpp: use the new functions in generateKey (). discards a0e7309 src/onmainwindow.{cpp,h}: add new function default_size_for_key_type (). discards 324fbf8 src/onmainwindow.{cpp,h}: add new function key_type_to_string (). discards b8736c1 src/onmainwindow.{cpp,h}: add new function check_key_type (). discards b84ca8c src/onmainwindow.cpp: terminate sshd more correctly. discards 7b48903 src/onmainwindow.cpp: uppercase key type in debug output and comment string in generateKey (). discards 66e14dd src/onmainwindow.cpp: when starting sshd on Unix-based plattforms, raise maximum startup time to 5 seconds and break out early, if the process went into running state earlier. discards eaefda1 src/{onmainwindow.{cpp,h},configdialog.cpp}: remove userSshd variable and code related to non-user-mode-sshd setups. discards b3b2618 src/onmainwindow.cpp: fix up a few debug strings. discards c65e647 src/onmainwindow.cpp: add more error handling to generateKey () and fix up a broken error-handling section. discards 84a1b9b src/onmainwindow.{cpp,h}: rewrite generateKey () function to actually also generate user keys. discards d2946a8 src/onmainwindow.cpp: refactor generateKey () a little bit to compact it. discards 11921f2 src/onmainwindow.{cpp,h}: rename generateHostKey () to generateKey () and add a boolean parameter with a default of false to request a public key. discards 700a820 src/onmainwindow.cpp: add support for explicitly setting the private key bit size based on type and use values (currently) regarded as secure to generateHostKey (). discards 0ceefda src/onmainwindow.cpp: document createRSAKey () because what it does is completely non-obvious. discards f4b137f src/{unixhelper.cpp,x2goclient.cpp}: fix errno usage - save before use. discards 42b3034 src/unixhelper.cpp: code cleanup. discards 09ebb8f src/pulsemanager.cpp: remove unused variables. discards b4c4fe8 src/unixhelper.{cpp,h}: rewrite kill_pgroup () to act as a wrapper around real_kill_pgroup (). discards c77f3e0 src/unixhelper.{cpp,h}: split off core functionality of kill_pgroup () into a new function called real_kill_pgroup (). discards d0ed5dc src/unixhelper.h: style and general fixes within comments. discards 74ab684 src/unixhelper.{cpp,h}: make argument of kill_pgroup () const. discards 34a1149 src/pulsemanager.cpp: fix PA version fetching on OS X again. discards 3f31599 src/pulsemanager.cpp: make sure that wherever we interface with non-Qt functions, paths are in native form (i.e., containing empty separators, instead of the "generic" slash UNIX-style separator.) discards 588b092 src/pulsemanager.cpp: make PA version parsing function more generic and don't expect that a number is always terminated with a period or dash. discards 032acc9 src/pulsemanager.h: include accidentally omitted wapi.h header file. discards 5dd0454 src/onmainwindow.cpp: use correct C++ universal initializer for initializing in_addr-type variable, the C-style universal zero initializer won't cut it here. discards 5df0171 src/onmainwindow.cpp: fix compile error on Windows after moving some code around. discards fdcec57 src/onmainwindow.cpp: add another pair of braces to in_addr-type variable initialization on Windows to silence compiler warning. discards e8198d9 src/onmainwindow.cpp: drop obsolete pulseVersionIsLegacy variable initialization in Windows-only code. discards 4ebccea src/onmainwindow.cpp: drop obsolete pulseVersionTest variable initialization in Windows-only code. discards f4ca2db src/onmainwindow.cpp: short out code parts unconditionally checking for the userSshd variable. discards 1b0f1fa src/pulsemanager.h: use windows_stdint.h header on Windows, cstdint otherwise. discards 248650a src/: new file windows_stdint.h for Windows-compatibility when using std::(u)int*_t types. discards 78d19e2 nsis/x2goclient.nsi: add startup.wav to installer package. discards 0458d42 src/x2goutils.cpp: add some debug logging to find_binary (). discards 93a7b94 src/x2goutils.cpp: fix faulty logic in find_binary (): only reset the given path to CWD iff it's actually empty. Not the other way around. discards ffcc038 src/pulsemanager.cpp: remove extraneous newlines from debug output. discards f6b58a5 src/pulsemanager.cpp: add warning message boxes where appropriate. discards f5b4e02 src/pulsemanager.cpp: fix startup sound playback when using the system-PA version. discards 3c52b65 src/pulsemanager.cpp: fix startup when using the system-PA version. discards d0bc711 src/pulsemanager.cpp: fix compile error on Windows. discards ca80786 debian/changelog: fix typo in function name. discards 961b0b7 src/x2goutils.h: fix compile error due to typo. discards f57a7c7 src/pulsemanager.cpp: add error message boxes throughout PulseManager. discards 0b8c6d6 src/x2goutils.{cpp,h}: add application modality parameter to show_RichText_Generic_MsgBox () and its wrappers. discards 7082299 src/pulsemanager.cpp: correctly initialize and set system_pulse_ when required. discards 05846a6 src/pulsemanager.h: add new system_pulse_ variable to indicate that a system PA binary shall be used. discards 68e6d79 src/x2goutils.cpp: fix compile error. discards 562f8f5 src/pulsemanager.cpp: add reminder for Linux-implementation in play_startup_sound (). discards d1b6c4f src/pulsemanager.cpp: add comments to Qt 4 code part. discards 169ea15 src/pulsemanager.cpp: auto-detect PA binary in $PATH and MacPorts default prefix as well on OS X. discards 3ea3f1b src/x2goutils.{cpp,h}: add new function find_binary (). discards eff24ad src/pulsemanager.cpp: don't remove PA config and log file in ~/.x2go/pulse on PA shutdown if debugging has been requested. discards f852608 src/pulsemanager.cpp: insert PULSE_SERVER and PULSE_COOKIE variables into environment as used by PulseManager. discards 766a519 src/pulsemanager.cpp: don't insert stray newline into config.pa. discards cbfed15 src/pulsemanager.cpp: actually only play startup sound if debugging is enabled. discards 433ab3a src/pulsemanager.{cpp,h}: rename on_pulse_finished () to slot_on_pulse_finished (). discards fa7dabe src/pulsemanager.cpp: don't overwrite the temporary string variable for the current line with what was supposed to hold new data in fetch_pulseaudio_version (). discards 7883e4d src/pulsemanager.cpp: fix typo in fetch_pulseaudio_version (). discards 8ea4b38 macbuild.sh: save return value of parse_otool_output (). discards c2b7408 macbuild.sh: don't error out while executing parse_otool_output (). discards 0501a77 macbuild.sh: also add PA binaries to deduplication fixup list. discards 8a73dd2 macbuild.sh: fix copying of resource files. discards 3c7ec41 res: rename "sound" to "audio". discards 091790f macbuild.sh: add support for copying resource files. discards de6486e src/pulsemanager.cpp: don't time out while trying to start PA or paplay. discards 4ba52ca res/sound: add startup.wav sound to be played back when starting the PA daemon in debug mode. discards 18f4689 src/pulsemanager.h: fix compile error due to mismatching function declaration for set_debug (). discards f16e619 src/onmainwindow.cpp: port to new debugging feature of PulseManager. discards aa58c79 src/pulsemanager.{cpp,h}: port to new debugging feature. discards 09b6929 src/pulsemanager.{cpp,h}: add debugging setter and private variable. discards ab88b56 src/pulsemanager.cpp: hide Windows-only code behind #ifdefs. discards e98c722 src/pulsemanager.cpp: fix compile error due to typo. discards cedc296 src/onmainwindow.cpp: make use of new PulseManager::start () behavior and always use it, no matter whether server is up already or not. discards 92da786 src/onmainwindow.cpp: convert QDir object to QString for further processing. discards 8eae754 src/onmainwindow.cpp: fix compile error due to misuse of #ifdef. discards 0cdd675 src/pulsemanager.cpp: let start () act as a wrapper and do nothing if the PA server is already running. discards 27d58e8 src/onmainwindow.cpp: fix compile errors due to misspelled function names. discards e579616 src/configdialog.cpp: fix compile error by removing obsolete (and now faulty) line for removed restart message. discards 6d2d88d src/pulsemanager.cpp: output PA stdout/stderr via x2goDebug, not plainly to stdout. discards 3012cc9 src/pulsemanager.h: move x2gologdebug.h inclusion into implementation file. discards 6ae92cf src/mediawidget.cpp: reflect new capabilities through PulseManager. discards 511b647 src/onmainwindow.{cpp,h}: hook PulseManager in - for both OS X and Windows. discards 682f51f src/configdialog.cpp: whitespace only. discards 6a4aca1 src/configdialog.{cpp,h}: add "no record" support for OS X (through PulseManager.) discards fac39f5 src/pulsemanager.cpp: backport fix for 422. discards b2fce4b src/pulsemanager.cpp: backport fix for 526. discards 8f3cd18 src/pulsemanager.cpp: add "FIXME" debug logging (and cleanup.) discards 44ca15a src/pulsemanager.cpp: replace hardcoded modules paths with dynamic ones depending on the detected PA version. discards a632e92 src/pulsemanager.{cpp,h}: add get_pulse_dir () for fetching the (OS-dependent) PulseAudio config and cookie directory. discards eb61d2f pulsemanager.cpp: remove config.pa while doing post-exit cleanups. discards f12106d macbuild.sh: libpulsecore.dylib also resides in the "private" pulseaudio subdirectory now, adding it to "special files workaround". discards c99b955 macbuild.sh: PulseAudio has been updated to version 8.0. Reflect this. discards 3bb8540 pulsemanager.cpp: cleanup, don't use copy assignment operator when we just need to construct a new object. discards 18ac184 pulsemanager.cpp: use record and playback member variables. discards 7b1798a pulsemanager.h: more moving around. discards f54b004 pulsemanager.cpp: fix compile error in startup sound function. discards 8db868e pulsemanager.cpp: reorder member variables in initializer list. discards 64e8a89 pulsemanager.{cpp,h}: add record and playback private members, as well as getters and setters. discards de92d78 pulsemanager.{cpp,h}: only allow changing PA or ESD ports when server is not currently running. discards d8d4721 pulsemanager.cpp: add algorithm for actually extracting PA version number. discards 111b56b pulsemanager.h: reformat a bit by adding newlines and moving lines in a (hopefully) logical fashion. discards d69fe11 pulsemanager.{cpp,h}: some older PA versions used the major, minor and micro numbering scheme together with a descriptive string. discards d400cb3 pulsemanager.cpp: fix some error messages by removing redundant newlines. discards 61761ce pulsemanager.cpp: re-initialize buffer string on each run while getting CWD on Linux. discards cf64d47 pulsemanager.{cpp,h}: new member function fetch_pulseaudio_version () with first skeleton. discards 23e1d9c pulsemanager.cpp: generate platform-dependent values for member variables server_working_dir_ and server_binary_ in constructor. discards 4838f85 pulsemanager.cpp: add "dummy" start_linux () function. discards aa86e18 pulsemanager.cpp: reorder member variables in initialization list. discards f05cf5f pulsemanager.cpp: another typo fix: findPort -> find_port. discards aa8f363 pulsemanager.cpp: fix another compile error due to typo'd versions of generate_server_config () and generate_client_config (). discards 0f883d8 pulsemanager.cpp: fix compile errors in find_port () by renaming the ret or port variable to search_port. discards 5afe405 pulsemanager.{cpp,h}: find_port () actually returns a value, fix declaration accordingly. discards d0109b3 pulsemanager.cpp: typo fix in member variable name server_working_dir_. discards f7e89c1 pulsemanager.h: whitespace only. discards 59da29c pulsemanager.cpp: make startup sound playing via slot_play_startup_sound () Windows-compatible. discards 7038007 pulsemanager.cpp: only play startup sound if DEBUG macro is defined. discards 8263b02 pulsemanager.cpp: make generate_client_config () Windows-compatible. discards c65e338 pulsemanager.cpp: make generate_server_config () Windows-compatible. discards 9ada86b pulsemanager.cpp: also load module-esound-protocol-tcp module. discards 23ca3de pulsemanager.{cpp,h}: implement start_win () as part of Windows functionality. discards 9f427ba pulsemanager.cpp: let start_osx () use start_generic (). discards fc7b8aa pulsemanager.{cpp,h}: add new function start_generic () to split off common functionality. discards 6ca4793 pulsemanager.cpp: add Windows stuff to initial env in constructor. discards 12c7e8b pulsemanager.cpp: add cleanup support to on_pulse_finished (). discards 4b29aa8 pulsemanager.cpp: add Windows support to shutdown (). discards ce9f7d5 pulsemanager.{cpp,h}: new function create_client_dir (). discards 1ccc652 pulsemanager.cpp: make start () wrap the "real" OS-specific start functions. discards 7561904 pulsemanager.{cpp,h}: add server_args_, server_binary_ and server_working_dir_ class variables. discards cf4825f pulsemanager.{cpp,h}: fixup preprocessor usage. discards c4ae261 pulsemanager.cpp: reformat only. discards 450b215 pulsemanager.{cpp,h}: rename relaunch () to restart (). discards 87c186c pulsemanager.{cpp,h}: add ESD support. discards ba3d72b pulsemanager.h: add std:: namespace selector for uint32_t version variables. discards 46d9374 pulsemanager.{cpp,h}: switch port definitions to std::uint16_t. discards c9b58a8 pulsemanager.cpp: reformat only. discards cdfb9cf pulsemanager.{cpp,h}: add pulse_version_{major,minor}_ member variables. discards a59cef1 pulsemanager.cpp: use initializer list for constructor. discards 52c661b pulsemanager.{cpp,h}: reformat only. discards 24c8326 pulsemanager.cpp: minor non-behavior changing fixes. discards c2d4c59 pulsemanager.{cpp,h}: use name and underscore for member variables, not underscore and name. discards 836ccc0 macbuild.sh: rewrite ID line detection algorithm. discards 3f09649 macbuild.sh: copy "special" files, so that they can be removed later on. discards 3c0c58a macbuild.sh: fix removal of base prefix in deduplication if base prefix ends in a slash. discards 0ca98c7 macbuild.sh: more debug messages and a whitespace change. discards 59168a1 macbuild.sh: spelling fix. discards f5e6238 macbuild.sh: merge deduplicate.sh content in. discards d13458c deduplicate.sh: replace tabs with two spaces. No functional changes. discards eda26f7 macbuild.sh: replace tabs with two spaces. No functional changes. discards 547a7ec deduplicate.sh: remove some noisy debug output. discards 47da974 deduplicate.sh: add WARNING to status message. discards b3e6e4b deduplicate.sh: fix wrong return value capture. discards cf417cd deduplicate.sh: remove a bit of noisy debug output, but turn on parse_otool_output debugging. discards a581a0a deduplicate.sh: cleanup as announced in the last commit - using lazy_canonical_path. discards 23a570b deduplicate.sh: surprisingly, it turned out that only checking the duplicate's basename against the current dependency's basename is not good enough. discards b942869 deduplicate.sh: more temporary debugging output in fixup section. discards 9c5b0ee deduplicate.sh: copy lazy_canonical_path from macbuild.sh for now. discards a020de6 deduplicate.sh: save dependency format base string as a readonly variable and use that instead of repeating a fixed string. discards a6a8527 deduplicate.sh: actually include file name in install_name_tool pseudo output. discards b747b83 deduplicate.sh: parse_otool_output: jump over first matching entry, which is - hopefully - the id line. discards f6a9ab0 deduplicate.sh: unstub fixup section. discards 1d7faaf deduplicate.sh: add more useful information in fixup section's error message. discards e9fc21a deduplicate.sh: switch to range-based for loop in fixup section for duplicate array walking as we need to access the same element index in the replacement array. discards 7d53d71 deduplicate.sh: prevent word splitting when parsing otool's output. discards 344bda6 deduplicate.sh: debug parse_otool_output fiercely for the time being. discards 3fb7b43 deduplicate.sh: record crafted "library path" values in duplicates replacement to_files array. discards c65918c deduplicate.sh: change exit to return in parse_otool_output. discards 9a147ac deduplicate.sh: fix parse_otool_output: we want to return failure only iff any of the strings are present in otool's output and actually handle the failure string *ARRAY* correctly as that. discards 62796f9 deduplicate.sh: quote "${arr[@]}" correctly to not suddenly force word splitting. discards 084ff79 deduplicate.sh: change range-based for loops to "${!arr[@]}" to handle "sparse" arrays correctly. discards 7d34786 deduplicate.sh: correctly unset an array element. discards da9bef9 deduplicate.sh: add first skeleton for library dependency rewriting of deleted duplicates. discards 797d421 deduplicate.sh: non-functional: change WARNING to ERROR in error messages. discards 091d3bb deduplicate.sh: new function for parsing otool's output and printing library dependencies if no error occurred. discards 691c26c deduplicate.sh: add missed local variable declaration. discards 2edc739 deduplicate.sh: add duplicates-to-real mapping. discards eb05167 deduplicate.sh: add new, more or less Proof of Concept, and Work in Progress file deduplication script. discards ab02656 macbuild.sh: also install libraries into staging area with intermediate library path. discards 52529f9 macbuild.sh: fix echo call to also show the intermediate lib dir, not just the library file name. discards daea08c macbuild.sh: when actually bundling libraries, use @executable_path instead of @loader_path. discards d617bc7 macbuild.sh: add the correct file path to the library bundling array. discards 648f513 macbuild.sh: check current file name against regex, not a (now) full path. discards ba3cad1 macbuild.sh: use while-read-loop and find to actually recurse through directories. discards fd97787 macbuild.sh: remove libpulse and libpulsecore from libraries to be bundled, as something else will bundle them anyway. discards 600c2f9 macbuild.sh: add some more debugging output. discards a27df0e macbuild.sh: directories are "executable", so the first check must explicitly include a check for the argument being not a directory. discards fd29c1b macbuild.sh: add Linux library file name scheme regex as a precaution. discards 96113cd macbuild.sh: add work-in-progress PulseAudio bundling. discards a8339e6 macbuild.sh: add phase output for bundling nxproxy. discards a083a49 macbuild.sh: copy PulseAudio libraries and binaries. discards 8416790 macbuild.sh: define PulseAudio libraries and binaries to be later copied. discards 189782c macbuild.sh: add EXE_DIR and FRAMEWORKS_DIR internal variables. discards f55d8eb macbuild.sh: refactor nxproxy detection to use MACPORTS_PREFIX. discards e1193fd macbuild.sh: add new repeat_str() helper function. discards dba93b8 macbuild.sh: add new get_nesting_level() helper function. discards 098b6df macbuild.sh: add new lazy_canonical_path() helper function. discards 7857117 macbuild.sh: add new dependency_error() helper function. discards 8986b54 macbuild.sh: add new MACPORTS_PREFIX detection/variable. discards 52ab633 x2goclient.pro{maemo}: reference new pulsemanager.{cpp,h} files. discards ac5d0d4 pulsemanager.{cpp,h}: new class for PulseAudio management. discards 29a6bd2 compat.h: include QtCore/qglobal.h for Q_OS_... macros. discards c1208d6 compat.{cpp,h}: remove inline keyword, because function is not defined in header file. discards f47284f compat.{cpp,h}: new files. Implements strndup on OS X 10.6 and below. Add to x2goclient.cpp, x2goclient.pro and x2goclient.pro.maemo. discards 075bc6a onmainwindow.cpp: correctly use ~/.x2go/.ssh as ssh directory when starting sshd in user mode. discards 222ad83 appdialog.cpp: initialize parent in default case. Another GCC compile warning fix. discards e2f3f1b {appdialog,configwidget,onmainwindow,unixhelper}.cpp: fix some compile warnings with GCC. Fix a few whitespace issues. discards 36e920f x2goclient.cpp: fix failing exec() call for the UNIX helper utility: correctly terminate arguments vector. discards 4bd7e5f unixhelper.{cpp,h}: ignore SIGINT, SIGTERM, SIGPIPE, SIGQUIT, SIGUSR1 and SIGUSR2. discards 84c357f {unixhelper.{cpp,h},x2goclient.cpp}: switch main cleanup handling to parent PID polling. discards a0ab46e unixhelper.{cpp,h}: raise sleeping time to two seconds and grace period to 10 seconds. discards 2e21bd0 x2goclient.cpp: create new argv array on the heap instead of on the stack. discards 3ba6b6f x2goclient.cpp: fix string comparison. discards c5a9b1b x2goclient.cpp: fix compile problems introduced with the last commit. discards 7ed74e3 x2goclient.cpp: don't start the UNIX cleanup helper process right after forking. discards 38c39b2 x2goclient.cpp: clean up. discards 2de3c11 unixhelper.cpp: port from std::signal() to sigaction(). Handle errors. discards 268b431 unixhelper.{cpp,h}: implement signal unblocking in unixhelper::unix_cleanup(). Update documentation. discards 02f70e5 unixhelper.cpp: kill process group on error. discards bcaa8e3 x2goclient.cpp: return return value of unixhelper::unix_cleanup(). discards 451943c unixhelper.{cpp,h}: add documentation/comments. discards 51a592b unixhelper.{cpp,h},x2goclient.cpp}: unixhelper should really be a (module) namespace, not a class. discards 15f4819 unixhelper.h: forgot to declare type of unix_cleanup() function. discards 4e094cf unixhelper.{h,cpp}: also include <QtCore/qglobal.h> to have Q_OS_UNIX defined on UNIX-based platforms. Move guards around. discards f2fa964 x2goclient.cpp: fix std::edit -> std::exit typo. discards c962e00 x2goclient.cpp: add legacy <sys/types.h> header needed for old operating systems. discards 9211d5c x2goclient.cpp: add myself to copyright header. discards acb2081 x2goclient.cpp: use setsid() on UNIX to become session and process group leader. discards 52bc7c5 x2goclient.cpp: add fork_helper() function to start up the UNIX cleanup helper. discards d745992 x2goclient.cpp: wrap X2Go Client main function and use that. discards bc63bc3 unixhelper.{cpp,h}: implement cleanup program for process group. discards 87e6712 {unixhelper.{cpp,h},x2goclient.pro{maemo}}: add unixhelper stub. adds 517d90a {res/,x2goclient.pro}: rename .rcc files to .qrc. Fixes: #1096. adds 1ec40ee src/{onmainwindow.{cpp,h},help.cpp}: modify autostart option to support multiple autostart apps at the same time. Fixes: #1024. adds e0670e6 res/: fix up previous change, the renaming of changelog.qrc was not correctly committed. adds b8e3027 debian/changelog: add entry for the latest change. new b696c60 {unixhelper.{cpp,h},x2goclient.pro{maemo}}: add unixhelper stub. new db7500f unixhelper.{cpp,h}: implement cleanup program for process group. new 24c3278 x2goclient.cpp: wrap X2Go Client main function and use that. new 7652675 x2goclient.cpp: add fork_helper() function to start up the UNIX cleanup helper. new d3a3b98 x2goclient.cpp: use setsid() on UNIX to become session and process group leader. new affe1b9 x2goclient.cpp: add myself to copyright header. new 3088686 x2goclient.cpp: add legacy <sys/types.h> header needed for old operating systems. new e1eb767 x2goclient.cpp: fix std::edit -> std::exit typo. new b170459 unixhelper.{h,cpp}: also include <QtCore/qglobal.h> to have Q_OS_UNIX defined on UNIX-based platforms. Move guards around. new f1a1953 unixhelper.h: forgot to declare type of unix_cleanup() function. new e972a9a unixhelper.{cpp,h},x2goclient.cpp}: unixhelper should really be a (module) namespace, not a class. new f2d4ab9 unixhelper.{cpp,h}: add documentation/comments. new f4504be x2goclient.cpp: return return value of unixhelper::unix_cleanup(). new b0b5ce2 unixhelper.cpp: kill process group on error. new e9cdcda unixhelper.{cpp,h}: implement signal unblocking in unixhelper::unix_cleanup(). Update documentation. new 098baac unixhelper.cpp: port from std::signal() to sigaction(). Handle errors. new c36cdb3 x2goclient.cpp: clean up. new 5a47e79 x2goclient.cpp: don't start the UNIX cleanup helper process right after forking. new 4617765 x2goclient.cpp: fix compile problems introduced with the last commit. new 5f0a681 x2goclient.cpp: fix string comparison. new 7f1eae2 x2goclient.cpp: create new argv array on the heap instead of on the stack. new ecbfe7d unixhelper.{cpp,h}: raise sleeping time to two seconds and grace period to 10 seconds. new 220fe91 {unixhelper.{cpp,h},x2goclient.cpp}: switch main cleanup handling to parent PID polling. new cebd8e5 unixhelper.{cpp,h}: ignore SIGINT, SIGTERM, SIGPIPE, SIGQUIT, SIGUSR1 and SIGUSR2. new c729dd5 x2goclient.cpp: fix failing exec() call for the UNIX helper utility: correctly terminate arguments vector. new 64d5e1f {appdialog,configwidget,onmainwindow,unixhelper}.cpp: fix some compile warnings with GCC. Fix a few whitespace issues. new 85d445c appdialog.cpp: initialize parent in default case. Another GCC compile warning fix. new 5657256 onmainwindow.cpp: correctly use ~/.x2go/.ssh as ssh directory when starting sshd in user mode. new d58b5ac compat.{cpp,h}: new files. Implements strndup on OS X 10.6 and below. Add to x2goclient.cpp, x2goclient.pro and x2goclient.pro.maemo. new 94e366d compat.{cpp,h}: remove inline keyword, because function is not defined in header file. new 840540e compat.h: include QtCore/qglobal.h for Q_OS_... macros. new abb1e20 pulsemanager.{cpp,h}: new class for PulseAudio management. new a58ff85 x2goclient.pro{maemo}: reference new pulsemanager.{cpp,h} files. new a84d356 macbuild.sh: add new MACPORTS_PREFIX detection/variable. new 0d6d016 macbuild.sh: add new dependency_error() helper function. new 7698b89 macbuild.sh: add new lazy_canonical_path() helper function. new 8921df3 macbuild.sh: add new get_nesting_level() helper function. new b493206 macbuild.sh: add new repeat_str() helper function. new 6736cad macbuild.sh: refactor nxproxy detection to use MACPORTS_PREFIX. new 0df4cb0 macbuild.sh: add EXE_DIR and FRAMEWORKS_DIR internal variables. new e4b9cda macbuild.sh: define PulseAudio libraries and binaries to be later copied. new 443dbb2 macbuild.sh: copy PulseAudio libraries and binaries. new b1bb61c macbuild.sh: add phase output for bundling nxproxy. new 4325c9c macbuild.sh: add work-in-progress PulseAudio bundling. new 31863bb macbuild.sh: add Linux library file name scheme regex as a precaution. new 4ad8d38 macbuild.sh: directories are "executable", so the first check must explicitly include a check for the argument being not a directory. new 8a051ad macbuild.sh: add some more debugging output. new 5d580f0 macbuild.sh: remove libpulse and libpulsecore from libraries to be bundled, as something else will bundle them anyway. new f1ed5d0 macbuild.sh: use while-read-loop and find to actually recurse through directories. new a084c8d macbuild.sh: check current file name against regex, not a (now) full path. new 6063053 macbuild.sh: add the correct file path to the library bundling array. new e10f256 macbuild.sh: when actually bundling libraries, use @executable_path instead of @loader_path. new 49867fc macbuild.sh: fix echo call to also show the intermediate lib dir, not just the library file name. new 0caeaa7 macbuild.sh: also install libraries into staging area with intermediate library path. new 9c411d0 deduplicate.sh: add new, more or less Proof of Concept, and Work in Progress file deduplication script. new 83a41ff deduplicate.sh: add duplicates-to-real mapping. new 6489a99 deduplicate.sh: add missed local variable declaration. new 3f325b1 deduplicate.sh: new function for parsing otool's output and printing library dependencies if no error occurred. new d06b4a9 deduplicate.sh: non-functional: change WARNING to ERROR in error messages. new 9792e5c deduplicate.sh: add first skeleton for library dependency rewriting of deleted duplicates. new 1463e41 deduplicate.sh: correctly unset an array element. new 9c6fa0d deduplicate.sh: change range-based for loops to "${!arr[@]}" to handle "sparse" arrays correctly. new 6eccae6 deduplicate.sh: quote "${arr[@]}" correctly to not suddenly force word splitting. new 3afee63 deduplicate.sh: fix parse_otool_output: we want to return failure only iff any of the strings are present in otool's output and actually handle the failure string *ARRAY* correctly as that. new 513122a deduplicate.sh: change exit to return in parse_otool_output. new a861c5d deduplicate.sh: record crafted "library path" values in duplicates replacement to_files array. new 21a54c5 deduplicate.sh: debug parse_otool_output fiercely for the time being. new 59be605 deduplicate.sh: prevent word splitting when parsing otool's output. new 6495dc9 deduplicate.sh: switch to range-based for loop in fixup section for duplicate array walking as we need to access the same element index in the replacement array. new c17a32d deduplicate.sh: add more useful information in fixup section's error message. new 3b3b1c7 deduplicate.sh: unstub fixup section. new 1d7a5cb deduplicate.sh: parse_otool_output: jump over first matching entry, which is - hopefully - the id line. new a5d9ad0 deduplicate.sh: actually include file name in install_name_tool pseudo output. new efc5e23 deduplicate.sh: save dependency format base string as a readonly variable and use that instead of repeating a fixed string. new 78d90ac deduplicate.sh: copy lazy_canonical_path from macbuild.sh for now. new 1d4d492 deduplicate.sh: more temporary debugging output in fixup section. new 4ba528a deduplicate.sh: surprisingly, it turned out that only checking the duplicate's basename against the current dependency's basename is not good enough. new 87ab8ea deduplicate.sh: cleanup as announced in the last commit - using lazy_canonical_path. new 7a72546 deduplicate.sh: remove a bit of noisy debug output, but turn on parse_otool_output debugging. new e16ec2a deduplicate.sh: fix wrong return value capture. new 59d5671 deduplicate.sh: add WARNING to status message. new aa81eba deduplicate.sh: remove some noisy debug output. new b7439fb macbuild.sh: replace tabs with two spaces. No functional changes. new 43074a6 deduplicate.sh: replace tabs with two spaces. No functional changes. new 1024be0 macbuild.sh: merge deduplicate.sh content in. new 9ba3784 macbuild.sh: spelling fix. new 4688086 macbuild.sh: more debug messages and a whitespace change. new 0d9d6cc macbuild.sh: fix removal of base prefix in deduplication if base prefix ends in a slash. new dea9fa6 macbuild.sh: copy "special" files, so that they can be removed later on. new 70debcc macbuild.sh: rewrite ID line detection algorithm. new f695f5a pulsemanager.{cpp,h}: use name and underscore for member variables, not underscore and name. new d6190f3 pulsemanager.cpp: minor non-behavior changing fixes. new 935844e pulsemanager.{cpp,h}: reformat only. new 3bb877d pulsemanager.cpp: use initializer list for constructor. new 27391c4 pulsemanager.{cpp,h}: add pulse_version_{major,minor}_ member variables. new 8c47152 pulsemanager.cpp: reformat only. new bde71e2 pulsemanager.{cpp,h}: switch port definitions to std::uint16_t. new 0662aff pulsemanager.h: add std:: namespace selector for uint32_t version variables. new 52f559e pulsemanager.{cpp,h}: add ESD support. new eac6de5 pulsemanager.{cpp,h}: rename relaunch () to restart (). new 5003b8d pulsemanager.cpp: reformat only. new e1b5f08 pulsemanager.{cpp,h}: fixup preprocessor usage. new abf85fb pulsemanager.{cpp,h}: add server_args_, server_binary_ and server_working_dir_ class variables. new 61b817e pulsemanager.cpp: make start () wrap the "real" OS-specific start functions. new 0fd1e82 pulsemanager.{cpp,h}: new function create_client_dir (). new aafe943 pulsemanager.cpp: add Windows support to shutdown (). new 63c9b86 pulsemanager.cpp: add cleanup support to on_pulse_finished (). new 53fecb6 pulsemanager.cpp: add Windows stuff to initial env in constructor. new 455eb6c pulsemanager.{cpp,h}: add new function start_generic () to split off common functionality. new 87291f9 pulsemanager.cpp: let start_osx () use start_generic (). new b31b7fe pulsemanager.{cpp,h}: implement start_win () as part of Windows functionality. new b196479 pulsemanager.cpp: also load module-esound-protocol-tcp module. new d53600e pulsemanager.cpp: make generate_server_config () Windows-compatible. new 13e4980 pulsemanager.cpp: make generate_client_config () Windows-compatible. new 748c2c2 pulsemanager.cpp: only play startup sound if DEBUG macro is defined. new ab0b5e4 pulsemanager.cpp: make startup sound playing via slot_play_startup_sound () Windows-compatible. new 371220d pulsemanager.h: whitespace only. new 9b80479 pulsemanager.cpp: typo fix in member variable name server_working_dir_. new de314cb pulsemanager.{cpp,h}: find_port () actually returns a value, fix declaration accordingly. new 1c3081a pulsemanager.cpp: fix compile errors in find_port () by renaming the ret or port variable to search_port. new 903d651 pulsemanager.cpp: fix another compile error due to typo'd versions of generate_server_config () and generate_client_config (). new 82b71a2 pulsemanager.cpp: another typo fix: findPort -> find_port. new ae7fac9 pulsemanager.cpp: reorder member variables in initialization list. new aa02e66 pulsemanager.cpp: add "dummy" start_linux () function. new 09c28d8 pulsemanager.cpp: generate platform-dependent values for member variables server_working_dir_ and server_binary_ in constructor. new 25a146d pulsemanager.{cpp,h}: new member function fetch_pulseaudio_version () with first skeleton. new a9d3461 pulsemanager.cpp: re-initialize buffer string on each run while getting CWD on Linux. new 1ec5d07 pulsemanager.cpp: fix some error messages by removing redundant newlines. new a1a746d pulsemanager.{cpp,h}: some older PA versions used the major, minor and micro numbering scheme together with a descriptive string. new 283a410 pulsemanager.h: reformat a bit by adding newlines and moving lines in a (hopefully) logical fashion. new 7760a31 pulsemanager.cpp: add algorithm for actually extracting PA version number. new ec05b7d pulsemanager.{cpp,h}: only allow changing PA or ESD ports when server is not currently running. new 7770a56 pulsemanager.{cpp,h}: add record and playback private members, as well as getters and setters. new 703aad9 pulsemanager.cpp: reorder member variables in initializer list. new 4053676 pulsemanager.cpp: fix compile error in startup sound function. new 251ba7c pulsemanager.h: more moving around. new 53a1896 pulsemanager.cpp: use record and playback member variables. new 799ee93 pulsemanager.cpp: cleanup, don't use copy assignment operator when we just need to construct a new object. new 378ea7f macbuild.sh: PulseAudio has been updated to version 8.0. Reflect this. new 539adc7 macbuild.sh: libpulsecore.dylib also resides in the "private" pulseaudio subdirectory now, adding it to "special files workaround". new 3761c27 pulsemanager.cpp: remove config.pa while doing post-exit cleanups. new 6509901 src/pulsemanager.{cpp,h}: add get_pulse_dir () for fetching the (OS-dependent) PulseAudio config and cookie directory. new 281795f src/pulsemanager.cpp: replace hardcoded modules paths with dynamic ones depending on the detected PA version. new 469d24a src/pulsemanager.cpp: add "FIXME" debug logging (and cleanup.) new c617dd2 src/pulsemanager.cpp: backport fix for 526. new 9ab4bb2 src/pulsemanager.cpp: backport fix for 422. new 6b263c7 src/configdialog.{cpp,h}: add "no record" support for OS X (through PulseManager.) new 8c83146 src/configdialog.cpp: whitespace only. new 983b6ef src/onmainwindow.{cpp,h}: hook PulseManager in - for both OS X and Windows. new dc95778 src/mediawidget.cpp: reflect new capabilities through PulseManager. new 91050ea src/pulsemanager.h: move x2gologdebug.h inclusion into implementation file. new 74d5865 src/pulsemanager.cpp: output PA stdout/stderr via x2goDebug, not plainly to stdout. new 9383768 src/configdialog.cpp: fix compile error by removing obsolete (and now faulty) line for removed restart message. new 010e50f src/onmainwindow.cpp: fix compile errors due to misspelled function names. new 6d2a532 src/pulsemanager.cpp: let start () act as a wrapper and do nothing if the PA server is already running. new 8ff281a src/onmainwindow.cpp: fix compile error due to misuse of #ifdef. new 4e132c4 src/onmainwindow.cpp: convert QDir object to QString for further processing. new 3624c97 src/onmainwindow.cpp: make use of new PulseManager::start () behavior and always use it, no matter whether server is up already or not. new c9f6585 src/pulsemanager.cpp: fix compile error due to typo. new c568d4a src/pulsemanager.cpp: hide Windows-only code behind #ifdefs. new 760c50f src/pulsemanager.{cpp,h}: add debugging setter and private variable. new 9fc9bb1 src/pulsemanager.{cpp,h}: port to new debugging feature. new 812d681 src/onmainwindow.cpp: port to new debugging feature of PulseManager. new c876e50 src/pulsemanager.h: fix compile error due to mismatching function declaration for set_debug (). new ef54dfc res/sound: add startup.wav sound to be played back when starting the PA daemon in debug mode. new 5c62d71 src/pulsemanager.cpp: don't time out while trying to start PA or paplay. new 6e51c2c macbuild.sh: add support for copying resource files. new 2c3c8e0 res: rename "sound" to "audio". new 0ef4dc8 macbuild.sh: fix copying of resource files. new a100fe9 macbuild.sh: also add PA binaries to deduplication fixup list. new 6d25016 macbuild.sh: don't error out while executing parse_otool_output (). new 6cfe224 macbuild.sh: save return value of parse_otool_output (). new a515eb1 src/pulsemanager.cpp: fix typo in fetch_pulseaudio_version (). new fa1a401 src/pulsemanager.cpp: don't overwrite the temporary string variable for the current line with what was supposed to hold new data in fetch_pulseaudio_version (). new 5193f96 src/pulsemanager.{cpp,h}: rename on_pulse_finished () to slot_on_pulse_finished (). new 0122690 src/pulsemanager.cpp: actually only play startup sound if debugging is enabled. new d539537 src/pulsemanager.cpp: don't insert stray newline into config.pa. new fc2e700 src/pulsemanager.cpp: insert PULSE_SERVER and PULSE_COOKIE variables into environment as used by PulseManager. new 7d31462 src/pulsemanager.cpp: don't remove PA config and log file in ~/.x2go/pulse on PA shutdown if debugging has been requested. new 220ed25 src/x2goutils.{cpp,h}: add new function find_binary (). new f1f51f9 src/pulsemanager.cpp: auto-detect PA binary in $PATH and MacPorts default prefix as well on OS X. new 2cfea17 src/pulsemanager.cpp: add comments to Qt 4 code part. new da75a52 src/pulsemanager.cpp: add reminder for Linux-implementation in play_startup_sound (). new 7f077db src/x2goutils.cpp: fix compile error. new 061a04b src/pulsemanager.h: add new system_pulse_ variable to indicate that a system PA binary shall be used. new bd55b66 src/pulsemanager.cpp: correctly initialize and set system_pulse_ when required. new 5a615da src/x2goutils.{cpp,h}: add application modality parameter to show_RichText_Generic_MsgBox () and its wrappers. new 4ac44f7 src/pulsemanager.cpp: add error message boxes throughout PulseManager. new d2fa9e6 src/x2goutils.h: fix compile error due to typo. new 3344a31 debian/changelog: fix typo in function name. new e407de9 src/pulsemanager.cpp: fix compile error on Windows. new 9ff6d9c src/pulsemanager.cpp: fix startup when using the system-PA version. new a0d833c src/pulsemanager.cpp: fix startup sound playback when using the system-PA version. new 9fc7a11 src/pulsemanager.cpp: add warning message boxes where appropriate. new fe0f066 src/pulsemanager.cpp: remove extraneous newlines from debug output. new b469003 src/x2goutils.cpp: fix faulty logic in find_binary (): only reset the given path to CWD iff it's actually empty. Not the other way around. new bd02254 src/x2goutils.cpp: add some debug logging to find_binary (). new ae62fb1 nsis/x2goclient.nsi: add startup.wav to installer package. new 0b1bb28 src/: new file windows_stdint.h for Windows-compatibility when using std::(u)int*_t types. new c31613c src/pulsemanager.h: use windows_stdint.h header on Windows, cstdint otherwise. new aed3611 src/onmainwindow.cpp: short out code parts unconditionally checking for the userSshd variable. new 37dacf0 src/onmainwindow.cpp: drop obsolete pulseVersionTest variable initialization in Windows-only code. new bf37b13 src/onmainwindow.cpp: drop obsolete pulseVersionIsLegacy variable initialization in Windows-only code. new 07dd1b6 src/onmainwindow.cpp: add another pair of braces to in_addr-type variable initialization on Windows to silence compiler warning. new d845dc1 src/onmainwindow.cpp: fix compile error on Windows after moving some code around. new fda9c8f src/onmainwindow.cpp: use correct C++ universal initializer for initializing in_addr-type variable, the C-style universal zero initializer won't cut it here. new f7dd3e8 src/pulsemanager.h: include accidentally omitted wapi.h header file. new f62a804 src/pulsemanager.cpp: make PA version parsing function more generic and don't expect that a number is always terminated with a period or dash. new f175965 src/pulsemanager.cpp: make sure that wherever we interface with non-Qt functions, paths are in native form (i.e., containing empty separators, instead of the "generic" slash UNIX-style separator.) new 00d5813 src/pulsemanager.cpp: fix PA version fetching on OS X again. new 436a0c7 src/unixhelper.{cpp,h}: make argument of kill_pgroup () const. new 6d778b3 src/unixhelper.h: style and general fixes within comments. new f4ece76 src/unixhelper.{cpp,h}: split off core functionality of kill_pgroup () into a new function called real_kill_pgroup (). new 781ffcb src/unixhelper.{cpp,h}: rewrite kill_pgroup () to act as a wrapper around real_kill_pgroup (). new c2fa6e1 src/pulsemanager.cpp: remove unused variables. new 7889b31 src/unixhelper.cpp: code cleanup. new 7ebc06e src/{unixhelper.cpp,x2goclient.cpp}: fix errno usage - save before use. new 2dbe801 src/onmainwindow.cpp: document createRSAKey () because what it does is completely non-obvious. new 1f6fcbe src/onmainwindow.cpp: add support for explicitly setting the private key bit size based on type and use values (currently) regarded as secure to generateHostKey (). new 11f7f34 src/onmainwindow.{cpp,h}: rename generateHostKey () to generateKey () and add a boolean parameter with a default of false to request a public key. new 65db516 src/onmainwindow.cpp: refactor generateKey () a little bit to compact it. new c0a3150 src/onmainwindow.{cpp,h}: rewrite generateKey () function to actually also generate user keys. new 09fad0a src/onmainwindow.cpp: add more error handling to generateKey () and fix up a broken error-handling section. new 098d3c9 src/onmainwindow.cpp: fix up a few debug strings. new 5c8bae8 src/{onmainwindow.{cpp,h},configdialog.cpp}: remove userSshd variable and code related to non-user-mode-sshd setups. new 1b88392 src/onmainwindow.cpp: when starting sshd on Unix-based plattforms, raise maximum startup time to 5 seconds and break out early, if the process went into running state earlier. new 95b0bec src/onmainwindow.cpp: uppercase key type in debug output and comment string in generateKey (). new 4e19f6f src/onmainwindow.cpp: terminate sshd more correctly. new 49bffc7 src/onmainwindow.{cpp,h}: add new function check_key_type (). new 8661221 src/onmainwindow.{cpp,h}: add new function key_type_to_string (). new e4dcf7e src/onmainwindow.{cpp,h}: add new function default_size_for_key_type (). new 30d83ec src/onmainwindow.cpp: use the new functions in generateKey (). new 32e5a01 src/onmainwindow.h: move generateKey () declaration around. new 125a2f1 src/onmainwindow.{cpp,h}: reformat generateKey () only. new 105651a src/onmainwindow.{cpp,h}: move createRSAKey () around. new b0dbf3e src/onmainwindow.{cpp,h}: reformat createRSAKey () only. new 9d023fd src/onmainwindow.cpp: let startSshd () act as a wrapper and be called multiple times. new 3fbee71 src/onmainwindow.cpp: add some comments only to createRSAKey (). new 31f2deb src/onmainwindow.{cpp,h}: rename createRSAKey () to the more-appropriate name createKeyBundle (). This update added new revisions after undoing existing revisions. That is to say, some revisions that were in the old version of the branch are not in the new version. This situation occurs when a user --force pushes a change and generates a repository containing something like this: * -- * -- B -- O -- O -- O (c4004a2) \ N -- N -- N refs/heads/bugfix/osx (31f2deb) You should already have received notification emails for all of the O revisions, and so the following emails describe only the N revisions from the common base, B. Any revisions marked "omits" are not gone; other references still refer to them. Any revisions marked "discards" are gone forever. The 239 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "adds" were already present in the repository and have only been added to this reference. Summary of changes: debian/changelog | 18 ++++++++ res/{changelog.rcc => changelog.qrc} | 0 res/{git.rcc => git.qrc} | 0 res/{resources.rcc => resources.qrc} | 0 src/help.cpp | 2 +- src/onmainwindow.cpp | 80 +++++++++++++++++++++++----------- src/onmainwindow.h | 4 +- x2goclient.pro | 6 +-- 8 files changed, 79 insertions(+), 31 deletions(-) rename res/{changelog.rcc => changelog.qrc} (100%) rename res/{git.rcc => git.qrc} (100%) rename res/{resources.rcc => resources.qrc} (100%) -- Alioth's /srv/git/code.x2go.org/x2goclient.git//..//_hooks_/post-receive-email on /srv/git/code.x2go.org/x2goclient.git