This is an automated email from the git hooks/post-receive script. x2go pushed a change to branch bugfix/osx in repository x2goclient. discards 15461fd src/unixhelper.{cpp,h}: rewrite kill_pgroup () to act as a wrapper around real_kill_pgroup (). discards d643979 src/unixhelper.{cpp,h}: split off core functionality of kill_pgroup () into a new function called real_kill_pgroup (). discards 40b9683 src/unixhelper.h: style and general fixes within comments. discards f1953cb src/unixhelper.{cpp,h}: make argument of kill_pgroup () const. discards 7281b93 src/pulsemanager.cpp: fix PA version fetching on OS X again. discards c7e6a9e src/pulsemanager.cpp: make sure that wherever we interface with non-Qt functions, paths are in native form (i.e., containing empty separators, instead of the "generic" slash UNIX-style separator.) discards 7e1f4d0 src/pulsemanager.cpp: make PA version parsing function more generic and don't expect that a number is always terminated with a period or dash. discards 842698b src/pulsemanager.h: include accidentally omitted wapi.h header file. discards 9947f8a src/onmainwindow.cpp: use correct C++ universal initializer for initializing in_addr-type variable, the C-style universal zero initializer won't cut it here. discards 4a90cc2 src/onmainwindow.cpp: fix compile error on Windows after moving some code around. discards 3c2dee0 src/onmainwindow.cpp: add another pair of braces to in_addr-type variable initialization on Windows to silence compiler warning. discards 3f43162 src/onmainwindow.cpp: drop obsolete pulseVersionIsLegacy variable initialization in Windows-only code. discards 6b884d2 src/onmainwindow.cpp: drop obsolete pulseVersionTest variable initialization in Windows-only code. discards c5d37b0 src/onmainwindow.cpp: short out code parts unconditionally checking for the userSshd variable. discards 0bf4d26 src/pulsemanager.h: use windows_stdint.h header on Windows, cstdint otherwise. discards 870d370 src/: new file windows_stdint.h for Windows-compatibility when using std::(u)int*_t types. discards bf08f56 nsis/x2goclient.nsi: add startup.wav to installer package. discards 72821da src/x2goutils.cpp: add some debug logging to find_binary (). discards a03a4e2 src/x2goutils.cpp: fix faulty logic in find_binary (): only reset the given path to CWD iff it's actually empty. Not the other way around. discards 3259b65 src/pulsemanager.cpp: remove extraneous newlines from debug output. discards 32f408e src/pulsemanager.cpp: add warning message boxes where appropriate. discards cd47912 src/pulsemanager.cpp: fix startup sound playback when using the system-PA version. discards e3fb537 src/pulsemanager.cpp: fix startup when using the system-PA version. discards 7e647d6 src/pulsemanager.cpp: fix compile error on Windows. discards d75b812 debian/changelog: fix typo in function name. discards 0f52248 src/x2goutils.h: fix compile error due to typo. discards f2466ca src/pulsemanager.cpp: add error message boxes throughout PulseManager. discards 95f0bf1 src/x2goutils.{cpp,h}: add application modality parameter to show_RichText_Generic_MsgBox () and its wrappers. discards 439c119 src/pulsemanager.cpp: correctly initialize and set system_pulse_ when required. discards f801dac src/pulsemanager.h: add new system_pulse_ variable to indicate that a system PA binary shall be used. discards ab12f57 src/x2goutils.cpp: fix compile error. discards 96acbc0 src/pulsemanager.cpp: add remainder for Linux-implementation in play_startup_sound (). discards b5567ef src/pulsemanager.cpp: add comments to Qt 4 code part. discards 51bd3bb src/pulsemanager.cpp: auto-detect PA binary in $PATH and MacPorts default prefix as well on OS X. discards c3a30e4 src/x2goutils.{cpp,h}: add new function find_binary (). discards f339035 src/pulsemanager.cpp: don't remove PA config and log file in ~/.x2go/pulse on PA shutdown if debugging has been requested. discards 6544f5e src/pulsemanager.cpp: insert PULSE_SERVER and PULSE_COOKIE variables into environment as used by PulseManager. discards 55a411f src/pulsemanager.cpp: don't insert stray newline into config.pa. discards 7fdb087 src/pulsemanager.cpp: actually only play startup sound if debugging is enabled. discards 437b7f7 src/pulsemanager.{cpp,h}: rename on_pulse_finished () to slot_on_pulse_finished (). discards 75b0683 src/pulsemanager.cpp: don't overwrite the temporary string variable for the current line with what was supposed to hold new data in fetch_pulseaudio_version (). discards 2466da3 src/pulsemanager.cpp: fix typo in fetch_pulseaudio_version (). discards 11045e3 macbuild.sh: save return value of parse_otool_output (). discards 80d47af macbuild.sh: don't error out while executing parse_otool_output (). discards fc38701 macbuild.sh: also add PA binaries to deduplication fixup list. discards 7849eab macbuild.sh: fix copying of resource files. discards a70ece8 res: rename "sound" to "audio". discards bd74f81 macbuild.sh: add support for copying resource files. discards 522cda7 src/pulsemanager.cpp: don't time out while trying to start PA or paplay. discards a1cb27b res/sound: add startup.wav sound to be played back when starting the PA daemon in debug mode. discards 2abaa9b src/pulsemanager.h: fix compile error due to mismatching function declaration for set_debug (). discards 6ad9934 src/onmainwindow.cpp: port to new debugging feature of PulseManager. discards 7c38212 src/pulsemanager.{cpp,h}: port to new debugging feature. discards ea7a944 src/pulsemanager.{cpp,h}: add debugging setter and private variable. discards 4090ca0 src/pulsemanager.cpp: hide Windows-only code behind #ifdefs. discards d80dfe1 src/pulsemanager.cpp: fix compile error due to typo. discards e9534d1 src/onmainwindow.cpp: make use of new PulseManager::start () behavior and always use it, no matter whether server is up already or not. discards 3c9001e src/onmainwindow.cpp: convert QDir object to QString for further processing. discards 7ed0890 src/onmainwindow.cpp: fix compile error due to misuse of #ifdef. discards 02abc66 src/pulsemanager.cpp: let start () act as a wrapper and do nothing if the PA server is already running. discards e609af5 src/onmainwindow.cpp: fix compile errors due to misspelled function names. discards 93ee433 src/configdialog.cpp: fix compile error by removing obsolete (and now faulty) line for removed restart message. discards 6bdbf73 src/pulsemanager.cpp: output PA stdout/stderr via x2goDebug, not plainly to stdout. discards a804a09 src/pulsemanager.h: move x2gologdebug.h inclusion into implementation file. discards 228458a src/mediawidget.cpp: reflect new capabilities through PulseManager. discards c46c1eb src/onmainwindow.{cpp,h}: hook PulseManager in - for both OS X and Windows. discards f8f2d2d src/configdialog.cpp: whitespace only. discards 45375be src/configdialog.{cpp,h}: add "no record" support for OS X (through PulseManager.) discards 972a263 src/pulsemanager.cpp: backport fix for 422. discards 666d68c src/pulsemanager.cpp: backport fix for 526. discards cfdaf1a src/pulsemanager.cpp: add "FIXME" debug logging (and cleanup.) discards 8931fac src/pulsemanager.cpp: replace hardcoded modules paths with dynamic ones depending on the detected PA version. discards 13f5ff5 src/pulsemanager.{cpp,h}: add get_pulse_dir () for fetching the (OS-dependent) PulseAudio config and cookie directory. discards 29e0c58 pulsemanager.cpp: remove config.pa while doing post-exit cleanups. discards 1f61e65 macbuild.sh: libpulsecore.dylib also resides in the "private" pulseaudio subdirectory now, adding it to "special files workaround". discards 9966e05 macbuild.sh: PulseAudio has been updated to version 8.0. Reflect this. discards 2e30e93 pulsemanager.cpp: cleanup, don't use copy assignment operator when we just need to construct a new object. discards 1a6f070 pulsemanager.cpp: use record and playback member variables. discards 39041a2 pulsemanager.h: more moving around. discards 22c0df0 pulsemanager.cpp: fix compile error in startup sound function. discards 7180143 pulsemanager.cpp: reorder member variables in initializer list. discards f00abd5 pulsemanager.{cpp,h}: add record and playback private members, as well as getters and setters. discards 7b261a0 pulsemanager.{cpp,h}: only allow changing PA or ESD ports when server is not currently running. discards 2ab6c66 pulsemanager.cpp: add algorithm for actually extracting PA version number. discards fbc9b3f pulsemanager.h: reformat a bit by adding newlines and moving lines in a (hopefully) logical fashion. discards 78f9c07 pulsemanager.{cpp,h}: some older PA versions used the major, minor and micro numbering scheme together with a descriptive string. discards 191160f pulsemanager.cpp: fix some error messages by removing redundant newlines. discards 9eea515 pulsemanager.cpp: re-initialize buffer string on each run while getting CWD on Linux. discards 98cc221 pulsemanager.{cpp,h}: new member function fetch_pulseaudio_version () with first skeleton. discards 9222b3c pulsemanager.cpp: generate platform-dependent values for member variables server_working_dir_ and server_binary_ in constructor. discards c9ac232 pulsemanager.cpp: add "dummy" start_linux () function. discards b7b0606 pulsemanager.cpp: reorder member variables in initialization list. discards 90a577a pulsemanager.cpp: another typo fix: findPort -> find_port. discards bcdf545 pulsemanager.cpp: fix another compile error due to typo'd versions of generate_server_config () and generate_client_config (). discards d1885e3 pulsemanager.cpp: fix compile errors in find_port () by renaming the ret or port variable to search_port. discards 86c60fa pulsemanager.{cpp,h}: find_port () actually returns a value, fix declaration accordingly. discards 2b1822b pulsemanager.cpp: typo fix in member variable name server_working_dir_. discards 888f272 pulsemanager.h: whitespace only. discards ca213bc pulsemanager.cpp: make startup sound playing via slot_play_startup_sound () Windows-compatible. discards e35e834 pulsemanager.cpp: only play startup sound if DEBUG macro is defined. discards 03d58b0 pulsemanager.cpp: make generate_client_config () Windows-compatible. discards c462b36 pulsemanager.cpp: make generate_server_config () Windows-compatible. discards c2fa743 pulsemanager.cpp: also load module-esound-protocol-tcp module. discards 69bda96 pulsemanager.{cpp,h}: implement start_win () as part of Windows functionality. discards f508d10 pulsemanager.cpp: let start_osx () use start_generic (). discards 0368cd6 pulsemanager.{cpp,h}: add new function start_generic () to split off common functionality. discards 84faad2 pulsemanager.cpp: add Windows stuff to initial env in constructor. discards 7b00060 pulsemanager.cpp: add cleanup support to on_pulse_finished (). discards ac1ea59 pulsemanager.cpp: add Windows support to shutdown (). discards 8d4d730 pulsemanager.{cpp,h}: new function create_client_dir (). discards a174986 pulsemanager.cpp: make start () wrap the "real" OS-specific start functions. discards 05b73f2 pulsemanager.{cpp,h}: add server_args_, server_binary_ and server_working_dir_ class variables. discards da4b0c1 pulsemanager.{cpp,h}: fixup preprocessor usage. discards c6a6910 pulsemanager.cpp: reformat only. discards 797a559 pulsemanager.{cpp,h}: rename relaunch () to restart (). discards b393081 pulsemanager.{cpp,h}: add ESD support. discards 40a5673 pulsemanager.h: add std:: namespace selector for uint32_t version variables. discards 1c9d539 pulsemanager.{cpp,h}: switch port definitions to std::uint16_t. discards e6882ed pulsemanager.cpp: reformat only. discards 3a6dd5f pulsemanager.{cpp,h}: add pulse_version_{major,minor}_ member variables. discards 495067b pulsemanager.cpp: use initializer list for constructor. discards d536943 pulsemanager.{cpp,h}: reformat only. discards c468dba pulsemanager.cpp: minor non-behavior changing fixes. discards b27127e pulsemanager.{cpp,h}: use name and underscore for member variables, not underscore and name. discards 70e23bd macbuild.sh: rewrite ID line detection algorithm. discards 68693f1 macbuild.sh: copy "special" files, so that they can be removed later on. discards 8a657b3 macbuild.sh: fix removal of base prefix in deduplication if base prefix ends in a slash. discards 5a8bd1c macbuild.sh: more debug messages and a whitespace change. discards c594425 macbuild.sh: spelling fix. discards 1db1dcd macbuild.sh: merge deduplicate.sh content in. discards d736a5d deduplicate.sh: replace tabs with two spaces. No functional changes. discards deca5f1 macbuild.sh: replace tabs with two spaces. No functional changes. discards 8669077 deduplicate.sh: remove some noisy debug output. discards fe7e9c4 deduplicate.sh: add WARNING to status message. discards a173655 deduplicate.sh: fix wrong return value capture. discards 6d90f69 deduplicate.sh: remove a bit of noisy debug output, but turn on parse_otool_output debugging. discards e35fd3a deduplicate.sh: cleanup as announced in the last commit - using lazy_canonical_path. discards 951333a deduplicate.sh: surprisingly, it turned out that only checking the duplicate's basename against the current dependency's basename is not good enough. discards 5f0f643 deduplicate.sh: more temporary debugging output in fixup section. discards c2405dd deduplicate.sh: copy lazy_canonical_path from macbuild.sh for now. discards 3e30d8d deduplicate.sh: save dependency format base string as a readonly variable and use that instead of repeating a fixed string. discards 0b037b9 deduplicate.sh: actually include file name in install_name_tool pseudo output. discards ad04f60 deduplicate.sh: parse_otool_output: jump over first matching entry, which is - hopefully - the id line. discards 92aa7c4 deduplicate.sh: unstub fixup section. discards f364d4f deduplicate.sh: add more useful information in fixup section's error message. discards 57d2c61 deduplicate.sh: switch to range-based for loop in fixup section for duplicate array walking as we need to access the same element index in the replacement array. discards a482127 deduplicate.sh: prevent word splitting when parsing otool's output. discards 2feb4bd deduplicate.sh: debug parse_otool_output fiercely for the time being. discards 31fd918 deduplicate.sh: record crafted "library path" values in duplicates replacement to_files array. discards 0a7bb5a deduplicate.sh: change exit to return in parse_otool_output. discards 9f67dc0 deduplicate.sh: fix parse_otool_output: we want to return failure only iff any of the strings are present in otool's output and actually handle the failure string *ARRAY* correctly as that. discards 40303f5 deduplicate.sh: quote "${arr[@]}" correctly to not suddenly force word splitting. discards 930bc8d deduplicate.sh: change range-based for loops to "${!arr[@]}" to handle "sparse" arrays correctly. discards 2faf8f5 deduplicate.sh: correctly unset an array element. discards ad0350c deduplicate.sh: add first skeleton for library dependency rewriting of deleted duplicates. discards b2fc450 deduplicate.sh: non-functional: change WARNING to ERROR in error messages. discards a4e09a4 deduplicate.sh: new function for parsing otool's output and printing library dependencies if no error occurred. discards 3c00c48 deduplicate.sh: add missed local variable declaration. discards 287e702 deduplicate.sh: add duplicates-to-real mapping. discards fe6cdfd deduplicate.sh: add new, more or less Proof of Concept, and Work in Progress file deduplication script. discards cbc1a84 macbuild.sh: also install libraries into staging area with intermediate library path. discards 1388a8a macbuild.sh: fix echo call to also show the intermediate lib dir, not just the library file name. discards ac652e8 macbuild.sh: when actually bundling libraries, use @executable_path instead of @loader_path. discards f665486 macbuild.sh: add the correct file path to the library bundling array. discards d79382f macbuild.sh: check current file name against regex, not a (now) full path. discards ec15009 macbuild.sh: use while-read-loop and find to actually recurse through directories. discards a0a27de macbuild.sh: remove libpulse and libpulsecore from libraries to be bundled, as something else will bundle them anyway. discards dd6c200 macbuild.sh: add some more debugging output. discards dcb4078 macbuild.sh: directories are "executable", so the first check must explicitly include a check for the argument being not a directory. discards 03bfcde macbuild.sh: add Linux library file name scheme regex as a precaution. discards 8a45bb2 macbuild.sh: add work-in-progress PulseAudio bundling. discards 684a0c4 macbuild.sh: add phase output for bundling nxproxy. discards 764a950 macbuild.sh: copy PulseAudio libraries and binaries. discards b00b033 macbuild.sh: define PulseAudio libraries and binaries to be later copied. discards e020d45 macbuild.sh: add EXE_DIR and FRAMEWORKS_DIR internal variables. discards 444620d macbuild.sh: refactor nxproxy detection to use MACPORTS_PREFIX. discards 2aa7f9a macbuild.sh: add new repeat_str() helper function. discards b65c126 macbuild.sh: add new get_nesting_level() helper function. discards 95d905e macbuild.sh: add new lazy_canonical_path() helper function. discards 1096311 macbuild.sh: add new dependency_error() helper function. discards cb3e931 macbuild.sh: add new MACPORTS_PREFIX detection/variable. discards ea0e4a0 x2goclient.pro{maemo}: reference new pulsemanager.{cpp,h} files. discards 80acfd8 pulsemanager.{cpp,h}: new class for PulseAudio management. discards f49ebb3 compat.h: include QtCore/qglobal.h for Q_OS_... macros. discards f03ff7a compat.{cpp,h}: remove inline keyword, because function is not defined in header file. discards e3f0a8b compat.{cpp,h}: new files. Implements strndup on OS X 10.6 and below. Add to x2goclient.cpp, x2goclient.pro and x2goclient.pro.maemo. discards fe0c476 onmainwindow.cpp: correctly use ~/.x2go/.ssh as ssh directory when starting sshd in user mode. discards 82b9d2d appdialog.cpp: initialize parent in default case. Another GCC compile warning fix. discards 8e204d6 {appdialog,configwidget,onmainwindow,unixhelper}.cpp: fix some compile warnings with GCC. Fix a few whitespace issues. discards b832b8c x2goclient.cpp: fix failing exec() call for the UNIX helper utility: correctly terminate arguments vector. discards 2fcb598 unixhelper.{cpp,h}: ignore SIGINT, SIGTERM, SIGPIPE, SIGQUIT, SIGUSR1 and SIGUSR2. discards 0674673 {unixhelper.{cpp,h},x2goclient.cpp}: switch main cleanup handling to parent PID polling. discards 95ac78d unixhelper.{cpp,h}: raise sleeping time to two seconds and grace period to 10 seconds. discards a603bfe x2goclient.cpp: create new argv array on the heap instead of on the stack. discards ad1bf67 x2goclient.cpp: fix string comparison. discards d920e57 x2goclient.cpp: fix compile problems introduced with the last commit. discards 86ccfb7 x2goclient.cpp: don't start the UNIX cleanup helper process right after forking. discards b6995c4 x2goclient.cpp: clean up. discards e846bac unixhelper.cpp: port from std::signal() to sigaction(). Handle errors. discards 27b6827 unixhelper.{cpp,h}: implement signal unblocking in unixhelper::unix_cleanup(). Update documentation. discards e6cd5d3 unixhelper.cpp: kill process group on error. discards c287209 x2goclient.cpp: return return value of unixhelper::unix_cleanup(). discards 4e519c1 unixhelper.{cpp,h}: add documentation/comments. discards 2ec215d unixhelper.{cpp,h},x2goclient.cpp}: unixhelper should really be a (module) namespace, not a class. discards 303029c unixhelper.h: forgot to declare type of unix_cleanup() function. discards 380b6d5 unixhelper.{h,cpp}: also include <QtCore/qglobal.h> to have Q_OS_UNIX defined on UNIX-based platforms. Move guards around. discards 4e262b0 x2goclient.cpp: fix std::edit -> std::exit typo. discards fa2a756 x2goclient.cpp: add legacy <sys/types.h> header needed for old operating systems. discards 90a8c7a x2goclient.cpp: add myself to copyright header. discards 9552988 x2goclient.cpp: use setsid() on UNIX to become session and process group leader. discards 0bd016f x2goclient.cpp: add fork_helper() function to start up the UNIX cleanup helper. discards 761853d x2goclient.cpp: wrap X2Go Client main function and use that. discards 14ffb2f unixhelper.{cpp,h}: implement cleanup program for process group. discards 4d6c400 {unixhelper.{cpp,h},x2goclient.pro{maemo}}: add unixhelper stub. adds 35842b7 Windows: Update PuTTY from 0.66 to 0.67 adds 308995c Win32-OpenSSL: 1.0.1q -> 1.0.1t adds 742205c src/onmainwindow.cpp: work around changed SSH host key locations in OS X 10.11+. Fixes: #1079. new 803dac0 {unixhelper.{cpp,h},x2goclient.pro{maemo}}: add unixhelper stub. new dd90512 unixhelper.{cpp,h}: implement cleanup program for process group. new 0d27e9c x2goclient.cpp: wrap X2Go Client main function and use that. new 07c2e04 x2goclient.cpp: add fork_helper() function to start up the UNIX cleanup helper. new 40bd0c9 x2goclient.cpp: use setsid() on UNIX to become session and process group leader. new cea7e67 x2goclient.cpp: add myself to copyright header. new 6c33066 x2goclient.cpp: add legacy <sys/types.h> header needed for old operating systems. new 7e94995 x2goclient.cpp: fix std::edit -> std::exit typo. new 6a19d24 unixhelper.{h,cpp}: also include <QtCore/qglobal.h> to have Q_OS_UNIX defined on UNIX-based platforms. Move guards around. new b853308 unixhelper.h: forgot to declare type of unix_cleanup() function. new d0e4e07 unixhelper.{cpp,h},x2goclient.cpp}: unixhelper should really be a (module) namespace, not a class. new 6f948e3 unixhelper.{cpp,h}: add documentation/comments. new d1dbc18 x2goclient.cpp: return return value of unixhelper::unix_cleanup(). new ba2777e unixhelper.cpp: kill process group on error. new 89ecda0 unixhelper.{cpp,h}: implement signal unblocking in unixhelper::unix_cleanup(). Update documentation. new d6b568f unixhelper.cpp: port from std::signal() to sigaction(). Handle errors. new f3b5a65 x2goclient.cpp: clean up. new 9a760c4 x2goclient.cpp: don't start the UNIX cleanup helper process right after forking. new 85ee744 x2goclient.cpp: fix compile problems introduced with the last commit. new e3154e8 x2goclient.cpp: fix string comparison. new 60661ce x2goclient.cpp: create new argv array on the heap instead of on the stack. new e6f6c9f unixhelper.{cpp,h}: raise sleeping time to two seconds and grace period to 10 seconds. new 30227f8 {unixhelper.{cpp,h},x2goclient.cpp}: switch main cleanup handling to parent PID polling. new 3775edb unixhelper.{cpp,h}: ignore SIGINT, SIGTERM, SIGPIPE, SIGQUIT, SIGUSR1 and SIGUSR2. new 390bbd4 x2goclient.cpp: fix failing exec() call for the UNIX helper utility: correctly terminate arguments vector. new c41a896 {appdialog,configwidget,onmainwindow,unixhelper}.cpp: fix some compile warnings with GCC. Fix a few whitespace issues. new a9d100d appdialog.cpp: initialize parent in default case. Another GCC compile warning fix. new 69e0c0f onmainwindow.cpp: correctly use ~/.x2go/.ssh as ssh directory when starting sshd in user mode. new 5f97cd6 compat.{cpp,h}: new files. Implements strndup on OS X 10.6 and below. Add to x2goclient.cpp, x2goclient.pro and x2goclient.pro.maemo. new e80fd49 compat.{cpp,h}: remove inline keyword, because function is not defined in header file. new 9bfcda8 compat.h: include QtCore/qglobal.h for Q_OS_... macros. new fc660d7 pulsemanager.{cpp,h}: new class for PulseAudio management. new 3966aa3 x2goclient.pro{maemo}: reference new pulsemanager.{cpp,h} files. new 1c8fc1a macbuild.sh: add new MACPORTS_PREFIX detection/variable. new f8a4f7f macbuild.sh: add new dependency_error() helper function. new 77470c3 macbuild.sh: add new lazy_canonical_path() helper function. new e617f5f macbuild.sh: add new get_nesting_level() helper function. new 4ee69e0 macbuild.sh: add new repeat_str() helper function. new bbf966d macbuild.sh: refactor nxproxy detection to use MACPORTS_PREFIX. new f2ee9a4 macbuild.sh: add EXE_DIR and FRAMEWORKS_DIR internal variables. new 280f98a macbuild.sh: define PulseAudio libraries and binaries to be later copied. new c200d19 macbuild.sh: copy PulseAudio libraries and binaries. new 44d6738 macbuild.sh: add phase output for bundling nxproxy. new d86e2e1 macbuild.sh: add work-in-progress PulseAudio bundling. new 93fd51a macbuild.sh: add Linux library file name scheme regex as a precaution. new cacf622 macbuild.sh: directories are "executable", so the first check must explicitly include a check for the argument being not a directory. new 4c29d45 macbuild.sh: add some more debugging output. new 09d0700 macbuild.sh: remove libpulse and libpulsecore from libraries to be bundled, as something else will bundle them anyway. new 480b647 macbuild.sh: use while-read-loop and find to actually recurse through directories. new d2ee38e macbuild.sh: check current file name against regex, not a (now) full path. new d60f60b macbuild.sh: add the correct file path to the library bundling array. new 1669924 macbuild.sh: when actually bundling libraries, use @executable_path instead of @loader_path. new 3ddccff macbuild.sh: fix echo call to also show the intermediate lib dir, not just the library file name. new e0f1b84 macbuild.sh: also install libraries into staging area with intermediate library path. new 6921981 deduplicate.sh: add new, more or less Proof of Concept, and Work in Progress file deduplication script. new 27ec7cb deduplicate.sh: add duplicates-to-real mapping. new febff81 deduplicate.sh: add missed local variable declaration. new 19cc818 deduplicate.sh: new function for parsing otool's output and printing library dependencies if no error occurred. new e0158f0 deduplicate.sh: non-functional: change WARNING to ERROR in error messages. new c0d1edd deduplicate.sh: add first skeleton for library dependency rewriting of deleted duplicates. new 66d0815 deduplicate.sh: correctly unset an array element. new c4ea4cb deduplicate.sh: change range-based for loops to "${!arr[@]}" to handle "sparse" arrays correctly. new 3c3d2f4 deduplicate.sh: quote "${arr[@]}" correctly to not suddenly force word splitting. new e776381 deduplicate.sh: fix parse_otool_output: we want to return failure only iff any of the strings are present in otool's output and actually handle the failure string *ARRAY* correctly as that. new 84cc05e deduplicate.sh: change exit to return in parse_otool_output. new 1a74212 deduplicate.sh: record crafted "library path" values in duplicates replacement to_files array. new 29b8641 deduplicate.sh: debug parse_otool_output fiercely for the time being. new 8f5f3c2 deduplicate.sh: prevent word splitting when parsing otool's output. new a8617ed deduplicate.sh: switch to range-based for loop in fixup section for duplicate array walking as we need to access the same element index in the replacement array. new 5b81608 deduplicate.sh: add more useful information in fixup section's error message. new d98590f deduplicate.sh: unstub fixup section. new 23841d4 deduplicate.sh: parse_otool_output: jump over first matching entry, which is - hopefully - the id line. new fa493c7 deduplicate.sh: actually include file name in install_name_tool pseudo output. new 55a4849 deduplicate.sh: save dependency format base string as a readonly variable and use that instead of repeating a fixed string. new d9bf7f1 deduplicate.sh: copy lazy_canonical_path from macbuild.sh for now. new 255dea1 deduplicate.sh: more temporary debugging output in fixup section. new de3144f deduplicate.sh: surprisingly, it turned out that only checking the duplicate's basename against the current dependency's basename is not good enough. new d740b62 deduplicate.sh: cleanup as announced in the last commit - using lazy_canonical_path. new 3df035d deduplicate.sh: remove a bit of noisy debug output, but turn on parse_otool_output debugging. new cef21d0 deduplicate.sh: fix wrong return value capture. new 41ce988 deduplicate.sh: add WARNING to status message. new 9ad0bcc deduplicate.sh: remove some noisy debug output. new 9db0bbb macbuild.sh: replace tabs with two spaces. No functional changes. new 66a9aae deduplicate.sh: replace tabs with two spaces. No functional changes. new 84de6d9 macbuild.sh: merge deduplicate.sh content in. new 7ce769e macbuild.sh: spelling fix. new c856afb macbuild.sh: more debug messages and a whitespace change. new 0d1a609 macbuild.sh: fix removal of base prefix in deduplication if base prefix ends in a slash. new 665f0b7 macbuild.sh: copy "special" files, so that they can be removed later on. new 8e7a243 macbuild.sh: rewrite ID line detection algorithm. new 7adefb5 pulsemanager.{cpp,h}: use name and underscore for member variables, not underscore and name. new b0165ca pulsemanager.cpp: minor non-behavior changing fixes. new dbe97b0 pulsemanager.{cpp,h}: reformat only. new 5a7b3a1 pulsemanager.cpp: use initializer list for constructor. new 9065aa2 pulsemanager.{cpp,h}: add pulse_version_{major,minor}_ member variables. new 0dea841 pulsemanager.cpp: reformat only. new 489c8dc pulsemanager.{cpp,h}: switch port definitions to std::uint16_t. new 97197c0 pulsemanager.h: add std:: namespace selector for uint32_t version variables. new 2f4a881 pulsemanager.{cpp,h}: add ESD support. new 4abe45a pulsemanager.{cpp,h}: rename relaunch () to restart (). new 9e3d413 pulsemanager.cpp: reformat only. new 268edde pulsemanager.{cpp,h}: fixup preprocessor usage. new b0aefa6 pulsemanager.{cpp,h}: add server_args_, server_binary_ and server_working_dir_ class variables. new 3843e37 pulsemanager.cpp: make start () wrap the "real" OS-specific start functions. new 2728411 pulsemanager.{cpp,h}: new function create_client_dir (). new ce59c8a pulsemanager.cpp: add Windows support to shutdown (). new 27024c6 pulsemanager.cpp: add cleanup support to on_pulse_finished (). new 3a4a1d0 pulsemanager.cpp: add Windows stuff to initial env in constructor. new 39d004a pulsemanager.{cpp,h}: add new function start_generic () to split off common functionality. new 8b087bc pulsemanager.cpp: let start_osx () use start_generic (). new a9ffc64 pulsemanager.{cpp,h}: implement start_win () as part of Windows functionality. new 3ab01bc pulsemanager.cpp: also load module-esound-protocol-tcp module. new 88dae8a pulsemanager.cpp: make generate_server_config () Windows-compatible. new 9f47f59 pulsemanager.cpp: make generate_client_config () Windows-compatible. new dc1ec7c pulsemanager.cpp: only play startup sound if DEBUG macro is defined. new fd8198f pulsemanager.cpp: make startup sound playing via slot_play_startup_sound () Windows-compatible. new e0d607a pulsemanager.h: whitespace only. new ade3ff8 pulsemanager.cpp: typo fix in member variable name server_working_dir_. new 38b0fc9 pulsemanager.{cpp,h}: find_port () actually returns a value, fix declaration accordingly. new 7eb47fd pulsemanager.cpp: fix compile errors in find_port () by renaming the ret or port variable to search_port. new f357c0a pulsemanager.cpp: fix another compile error due to typo'd versions of generate_server_config () and generate_client_config (). new 5021846 pulsemanager.cpp: another typo fix: findPort -> find_port. new 8be004c pulsemanager.cpp: reorder member variables in initialization list. new fd9f8e8 pulsemanager.cpp: add "dummy" start_linux () function. new bfd0a6f pulsemanager.cpp: generate platform-dependent values for member variables server_working_dir_ and server_binary_ in constructor. new 6d5248d pulsemanager.{cpp,h}: new member function fetch_pulseaudio_version () with first skeleton. new 1842f97 pulsemanager.cpp: re-initialize buffer string on each run while getting CWD on Linux. new b081eb5 pulsemanager.cpp: fix some error messages by removing redundant newlines. new c11fc04 pulsemanager.{cpp,h}: some older PA versions used the major, minor and micro numbering scheme together with a descriptive string. new 611e3df pulsemanager.h: reformat a bit by adding newlines and moving lines in a (hopefully) logical fashion. new 1428a31 pulsemanager.cpp: add algorithm for actually extracting PA version number. new 55de580 pulsemanager.{cpp,h}: only allow changing PA or ESD ports when server is not currently running. new 4d69257 pulsemanager.{cpp,h}: add record and playback private members, as well as getters and setters. new 744b91a pulsemanager.cpp: reorder member variables in initializer list. new 2875eae pulsemanager.cpp: fix compile error in startup sound function. new 09ad592 pulsemanager.h: more moving around. new 38ce895 pulsemanager.cpp: use record and playback member variables. new 7edd2dd pulsemanager.cpp: cleanup, don't use copy assignment operator when we just need to construct a new object. new f76192e macbuild.sh: PulseAudio has been updated to version 8.0. Reflect this. new faa07ee macbuild.sh: libpulsecore.dylib also resides in the "private" pulseaudio subdirectory now, adding it to "special files workaround". new 9825ec6 pulsemanager.cpp: remove config.pa while doing post-exit cleanups. new 3daf937 src/pulsemanager.{cpp,h}: add get_pulse_dir () for fetching the (OS-dependent) PulseAudio config and cookie directory. new a757fd2 src/pulsemanager.cpp: replace hardcoded modules paths with dynamic ones depending on the detected PA version. new ed550de src/pulsemanager.cpp: add "FIXME" debug logging (and cleanup.) new 3ad2e9f src/pulsemanager.cpp: backport fix for 526. new b396272 src/pulsemanager.cpp: backport fix for 422. new e570ed9 src/configdialog.{cpp,h}: add "no record" support for OS X (through PulseManager.) new 6b72065 src/configdialog.cpp: whitespace only. new 6b4e636 src/onmainwindow.{cpp,h}: hook PulseManager in - for both OS X and Windows. new adc61b7 src/mediawidget.cpp: reflect new capabilities through PulseManager. new 9668407 src/pulsemanager.h: move x2gologdebug.h inclusion into implementation file. new b6c8d4c src/pulsemanager.cpp: output PA stdout/stderr via x2goDebug, not plainly to stdout. new c866e91 src/configdialog.cpp: fix compile error by removing obsolete (and now faulty) line for removed restart message. new d26d982 src/onmainwindow.cpp: fix compile errors due to misspelled function names. new 97b384c src/pulsemanager.cpp: let start () act as a wrapper and do nothing if the PA server is already running. new 77cc7bf src/onmainwindow.cpp: fix compile error due to misuse of #ifdef. new 1e338d4 src/onmainwindow.cpp: convert QDir object to QString for further processing. new 701f3fb src/onmainwindow.cpp: make use of new PulseManager::start () behavior and always use it, no matter whether server is up already or not. new fe76c28 src/pulsemanager.cpp: fix compile error due to typo. new b27e474 src/pulsemanager.cpp: hide Windows-only code behind #ifdefs. new 1fb021a src/pulsemanager.{cpp,h}: add debugging setter and private variable. new 91a5436 src/pulsemanager.{cpp,h}: port to new debugging feature. new c1b5a66 src/onmainwindow.cpp: port to new debugging feature of PulseManager. new bb03915 src/pulsemanager.h: fix compile error due to mismatching function declaration for set_debug (). new f929b52 res/sound: add startup.wav sound to be played back when starting the PA daemon in debug mode. new b03cf75 src/pulsemanager.cpp: don't time out while trying to start PA or paplay. new e6b7b95 macbuild.sh: add support for copying resource files. new 868dd0f res: rename "sound" to "audio". new f56df66 macbuild.sh: fix copying of resource files. new 80319a8 macbuild.sh: also add PA binaries to deduplication fixup list. new ae8a73f macbuild.sh: don't error out while executing parse_otool_output (). new f30b6b4 macbuild.sh: save return value of parse_otool_output (). new 015a107 src/pulsemanager.cpp: fix typo in fetch_pulseaudio_version (). new 74244d8 src/pulsemanager.cpp: don't overwrite the temporary string variable for the current line with what was supposed to hold new data in fetch_pulseaudio_version (). new cc14c21 src/pulsemanager.{cpp,h}: rename on_pulse_finished () to slot_on_pulse_finished (). new fc07778 src/pulsemanager.cpp: actually only play startup sound if debugging is enabled. new 1d9a7e1 src/pulsemanager.cpp: don't insert stray newline into config.pa. new aa6977d src/pulsemanager.cpp: insert PULSE_SERVER and PULSE_COOKIE variables into environment as used by PulseManager. new 76cbe47 src/pulsemanager.cpp: don't remove PA config and log file in ~/.x2go/pulse on PA shutdown if debugging has been requested. new 7316e7c src/x2goutils.{cpp,h}: add new function find_binary (). new 03e96e7 src/pulsemanager.cpp: auto-detect PA binary in $PATH and MacPorts default prefix as well on OS X. new 87b4c46 src/pulsemanager.cpp: add comments to Qt 4 code part. new 5584613 src/pulsemanager.cpp: add remainder for Linux-implementation in play_startup_sound (). new 47d1296 src/x2goutils.cpp: fix compile error. new d7ec05b src/pulsemanager.h: add new system_pulse_ variable to indicate that a system PA binary shall be used. new 9ec8a2c src/pulsemanager.cpp: correctly initialize and set system_pulse_ when required. new a4d7e7f src/x2goutils.{cpp,h}: add application modality parameter to show_RichText_Generic_MsgBox () and its wrappers. new 34f9d9a src/pulsemanager.cpp: add error message boxes throughout PulseManager. new b9d48d9 src/x2goutils.h: fix compile error due to typo. new fb194c6 debian/changelog: fix typo in function name. new cfbd0b1 src/pulsemanager.cpp: fix compile error on Windows. new dc05e9d src/pulsemanager.cpp: fix startup when using the system-PA version. new 57446c7 src/pulsemanager.cpp: fix startup sound playback when using the system-PA version. new bf71666 src/pulsemanager.cpp: add warning message boxes where appropriate. new 599a0ef src/pulsemanager.cpp: remove extraneous newlines from debug output. new 7f543fb src/x2goutils.cpp: fix faulty logic in find_binary (): only reset the given path to CWD iff it's actually empty. Not the other way around. new 5f6d6b4 src/x2goutils.cpp: add some debug logging to find_binary (). new ee59ede nsis/x2goclient.nsi: add startup.wav to installer package. new f732b34 src/: new file windows_stdint.h for Windows-compatibility when using std::(u)int*_t types. new 283b649 src/pulsemanager.h: use windows_stdint.h header on Windows, cstdint otherwise. new 06ae105 src/onmainwindow.cpp: short out code parts unconditionally checking for the userSshd variable. new 326b4b3 src/onmainwindow.cpp: drop obsolete pulseVersionTest variable initialization in Windows-only code. new 45fa5ae src/onmainwindow.cpp: drop obsolete pulseVersionIsLegacy variable initialization in Windows-only code. new 8c1f3d3 src/onmainwindow.cpp: add another pair of braces to in_addr-type variable initialization on Windows to silence compiler warning. new 0715c0f src/onmainwindow.cpp: fix compile error on Windows after moving some code around. new de931a1 src/onmainwindow.cpp: use correct C++ universal initializer for initializing in_addr-type variable, the C-style universal zero initializer won't cut it here. new d18c800 src/pulsemanager.h: include accidentally omitted wapi.h header file. new e28e785 src/pulsemanager.cpp: make PA version parsing function more generic and don't expect that a number is always terminated with a period or dash. new 5f7145d src/pulsemanager.cpp: make sure that wherever we interface with non-Qt functions, paths are in native form (i.e., containing empty separators, instead of the "generic" slash UNIX-style separator.) new 30d27c3 src/pulsemanager.cpp: fix PA version fetching on OS X again. new ca4ddfc src/unixhelper.{cpp,h}: make argument of kill_pgroup () const. new 03ed57d src/unixhelper.h: style and general fixes within comments. new 4330afe src/unixhelper.{cpp,h}: split off core functionality of kill_pgroup () into a new function called real_kill_pgroup (). new 15dc764 src/unixhelper.{cpp,h}: rewrite kill_pgroup () to act as a wrapper around real_kill_pgroup (). new 17e70ba src/pulsemanager.cpp: remove unused variables. new 844e768 src/unixhelper.cpp: code cleanup. new 39dae21 src/{unixhelper.cpp,x2goclient.cpp}: fix errno usage - save before use. This update added new revisions after undoing existing revisions. That is to say, some revisions that were in the old version of the branch are not in the new version. This situation occurs when a user --force pushes a change and generates a repository containing something like this: * -- * -- B -- O -- O -- O (15461fd) \ N -- N -- N refs/heads/bugfix/osx (39dae21) You should already have received notification emails for all of the O revisions, and so the following emails describe only the N revisions from the common base, B. Any revisions marked "omits" are not gone; other references still refer to them. Any revisions marked "discards" are gone forever. The 217 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "adds" were already present in the repository and have only been added to this reference. Summary of changes: copy-deps-win32.bat | 2 +- debian/changelog | 10 ++++++++++ src/onmainwindow.cpp | 16 +++++++++++++++- src/pulsemanager.cpp | 2 -- src/unixhelper.cpp | 30 ++++++++++++++++-------------- src/x2goclient.cpp | 9 ++++++--- 6 files changed, 48 insertions(+), 21 deletions(-) -- Alioth's /srv/git/code.x2go.org/x2goclient.git//..//_hooks_/post-receive-email on /srv/git/code.x2go.org/x2goclient.git