This is an automated email from the git hooks/post-receive script. x2go pushed a commit to branch master in repository x2goserver. commit 3c7a8f2fbaf99515f20c2a62ad13c5c538d2d98d Author: Mihai Moldovan <ionic@ionic.de> Date: Sat Nov 7 12:50:53 2020 +0100 X2Go/Server/Agent/NX/Options.pm: fix some Perl Critic warnings and silence others. --- X2Go/Server/Agent/NX/Options.pm | 6 ++++-- debian/changelog | 2 ++ 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/X2Go/Server/Agent/NX/Options.pm b/X2Go/Server/Agent/NX/Options.pm index ecd7a8a7..952adfa3 100644 --- a/X2Go/Server/Agent/NX/Options.pm +++ b/X2Go/Server/Agent/NX/Options.pm @@ -598,7 +598,9 @@ sub transform_intermediate { # List::MoreUtils::any would be more appropriate here, but this would add # another dependency and option strings are pretty small, so don't # overoptimize here. + ## no critic (BuiltinFunctions::ProhibitBooleanGrep) if (scalar (grep { filter_find_key ($work_option_key, $work_option_value, $_, --$elements_left) } (@{$ret}))) { + ## critic (BuiltinFunctions::ProhibitBooleanGrep) # Such an option already exists, we'll modify all occurrences. $elements_left = @{$ret}; $ret = [ map { filter_option_modify ($work_option_key, $work_option_value, $_, --$elements_left) } (@{$ret}) ]; @@ -899,8 +901,8 @@ If this is not the case, please report a bug. =head1 OPTIONS STRINGS -B<X2Go/NX Agent> options strings are fully documented in L<nxagent> and -additional, linked places. +B<X2Go/NX Agent> options strings are fully documented in +L<nxagent's documentation|nxagent> and additional, linked places therein. This module is not really concerned with the actual content of an options string, but mostly its format. diff --git a/debian/changelog b/debian/changelog index f3914ee0..d85d7e91 100644 --- a/debian/changelog +++ b/debian/changelog @@ -232,6 +232,8 @@ x2goserver (4.1.0.4-0x2go1.2) UNRELEASED; urgency=medium line. Non-functional. - X2Go/Server/Agent/NX/Options.pm: document the new compact_intermediate () function and its implications. + - X2Go/Server/Agent/NX/Options.pm: fix some Perl Critic warnings and + silence others. * debian/control: + Build-depend upon lsb-release for distro version detection. * debian/x2goserver.manpages: -- Alioth's /home/x2go-admin/maintenancescripts/git/hooks/post-receive-email on /srv/git/code.x2go.org/x2goserver.git