This is an automated email from the git hooks/post-receive script. x2go pushed a commit to branch master in repository x2goserver. commit 6c6f5ba83684465534226a3e84fc5a6e3083deff Author: Mihai Moldovan <ionic@ionic.de> Date: Mon Nov 23 05:52:58 2020 +0100 x2goserver/bin/x2goupdateoptionsstring: remove obsolete comment, we're not using a do block/do-while loop any longer. While the information provided there might be an interesting tidbit, it's not relevant to the code any longer and might actually confuse readers. --- debian/changelog | 4 ++++ x2goserver/bin/x2goupdateoptionsstring | 6 ------ 2 files changed, 4 insertions(+), 6 deletions(-) diff --git a/debian/changelog b/debian/changelog index 2d671f6d..c3c973c2 100644 --- a/debian/changelog +++ b/debian/changelog @@ -317,6 +317,10 @@ x2goserver (4.1.0.4-0x2go1.2) UNRELEASED; urgency=medium x2goserver/bin/x2goupdateoptionsstring}: fix/silence a few Perl::Critic warnings. - x2goserver/bin/x2goupdateoptionsstring: typo fix in output message only. + - x2goserver/bin/x2goupdateoptionsstring: remove obsolete comment, we're + not using a do block/do-while loop any longer. While the information + provided there might be an interesting tidbit, it's not relevant to the + code any longer and might actually confuse readers. * debian/control: + Build-depend upon lsb-release for distro version detection. * debian/x2goserver.manpages: diff --git a/x2goserver/bin/x2goupdateoptionsstring b/x2goserver/bin/x2goupdateoptionsstring index 6d7e20bb..cb48325c 100755 --- a/x2goserver/bin/x2goupdateoptionsstring +++ b/x2goserver/bin/x2goupdateoptionsstring @@ -460,12 +460,6 @@ sub Main { my $transformed = 0; - # Nasty trick (to some degree): "do"-blocks are not recognized as loops by - # Perl, but we could wrap the body in another block, which WILL BE recognized - # as a loop (one, that only executes once), oddly enough. However, using - # "last" won't work in such a situation, but rather behave like "next". - # Worse, the condition will also not be checked in such a case. - # Thus, we'd better use a real loop. while (defined (my $cur_transform = shift (@program_arguments))) { $transformed = 1; -- Alioth's /home/x2go-admin/maintenancescripts/git/hooks/post-receive-email on /srv/git/code.x2go.org/x2goserver.git