This is an automated email from the git hooks/post-receive script. x2go pushed a commit to branch 3.6.x in repository nx-libs. commit 972a92cab16a99d86a5b66b03967229799f1216d Author: Ulrich Sibiller <uli42@gmx.de> Date: Fri Oct 2 22:48:51 2020 +0200 Clipboard.c: add/fix comments --- nx-X11/programs/Xserver/hw/nxagent/Clipboard.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/nx-X11/programs/Xserver/hw/nxagent/Clipboard.c b/nx-X11/programs/Xserver/hw/nxagent/Clipboard.c index 22fc96f4f..bb8ca5843 100644 --- a/nx-X11/programs/Xserver/hw/nxagent/Clipboard.c +++ b/nx-X11/programs/Xserver/hw/nxagent/Clipboard.c @@ -827,9 +827,10 @@ void nxagentHandleSelectionRequestFromXServer(XEvent *X) * * The list is aligned with the one in nxagentConvertSelection. * - * FIXME: the perfect solution should not just answer with - * XA_STRING but ask the real owner what format it supports. The - * result should then be sent to the original requestor. + * FIXME: the perfect solution should not just answer with a + * hardcoded list but ask the real owner what format it + * supports. The result should then be sent to the original + * requestor. */ long targets[] = {XA_STRING, serverUTF8_STRING, serverTEXT, serverCOMPOUND_TEXT, serverTARGETS, serverTIMESTAMP}; @@ -877,6 +878,7 @@ void nxagentHandleSelectionRequestFromXServer(XEvent *X) * * FIXME: ensure we are reporting an _external_ timestamp * FIXME: for a 32 bit property list we need to pass a "long" array, not "char"! + * FIXME: selection has already been checked above, so we do not need to check again here */ int i = nxagentFindLastSelectionOwnerIndex(X->xselectionrequest.selection); @@ -1784,6 +1786,7 @@ int nxagentConvertSelection(ClientPtr client, WindowPtr pWin, Atom selection, __func__, nxagentClientInfoString(client)); #endif + /* notify the sender of the new request of failure */ sendSelectionNotifyEventToClient(client, time, requestor, selection, target, None); return 1; -- Alioth's /home/x2go-admin/maintenancescripts/git/hooks/post-receive-email on /srv/git/code.x2go.org/nx-libs.git