[X2Go-Commits] [x2goclient] branch bugfix/osx updated (f6351af -> 34e372f)

This is an automated email from the git hooks/post-receive script. x2go pushed a change to branch bugfix/osx in repository x2goclient. discards f6351af src/mediawidget.cpp: add deprecation warning for ESounD. discards 8a8713e src/mediawidget.cpp: add deprecation warning for ARTS. discards 4f5a879 src/mediawidget.cpp: simplify expression. discards 64edec6 src/mediawidget.cpp: unify some redundant code. discards ff6231c src/onmainwindow.cpp: convert piece of code to non-Windows and non-Darwin, so that not only Linux but other operating systems are covered as well. discards 66acb1a src/onmainwindow.{cpp,h}: remove left-over parec references and code. discards 3a48203 src/unix_stdint.h: use same hack to import ssize_t into std namespace. discards f79a1a6 src/pulsemanager.cpp: cast the return value of realloc () to char*, as GCC doesn't seem to like reassigning the pointer otherwise. discards 7679137 src/pulsemanager.cpp: use std::ssize_t for the path length, because it could be -1 and std::size_t is not applicable. discards 2f82839 src/pulsemanager.cpp: fix Linux-based code by fixing a really stupid typo ("erange" instead of "errno") and including the cerrno header. discards 56c4155 src/pulsemanager.h: use unix_stdint.h on non-Windows-platforms to get std::(u)int*_t types without having to use C++11. discards b91e6de src/: create new file unix_stdint.h which imports the (u)int*_t types into the std namespace. discards e7db217 src/unixhelper.cpp: use cstdio instead of stdio.h. discards fb92462 src/x2goutils.cpp: fix add_to_path (). discards 706d8fa src/x2goutils.cpp: add debugging output to add_to_path (). discards 1c48c7f src/onmainwindow.cpp: remove trailing slash from Mageia/SUSE/Arch sftp-server binary search path. discards f185cc8 src/{onmainwindow,pulsemanager}.cpp: actually *use* what we got back from add_to_path ()... discards a63a274 src/onmainwindow.cpp: stop duplicating the list of known sftp-server binary locations. discards 5cc0564 src/onmainwindow.cpp: move generateEtcFiles () call to startSshd (). discards 5280dd7 src/pulsemanager.cpp: fix PA binary searching logic. discards 59d6bfa src/onmainwindow.cpp: fix sshd_config generation on UNIX by searching for the real sftp-server binary path. discards 2b944c4 src/pulsemanager.cpp: refactor PA binary searching code. discards ec37ba9 src/x2goutils.{cpp,h}: make find_binary () and add_to_path () available on all UNIX-based operating systems. discards 5f99392 src/onmainwindow.cpp: use QFileInfo to get the key file's basename in exportDirs () instead of the old, potentially faulty string replace dance. discards e5cf0f1 src/onmainwindow.cpp: only pass non-Cygwin paths to QFile::exists () in generateKey (). discards 56afe6a src/onmainwindow.h: actually, we do need startSshd () to be public. Move it back. discards 1890a91 src/onmainwindow.cpp: re-order initializer list of WinServerStarter constructor. discards 44000d0 src/onmainwindow.{cpp,h}: don't try to initialize non-static ssh_key_type_ member variable directly, but in the constructor. discards 5c17ebf src/onmainwindow.h: remove WWrapper definition, seems to be unused. discards 8a81ce1 src/onmainwindow.h: move WinServerStarter class definition around to hopefully get the definition of ONMainWindow::key_types. discards 16768f5 src/onmainwindow.cpp: actually use key_type parameter in startSshd () and make selection more generic. discards 31c9a39 src/onmainwindow.cpp: add and use key_types parameter to startWinServers (). discards 16f34b2 src/onmainwindow.cpp: pass key_type parameter to startSshd () in createKeyBundle (). discards cc50945 src/onmainwindow.cpp: pass new ssh_key_type_ member to startSshd () call in WinServerStarter::run (). discards 69d74ff src/onmainwindow.{cpp,h}: add SSH key type parameter to startSshd (). discards 3421fde src/onmainwindow.{cpp,h}: add ssh_key_type_ member variable and getter and setter to WinServerStarter class. discards fe53ccc src/onmainwindow.{cpp,h}: make startSshd () private. discards 9ec24df src/onmainwindow.cpp: add listening-check loop to the Windows-specific code of startSshd (). discards 511c52f src/onmainwindow.cpp: add comment to last all-in listening check in startSshd (). discards 997f4bd src/onmainwindow.cpp: move QProcess startup check in startSshd () to non-Windows code section and add a listening socket check loop. discards 7702a4e macbuild.sh: switch to bundling PA 9.0. discards 9b8bcdc src/onmainwindow.{cpp,h}: rename createRSAKey () to the more-appropriate name createKeyBundle (). discards fde706f src/onmainwindow.cpp: add some comments only to createRSAKey (). discards d85f9ab src/onmainwindow.cpp: let startSshd () act as a wrapper and be called multiple times. discards 3df30b5 src/onmainwindow.{cpp,h}: reformat createRSAKey () only. discards 5250ae7 src/onmainwindow.{cpp,h}: move createRSAKey () around. discards e4f5bca src/onmainwindow.{cpp,h}: reformat generateKey () only. discards d9e96a2 src/onmainwindow.h: move generateKey () declaration around. discards f37e2be src/onmainwindow.cpp: use the new functions in generateKey (). discards c8d3d86 src/onmainwindow.{cpp,h}: add new function default_size_for_key_type (). discards e426f3b src/onmainwindow.{cpp,h}: add new function key_type_to_string (). discards 9e888ee src/onmainwindow.{cpp,h}: add new function check_key_type (). discards 4b1365f src/onmainwindow.cpp: terminate sshd more correctly. discards 4520eb2 src/onmainwindow.cpp: uppercase key type in debug output and comment string in generateKey (). discards 35cbbd5 src/onmainwindow.cpp: when starting sshd on Unix-based plattforms, raise maximum startup time to 5 seconds and break out early, if the process went into running state earlier. discards 4ef08ea src/{onmainwindow.{cpp,h},configdialog.cpp}: remove userSshd variable and code related to non-user-mode-sshd setups. discards 1a02765 src/onmainwindow.cpp: fix up a few debug strings. discards 367533c src/onmainwindow.cpp: add more error handling to generateKey () and fix up a broken error-handling section. discards c1dd082 src/onmainwindow.{cpp,h}: rewrite generateKey () function to actually also generate user keys. discards a05f7ce src/onmainwindow.cpp: refactor generateKey () a little bit to compact it. discards 56ea9b9 src/onmainwindow.{cpp,h}: rename generateHostKey () to generateKey () and add a boolean parameter with a default of false to request a public key. discards 95bbce4 src/onmainwindow.cpp: add support for explicitly setting the private key bit size based on type and use values (currently) regarded as secure to generateHostKey (). discards 1a81f49 src/onmainwindow.cpp: document createRSAKey () because what it does is completely non-obvious. discards f329073 src/{unixhelper.cpp,x2goclient.cpp}: fix errno usage - save before use. discards 05a949b src/unixhelper.cpp: code cleanup. discards 91aa49b src/pulsemanager.cpp: remove unused variables. discards c760abd src/unixhelper.{cpp,h}: rewrite kill_pgroup () to act as a wrapper around real_kill_pgroup (). discards e40b782 src/unixhelper.{cpp,h}: split off core functionality of kill_pgroup () into a new function called real_kill_pgroup (). discards 2d01c8e src/unixhelper.h: style and general fixes within comments. discards 57384ec src/unixhelper.{cpp,h}: make argument of kill_pgroup () const. discards f27e5e9 src/pulsemanager.cpp: fix PA version fetching on OS X again. discards 25e1eaf src/pulsemanager.cpp: make sure that wherever we interface with non-Qt functions, paths are in native form (i.e., containing empty separators, instead of the "generic" slash UNIX-style separator.) discards ae430fd src/pulsemanager.cpp: make PA version parsing function more generic and don't expect that a number is always terminated with a period or dash. discards 2b6901d src/pulsemanager.h: include accidentally omitted wapi.h header file. discards 5d3096b src/onmainwindow.cpp: use correct C++ universal initializer for initializing in_addr-type variable, the C-style universal zero initializer won't cut it here. discards 1a28ff2 src/onmainwindow.cpp: fix compile error on Windows after moving some code around. discards c64a0fc src/onmainwindow.cpp: add another pair of braces to in_addr-type variable initialization on Windows to silence compiler warning. discards a6cb9e8 src/onmainwindow.cpp: drop obsolete pulseVersionIsLegacy variable initialization in Windows-only code. discards 55957a1 src/onmainwindow.cpp: drop obsolete pulseVersionTest variable initialization in Windows-only code. discards cdce725 src/onmainwindow.cpp: short out code parts unconditionally checking for the userSshd variable. discards f219df2 src/pulsemanager.h: use windows_stdint.h header on Windows, cstdint otherwise. discards 6facff6 src/: new file windows_stdint.h for Windows-compatibility when using std::(u)int*_t types. discards fb25e26 nsis/x2goclient.nsi: add startup.wav to installer package. discards af687ca src/x2goutils.cpp: add some debug logging to find_binary (). discards 403a294 src/x2goutils.cpp: fix faulty logic in find_binary (): only reset the given path to CWD iff it's actually empty. Not the other way around. discards a2286ab src/pulsemanager.cpp: remove extraneous newlines from debug output. discards 086da73 src/pulsemanager.cpp: add warning message boxes where appropriate. discards a4e9688 src/pulsemanager.cpp: fix startup sound playback when using the system-PA version. discards d28ef9e src/pulsemanager.cpp: fix startup when using the system-PA version. discards 019ab8a src/pulsemanager.cpp: fix compile error on Windows. discards 3bda534 debian/changelog: fix typo in function name. discards 7121d44 src/x2goutils.h: fix compile error due to typo. discards c0319a2 src/pulsemanager.cpp: add error message boxes throughout PulseManager. discards e175dfa src/x2goutils.{cpp,h}: add application modality parameter to show_RichText_Generic_MsgBox () and its wrappers. discards d7c84b8 src/pulsemanager.cpp: correctly initialize and set system_pulse_ when required. discards fbaf43b src/pulsemanager.h: add new system_pulse_ variable to indicate that a system PA binary shall be used. discards b26af8d src/x2goutils.cpp: fix compile error. discards 51db83e src/pulsemanager.cpp: add reminder for Linux-implementation in play_startup_sound (). discards 7de9075 src/pulsemanager.cpp: add comments to Qt 4 code part. discards 7f074fe src/pulsemanager.cpp: auto-detect PA binary in $PATH and MacPorts default prefix as well on OS X. discards 7c99f21 src/x2goutils.{cpp,h}: add new function find_binary (). discards 77c64d0 src/pulsemanager.cpp: don't remove PA config and log file in ~/.x2go/pulse on PA shutdown if debugging has been requested. discards 8a1f3ce src/pulsemanager.cpp: insert PULSE_SERVER and PULSE_COOKIE variables into environment as used by PulseManager. discards ba02068 src/pulsemanager.cpp: don't insert stray newline into config.pa. discards 3b4f2a8 src/pulsemanager.cpp: actually only play startup sound if debugging is enabled. discards 81b035d src/pulsemanager.{cpp,h}: rename on_pulse_finished () to slot_on_pulse_finished (). discards 40946d9 src/pulsemanager.cpp: don't overwrite the temporary string variable for the current line with what was supposed to hold new data in fetch_pulseaudio_version (). discards 8f38efe src/pulsemanager.cpp: fix typo in fetch_pulseaudio_version (). discards 95470de macbuild.sh: save return value of parse_otool_output (). discards d0bfe8e macbuild.sh: don't error out while executing parse_otool_output (). discards c98836c macbuild.sh: also add PA binaries to deduplication fixup list. discards ea8074b macbuild.sh: fix copying of resource files. discards 6afa621 res: rename "sound" to "audio". discards 9f2a2dc macbuild.sh: add support for copying resource files. discards dd0434d src/pulsemanager.cpp: don't time out while trying to start PA or paplay. discards 7d2aae2 res/sound: add startup.wav sound to be played back when starting the PA daemon in debug mode. discards 357a246 src/pulsemanager.h: fix compile error due to mismatching function declaration for set_debug (). discards 6bb994a src/onmainwindow.cpp: port to new debugging feature of PulseManager. discards 5f76771 src/pulsemanager.{cpp,h}: port to new debugging feature. discards 8338f7e src/pulsemanager.{cpp,h}: add debugging setter and private variable. discards a8dcfc4 src/pulsemanager.cpp: hide Windows-only code behind #ifdefs. discards c8b4eb2 src/pulsemanager.cpp: fix compile error due to typo. discards 694c927 src/onmainwindow.cpp: make use of new PulseManager::start () behavior and always use it, no matter whether server is up already or not. discards 9a276f0 src/onmainwindow.cpp: convert QDir object to QString for further processing. discards b05b8d9 src/onmainwindow.cpp: fix compile error due to misuse of #ifdef. discards 2251929 src/pulsemanager.cpp: let start () act as a wrapper and do nothing if the PA server is already running. discards c7f5373 src/onmainwindow.cpp: fix compile errors due to misspelled function names. discards 6c7ec46 src/configdialog.cpp: fix compile error by removing obsolete (and now faulty) line for removed restart message. discards decda14 src/pulsemanager.cpp: output PA stdout/stderr via x2goDebug, not plainly to stdout. discards 762b5ca src/pulsemanager.h: move x2gologdebug.h inclusion into implementation file. discards 34a6f95 src/mediawidget.cpp: reflect new capabilities through PulseManager. discards 6945270 src/onmainwindow.{cpp,h}: hook PulseManager in - for both OS X and Windows. discards d406a31 src/configdialog.cpp: whitespace only. discards 22e799f src/configdialog.{cpp,h}: add "no record" support for OS X (through PulseManager.) discards 4afe913 src/pulsemanager.cpp: backport fix for 422. discards 0954be8 src/pulsemanager.cpp: backport fix for 526. discards feef7c1 src/pulsemanager.cpp: add "FIXME" debug logging (and cleanup.) discards af5653c src/pulsemanager.cpp: replace hardcoded modules paths with dynamic ones depending on the detected PA version. discards fe0dfbc src/pulsemanager.{cpp,h}: add get_pulse_dir () for fetching the (OS-dependent) PulseAudio config and cookie directory. discards 1f55d80 pulsemanager.cpp: remove config.pa while doing post-exit cleanups. discards c3fb546 macbuild.sh: libpulsecore.dylib also resides in the "private" pulseaudio subdirectory now, adding it to "special files workaround". discards f82c679 macbuild.sh: PulseAudio has been updated to version 8.0. Reflect this. discards f0380a9 pulsemanager.cpp: cleanup, don't use copy assignment operator when we just need to construct a new object. discards a6dbe5b pulsemanager.cpp: use record and playback member variables. discards fa41daf pulsemanager.h: more moving around. discards a397293 pulsemanager.cpp: fix compile error in startup sound function. discards 1b21056 pulsemanager.cpp: reorder member variables in initializer list. discards ae8738f pulsemanager.{cpp,h}: add record and playback private members, as well as getters and setters. discards 53390d1 pulsemanager.{cpp,h}: only allow changing PA or ESD ports when server is not currently running. discards 237c026 pulsemanager.cpp: add algorithm for actually extracting PA version number. discards f9c45b1 pulsemanager.h: reformat a bit by adding newlines and moving lines in a (hopefully) logical fashion. discards 99529e5 pulsemanager.{cpp,h}: some older PA versions used the major, minor and micro numbering scheme together with a descriptive string. discards 5d3ff29 pulsemanager.cpp: fix some error messages by removing redundant newlines. discards e71dc40 pulsemanager.cpp: re-initialize buffer string on each run while getting CWD on Linux. discards 13ea68a pulsemanager.{cpp,h}: new member function fetch_pulseaudio_version () with first skeleton. discards bcda83c pulsemanager.cpp: generate platform-dependent values for member variables server_working_dir_ and server_binary_ in constructor. discards 5bae684 pulsemanager.cpp: add "dummy" start_linux () function. discards 769c58a pulsemanager.cpp: reorder member variables in initialization list. discards 1e849b2 pulsemanager.cpp: another typo fix: findPort -> find_port. discards e9838d5 pulsemanager.cpp: fix another compile error due to typo'd versions of generate_server_config () and generate_client_config (). discards 84857c2 pulsemanager.cpp: fix compile errors in find_port () by renaming the ret or port variable to search_port. discards 900ef5f pulsemanager.{cpp,h}: find_port () actually returns a value, fix declaration accordingly. discards 98d42ab pulsemanager.cpp: typo fix in member variable name server_working_dir_. discards d50f0d8 pulsemanager.h: whitespace only. discards 8477bc9 pulsemanager.cpp: make startup sound playing via slot_play_startup_sound () Windows-compatible. discards c6f84c5 pulsemanager.cpp: only play startup sound if DEBUG macro is defined. discards aa0add6 pulsemanager.cpp: make generate_client_config () Windows-compatible. discards a591c69 pulsemanager.cpp: make generate_server_config () Windows-compatible. discards cdad141 pulsemanager.cpp: also load module-esound-protocol-tcp module. discards 475da8f pulsemanager.{cpp,h}: implement start_win () as part of Windows functionality. discards 095249b pulsemanager.cpp: let start_osx () use start_generic (). discards 7628775 pulsemanager.{cpp,h}: add new function start_generic () to split off common functionality. discards 5dc6671 pulsemanager.cpp: add Windows stuff to initial env in constructor. discards 7ce83ca pulsemanager.cpp: add cleanup support to on_pulse_finished (). discards b204f1a pulsemanager.cpp: add Windows support to shutdown (). discards fd3228a pulsemanager.{cpp,h}: new function create_client_dir (). discards e4a35e0 pulsemanager.cpp: make start () wrap the "real" OS-specific start functions. discards edb803b pulsemanager.{cpp,h}: add server_args_, server_binary_ and server_working_dir_ class variables. discards 94d0125 pulsemanager.{cpp,h}: fixup preprocessor usage. discards cd55fac pulsemanager.cpp: reformat only. discards 992c472 pulsemanager.{cpp,h}: rename relaunch () to restart (). discards 3a521d9 pulsemanager.{cpp,h}: add ESD support. discards 5bb2800 pulsemanager.h: add std:: namespace selector for uint32_t version variables. discards aa35383 pulsemanager.{cpp,h}: switch port definitions to std::uint16_t. discards b4a1704 pulsemanager.cpp: reformat only. discards 7d9e715 pulsemanager.{cpp,h}: add pulse_version_{major,minor}_ member variables. discards 73c7c73 pulsemanager.cpp: use initializer list for constructor. discards 6093d43 pulsemanager.{cpp,h}: reformat only. discards 936a135 pulsemanager.cpp: minor non-behavior changing fixes. discards e2bf78f pulsemanager.{cpp,h}: use name and underscore for member variables, not underscore and name. discards a50d229 macbuild.sh: rewrite ID line detection algorithm. discards c3e6484 macbuild.sh: copy "special" files, so that they can be removed later on. discards 2fb7826 macbuild.sh: fix removal of base prefix in deduplication if base prefix ends in a slash. discards c18fb0a macbuild.sh: more debug messages and a whitespace change. discards 6f45d0f macbuild.sh: spelling fix. discards ce32eb0 macbuild.sh: merge deduplicate.sh content in. discards f12d046 deduplicate.sh: replace tabs with two spaces. No functional changes. discards c8e9820 macbuild.sh: replace tabs with two spaces. No functional changes. discards e75c5aa deduplicate.sh: remove some noisy debug output. discards 51a94f0 deduplicate.sh: add WARNING to status message. discards 60ca1ce deduplicate.sh: fix wrong return value capture. discards 0ebdd78 deduplicate.sh: remove a bit of noisy debug output, but turn on parse_otool_output debugging. discards a285096 deduplicate.sh: cleanup as announced in the last commit - using lazy_canonical_path. discards 8ccb0dd deduplicate.sh: surprisingly, it turned out that only checking the duplicate's basename against the current dependency's basename is not good enough. discards b29ee94 deduplicate.sh: more temporary debugging output in fixup section. discards 4c6fa50 deduplicate.sh: copy lazy_canonical_path from macbuild.sh for now. discards c4be529 deduplicate.sh: save dependency format base string as a readonly variable and use that instead of repeating a fixed string. discards 3e34237 deduplicate.sh: actually include file name in install_name_tool pseudo output. discards ebd1446 deduplicate.sh: parse_otool_output: jump over first matching entry, which is - hopefully - the id line. discards a712c0d deduplicate.sh: unstub fixup section. discards 3628739 deduplicate.sh: add more useful information in fixup section's error message. discards b1165d0 deduplicate.sh: switch to range-based for loop in fixup section for duplicate array walking as we need to access the same element index in the replacement array. discards 3e62da1 deduplicate.sh: prevent word splitting when parsing otool's output. discards 7c63814 deduplicate.sh: debug parse_otool_output fiercely for the time being. discards 9e7ff84 deduplicate.sh: record crafted "library path" values in duplicates replacement to_files array. discards e8548c0 deduplicate.sh: change exit to return in parse_otool_output. discards bd3eb17 deduplicate.sh: fix parse_otool_output: we want to return failure only iff any of the strings are present in otool's output and actually handle the failure string *ARRAY* correctly as that. discards 9364868 deduplicate.sh: quote "${arr[@]}" correctly to not suddenly force word splitting. discards 7004f4b deduplicate.sh: change range-based for loops to "${!arr[@]}" to handle "sparse" arrays correctly. discards c93b513 deduplicate.sh: correctly unset an array element. discards 2db3174 deduplicate.sh: add first skeleton for library dependency rewriting of deleted duplicates. discards b2a54e8 deduplicate.sh: non-functional: change WARNING to ERROR in error messages. discards 18b2411 deduplicate.sh: new function for parsing otool's output and printing library dependencies if no error occurred. discards 795f4e5 deduplicate.sh: add missed local variable declaration. discards 0807242 deduplicate.sh: add duplicates-to-real mapping. discards d0230a3 deduplicate.sh: add new, more or less Proof of Concept, and Work in Progress file deduplication script. discards 8a6f46b macbuild.sh: also install libraries into staging area with intermediate library path. discards 051ecb1 macbuild.sh: fix echo call to also show the intermediate lib dir, not just the library file name. discards 23ce3f2 macbuild.sh: when actually bundling libraries, use @executable_path instead of @loader_path. discards 6134138 macbuild.sh: add the correct file path to the library bundling array. discards 50743fe macbuild.sh: check current file name against regex, not a (now) full path. discards 717972f macbuild.sh: use while-read-loop and find to actually recurse through directories. discards 83fb43a macbuild.sh: remove libpulse and libpulsecore from libraries to be bundled, as something else will bundle them anyway. discards 0763ea2 macbuild.sh: add some more debugging output. discards eb6b6fb macbuild.sh: directories are "executable", so the first check must explicitly include a check for the argument being not a directory. discards 3f8d6eb macbuild.sh: add Linux library file name scheme regex as a precaution. discards 1d56609 macbuild.sh: add work-in-progress PulseAudio bundling. discards b1b258c macbuild.sh: add phase output for bundling nxproxy. discards 4fbc0eb macbuild.sh: copy PulseAudio libraries and binaries. discards 6682197 macbuild.sh: define PulseAudio libraries and binaries to be later copied. discards 8966d53 macbuild.sh: add EXE_DIR and FRAMEWORKS_DIR internal variables. discards 347cab0 macbuild.sh: refactor nxproxy detection to use MACPORTS_PREFIX. discards f720d1f macbuild.sh: add new repeat_str() helper function. discards 572ec9c macbuild.sh: add new get_nesting_level() helper function. discards 62587c3 macbuild.sh: add new lazy_canonical_path() helper function. discards 3575bbb macbuild.sh: add new dependency_error() helper function. discards 0c5e5c1 macbuild.sh: add new MACPORTS_PREFIX detection/variable. discards 746616a x2goclient.pro{maemo}: reference new pulsemanager.{cpp,h} files. discards 83ed0cd pulsemanager.{cpp,h}: new class for PulseAudio management. discards 848fd9c compat.h: include QtCore/qglobal.h for Q_OS_... macros. discards 15629bf compat.{cpp,h}: remove inline keyword, because function is not defined in header file. discards 198b5ce compat.{cpp,h}: new files. Implements strndup on OS X 10.6 and below. Add to x2goclient.cpp, x2goclient.pro and x2goclient.pro.maemo. discards 7eec91a onmainwindow.cpp: correctly use ~/.x2go/.ssh as ssh directory when starting sshd in user mode. discards 62adaa3 appdialog.cpp: initialize parent in default case. Another GCC compile warning fix. discards 9426f0b {appdialog,configwidget,onmainwindow,unixhelper}.cpp: fix some compile warnings with GCC. Fix a few whitespace issues. discards 164bdcc x2goclient.cpp: fix failing exec() call for the UNIX helper utility: correctly terminate arguments vector. discards 550436d unixhelper.{cpp,h}: ignore SIGINT, SIGTERM, SIGPIPE, SIGQUIT, SIGUSR1 and SIGUSR2. discards 8eca258 {unixhelper.{cpp,h},x2goclient.cpp}: switch main cleanup handling to parent PID polling. discards f7bf3fe unixhelper.{cpp,h}: raise sleeping time to two seconds and grace period to 10 seconds. discards 2d12de7 x2goclient.cpp: create new argv array on the heap instead of on the stack. discards d834425 x2goclient.cpp: fix string comparison. discards a790599 x2goclient.cpp: fix compile problems introduced with the last commit. discards a94f0a6 x2goclient.cpp: don't start the UNIX cleanup helper process right after forking. discards 7f63e8c x2goclient.cpp: clean up. discards 909ed77 unixhelper.cpp: port from std::signal() to sigaction(). Handle errors. discards 38f4777 unixhelper.{cpp,h}: implement signal unblocking in unixhelper::unix_cleanup(). Update documentation. discards 60c13c0 unixhelper.cpp: kill process group on error. discards 1c4a123 x2goclient.cpp: return return value of unixhelper::unix_cleanup(). discards 31a031c unixhelper.{cpp,h}: add documentation/comments. discards af81f56 unixhelper.{cpp,h},x2goclient.cpp}: unixhelper should really be a (module) namespace, not a class. discards 999db47 unixhelper.h: forgot to declare type of unix_cleanup() function. discards 415e635 unixhelper.{h,cpp}: also include <QtCore/qglobal.h> to have Q_OS_UNIX defined on UNIX-based platforms. Move guards around. discards 2c95bc8 x2goclient.cpp: fix std::edit -> std::exit typo. discards d190941 x2goclient.cpp: add legacy <sys/types.h> header needed for old operating systems. discards 3d8a385 x2goclient.cpp: add myself to copyright header. discards af08f84 x2goclient.cpp: use setsid() on UNIX to become session and process group leader. discards 5d7cef1 x2goclient.cpp: add fork_helper() function to start up the UNIX cleanup helper. discards 09d814b x2goclient.cpp: wrap X2Go Client main function and use that. discards 4843924 unixhelper.{cpp,h}: implement cleanup program for process group. discards bc2fa04 {unixhelper.{cpp,h},x2goclient.pro{maemo}}: add unixhelper stub. adds be1355b {res/img/svg/,res/resources.qrc}: add new file hamburger.svg, a custom-created hamburger icon. adds 585fb93 src/sessionbutton.cpp: replace drop down menu button on session buttons again with the custom-created hamburger icon. adds c092262 src/onmainwindow.{cpp,h}: add new function images_resource_path (), similar to iconsPath () but without explicitly referring to icons. adds 707f990 src/sessionbutton.cpp: we cannot use ".." in resource paths to move up one level, so use images_resource_path () instead and hope that we finally get a yummy hamburger. adds cd36a75 src/onmainwindow.{cpp,h}: let iconsPath () take a const-reference instead of an object and make it a const member function. adds 5eca0cf src/onmainwindow.{cpp,h}: let images_resource_path () take a new, optional "base" parameter, that might be empty and is put in-between the fixed resource path string and the filename parameter. adds 7f48257 src/onmainwindow.cpp: use images_resource_path () in iconsPath (). adds b04960e src/sessionbutton.cpp: instead of using the hamburger.svg file directly, render it to a raster image and use this Pixmap as the icon file - otherwise the icon will not show up. new 1740675 {unixhelper.{cpp,h},x2goclient.pro{maemo}}: add unixhelper stub. new 71b8fa7 unixhelper.{cpp,h}: implement cleanup program for process group. new 4630575 x2goclient.cpp: wrap X2Go Client main function and use that. new b6dae74 x2goclient.cpp: add fork_helper() function to start up the UNIX cleanup helper. new 7119325 x2goclient.cpp: use setsid() on UNIX to become session and process group leader. new 99e06df x2goclient.cpp: add myself to copyright header. new ab46352 x2goclient.cpp: add legacy <sys/types.h> header needed for old operating systems. new b0a4e8a x2goclient.cpp: fix std::edit -> std::exit typo. new ea5a459 unixhelper.{h,cpp}: also include <QtCore/qglobal.h> to have Q_OS_UNIX defined on UNIX-based platforms. Move guards around. new 6a97413 unixhelper.h: forgot to declare type of unix_cleanup() function. new ab82e0a unixhelper.{cpp,h},x2goclient.cpp}: unixhelper should really be a (module) namespace, not a class. new 521aec8 unixhelper.{cpp,h}: add documentation/comments. new 971f61d x2goclient.cpp: return return value of unixhelper::unix_cleanup(). new 88ee873 unixhelper.cpp: kill process group on error. new 395d9bc unixhelper.{cpp,h}: implement signal unblocking in unixhelper::unix_cleanup(). Update documentation. new df64bd4 unixhelper.cpp: port from std::signal() to sigaction(). Handle errors. new 7a1ea91 x2goclient.cpp: clean up. new 184a757 x2goclient.cpp: don't start the UNIX cleanup helper process right after forking. new c224af3 x2goclient.cpp: fix compile problems introduced with the last commit. new 3404eb0 x2goclient.cpp: fix string comparison. new 1c274a8 x2goclient.cpp: create new argv array on the heap instead of on the stack. new ddd92ff unixhelper.{cpp,h}: raise sleeping time to two seconds and grace period to 10 seconds. new b0e8602 {unixhelper.{cpp,h},x2goclient.cpp}: switch main cleanup handling to parent PID polling. new 874b923 unixhelper.{cpp,h}: ignore SIGINT, SIGTERM, SIGPIPE, SIGQUIT, SIGUSR1 and SIGUSR2. new 0d0788f x2goclient.cpp: fix failing exec() call for the UNIX helper utility: correctly terminate arguments vector. new 7cec536 {appdialog,configwidget,onmainwindow,unixhelper}.cpp: fix some compile warnings with GCC. Fix a few whitespace issues. new ead8507 appdialog.cpp: initialize parent in default case. Another GCC compile warning fix. new 536e614 onmainwindow.cpp: correctly use ~/.x2go/.ssh as ssh directory when starting sshd in user mode. new 732d343 compat.{cpp,h}: new files. Implements strndup on OS X 10.6 and below. Add to x2goclient.cpp, x2goclient.pro and x2goclient.pro.maemo. new 7b54b79 compat.{cpp,h}: remove inline keyword, because function is not defined in header file. new 1ba8caf compat.h: include QtCore/qglobal.h for Q_OS_... macros. new aa1727b pulsemanager.{cpp,h}: new class for PulseAudio management. new 758b4ba x2goclient.pro{maemo}: reference new pulsemanager.{cpp,h} files. new e874dc3 macbuild.sh: add new MACPORTS_PREFIX detection/variable. new 59812f4 macbuild.sh: add new dependency_error() helper function. new f3d3640 macbuild.sh: add new lazy_canonical_path() helper function. new ca9c9d2 macbuild.sh: add new get_nesting_level() helper function. new 015d810 macbuild.sh: add new repeat_str() helper function. new c9c5f3c macbuild.sh: refactor nxproxy detection to use MACPORTS_PREFIX. new 783628e macbuild.sh: add EXE_DIR and FRAMEWORKS_DIR internal variables. new 3740f47 macbuild.sh: define PulseAudio libraries and binaries to be later copied. new 6da5640 macbuild.sh: copy PulseAudio libraries and binaries. new 200fe5b macbuild.sh: add phase output for bundling nxproxy. new fbc4ac8 macbuild.sh: add work-in-progress PulseAudio bundling. new e521d3f macbuild.sh: add Linux library file name scheme regex as a precaution. new fb74e67 macbuild.sh: directories are "executable", so the first check must explicitly include a check for the argument being not a directory. new d78c5b9 macbuild.sh: add some more debugging output. new 1ea7af4 macbuild.sh: remove libpulse and libpulsecore from libraries to be bundled, as something else will bundle them anyway. new bd6d3fd macbuild.sh: use while-read-loop and find to actually recurse through directories. new 6e59f60 macbuild.sh: check current file name against regex, not a (now) full path. new 583d588 macbuild.sh: add the correct file path to the library bundling array. new 2cd9333 macbuild.sh: when actually bundling libraries, use @executable_path instead of @loader_path. new d416c5e macbuild.sh: fix echo call to also show the intermediate lib dir, not just the library file name. new 3c487eb macbuild.sh: also install libraries into staging area with intermediate library path. new b7704e9 deduplicate.sh: add new, more or less Proof of Concept, and Work in Progress file deduplication script. new e05c465 deduplicate.sh: add duplicates-to-real mapping. new f900a7d deduplicate.sh: add missed local variable declaration. new c78f27d deduplicate.sh: new function for parsing otool's output and printing library dependencies if no error occurred. new d495a0a deduplicate.sh: non-functional: change WARNING to ERROR in error messages. new 2ecf444 deduplicate.sh: add first skeleton for library dependency rewriting of deleted duplicates. new 209d167 deduplicate.sh: correctly unset an array element. new f498ad4 deduplicate.sh: change range-based for loops to "${!arr[@]}" to handle "sparse" arrays correctly. new 1bdbd9a deduplicate.sh: quote "${arr[@]}" correctly to not suddenly force word splitting. new f70b4fd deduplicate.sh: fix parse_otool_output: we want to return failure only iff any of the strings are present in otool's output and actually handle the failure string *ARRAY* correctly as that. new bb20604 deduplicate.sh: change exit to return in parse_otool_output. new cbb174e deduplicate.sh: record crafted "library path" values in duplicates replacement to_files array. new 12ee219 deduplicate.sh: debug parse_otool_output fiercely for the time being. new c9f9888 deduplicate.sh: prevent word splitting when parsing otool's output. new 9f8b79d deduplicate.sh: switch to range-based for loop in fixup section for duplicate array walking as we need to access the same element index in the replacement array. new 1079389 deduplicate.sh: add more useful information in fixup section's error message. new a3c50f7 deduplicate.sh: unstub fixup section. new 5146821 deduplicate.sh: parse_otool_output: jump over first matching entry, which is - hopefully - the id line. new 5c88593 deduplicate.sh: actually include file name in install_name_tool pseudo output. new 4df76a3 deduplicate.sh: save dependency format base string as a readonly variable and use that instead of repeating a fixed string. new e23dc88 deduplicate.sh: copy lazy_canonical_path from macbuild.sh for now. new ff427a9 deduplicate.sh: more temporary debugging output in fixup section. new 73475de deduplicate.sh: surprisingly, it turned out that only checking the duplicate's basename against the current dependency's basename is not good enough. new 90e5d02 deduplicate.sh: cleanup as announced in the last commit - using lazy_canonical_path. new 4ef1268 deduplicate.sh: remove a bit of noisy debug output, but turn on parse_otool_output debugging. new e52d7eb deduplicate.sh: fix wrong return value capture. new 7ad9134 deduplicate.sh: add WARNING to status message. new a84a817 deduplicate.sh: remove some noisy debug output. new f4cd198 macbuild.sh: replace tabs with two spaces. No functional changes. new a058c82 deduplicate.sh: replace tabs with two spaces. No functional changes. new 92b73d6 macbuild.sh: merge deduplicate.sh content in. new 5575ccc macbuild.sh: spelling fix. new da99597 macbuild.sh: more debug messages and a whitespace change. new c7be38a macbuild.sh: fix removal of base prefix in deduplication if base prefix ends in a slash. new 1459742 macbuild.sh: copy "special" files, so that they can be removed later on. new 823e495 macbuild.sh: rewrite ID line detection algorithm. new ede7d81 pulsemanager.{cpp,h}: use name and underscore for member variables, not underscore and name. new baafffc pulsemanager.cpp: minor non-behavior changing fixes. new ebdeaef pulsemanager.{cpp,h}: reformat only. new 57b8b72 pulsemanager.cpp: use initializer list for constructor. new 93d56b8 pulsemanager.{cpp,h}: add pulse_version_{major,minor}_ member variables. new ef7ccd4 pulsemanager.cpp: reformat only. new 18e3858 pulsemanager.{cpp,h}: switch port definitions to std::uint16_t. new 6c2e4eb pulsemanager.h: add std:: namespace selector for uint32_t version variables. new 724bab1 pulsemanager.{cpp,h}: add ESD support. new d3eb996 pulsemanager.{cpp,h}: rename relaunch () to restart (). new 26b054d pulsemanager.cpp: reformat only. new 53df4ba pulsemanager.{cpp,h}: fixup preprocessor usage. new 0389589 pulsemanager.{cpp,h}: add server_args_, server_binary_ and server_working_dir_ class variables. new 2fb2ad6 pulsemanager.cpp: make start () wrap the "real" OS-specific start functions. new 2e43da4 pulsemanager.{cpp,h}: new function create_client_dir (). new 7b48132 pulsemanager.cpp: add Windows support to shutdown (). new a577194 pulsemanager.cpp: add cleanup support to on_pulse_finished (). new 44d2d61 pulsemanager.cpp: add Windows stuff to initial env in constructor. new 9038551 pulsemanager.{cpp,h}: add new function start_generic () to split off common functionality. new 7e5fd58 pulsemanager.cpp: let start_osx () use start_generic (). new fde3b88 pulsemanager.{cpp,h}: implement start_win () as part of Windows functionality. new 9146491 pulsemanager.cpp: also load module-esound-protocol-tcp module. new 52e1e0d pulsemanager.cpp: make generate_server_config () Windows-compatible. new 00c6f79 pulsemanager.cpp: make generate_client_config () Windows-compatible. new 7070895 pulsemanager.cpp: only play startup sound if DEBUG macro is defined. new e3fc560 pulsemanager.cpp: make startup sound playing via slot_play_startup_sound () Windows-compatible. new 4a4bea9 pulsemanager.h: whitespace only. new e4ad215 pulsemanager.cpp: typo fix in member variable name server_working_dir_. new 77fd710 pulsemanager.{cpp,h}: find_port () actually returns a value, fix declaration accordingly. new 6602b15 pulsemanager.cpp: fix compile errors in find_port () by renaming the ret or port variable to search_port. new 97b32a9 pulsemanager.cpp: fix another compile error due to typo'd versions of generate_server_config () and generate_client_config (). new 47fbb31 pulsemanager.cpp: another typo fix: findPort -> find_port. new 2b546a3 pulsemanager.cpp: reorder member variables in initialization list. new 3344476 pulsemanager.cpp: add "dummy" start_linux () function. new 547aeff pulsemanager.cpp: generate platform-dependent values for member variables server_working_dir_ and server_binary_ in constructor. new 9d28e79 pulsemanager.{cpp,h}: new member function fetch_pulseaudio_version () with first skeleton. new c50e429 pulsemanager.cpp: re-initialize buffer string on each run while getting CWD on Linux. new a508d02 pulsemanager.cpp: fix some error messages by removing redundant newlines. new 066c8cb pulsemanager.{cpp,h}: some older PA versions used the major, minor and micro numbering scheme together with a descriptive string. new 7cd6b80 pulsemanager.h: reformat a bit by adding newlines and moving lines in a (hopefully) logical fashion. new f345591 pulsemanager.cpp: add algorithm for actually extracting PA version number. new 1d19c5d pulsemanager.{cpp,h}: only allow changing PA or ESD ports when server is not currently running. new 2cbf5bb pulsemanager.{cpp,h}: add record and playback private members, as well as getters and setters. new f92ee5c pulsemanager.cpp: reorder member variables in initializer list. new 1c95b06 pulsemanager.cpp: fix compile error in startup sound function. new 8fd429e pulsemanager.h: more moving around. new 649e739 pulsemanager.cpp: use record and playback member variables. new ca08199 pulsemanager.cpp: cleanup, don't use copy assignment operator when we just need to construct a new object. new c628cd7 macbuild.sh: PulseAudio has been updated to version 8.0. Reflect this. new a036bce macbuild.sh: libpulsecore.dylib also resides in the "private" pulseaudio subdirectory now, adding it to "special files workaround". new 54bd8cf pulsemanager.cpp: remove config.pa while doing post-exit cleanups. new 1a85a09 src/pulsemanager.{cpp,h}: add get_pulse_dir () for fetching the (OS-dependent) PulseAudio config and cookie directory. new c8ac3db src/pulsemanager.cpp: replace hardcoded modules paths with dynamic ones depending on the detected PA version. new ee43b4c src/pulsemanager.cpp: add "FIXME" debug logging (and cleanup.) new a5d45b3 src/pulsemanager.cpp: backport fix for 526. new 7921f0d src/pulsemanager.cpp: backport fix for 422. new 8173f20 src/configdialog.{cpp,h}: add "no record" support for OS X (through PulseManager.) new e266f8f src/configdialog.cpp: whitespace only. new f2f849b src/onmainwindow.{cpp,h}: hook PulseManager in - for both OS X and Windows. new 822ac31 src/mediawidget.cpp: reflect new capabilities through PulseManager. new 9b0e1bd src/pulsemanager.h: move x2gologdebug.h inclusion into implementation file. new 78f998a src/pulsemanager.cpp: output PA stdout/stderr via x2goDebug, not plainly to stdout. new 5a2ce74 src/configdialog.cpp: fix compile error by removing obsolete (and now faulty) line for removed restart message. new b356a80 src/onmainwindow.cpp: fix compile errors due to misspelled function names. new 0e276ad src/pulsemanager.cpp: let start () act as a wrapper and do nothing if the PA server is already running. new b613baf src/onmainwindow.cpp: fix compile error due to misuse of #ifdef. new 6b08295 src/onmainwindow.cpp: convert QDir object to QString for further processing. new 841ebb0 src/onmainwindow.cpp: make use of new PulseManager::start () behavior and always use it, no matter whether server is up already or not. new f91bb55 src/pulsemanager.cpp: fix compile error due to typo. new 2ff420e src/pulsemanager.cpp: hide Windows-only code behind #ifdefs. new e1a2016 src/pulsemanager.{cpp,h}: add debugging setter and private variable. new 9356691 src/pulsemanager.{cpp,h}: port to new debugging feature. new e068a55 src/onmainwindow.cpp: port to new debugging feature of PulseManager. new 203aede src/pulsemanager.h: fix compile error due to mismatching function declaration for set_debug (). new e4691a2 res/sound: add startup.wav sound to be played back when starting the PA daemon in debug mode. new 7865b56 src/pulsemanager.cpp: don't time out while trying to start PA or paplay. new 796b5b6 macbuild.sh: add support for copying resource files. new 1fccb2d res: rename "sound" to "audio". new 066655a macbuild.sh: fix copying of resource files. new 015b521 macbuild.sh: also add PA binaries to deduplication fixup list. new d94eadf macbuild.sh: don't error out while executing parse_otool_output (). new 8db27c1 macbuild.sh: save return value of parse_otool_output (). new 56171d7 src/pulsemanager.cpp: fix typo in fetch_pulseaudio_version (). new f206423 src/pulsemanager.cpp: don't overwrite the temporary string variable for the current line with what was supposed to hold new data in fetch_pulseaudio_version (). new 4192bab src/pulsemanager.{cpp,h}: rename on_pulse_finished () to slot_on_pulse_finished (). new d987d6d src/pulsemanager.cpp: actually only play startup sound if debugging is enabled. new 665823a src/pulsemanager.cpp: don't insert stray newline into config.pa. new 967a839 src/pulsemanager.cpp: insert PULSE_SERVER and PULSE_COOKIE variables into environment as used by PulseManager. new a0bc125 src/pulsemanager.cpp: don't remove PA config and log file in ~/.x2go/pulse on PA shutdown if debugging has been requested. new 9f298d9 src/x2goutils.{cpp,h}: add new function find_binary (). new 1a34ea4 src/pulsemanager.cpp: auto-detect PA binary in $PATH and MacPorts default prefix as well on OS X. new 3417610 src/pulsemanager.cpp: add comments to Qt 4 code part. new 86c9541 src/pulsemanager.cpp: add reminder for Linux-implementation in play_startup_sound (). new 239ede4 src/x2goutils.cpp: fix compile error. new 01dde02 src/pulsemanager.h: add new system_pulse_ variable to indicate that a system PA binary shall be used. new 7b4d671 src/pulsemanager.cpp: correctly initialize and set system_pulse_ when required. new 5f0e2cb src/x2goutils.{cpp,h}: add application modality parameter to show_RichText_Generic_MsgBox () and its wrappers. new fa0c8de src/pulsemanager.cpp: add error message boxes throughout PulseManager. new 861f990 src/x2goutils.h: fix compile error due to typo. new ebc5bdd debian/changelog: fix typo in function name. new 1318656 src/pulsemanager.cpp: fix compile error on Windows. new 7768dfc src/pulsemanager.cpp: fix startup when using the system-PA version. new 126e4a8 src/pulsemanager.cpp: fix startup sound playback when using the system-PA version. new 6719756 src/pulsemanager.cpp: add warning message boxes where appropriate. new 4dec14f src/pulsemanager.cpp: remove extraneous newlines from debug output. new 38e6efd src/x2goutils.cpp: fix faulty logic in find_binary (): only reset the given path to CWD iff it's actually empty. Not the other way around. new a279b70 src/x2goutils.cpp: add some debug logging to find_binary (). new 23d0e4e nsis/x2goclient.nsi: add startup.wav to installer package. new dc56238 src/: new file windows_stdint.h for Windows-compatibility when using std::(u)int*_t types. new 62fffcf src/pulsemanager.h: use windows_stdint.h header on Windows, cstdint otherwise. new 37c2f8b src/onmainwindow.cpp: short out code parts unconditionally checking for the userSshd variable. new 73dc547 src/onmainwindow.cpp: drop obsolete pulseVersionTest variable initialization in Windows-only code. new 5862ae1 src/onmainwindow.cpp: drop obsolete pulseVersionIsLegacy variable initialization in Windows-only code. new d0b0af4 src/onmainwindow.cpp: add another pair of braces to in_addr-type variable initialization on Windows to silence compiler warning. new 90c0da3 src/onmainwindow.cpp: fix compile error on Windows after moving some code around. new cbdb450 src/onmainwindow.cpp: use correct C++ universal initializer for initializing in_addr-type variable, the C-style universal zero initializer won't cut it here. new b4bef6a src/pulsemanager.h: include accidentally omitted wapi.h header file. new 1b466dc src/pulsemanager.cpp: make PA version parsing function more generic and don't expect that a number is always terminated with a period or dash. new 0620fd7 src/pulsemanager.cpp: make sure that wherever we interface with non-Qt functions, paths are in native form (i.e., containing empty separators, instead of the "generic" slash UNIX-style separator.) new 1e7bc07 src/pulsemanager.cpp: fix PA version fetching on OS X again. new 0518893 src/unixhelper.{cpp,h}: make argument of kill_pgroup () const. new c0d1921 src/unixhelper.h: style and general fixes within comments. new a193a4c src/unixhelper.{cpp,h}: split off core functionality of kill_pgroup () into a new function called real_kill_pgroup (). new 8c011d9 src/unixhelper.{cpp,h}: rewrite kill_pgroup () to act as a wrapper around real_kill_pgroup (). new e04e71a src/pulsemanager.cpp: remove unused variables. new 6fe0ef0 src/unixhelper.cpp: code cleanup. new 5078b83 src/{unixhelper.cpp,x2goclient.cpp}: fix errno usage - save before use. new cf97425 src/onmainwindow.cpp: document createRSAKey () because what it does is completely non-obvious. new 34fa207 src/onmainwindow.cpp: add support for explicitly setting the private key bit size based on type and use values (currently) regarded as secure to generateHostKey (). new 2685544 src/onmainwindow.{cpp,h}: rename generateHostKey () to generateKey () and add a boolean parameter with a default of false to request a public key. new 994a129 src/onmainwindow.cpp: refactor generateKey () a little bit to compact it. new e94e94e src/onmainwindow.{cpp,h}: rewrite generateKey () function to actually also generate user keys. new 0eaec37 src/onmainwindow.cpp: add more error handling to generateKey () and fix up a broken error-handling section. new 1111f95 src/onmainwindow.cpp: fix up a few debug strings. new fc842aa src/{onmainwindow.{cpp,h},configdialog.cpp}: remove userSshd variable and code related to non-user-mode-sshd setups. new 88134de src/onmainwindow.cpp: when starting sshd on Unix-based plattforms, raise maximum startup time to 5 seconds and break out early, if the process went into running state earlier. new 5307708 src/onmainwindow.cpp: uppercase key type in debug output and comment string in generateKey (). new a0ee3c1 src/onmainwindow.cpp: terminate sshd more correctly. new 33c23e0 src/onmainwindow.{cpp,h}: add new function check_key_type (). new cb59e62 src/onmainwindow.{cpp,h}: add new function key_type_to_string (). new 8f652e7 src/onmainwindow.{cpp,h}: add new function default_size_for_key_type (). new b8878c2 src/onmainwindow.cpp: use the new functions in generateKey (). new 59da4b8 src/onmainwindow.h: move generateKey () declaration around. new 4ee6820 src/onmainwindow.{cpp,h}: reformat generateKey () only. new 07bcb15 src/onmainwindow.{cpp,h}: move createRSAKey () around. new 3b43148 src/onmainwindow.{cpp,h}: reformat createRSAKey () only. new 299f4e1 src/onmainwindow.cpp: let startSshd () act as a wrapper and be called multiple times. new e3439e4 src/onmainwindow.cpp: add some comments only to createRSAKey (). new bb16e81 src/onmainwindow.{cpp,h}: rename createRSAKey () to the more-appropriate name createKeyBundle (). new 4455230 macbuild.sh: switch to bundling PA 9.0. new 290987c src/onmainwindow.cpp: move QProcess startup check in startSshd () to non-Windows code section and add a listening socket check loop. new e5c6396 src/onmainwindow.cpp: add comment to last all-in listening check in startSshd (). new 40b7fda src/onmainwindow.cpp: add listening-check loop to the Windows-specific code of startSshd (). new 5391148 src/onmainwindow.{cpp,h}: make startSshd () private. new 9bce12a src/onmainwindow.{cpp,h}: add ssh_key_type_ member variable and getter and setter to WinServerStarter class. new da7833b src/onmainwindow.{cpp,h}: add SSH key type parameter to startSshd (). new c6567c1 src/onmainwindow.cpp: pass new ssh_key_type_ member to startSshd () call in WinServerStarter::run (). new 7826b3d src/onmainwindow.cpp: pass key_type parameter to startSshd () in createKeyBundle (). new fc24102 src/onmainwindow.cpp: add and use key_types parameter to startWinServers (). new 8c2bb96 src/onmainwindow.cpp: actually use key_type parameter in startSshd () and make selection more generic. new 5dc534f src/onmainwindow.h: move WinServerStarter class definition around to hopefully get the definition of ONMainWindow::key_types. new 1f7051e src/onmainwindow.h: remove WWrapper definition, seems to be unused. new e78ee21 src/onmainwindow.{cpp,h}: don't try to initialize non-static ssh_key_type_ member variable directly, but in the constructor. new 4f4e1a3 src/onmainwindow.cpp: re-order initializer list of WinServerStarter constructor. new c3c8bdf src/onmainwindow.h: actually, we do need startSshd () to be public. Move it back. new 642e4c5 src/onmainwindow.cpp: only pass non-Cygwin paths to QFile::exists () in generateKey (). new efb8da2 src/onmainwindow.cpp: use QFileInfo to get the key file's basename in exportDirs () instead of the old, potentially faulty string replace dance. new 1cfcd80 src/x2goutils.{cpp,h}: make find_binary () and add_to_path () available on all UNIX-based operating systems. new 4cd32bc src/pulsemanager.cpp: refactor PA binary searching code. new ae89ac6 src/onmainwindow.cpp: fix sshd_config generation on UNIX by searching for the real sftp-server binary path. new 6e986e2 src/pulsemanager.cpp: fix PA binary searching logic. new e440f47 src/onmainwindow.cpp: move generateEtcFiles () call to startSshd (). new 777cec1 src/onmainwindow.cpp: stop duplicating the list of known sftp-server binary locations. new 2779177 src/{onmainwindow,pulsemanager}.cpp: actually *use* what we got back from add_to_path ()... new 818163d src/onmainwindow.cpp: remove trailing slash from Mageia/SUSE/Arch sftp-server binary search path. new 201f9dd src/x2goutils.cpp: add debugging output to add_to_path (). new 44bdd1a src/x2goutils.cpp: fix add_to_path (). new 4499dc9 src/unixhelper.cpp: use cstdio instead of stdio.h. new a13b92c src/: create new file unix_stdint.h which imports the (u)int*_t types into the std namespace. new cb661f8 src/pulsemanager.h: use unix_stdint.h on non-Windows-platforms to get std::(u)int*_t types without having to use C++11. new 51d13bb src/pulsemanager.cpp: fix Linux-based code by fixing a really stupid typo ("erange" instead of "errno") and including the cerrno header. new 6d186eb src/pulsemanager.cpp: use std::ssize_t for the path length, because it could be -1 and std::size_t is not applicable. new 15ff67d src/pulsemanager.cpp: cast the return value of realloc () to char*, as GCC doesn't seem to like reassigning the pointer otherwise. new 856b009 src/unix_stdint.h: use same hack to import ssize_t into std namespace. new 882adda src/onmainwindow.{cpp,h}: remove left-over parec references and code. new c1b1a67 src/onmainwindow.cpp: convert piece of code to non-Windows and non-Darwin, so that not only Linux but other operating systems are covered as well. new 9c61957 src/mediawidget.cpp: unify some redundant code. new 8a5e3e5 src/mediawidget.cpp: simplify expression. new 6648940 src/mediawidget.cpp: add deprecation warning for ARTS. new 34e372f src/mediawidget.cpp: add deprecation warning for ESounD. This update added new revisions after undoing existing revisions. That is to say, some revisions that were in the old version of the branch are not in the new version. This situation occurs when a user --force pushes a change and generates a repository containing something like this: * -- * -- B -- O -- O -- O (f6351af) \ N -- N -- N refs/heads/bugfix/osx (34e372f) You should already have received notification emails for all of the O revisions, and so the following emails describe only the N revisions from the common base, B. Any revisions marked "omits" are not gone; other references still refer to them. Any revisions marked "discards" are gone forever. The 280 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "adds" were already present in the repository and have only been added to this reference. Summary of changes: debian/changelog | 20 ++++++++++++++++++++ res/img/svg/hamburger.svg | 18 ++++++++++++++++++ res/resources.qrc | 1 + src/onmainwindow.cpp | 38 ++++++++++++++++++++++++++++++++++++-- src/onmainwindow.h | 3 ++- src/sessionbutton.cpp | 24 ++++++++++++++++++++---- 6 files changed, 97 insertions(+), 7 deletions(-) create mode 100644 res/img/svg/hamburger.svg -- Alioth's /srv/git/code.x2go.org/x2goclient.git//..//_hooks_/post-receive-email on /srv/git/code.x2go.org/x2goclient.git