This is an automated email from the git hooks/post-receive script. x2go pushed a commit to branch master in repository buildscripts. commit 93057bc254892fffd32315166e0a4ce98ac8f014 Author: Mihai Moldovan <ionic@ionic.de> Date: Sat Oct 29 01:15:38 2016 +0200 bin/build-rpm-package: add comment to explain why caching is a good thing to the create_mock_config () comment. --- bin/build-rpm-package | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/bin/build-rpm-package b/bin/build-rpm-package index 9005137..57b7787 100755 --- a/bin/build-rpm-package +++ b/bin/build-rpm-package @@ -240,6 +240,14 @@ check_mock_version_atleast () { # Base refers to adding x2go-extras only, while full means also # adding the full X2Go upstream repository with all published files. # +# The file will be created in a temporary directory with a temporary name and +# removed together with the directory upon script termination. +# This creates a huge problem: as mock checks the config file's modification time +# to determine if it cache is usable and discards the whole cache if the file's +# modification time is newer than the cache creation time, each build will +# discard the cache and subsequently rebuild it. The I/O stress caused by this +# is high enough to warrant the implementation of a caching feature here... +# # Calling this function in a subshell is an error, as it NEEDS to modify # variables in global scope! create_mock_config () { # MOCK_BASE CUSTOM_REPO COMPONENT TARGET -- Alioth's /srv/git/code.x2go.org/buildscripts.git//..//_hooks_/post-receive-email on /srv/git/code.x2go.org/buildscripts.git