x2go-commits August 2013

x2go-commits@lists.x2go.org

2 participants
2119 discussions

page changed: doc:organigram
by wiki-admin＠x2go.org 30 Aug '13

30 Aug '13

A page in your DokuWiki was added or changed. Here are the details: Date : 2013/08/30 20:22 Browser : Mozilla/5.0 (X11; Linux x86_64; rv:23.0) Gecko/20100101 Firefox/23.0 IP-Address : 4.28.99.98 Hostname : NORTHWEST-R.edge3.Denver1.Level3.net Old Revision: http://wiki.x2go.org/doku.php/doc:organigram?rev=1377602097 New Revision: http://wiki.x2go.org/doku.php/doc:organigram Edit Summary: [Core Developers] Fix typo User : orion @@ -27,9 +27,9 @@ Contact: [[x2go-dev(a)… [View More]

1 0

nx-libs.git - build-baikal (branch) updated: redist-client/3.5.0.20-17-g13f2b57
by git-admin＠x2go.org 30 Aug '13

30 Aug '13

The branch, build-baikal has been updated via 13f2b57d421b6a5ee71effaa6e5da17b1554ac4e (commit) from 0946b437570dea31365790d5cbf39c39f1b59c02 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- ----------------------------------------------------------------------- Summary of changes: debian/… [View More]changelog | 2 ++ debian/keystrokes.cfg | 32 ++++++++++++++++---------------- 2 files changed, 18 insertions(+), 16 deletions(-) The diff of changes is: diff --git a/debian/changelog b/debian/changelog index b523ee1..401f334 100644 --- a/debian/changelog +++ b/debian/changelog @@ -14,6 +14,8 @@ nx-libs (2:3.5.0.21-0) UNRELEASED; urgency=low + Add B-Ds: libfontconfig1-dev, libfontenc-dev. * /debian/nx-libs-dev.install: + Remove unrelated files from -dev package. + * Fix keystrokes.cfg, use Ctrl+Alt+<key> instead of just Ctrl+<key>. (Adds to + fixing #223). [ Orion Poplawski ] * Change build options so that bundled libraries are not used anymore at diff --git a/debian/keystrokes.cfg b/debian/keystrokes.cfg index 9385459..a5e5210 100644 --- a/debian/keystrokes.cfg +++ b/debian/keystrokes.cfg @@ -1,19 +1,19 @@ <!DOCTYPE NXKeystroke> <keystrokes> -<keystroke action="close_session" Control="1" key="t" /> -<keystroke action="switch_all_screens" Control="1" key="f" /> -<keystroke action="minimize" Control="1" key="m" /> -<keystroke action="resize" Control="1" key="r" /> -<keystroke action="defer" Control="1" key="e" /> -<keystroke action="ignore" Control="1" key="BackSpace" /> -<keystroke action="force_synchronization" Control="1" key="j" /> -<keystroke action="debug_tree" Control="1" key="q" /> -<keystroke action="regions_on_screen" Control="1" key="a" /> -<keystroke action="test_input" Control="1" key="x" /> -<keystroke action="deactivate_input_devices_grab" Control="1" key="y" /> -<keystroke action="fullscreen" Control="1" Shift="1" key="f" /> -<keystroke action="viewport_move_left" Control="1" Shift="1" key="Left" /> -<keystroke action="viewport_move_up" Control="1" key="Up" /> -<keystroke action="viewport_move_right" Control="1" key="Right" /> -<keystroke action="viewport_move_down" Control="1" key="Down" /> +<keystroke action="close_session" Control="1" AltMeta= "1" key="t" /> +<keystroke action="switch_all_screens" Control="1" AltMeta= "1" key="f" /> +<keystroke action="minimize" Control="1" AltMeta= "1" key="m" /> +<keystroke action="resize" Control="1" AltMeta= "1" key="r" /> +<keystroke action="defer" Control="1" AltMeta= "1" key="e" /> +<keystroke action="ignore" Control="1" AltMeta= "1" key="BackSpace" /> +<keystroke action="force_synchronization" Control="1" AltMeta= "1" key="j" /> +<keystroke action="debug_tree" Control="1" AltMeta= "1" key="q" /> +<keystroke action="regions_on_screen" Control="1" AltMeta= "1" key="a" /> +<keystroke action="test_input" Control="1" AltMeta= "1" key="x" /> +<keystroke action="deactivate_input_devices_grab" Control="1" AltMeta= "1" key="y" /> +<keystroke action="fullscreen" Control="1" Shift="1" AltMeta= "1" key="f" /> +<keystroke action="viewport_move_left" Control="1" Shift="1" AltMeta= "1" key="Left" /> +<keystroke action="viewport_move_up" Control="1" AltMeta= "1" key="Up" /> +<keystroke action="viewport_move_right" Control="1" AltMeta= "1" key="Right" /> +<keystroke action="viewport_move_down" Control="1" AltMeta= "1" key="Down" /> </keystrokes> hooks/post-receive -- nx-libs.git (NX (redistributed)) This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "nx-libs.git" (NX (redistributed)). [View Less]

1 0

nx-libs.git - build-baikal (branch) updated: redist-server/3.5.0.21
by git-admin＠x2go.org 30 Aug '13

30 Aug '13

The branch, build-baikal has been updated via b2a3143f8a9c2d5aaf20c14408354ef9a712a3ee (commit) from 13f2b57d421b6a5ee71effaa6e5da17b1554ac4e (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- ----------------------------------------------------------------------- Summary of changes: debian/… [View More]

1 0

nx-libs.git - build-baikal (branch) updated: redist-server/3.5.0.21-1-gb29654d
by git-admin＠x2go.org 30 Aug '13

30 Aug '13

The branch, build-baikal has been updated via b29654d5421008e8aab89902ea2ee528990681c8 (commit) from b2a3143f8a9c2d5aaf20c14408354ef9a712a3ee (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- ----------------------------------------------------------------------- Summary of changes: debian/… [View More]

1 0

nx-libs.git - build-baikal (branch) updated: redist-client/3.5.0.20-15-ge46b434
by git-admin＠x2go.org 30 Aug '13

30 Aug '13

The branch, build-baikal has been updated via e46b43443fd45fa3f3196df34ba7efe8bff423a3 (commit) from 2a41a2ca5177d9dc7949b0195dd27a2ecbfa1912 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- ----------------------------------------------------------------------- Summary of changes: ...hanges-… [View More]

1 0

nx-libs.git - build-baikal (branch) updated: redist-client/3.5.0.20-16-g0946b43
by git-admin＠x2go.org 30 Aug '13

30 Aug '13

The branch, build-baikal has been updated via 0946b437570dea31365790d5cbf39c39f1b59c02 (commit) from e46b43443fd45fa3f3196df34ba7efe8bff423a3 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- ----------------------------------------------------------------------- Summary of changes: debian/… [View More]changelog | 5 ++ debian/patches/602_nx-X11_initgroups.full.patch | 67 +++++++++++++++++++++++ debian/patches/series | 1 + 3 files changed, 73 insertions(+) create mode 100644 debian/patches/602_nx-X11_initgroups.full.patch The diff of changes is: diff --git a/debian/changelog b/debian/changelog index 2242a75..b523ee1 100644 --- a/debian/changelog +++ b/debian/changelog @@ -19,6 +19,11 @@ nx-libs (2:3.5.0.21-0) UNRELEASED; urgency=low * Change build options so that bundled libraries are not used anymore at build time. Remove bundled libraries from rolled tarballs, as well. (Fixes: #238). + * Add patch: 602_nx-X11_initgroups.full.patch. Fix calling setuid and setgid + without setgroups or initgroups. There is a high probability this means it + didn't relinquish all groups, and this would be a potential security issue + to be fixed. Seek POS36-C on the web for details about the problem. (Fixes: + #293). -- Mike Gabriel <mike.gabriel(a)das-netzwerkteam.de> Thu, 28 Mar 2013 21:07:42 +0100 diff --git a/debian/patches/602_nx-X11_initgroups.full.patch b/debian/patches/602_nx-X11_initgroups.full.patch new file mode 100644 index 0000000..182b378 --- /dev/null +++ b/debian/patches/602_nx-X11_initgroups.full.patch @@ -0,0 +1,67 @@ +Description: Be compliant with POS36-C: Observe correct revocation order while relinquishing privileges +Author: Orion Poplawski <orion(a)cora.nwra.com> +Abstract: + The Fedora review of NX (redistributed) caught the following rpmlint issue: + . + This executable is calling setuid and setgid without setgroups or initgroups. + There is a high probability this mean it didn't relinquish all groups, and this + would be a potential security issue to be fixed. Seek POS36-C on the web for + details about the problem. + . + Ref POS36-C: + https://www.securecoding.cert.org/confluence/display/seccode/POS36-C.+Obser… + . + This patch adds initgroups() calls to the code to initialize the supplemental group list. +diff --git a/nx-X11/programs/Xserver/os/utils.c b/nx-X11/programs/Xserver/os/utils.c +index 7e62654..9b2431a 100644 +--- a/nx-X11/programs/Xserver/os/utils.c ++++ b/nx-X11/programs/Xserver/os/utils.c +@@ -112,6 +112,9 @@ OR PERFORMANCE OF THIS SOFTWARE. + #include <sys/stat.h> + #include <ctype.h> /* for isspace */ + #include <stdarg.h> ++#include <sys/types.h> ++#include <grp.h> ++#include <pwd.h> + + #if defined(DGUX) + #include <sys/resource.h> +@@ -1770,6 +1773,7 @@ System(char *command) + void (*csig)(int); + #endif + int status; ++ struct passwd *pwent; + + if (!command) + return(1); +@@ -1791,6 +1795,9 @@ System(char *command) + case -1: /* error */ + p = -1; + case 0: /* child */ ++ pwent = getpwuid(getuid()); ++ if (initgroups(pwent->pw_name,getgid()) == -1) ++ _exit(127); + if (setgid(getgid()) == -1) + _exit(127); + if (setuid(getuid()) == -1) +diff --git a/nxcomp/Pipe.cpp b/nxcomp/Pipe.cpp +index 7238d0c..aacbbae 100644 +--- a/nxcomp/Pipe.cpp ++++ b/nxcomp/Pipe.cpp +@@ -21,6 +21,7 @@ + #include <pwd.h> + #include <sys/types.h> + #include <sys/wait.h> ++#include <grp.h> + + #include "Pipe.h" + #include "Misc.h" +@@ -234,6 +235,8 @@ FILE *Popen(char * const parameters[], const char *type) + // Child. + // + ++ struct passwd *pwent = getpwuid(getuid()); ++ if (pwent) initgroups(pwent->pw_name,getgid()); + setgid(getgid()); + setuid(getuid()); + diff --git a/debian/patches/series b/debian/patches/series index 2d95bf5..8c5eebd 100644 --- a/debian/patches/series +++ b/debian/patches/series @@ -47,6 +47,7 @@ 302_nxagent_configurable-keystrokes.full.patch 600_nx-X11+nxcompext+nxcompshad_unique-libnames.full.patch 601_nx-X11_build-option-changes-to-not-use-bundled-libraries.full.patch +602_nx-X11_initgroups.full.patch 999_nxagent_unbrand-nxagent-brand-x2goagent.full.patch 016_nx-X11_install-location.debian.patch 102_xserver-xext_set-securitypolicy-path.debian.patch hooks/post-receive -- nx-libs.git (NX (redistributed)) This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "nx-libs.git" (NX (redistributed)). [View Less]

1 0

nx-libs.git - build-baikal (branch) updated: redist-client/3.5.0.20-13-g19ef7a2
by git-admin＠x2go.org 30 Aug '13

30 Aug '13

The branch, build-baikal has been updated via 19ef7a2ca7cbfb12269f75f5c3b19bae7665276e (commit) from 9113131a7d3ff7e6ec922b45c6bc9b08af4e7880 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- ----------------------------------------------------------------------- Summary of changes: debian/… [View More]

1 0

nx-libs.git - build-baikal (branch) updated: redist-client/3.5.0.20-14-g2a41a2c
by git-admin＠x2go.org 30 Aug '13

30 Aug '13

The branch, build-baikal has been updated via 2a41a2ca5177d9dc7949b0195dd27a2ecbfa1912 (commit) from 19ef7a2ca7cbfb12269f75f5c3b19bae7665276e (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- ----------------------------------------------------------------------- Summary of changes: debian/… [View More]

1 0

nx-libs.git - build-baikal (branch) updated: redist-client/3.5.0.20-6-gee35c3f
by git-admin＠x2go.org 30 Aug '13

30 Aug '13

The branch, build-baikal has been updated via ee35c3ff93ee328fee93d6447bdd514bccbf392d (commit) from e0fb697e9f86ff2e734a7530b5f4096ec1668c14 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- ----------------------------------------------------------------------- Summary of changes: debian/… [View More]

1 0

nx-libs.git - build-baikal (branch) updated: redist-client/3.5.0.20-11-gd90c457
by git-admin＠x2go.org 30 Aug '13

30 Aug '13

The branch, build-baikal has been updated via d90c457c4dd216c1baa11c8d1a991e21e83562bf (commit) from ead1e823aeb71e0e2e6742124cc485252699b22a (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- ----------------------------------------------------------------------- Summary of changes: debian/… [View More]changelog | 2 ++ debian/keystrokes.cfg | 24 ++++++++++++++++-------- 2 files changed, 18 insertions(+), 8 deletions(-) The diff of changes is: diff --git a/debian/changelog b/debian/changelog index ee527a7..32c4712 100644 --- a/debian/changelog +++ b/debian/changelog @@ -2,6 +2,8 @@ nx-libs (2:3.5.0.21-0) UNRELEASED; urgency=low * Provide a default keystrokes.cfg in /etc/nx (for nxagent) and /etc/x2go (for x2goagent). (Fixes: #199). + * Use a keystrokes.cfg that reflects the normally hard-coded defaults of + a vanilla nxagent. (Fixes: #223). * Set NXAGENT_KEYSTROKEFILE to /etc/x2go/keystrokes.cfg for wrapper x2goagent. * For vanilla nxagent move keystrokes.cfg from /etc/nx to /etc/nxagent. * Tarball roller script: diff --git a/debian/keystrokes.cfg b/debian/keystrokes.cfg index 734293a..9385459 100644 --- a/debian/keystrokes.cfg +++ b/debian/keystrokes.cfg @@ -1,11 +1,19 @@ <!DOCTYPE NXKeystroke> <keystrokes> -<keystroke action="fullscreen" AltMeta="1" Control="1" key="b" /> -<keystroke action="minimize" AltMeta="1" Control="1" key="space" /> -<keystroke action="minimize" key="Escape" Shift="1" /> -<keystroke action="close_session" key="F7" /> -<keystroke action="fullscreen" key="F7" Mod1="1" /> -<keystroke action="fullscreen" key="F6" Mod1="1" /> -<keystroke action="force_synchronization" key="f" /> -<keystroke action="fullscreen" key="space" Mod1="0" Mod2="0" Control="0" Shift="0" AltMeta="0" /> +<keystroke action="close_session" Control="1" key="t" /> +<keystroke action="switch_all_screens" Control="1" key="f" /> +<keystroke action="minimize" Control="1" key="m" /> +<keystroke action="resize" Control="1" key="r" /> +<keystroke action="defer" Control="1" key="e" /> +<keystroke action="ignore" Control="1" key="BackSpace" /> +<keystroke action="force_synchronization" Control="1" key="j" /> +<keystroke action="debug_tree" Control="1" key="q" /> +<keystroke action="regions_on_screen" Control="1" key="a" /> +<keystroke action="test_input" Control="1" key="x" /> +<keystroke action="deactivate_input_devices_grab" Control="1" key="y" /> +<keystroke action="fullscreen" Control="1" Shift="1" key="f" /> +<keystroke action="viewport_move_left" Control="1" Shift="1" key="Left" /> +<keystroke action="viewport_move_up" Control="1" key="Up" /> +<keystroke action="viewport_move_right" Control="1" key="Right" /> +<keystroke action="viewport_move_down" Control="1" key="Down" /> </keystrokes> hooks/post-receive -- nx-libs.git (NX (redistributed)) This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "nx-libs.git" (NX (redistributed)). [View Less]

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

x2go-commits August 2013