[X2Go-Dev] Bug#499: Fwd: [Bug 1097757] New: [abrt] x2goclient: QString(): x2goclient killed by SIGSEGV
Mihai Moldovan
ionic at ionic.de
Wed Mar 1 08:18:30 CET 2017
On 14.05.2014 04:53 PM, Orion Poplawski wrote:
> Package: x2goclient
> Version: 4.0.2.0
>
> Looks like:
>
> #1 id (this=0x0) at ../sessionbutton.h:39
> No locals.
> #2 ONMainWindow::slotSuspendSess (this=this at entry=0x1ad1ab0) at
> ../onmainwindow.cpp:4620
>
> X2goSettings st ( "sessions" );
> QString sid=lastSession->id();
>
> lastSession is null and not being checked. Probably applies to other parts of
> the code as well.
I don't know if that's still a problem, since the session manager/explorer
feature was added in the meantime, but I've tried to add guards to most
locations, except where it was obvious that getLastSession() must return
non-NULL because we already checked it before.
Should it ever actually be NULL, at least it shouldn't crash (at this point) any
longer, but I admit that I don't know how the client behaves when just returning
out of these functions without doing its work.
Mihai
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 884 bytes
Desc: OpenPGP digital signature
URL: <http://lists.x2go.org/pipermail/x2go-dev/attachments/20170301/5959196a/attachment.pgp>
More information about the x2go-dev
mailing list