[X2Go-Dev] Bug#1051: failing .deb builds due to flaw in code-to-version conversion scripts

Mike Gabriel mike.gabriel at das-netzwerkteam.de
Mon Jul 4 14:40:16 CEST 2016


Package: buildscripts
Severity: important

Hi Mihai,

I have played with X2Go Server a little today, trying to get the new  
execution logic for nxagent/x2goagent into X2Go Server 4.1.0.0. While  
doing that, I stumbled over build failures due to a flaw in the  
buildscripts.

This fixes the occurring issues:

```
jenkins at japsand:~/buildscripts$ git diff
diff --git a/bin/debian-codename-to-version.sh  
b/bin/debian-codename-to-version.sh
index 8bd0384..315fcbd 100755
--- a/bin/debian-codename-to-version.sh
+++ b/bin/debian-codename-to-version.sh
@@ -76,7 +76,5 @@ case "${codename}" in
         ("rex") echo "1.2";;
         ("buzz") echo "1.1";;

-       (*) ret="1";;
+       (*) echo "1";;
  esac
-
-return "${ret}"
diff --git a/bin/ubuntu-codename-to-version.sh  
b/bin/ubuntu-codename-to-version.sh
index 943e130..f0c1418 100755
--- a/bin/ubuntu-codename-to-version.sh
+++ b/bin/ubuntu-codename-to-version.sh
@@ -66,7 +66,5 @@ case "${codename}" in
         ("hoary") echo "5.04";;
         ("warty") echo "4.10";;

-       (*) ret="1";;
+       (*) echo "1";;
  esac
-
-return "${ret}"
```

light+love
Mike
-- 

DAS-NETZWERKTEAM
mike gabriel, herweg 7, 24357 fleckeby
mobile: +49 (1520) 1976 148
landline: +49 (4354) 8390 139

GnuPG Fingerprint: 9BFB AEE8 6C0A A5FF BF22  0782 9AF4 6B30 2577 1B31
mail: mike.gabriel at das-netzwerkteam.de, http://das-netzwerkteam.de

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 819 bytes
Desc: Digitale PGP-Signatur
URL: <http://lists.x2go.org/pipermail/x2go-dev/attachments/20160704/94e78c2b/attachment.pgp>


More information about the x2go-dev mailing list