[X2Go-Dev] Patch to support Qt5 as well as Qt4

[Sébastien Ducoulombier]

Mihai Moldovan wrote :
> The only problem I see with it is that all instances of QString::toAscii () have
> been replaced by QString::toUtf8 (). Personally, I like the idea of porting
> things to UTF-8, but fear side-effects in terms of passing UTF-8-encoded strings
> to other interfaces that actually expect ASCII (or really a plain 8bit encoding.)
> 
> Hence, I'd like to modify all these occurrences with QString::toLatin1 () for
> now. At the same time, I think your original patch serves as a great reference
> as to what locations can potentially be rather ported to using UTF-8. I'll need
> to examine where this is actually possible more accurately at a later time.
> 
> Does this make sense to you? Are there any objections?

It does make sense and I have no objection.


--
Sébastien