[X2Go-Dev] Bug#928: x2goclient 4.0.5.0 overwrites user's shell

[Orion Poplawski]

Package: x2goclient
Version: 4.0.5.0
Tags: patch

See https://bugzilla.redhat.com/show_bug.cgi?id=1256799

Description of problem:
After upgrading x2goclient my system assigned shell of /bin/zsh is ignored and
forcefully set to /bin/bash

The shift to running everything under /bin/bash had the side effect of setting
SHELL to /bin/bash, which is then what terminal emulators and others use for
spawning shells.

If we specify -l to bash it runs as a login shell, sources the proper startup
files and sets SHELL to whatever getpwent() returns for the login shell.

However, this also opens the door for things like ~/.bash_logout to get run
which executes "clear", which emits:

TERM environment variable not set.

when TERM is empty as it is here.  So we also set TERM=dumb to work around that.


It might be nice to add the ability to distinguish between a session startup
command and other utility commands (x2gomountdirs, etc.) and only add -l to
the session startup commands.  This is probably more appropriate.

-- 
Orion Poplawski
Technical Manager                     303-415-9701 x222
NWRA, Boulder/CoRA Office             FAX: 303-415-9702
3380 Mitchell Lane                       orion at nwra.com
Boulder, CO 80301                   http://www.nwra.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: x2goclient-shell.patch
Type: text/x-patch
Size: 1783 bytes
Desc: not available
URL: <http://lists.x2go.org/pipermail/x2go-dev/attachments/20150825/834a640d/attachment.bin>