[X2Go-Dev] Need advice on fixing x2goclient bug #109

[Oleksandr Shneyder]

Hi Mike,

this looks good to me. To avoid infinite loop you have two options. You
can check if user pressed "OK" or "Cancel" button in config dialog and
if user pressed "Cancel" quit loop. Or you can steel use
QMessageBox::critical with more as one standard button (for example
"Retry"|"Quit" instead of "Ok") and examine button pressed by user.

regards
Alex

Am 24.06.2014 16:21, schrieb Michael DePaulo:
> On Wed, Jun 11, 2014 at 10:16 AM, Michael DePaulo <mikedep333 at gmail.com> wrote:
>> Hi Alex, Mike, and anyone else who is familiar with the x2goclient code,
>>
>> I think I have an idea of how to solve bug 109, let me know if it
>> seems feasible:
>> http://bugs.x2go.org/cgi-bin/bugreport.cgi?bug=109
>>
>> Remember that I am not very experienced with C++.
>>
>> 1. For comparison, it appears that if your LDAP settings are incorrect
>> at x2goclient launch, then the settings menu opens up for you to
>> correct them. Am I correct?
>> 2. I would like to do the same with the X server settings on Windows.
>> 3. The error message (not a crash message) that was reported in bug
>> #109 is in ONMainWindow::getXDisplay()
>> 4. Currently, after that error message is shown, the QT function
>> close() is called to close x2goclient altogether.
>> 5. I figured I would replace the call to close() with a call to
>> slotConfig(), and then startXOrg(). This would open up the settings
>> menu, and then it would try to restart the X server, correct?
>> 6. Also, I would put a loop in getXDisplay() in case the user sets
>> incorrect X server settings (or doesn't change them at all).
>> 7. To avoid a possibly infinite loop, the error message would have an
>> option to exit x2goclient entirely rather than fixing the settings. I
>> think I would need to replace QMessageBox::critical with another
>> class.
>>
>> -Mike#2
> 
> Any thoughts? I would like to work on this after 4.0.2.1.
> 


-- 
-----------------------------------------------------------
Oleksandr Shneyder        | Email: o.shneyder at phoca-gmbh.de
phoca GmbH                | Tel. : 0911 - 14870374 0
Ludwig-Feuerbach-str. 18  | Fax. : 0911 - 14870374 9
D-90489 Nürnberg          | Mobil: 0163 - 49 64 461

Geschäftsführung:
Dipl.-Inf. Oleksandr Shneyder

Amtsgericht München | http://www.phoca-gmbh.de
HRB 196 658         | http://www.x2go.org
USt-IdNr.: DE281977973
-----------------------------------------------------------

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 242 bytes
Desc: OpenPGP digital signature
URL: <http://lists.x2go.org/pipermail/x2go-dev/attachments/20140625/fc6d0c20/attachment-0001.pgp>