[X2Go-Dev] nx-libs patches have not been applied in some of the x2goclient win32 releases

[Michael DePaulo]

Hi Developers,

Notice these instructions on the wiki about building nxproxy. I have
never updated them:
http://wiki.x2go.org/doku.php/wiki:development:build-howto-mswin:x2goclient#building_nxproxy

I just realized that if you follow these instructions, which have you
download from git, none of the patches are applied. So I think that
nxproxy (nx-libs-lite) is only at version 3.5.0, not 3.5.0.27.

If you build from the tarball instead, these patches have already been applied:
mikedep333 at X2Go-WinBuilder
/cygdrive/d/Build/TARBALL/nx-libs-3.5.0.27/doc/applied-patches
$ cat series
000_add-NX-redistribution-README.full+lite.patch
005_nxcomp_gcc43.full+lite.patch
006_nxcomp_libpng15.full+lite.patch
008_nxcomp_sa-restorer.full+lite.patch
009_nxproxy_add-man-page.full+lite.patch
012_nxcomp_makefile-uninstall+autoconf.full+lite.patch
015_nxproxy_makefile-uninstall.full+lite.patch
024_fix-make-clean.full+lite.patch
026_nxcomp_honour-optflags.full+lite.patch
027_nxcomp_abstract-X11-socket.full+lite.patch
029_nxcomp_ppc64.full+lite.patch
051_nxcomp_macos105-fdisset.full+lite.patch
052_nxcomp_macos10-nxauth-location.full+lite.patch
210_nxcomp_save_session_state.full+lite.patch
211_nxcomp_set_default_options.full+lite.patch
212_nxcomp_build-on-Android.full+lite.patch
220_nxproxy_bind-loopback-only.full+lite.patch

Unfortunately, since I started doing windows builds (I started with
4.0.1.2-pre01), I have alternated between compiling the
already-patched tarballs and compiling from the unpatched git sources.
And I do not see an easy way to determine which windows releases have
the patches or not. When I run the patched 3.5.0.27 "nxproxy.exe
-version", I only see "3.5.0."

I just compiled 3.5.0.27 from the patched tarball and updated the
X2Go-WinBuilder's files.I then triggered a jenkins build manually.
So this build has the patches:
http://code.x2go.org/releases/binary-win32/x2goclient/heuler/mingw32-4.4/qt-4.8/x2goclient-4.0.2.1-2014.07.02-setup.exe
(timestamp: 02-Jul-2014 04:58 )
build log (for x2goclient, not for nx-libs):
http://jenkins.x2go.org:8080/job/x2goclient+nightly+mingw32-4.4+qt-4.8/107/
And so should all subsequent builds.

Still, I'd like to know how to proceed. Especially in terms of the
x2goclient changelog.

Also, can I stop going out of my way to use libpng 1.2 now? See the
wiki page for what I mean (and note cygwin only has libpng 1.5 in its
repos now.)

-Mike#2

PS, I am hoping that this fixes multiple windows-specific bugs. It
does not fix #496