[X2Go-Dev] Default umask when mounting sshfs tunnel

[Mike Gabriel]

Hi Helmer,

On  Di 22 Okt 2013 18:53:20 CEST, Helmer Teles wrote:

> Just had a problem that when a user moves or copy a file from the mounted
> sshfs dir to a shared directory on the x2goserver, if this is a shared
> folder for a group with respective ACL's we've got a problem with the final
> permissions.
>
> The easy way to solve this is to change the x2gomountdirs to include the
> umask param.
>
> My diff is below.
> Is there any other way ( missed /etc/x2go/* param  that i've missed to
> solve this problem?
>
>
> 34,35d33
> < my $umask="0117";
> <
> 277c275
> <               $msg = "sshfs $code_conv -o idmap=user,uid=`id -u`,gid=`id
> -g`,umask=$umask,ServerAliveInterval=300,Cipher=blowfish,IdentityFile=$key,UserKnownHostsFile=$key.ident
> \"$user\"\@$host:\"@dirs[$i]\" \"$mntpath\" -p $port";
> ---
>>               $msg = "sshfs $code_conv -o idmap=user,uid=`id -u`,gid=`id
> -g`,ServerAliveInterval=300,Cipher=blowfish,IdentityFile=$key,UserKnownHostsFile=$key.ident
> \"$user\"\@$host:\"@dirs[$i]\" \"$mntpath\" -p $port";
> 280c278
> <               if (system("sshfs  $code_conv -o idmap=user,uid=`id
> -u`,gid=`id
> -g`,umask=$umask,ServerAliveInterval=300,Cipher=blowfish,IdentityFile=$key,UserKnownHostsFile=$key.ident
> \"$user\"\@$host:\"@dirs[$i]\" \"$mntpath\" -p $port 2>>~/mounts.log")==0)
> ---
>>               if (system("sshfs  $code_conv -o idmap=user,uid=`id
> -u`,gid=`id
> -g`,ServerAliveInterval=300,Cipher=blowfish,IdentityFile=$key,UserKnownHostsFile=$key.ident
> \"$user\"\@$host:\"@dirs[$i]\" \"$mntpath\" -p $port 2>>~/mounts.log")==0)

Could you resend your patch to the X2Go BTS [1]? Also, please generate  
your diffs with "diff -u" (they then become more readable for the  
human eye). And: please attach the patch as a patch file, don't  
copy+paste it into your mail.

About the configurability of the umask. This could be done in  
/etc/x2go/x2goserver.conf.

Once I have received your patch as a bug report, I will take a look at it.

Greets,
Mike (you tries to standardize patch our workflows...)

[1] http://wiki.x2go.org/doku.php/wiki:bugs
-- 

DAS-NETZWERKTEAM
mike gabriel, herweg 7, 24357 fleckeby
fon: +49 (1520) 1976 148

GnuPG Key ID 0x25771B31
mail: mike.gabriel at das-netzwerkteam.de, http://das-netzwerkteam.de

freeBusy:
https://mail.das-netzwerkteam.de/freebusy/m.gabriel%40das-netzwerkteam.de.xfb
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-keys
Size: 7251 bytes
Desc: ?ffentlicher PGP-Schl?ssel
URL: <http://lists.x2go.org/pipermail/x2go-dev/attachments/20131023/b6335a7e/attachment.key>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digitale PGP-Signatur
URL: <http://lists.x2go.org/pipermail/x2go-dev/attachments/20131023/b6335a7e/attachment.pgp>