[X2Go-Dev] x2godesktopsharing: Full Access not available for other users?

Milan Knížek knizek.confy at gmail.com
Sun Feb 19 21:22:29 CET 2012


Oops, made few mistakes in package names, corrected below.

Sorry,
Milan

V Sun, 19 Feb 2012 21:14:30 +0100
Milan Knížek <knizek.confy at gmail.com> napsáno:

> Hello list!
> 
> I am a bit confused re. the discrepancy between wiki and actual
> behaviour of x2godesktop sharing:
> 
> x the wiki [1] reads that 
>     With the desktopsharing function of X2go you can have full-access
>     the desktop from somebody else...
> 
> x when I (USER_B) connect from a remote machine with x2goclient to
> "local desktop" (USER_A logged in on tty7 of x2goserver), the
> USER_A's session is shown in the lists of sessions available for
> sharing, however the button "Full Access" is greyed-out and cannot be
> clicked. So USER_B is only allowed to view the USER_A's deskto.
> 
> x having looked at x2godesktopsharing.git/sharetray.cpp, I can see
                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
                     x2goclient.git/onmainwindow_part2.cpp

> that this is due to "bShadow->SetEnabled ( user==getCurrentUname()
> );" and have verified that the following patch removes the limitation:
> 
> ===
> --- onmainwindow_part2.cpp<---->2011-11-25 13:08:10.000000000 +0100
> +++ onmainwindow_part2.cpp_mod<>2012-02-19 19:50:36.200838546 +0100
> @@ -1132,7 +1132,7 @@
>                           index.row(),
>                           D_USER ).data().toString();
>          bShadowView->setEnabled ( true );
> -        bShadow->setEnabled ( user==getCurrentUname() );
> +        bShadow->setEnabled ( true );
>      }
>  }
> 
> ===
> 
> Is this intentional behaviour due to the potential security issues
> mentioned here [2] (anyway, the remote user _can_ recompile the
> x2goagent to get rid of the limitation)?
  ^^^^^^^^^
  x2goclient
> 
> 
> [1] http://www.x2go.org/wiki:components:desktop-sharing#usage
> [2]
> http://comments.gmane.org/gmane.linux.terminal-server.x2go.devel/2437
> 
> Regards,
> Milan
> 
> 



-- 
http://www.milan-knizek.net/
About linux and photography (Czech only)
O linuxu a fotografování



More information about the x2go-dev mailing list