[X2go-Dev] BUGS: x2godesktopsharing [SOLVED]

Mike Gabriel mike.gabriel at das-netzwerkteam.de
Wed Sep 28 14:45:53 CEST 2011


Hi devs, esp. Alex,

On Di 14 Jun 2011 00:27:44 CEST Mike Gabriel wrote:

> 1.
> When the x2godesktopsharing tray applet gets killed by SIGTERM (or  
> SIGINT) it does  neither remove its socket file  
> /tmp/x2godesktopsharing_... nor its  lock file...
>
> As a consequence, the x2golistdesktops script returns stale desktop   
> sessions resulting from stale x2godesktopsharing lock/socket files.
>
> x2godesktopsharing only removes its socket/lock files if the   
> ,,Beenden'' item in the applet's tray menu is clicked.

This is now fixed in Git by commit:
http://code.x2go.org/gitweb?p=x2godesktopsharing.git;a=commitdiff;h=cf356157e83da59220ab7af3c8bb71f722b3e754

This was not at all trivial and this posting in the Qt forum helped a  
lot of this:
http://developer.qt.nokia.com/forums/viewthread/1227

> 2.
> When connecting to x2godesktopsharing the x2godesktopsharing applet   
> always shows wrong username:
>
>   (a) session already running as user-a, start x2godesktopsharing
>   (b) connect a shadow session to user-a's session (as user-b)
>   (c) user-a then gets asked if it will accept an incoming connection
>       from user-a(!!!!), here it should ask for user-b instead
>
> The basic question here is a question of concept. I currently only  
> see  this approach:
>
> (i) -> pass another parameter from x2gostartagent to   
> x2godesktopsharing (client
>        mode), this parameter will be a representation of the connecting user
>        name (and maybe gecos field?)
>
>
> It would be good to fix both issues some time in the near future.   
> Apart from these two issues x2godesktopsharing works brilliantly.

This has been fixed by these commits:

http://code.x2go.org/gitweb?p=x2godesktopsharing.git;a=blobdiff;f=sharetray.cpp;h=5563e2d427cee79b5a5e1257946505ccebb9beae;hp=9f42997ad0cce33d5ce3f903e23399fe01b6f399;hb=05b2d0b00809da05a1e9f30ea4b1fdb71612a861;hpb=4cf4a0b2dad35e92ddaac712c9d2b6f513cd4a46

Packages are currently building and ready for testing soon.

@Alex: could you esp. take a closer look at the signal handler code  
(see first topic of this mail).

Greets,
Mike




-- 

DAS-NETZWERKTEAM
mike gabriel, dorfstr. 27, 24245 barmissen
fon: +49 (4302) 281418, fax: +49 (4302) 281419

GnuPG Key ID 0xB588399B
mail: mike.gabriel at das-netzwerkteam.de, http://das-netzwerkteam.de

freeBusy:
https://mail.das-netzwerkteam.de/freebusy/m.gabriel%40das-netzwerkteam.de.xfb
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 490 bytes
Desc: Digitale PGP-Unterschrift
URL: <http://lists.x2go.org/pipermail/x2go-dev/attachments/20110928/2a54829f/attachment.pgp>


More information about the x2go-dev mailing list