[X2Go-Commits] [buildscripts] 01/01: bin/slave-start-{connect, chroot}.sh: nope, PTY allocation directly via ssh is a bad idea.

git-admin at x2go.org git-admin at x2go.org
Sat Nov 25 06:45:54 CET 2017


This is an automated email from the git hooks/post-receive script.

x2go pushed a commit to branch master
in repository buildscripts.

commit fb07e95d423feb90a414865fcf5d5ec8a9fc185f
Author: Mihai Moldovan <ionic at ionic.de>
Date:   Sat Nov 25 06:45:49 2017 +0100

    bin/slave-start-{connect,chroot}.sh: nope, PTY allocation directly via ssh is a bad idea.
    
    Instead, hack around with python to spawn a PTY when we actually need it.
---
 bin/slave-start-chroot.sh  | 2 +-
 bin/slave-start-connect.sh | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/bin/slave-start-chroot.sh b/bin/slave-start-chroot.sh
index 0f98ebd..f51fef5 100755
--- a/bin/slave-start-chroot.sh
+++ b/bin/slave-start-chroot.sh
@@ -22,4 +22,4 @@ fi
 
 "${HOME}/bin/slave-sync.sh"
 
-schroot -c "${chroot}" "bin/${prefix}-slave-start-prepare.sh"
+schroot -c "${chroot}" -- python -c "import pty; pty.spawn('bin/${prefix}-slave-start-prepare.sh')"
diff --git a/bin/slave-start-connect.sh b/bin/slave-start-connect.sh
index db39c78..b791bf8 100755
--- a/bin/slave-start-connect.sh
+++ b/bin/slave-start-connect.sh
@@ -34,4 +34,4 @@ if [ "x$(basename "${0}")" = "x${prefix}-slave-start-connect.sh" ]; then
     esac
 fi
 
-ssh -tt "${user}@${host}" "bin/${prefix}-slave-start-chroot.sh"
+ssh "${user}@${host}" "bin/${prefix}-slave-start-chroot.sh"

--
Alioth's /home/x2go-admin/maintenancescripts/git/hooks/post-receive-email on /srv/git/code.x2go.org/buildscripts.git


More information about the x2go-commits mailing list