[X2Go-Commits] [buildscripts] 01/01: bin/build-rpm-package: disallow hyphens again. Bad idea for greedy regexes, especially when hyphens are used as field separators.

git-admin at x2go.org git-admin at x2go.org
Wed Apr 1 10:33:02 CEST 2015


This is an automated email from the git hooks/post-receive script.

x2go pushed a commit to branch master
in repository buildscripts.

commit 60c5f4b41441ebcfe69bfb4b4864f46011eec5a7
Author: Mihai Moldovan <ionic at ionic.de>
Date:   Wed Apr 1 10:32:48 2015 +0200

    bin/build-rpm-package: disallow hyphens again. Bad idea for greedy regexes, especially when hyphens are used as field separators.
---
 bin/build-rpm-package |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/bin/build-rpm-package b/bin/build-rpm-package
index cc7d304..7c886d0 100755
--- a/bin/build-rpm-package
+++ b/bin/build-rpm-package
@@ -258,7 +258,7 @@ create_mock_config () { # MOCK_BASE CUSTOM_REPO COMPONENT TARGET
 	# Check argument sanity.
 	typeset DISTRO=""
 			   # distribution -   version    - arch
-	typeset TMP_REGEX='^([[:alpha:]]+)-[[:alnum:]_-]+-[[:alnum]_-]+\.cfg$'
+	typeset TMP_REGEX='^([[:alpha:]]+)-[[:alnum:]_]+-[[:alnum]_]+\.cfg$'
 	if [[ ! "${MOCK_BASE}" =~ ${TMP_REGEX} ]]; then
 		echo "Error: MOCK_BASE parameter not well formed. Must be: 'distro-version-arch.cfg'." >&2
 		exit -1

--
Alioth's /srv/git/code.x2go.org/buildscripts.git//..//_hooks_/post-receive-email on /srv/git/code.x2go.org/buildscripts.git


More information about the x2go-commits mailing list