[X2Go-Commits] [python-x2go] 03/07: Performance tests have shown, that enabling SSH compression is not a good idea. NX should handle that instead (and does).

git-admin at x2go.org git-admin at x2go.org
Wed Jun 25 01:30:11 CEST 2014


This is an automated email from the git hooks/post-receive script.

x2go pushed a commit to branch master
in repository python-x2go.

commit dd92083f4351b456f21357e798b5cbbeb842b085
Author: Mike Gabriel <mike.gabriel at das-netzwerkteam.de>
Date:   Tue Jun 24 16:16:00 2014 +0200

    Performance tests have shown, that enabling SSH compression is not a good idea. NX should handle that instead (and does).
---
 debian/changelog               |    2 ++
 x2go/backends/control/plain.py |    2 +-
 x2go/sshproxy.py               |    2 +-
 3 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/debian/changelog b/debian/changelog
index aef8cf1..2cf3eaf 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -70,6 +70,8 @@ python-x2go (0.5.0.0-0x2go1) UNRELEASED; urgency=low
       (suspend/terminate).
     - Only enable Telekinesis client debugging if the logger instance is in
       debug mode.
+    - Performance tests have shown, that enabling SSH compression is not a
+      good idea. NX should handle that instead (and does).
   * debian/control:
     + Add dependencies: python-requests, python-simplejson.
   * python-x2go.spec:
diff --git a/x2go/backends/control/plain.py b/x2go/backends/control/plain.py
index 75b6c11..5409198 100644
--- a/x2go/backends/control/plain.py
+++ b/x2go/backends/control/plain.py
@@ -1066,7 +1066,7 @@ class X2GoControlSession(paramiko.SSHClient):
 
             # since Paramiko 1.7.7.1 there is compression available, let's use it if present...
             if x2go._paramiko.PARAMIKO_FEATURE['use-compression']:
-                ssh_transport.use_compression(compress=True)
+                ssh_transport.use_compression(compress=False)
             # enable keep alive callbacks
             ssh_transport.set_keepalive(5)
 
diff --git a/x2go/sshproxy.py b/x2go/sshproxy.py
index 39a852d..a70f931 100644
--- a/x2go/sshproxy.py
+++ b/x2go/sshproxy.py
@@ -348,7 +348,7 @@ class X2GoSSHProxy(paramiko.SSHClient, threading.Thread):
                 # since Paramiko 1.7.7.1 there is compression available, let's use it if present...
                 t = self.get_transport()
                 if x2go._paramiko.PARAMIKO_FEATURE['use-compression']:
-                    t.use_compression(compress=True)
+                    t.use_compression(compress=False)
                 t.set_keepalive(5)
 
             # if there is no private key, we will use the given password, if any

--
Alioth's /srv/git/_hooks_/post-receive-email on /srv/git/code.x2go.org/python-x2go.git


More information about the x2go-commits mailing list