[X2Go-Commits] [x2goclient] 01/01: Use QUrl::toPercentEncoding() method to properly encode passwords sent to X2Go Session Broker. (Fixes: #705).

[git-admin at x2go.org]

This is an automated email from the git hooks/post-receive script.

x2go pushed a commit to branch master
in repository x2goclient.

commit db7c2f3009d9f39cdf8a85327c632dcb643f631c
Author: Jason Alavaliant <alavaliant at ra09.com>
Date:   Wed Dec 17 11:14:02 2014 +0100

    Use QUrl::toPercentEncoding() method to properly encode passwords sent to X2Go Session Broker. (Fixes: #705).
---
 debian/changelog     |    5 +++++
 httpbrokerclient.cpp |   14 +++++++-------
 2 files changed, 12 insertions(+), 7 deletions(-)

diff --git a/debian/changelog b/debian/changelog
index 1a034f3..1a2701d 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -9,6 +9,11 @@ x2goclient (4.0.3.2-0x2go1) UNRELEASED; urgency=medium
   * New upstream release (4.0.3.2):
     - Provide empty Turkish translation file.
 
+  [ Jason Alavaliant ]
+  * New upstream verson (4.0.3.2):
+    - Use QUrl::toPercentEncoding() method to properly encode passwords sent
+      to X2Go Session Broker. (Fixes: #705).
+
   [ Mike DePaulo ]
   * New upstream release (4.0.3.2):
     - Windows: Fix compatibility with PulseAudio 6.0
diff --git a/httpbrokerclient.cpp b/httpbrokerclient.cpp
index fc4d891..3701c12 100644
--- a/httpbrokerclient.cpp
+++ b/httpbrokerclient.cpp
@@ -251,8 +251,8 @@ void HttpBrokerClient::getUserSessions()
         QString req;
         QTextStream ( &req ) <<
                              "task=listsessions&"<<
-                             "user="<<brokerUser<<"&"<<
-                             "password="<<config->brokerPass<<"&"<<
+                             "user="<<QUrl::toPercentEncoding(brokerUser)<<"&"<<
+                             "password="<<QUrl::toPercentEncoding(config->brokerPass)<<"&"<<
                              "authid="<<nextAuthId;
 
         x2goDebug << "sending request: "<< req.toUtf8();
@@ -290,8 +290,8 @@ void HttpBrokerClient::selectUserSession(const QString& session)
         QTextStream ( &req ) <<
                              "task=selectsession&"<<
                              "sid="<<session<<"&"<<
-                             "user="<<brokerUser<<"&"<<
-                             "password="<<config->brokerPass<<"&"<<
+                             "user="<<QUrl::toPercentEncoding(brokerUser)<<"&"<<
+                             "password="<<QUrl::toPercentEncoding(config->brokerPass)<<"&"<<
                              "authid="<<nextAuthId;
         x2goDebug << "sending request: "<< req.toUtf8();
         QNetworkRequest request(QUrl(config->brokerurl));
@@ -324,9 +324,9 @@ void HttpBrokerClient::changePassword(QString newPass)
         QString req;
         QTextStream ( &req ) <<
                              "task=setpass&"<<
-                             "newpass="<<newPass<<"&"<<
-                             "user="<<brokerUser<<"&"<<
-                             "password="<<config->brokerPass<<"&"<<
+                             "newpass="<<QUrl::toPercentEncoding(newPass)<<"&"<<
+                             "user="<<QUrl::toPercentEncoding(brokerUser)<<"&"<<
+                             "password="<<QUrl::toPercentEncoding(config->brokerPass)<<"&"<<
                              "authid="<<nextAuthId;
         x2goDebug << "sending request: "<< req.toUtf8();
         QNetworkRequest request(QUrl(config->brokerurl));

--
Alioth's /srv/git/_hooks_/post-receive-email on /srv/git/code.x2go.org/x2goclient.git